Linaro-mm-sig

linaro-mm-sig@lists.linaro.org

31 participants
6211 discussions

[PATCH v10 0/5] Rust bindings for gem shmem

by Lyude Paul

Most of this patch series has already been pushed upstream, this is just the second half of the patch series that has not been pushed yet + some additional changes which were required to implement changes requested by the mailing list. This patch series is originally from Asahi, previously posted by Daniel Almeida. The previous version of the patch series can be found here: (apparently it mistakenly was not sent to dri-devel, so no patchwork ): https://patchwork.freedesktop.org/series/156093/ Branch with patches applied available here (+ a hack required to make sure this builds: https://gitlab.freedesktop.org/lyudess/linux/-/commits/rust/gem-shmem Lyude Paul (5): rust: drm: gem: s/device::Device/Device/ for shmem.rs drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked() drm/gem/shmem: Export drm_gem_shmem_get_pages_sgt_locked() rust: drm: gem: Introduce shmem::SGTable rust: drm: gem: Add vmap functions to shmem bindings drivers/gpu/drm/drm_gem_shmem_helper.c | 48 ++- include/drm/drm_gem_shmem_helper.h | 2 + rust/kernel/drm/gem/shmem.rs | 553 ++++++++++++++++++++++++- 3 files changed, 590 insertions(+), 13 deletions(-) base-commit: a7a080bb4236ebe577b6776d940d1717912ff6dd -- 2.53.0

1 week, 4 days

ZEUS Crypt-o Rec-overy Services: the Worldwide Leading Crypt-o Recovery Experts in 2026

by onwekingsley021＠gmail.com

ZEUS Crypt-o Recover-y Services truly came through for me at a time when I felt completely hopeless. After losing my Bitcoin to a scam, I thought my -were gone forever. That's when I discovered ZEUS, and from the very first interaction, I knew I was in capable hands. Their team was incredibly responsive, professional, and knowledgeable about bloc-kchain technology and crypt-o investigations. - They took the time to understand my situation in detail, explained every step of the recov-ery process clearly, and provided regular updates that kept me reassured. What impressed me most was their persistence and dedication—they didn't give up until real progress was made. Thanks to their expertise and advanced tracking techniques, I was able to recover a significant portion of my lo-st fu-nds. ZEUS Cryp-to Recove-ry Services didn't just help me financially—they restored my confidence and peace of mind. If you've been a victim of crypt-o fra-ud or lo-st ac-cess to your di-gital asse-ts, I highly recommend reaching out to them. Contact ZEUS Cryp-to Recove-ry Services:

1 week, 4 days

[PATCH] dma-buf: fix order of trace and fput

by Christian König

Dropping the last reference to the DMA-buf and then accessing the name for tracing can't work correctly. Only compile tested! Signed-off-by: Christian König <christian.koenig(a)amd.com> Fixed: 281a22631423 ("dma-buf: add some tracepoints to debug.") --- drivers/dma-buf/dma-buf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 11711874a325..3a9d5113b98c 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -845,9 +845,8 @@ void dma_buf_put(struct dma_buf *dmabuf) if (WARN_ON(!dmabuf || !dmabuf->file)) return; - fput(dmabuf->file); - DMA_BUF_TRACE(trace_dma_buf_put, dmabuf); + fput(dmabuf->file); } EXPORT_SYMBOL_NS_GPL(dma_buf_put, "DMA_BUF"); -- 2.43.0

1 week, 5 days

Watsap +16465806302. Buy registered driving license. Buy 100% undetectable counterfeit euro.

by markcarlson70＠gmail.com

Watsap +16465806302. Buy registered driving license. Buy 100% undetectable counterfeit euro. darkwebdocuments.net. dollars, pounds. nationality certificate online. We deal and specialize in helping you to get high-quality Biometric documents, registered PASSPORT, DRIVING LICENSE, ID CARD, VISA, SSN TOEFL, IELTS, IDP, ESOL, GMAT CELTA/DELTA, DEGREE, DIPLOMAS & other Certificates. 100% undetectable counterfeit euros, pesos, dollars, pounds, and many other currencies. Buy Clone credit cards, credit card clone. https://darkwebdocuments.net/driving-classes-adults/ https://darkwebdocuments.net/ - WhatsApp.....................+13524051163 WhatsApp.....................+16465806302 Contact..............darkwebdocuments(a)gmail.com Buy SSD Chemical solution for cleaning all types of banknotes. We are the best and Unique producer of HIGH-QUALITY Undetectable Counterfeit Banknotes, with billions of our products circulating worldwide. Tel: +16465806302 We supply only original high-quality counterfeit currency NOTES to all countries worldwide. THESE BANKNOTES ARE HIGHLY INDISTINGUISHABLE FROM THE TOUCH AND THE FEEL OF THE HANDS AND THE LOOK OF THE NAKED EYES. THIS MONEY CARRIES INDIVIDUAL SERIALS AND BYPASSES ALL SECURITY TESTS INCLUDING UV-LIGHT AND IODINE COUNTERFEIT PEN MARKERS. BUY BIOMETRIC PASSPORT, DRIVING LICENSE, ID CARD, VISA, SSN. We have years of experience producing original quality real registered passports, IDs, driver licenses, and many other identity documents, really cheap for all countries such as; Switzerland, United Kingdom, United States, Spain, Sweden, Australia, Austria, Canada, Chile, Denmark, Ecuador, Finland, France, Germany, Israel, New Zealand, South Africa, e.t.c. Passports with chips for the following countries are also available: Australia, Austria, Finland, Germany, Malaysia, Netherlands, Sweden, Switzerland, Thailand, United Kingdom, United States, etc. We can also produce documents such as work permits, for the UK, USA, and Italy just to name a few. Buy biometric Passport, ID cards, Visa, Drivers License, TOEFL, IELTS, Toeic, Celta/Delt, BUY fake British passports (UK), Americans, Canadians, False identity CARDS ONLINE IN UNITED STATES, DRIVING LICENSE, Buy Registered birth certificates, BUY REAL DRIVING LICENSE, Buy Real EU/USA/UK/Canadian Passports, Driver’s License, ID Cards, Visas, USA Green Card and Citizenship, buy original/fake passports, Driver's license, ID cards, birth certificates, diplomas, university degrees, etc BUY HIGH QUALITY REAL PASSPORT, ID CARDS, DRIVING LICENSE, passport, visa, France driver's license, ID cards, diplomas, birth certificates ETC. Buy Visa, passport, ID card, birth certificate, Driving License Transcripts, Buy Original Passports, Id Card Drivers License, Best Quality Novelty real IDs and Passports, Marriage certificates and Driver licenses etc buy now high quality have the best HOLOGRAMS AND DUPLICATING MACHINES With over 13 million of out documents circulating over the world. -IDs Scan-yes...-HOLOGRAMS: IDENTICAL-BAR CODES: IDS SCAN-UV: https://fastnationality.com/ YES IDS WITH FAST SHIPPING https://darkwebdocuments.net/ WhatsApp..................+13524051163 Contact..............darkwebdocuments(a)gmail.com We guarantee and offer high-quality counterfeit bills for the following currencies; EUR – Euro USD – US Dollar GBP – British Pound BUY PASSPORT | PASSPORT ONLINE | PASSPORTS FOR SALE | ID CARD ONLINE | BUY DRIVING LICENSE | BUY ID CARD | DRIVERS LICENSE ONLINE | BUY IELTS CERTIFICATE ONLINE | AUSTRALIA DOCUMENTS | BELGIUM DOCUMENTS | CANADA DOCUMENTS | GERMANY DOCUMENTS | FRANCE DOCUMENTS | NETHERLANDS | DOCUMENTS | ITALY DOCUMENTS | SPAIN DOCUMENTS | PORTUGAL DOCUMENTS | USA DOCUMENTS | UNITED KINGDOM DOCUMENTS | BUY REAL CANADIAN PASSPORT | https://fastnationality.com/immigration-permanent-resident-card/ | BUY REAL USA PASSPORT | ID CARD USA | BUY PASSPORT CANADA | BUY US ID CARD | BUY REAL US PASSPORT ONLINE | You can contact us directly to get the additional information and place the order... https://darkwebdocuments.net/ WhatsApp..................+13524051163 Contact..............darkwebdocuments(a)gmail.com

1 week, 5 days

Watsap +16465806302. Buy registered driving license. Buy 100% undetectable counterfeit euro.

by markcarlson70＠gmail.com

Watsap +16465806302. Buy registered driving license. Buy 100% undetectable counterfeit euro.

1 week, 5 days

TANGIBLE INFORMATION ABOUT FUNDS RECOVERY AND HACKERS

by osmanbamsi41＠gmail.com

‎I was scammed of $92000 worth of bitcoin with a scam forex investment unknowingly then I didn’t know what to do.. I felt like I should committed a suicide but I fortunately have a good start again until my friend introduced me to one of the best recovery agent in Texas who helped me to recovered it back for me in just few days, if you feel scammed with fake forex or any form of scam you don’t need to be worried you can contact on Ghost Champion Hackers they are difference from others the did wonders for me which I have been living my best life. the recovered my funds with a software called Goplus super recovery. finally breathing again. They didn’t just return money—they gave me back hope and also trust. You can reach out to them at Email : ghostchampionwizard(a)gmail.com Telegram: https://t.me/WizardGhosthacker Website : https://stellamariaqueen03.wixsite.com/-ghost-champion-wiza

1 week, 5 days

TANGIBLE INFORMATION ABOUT FUNDS RECOVERY AND HACKERS

by osmanbamsi41＠gmail.com

1 week, 5 days

Re: [PATCH v5 6/7] drm/amdgpu: rename amdgpu_fill_buffer as amdgpu_ttm_clear_buffer

by Christian König

On 4/3/26 10:35, Pierre-Eric Pelloux-Prayer wrote: > This is the only use case for this function. > > --- > v2: amdgpu_ttm_clear_buffer instead of amdgpu_clear_buffer > --- > > Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> > Reviewed-by: Christian König <christian.koenig(a)amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++++------ > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 23 ++++++++++------------ > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 13 ++++++------ > 3 files changed, 22 insertions(+), 26 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index d0884bbffa75..195cb1c814d1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -717,9 +717,9 @@ int amdgpu_bo_create(struct amdgpu_device *adev, > bo->tbo.resource->mem_type == TTM_PL_VRAM) { > struct dma_fence *fence; > > - r = amdgpu_fill_buffer(amdgpu_ttm_next_clear_entity(adev), > - bo, 0, NULL, &fence, > - true, AMDGPU_KERNEL_JOB_ID_TTM_CLEAR_BUFFER); > + r = amdgpu_ttm_clear_buffer(amdgpu_ttm_next_clear_entity(adev), > + bo, NULL, &fence, Wait a second. Why is the dependency NULL here? Could it be that we relied on the fact that clears and moves were serialized in the past? Regards, Christian. > + true, AMDGPU_KERNEL_JOB_ID_TTM_CLEAR_BUFFER); > if (unlikely(r)) > goto fail_unreserve; > > @@ -1329,9 +1329,9 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo) > if (r) > goto out; > > - r = amdgpu_fill_buffer(amdgpu_ttm_next_clear_entity(adev), > - abo, 0, &bo->base._resv, &fence, > - false, AMDGPU_KERNEL_JOB_ID_CLEAR_ON_RELEASE); > + r = amdgpu_ttm_clear_buffer(amdgpu_ttm_next_clear_entity(adev), > + abo, &bo->base._resv, &fence, > + false, AMDGPU_KERNEL_JOB_ID_CLEAR_ON_RELEASE); > if (WARN_ON(r)) > goto out; > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index a3d0998b8cec..e74f9f8a88dc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -417,8 +417,8 @@ static int amdgpu_move_blit(struct ttm_buffer_object *bo, > if (old_mem->mem_type == TTM_PL_VRAM && > (abo->flags & AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE)) { > struct dma_fence *wipe_fence = NULL; > - r = amdgpu_fill_buffer(entity, abo, 0, NULL, &wipe_fence, > - false, AMDGPU_KERNEL_JOB_ID_MOVE_BLIT); > + r = amdgpu_ttm_clear_buffer(entity, abo, NULL, &wipe_fence, > + false, AMDGPU_KERNEL_JOB_ID_MOVE_BLIT); > if (r) { > goto error; > } else if (wipe_fence) { > @@ -2572,26 +2572,23 @@ static int amdgpu_ttm_fill_mem(struct amdgpu_device *adev, > } > > /** > - * amdgpu_fill_buffer - fill a buffer with a given value > + * amdgpu_ttm_clear_buffer - fill a buffer with 0 > * @entity: entity to use > * @bo: the bo to fill > - * @src_data: the value to set > * @resv: fences contained in this reservation will be used as dependencies. > * @out_fence: the fence from the last clear will be stored here. It might be > * NULL if no job was run. > - * @dependency: optional input dependency fence. > * @consider_clear_status: true if region reported as cleared by amdgpu_res_cleared() > * are skipped. > * @k_job_id: trace id > * > */ > -int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > - struct amdgpu_bo *bo, > - uint32_t src_data, > - struct dma_resv *resv, > - struct dma_fence **out_fence, > - bool consider_clear_status, > - u64 k_job_id) > +int amdgpu_ttm_clear_buffer(struct amdgpu_ttm_buffer_entity *entity, > + struct amdgpu_bo *bo, > + struct dma_resv *resv, > + struct dma_fence **out_fence, > + bool consider_clear_status, > + u64 k_job_id) > { > struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev); > struct dma_fence *fence = NULL; > @@ -2622,7 +2619,7 @@ int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > goto error; > > r = amdgpu_ttm_fill_mem(adev, entity, > - src_data, to, cur_size, resv, > + 0, to, cur_size, resv, > &next, true, k_job_id); > if (r) > goto error; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > index 436a3e09a178..d7b14d5cac77 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > @@ -187,13 +187,12 @@ int amdgpu_copy_buffer(struct amdgpu_device *adev, > struct dma_resv *resv, > struct dma_fence **fence, > bool vm_needs_flush, uint32_t copy_flags); > -int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > - struct amdgpu_bo *bo, > - uint32_t src_data, > - struct dma_resv *resv, > - struct dma_fence **out_fence, > - bool consider_clear_status, > - u64 k_job_id); > +int amdgpu_ttm_clear_buffer(struct amdgpu_ttm_buffer_entity *entity, > + struct amdgpu_bo *bo, > + struct dma_resv *resv, > + struct dma_fence **out_fence, > + bool consider_clear_status, > + u64 k_job_id); > struct amdgpu_ttm_buffer_entity *amdgpu_ttm_next_clear_entity(struct amdgpu_device *adev); > > int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo);

1 week, 6 days

Re: [PATCH v5 5/7] drm/amdgpu: get rid of amdgpu_ttm_clear_buffer

by Christian König

On 4/3/26 10:35, Pierre-Eric Pelloux-Prayer wrote: > It's doing the same thing as amdgpu_fill_buffer(src_data=0), so drop it. > > The only caveat is that amdgpu_res_cleared() return value is only valid > right after allocation. > > --- > v2: introduce new "bool consider_clear_status" arg > --- > > Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer(a)amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 16 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 88 +++++----------------- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 6 +- > 3 files changed, 32 insertions(+), 78 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index 66c20dd46d12..d0884bbffa75 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -717,13 +717,17 @@ int amdgpu_bo_create(struct amdgpu_device *adev, > bo->tbo.resource->mem_type == TTM_PL_VRAM) { > struct dma_fence *fence; > > - r = amdgpu_ttm_clear_buffer(bo, bo->tbo.base.resv, &fence); > + r = amdgpu_fill_buffer(amdgpu_ttm_next_clear_entity(adev), > + bo, 0, NULL, &fence, > + true, AMDGPU_KERNEL_JOB_ID_TTM_CLEAR_BUFFER); > if (unlikely(r)) > goto fail_unreserve; > > - dma_resv_add_fence(bo->tbo.base.resv, fence, > - DMA_RESV_USAGE_KERNEL); > - dma_fence_put(fence); > + if (fence) { > + dma_resv_add_fence(bo->tbo.base.resv, fence, > + DMA_RESV_USAGE_KERNEL); > + dma_fence_put(fence); > + } > } > if (!bp->resv) > amdgpu_bo_unreserve(bo); > @@ -1326,8 +1330,8 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo) > goto out; > > r = amdgpu_fill_buffer(amdgpu_ttm_next_clear_entity(adev), > - abo, 0, &bo->base._resv, > - &fence, AMDGPU_KERNEL_JOB_ID_CLEAR_ON_RELEASE); > + abo, 0, &bo->base._resv, &fence, > + false, AMDGPU_KERNEL_JOB_ID_CLEAR_ON_RELEASE); > if (WARN_ON(r)) > goto out; > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 648ad344e89c..a3d0998b8cec 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -418,7 +418,7 @@ static int amdgpu_move_blit(struct ttm_buffer_object *bo, > (abo->flags & AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE)) { > struct dma_fence *wipe_fence = NULL; > r = amdgpu_fill_buffer(entity, abo, 0, NULL, &wipe_fence, > - AMDGPU_KERNEL_JOB_ID_MOVE_BLIT); > + false, AMDGPU_KERNEL_JOB_ID_MOVE_BLIT); > if (r) { > goto error; > } else if (wipe_fence) { > @@ -2572,76 +2572,25 @@ static int amdgpu_ttm_fill_mem(struct amdgpu_device *adev, > } > > /** > - * amdgpu_ttm_clear_buffer - clear memory buffers > - * @bo: amdgpu buffer object > - * @resv: reservation object > - * @fence: dma_fence associated with the operation > + * amdgpu_fill_buffer - fill a buffer with a given value > + * @entity: entity to use > + * @bo: the bo to fill > + * @src_data: the value to set > + * @resv: fences contained in this reservation will be used as dependencies. > + * @out_fence: the fence from the last clear will be stored here. It might be > + * NULL if no job was run. > + * @dependency: optional input dependency fence. > + * @consider_clear_status: true if region reported as cleared by amdgpu_res_cleared() > + * are skipped. > + * @k_job_id: trace id > * > - * Clear the memory buffer resource. > - * > - * Returns: > - * 0 for success or a negative error code on failure. > */ > -int amdgpu_ttm_clear_buffer(struct amdgpu_bo *bo, > - struct dma_resv *resv, > - struct dma_fence **fence) > -{ > - struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev); > - struct amdgpu_ttm_buffer_entity *entity; > - struct amdgpu_res_cursor cursor; > - u64 addr; > - int r = 0; > - > - if (!adev->mman.buffer_funcs_enabled) > - return -EINVAL; > - > - if (!fence) > - return -EINVAL; > - entity = &adev->mman.clear_entities[0]; > - *fence = dma_fence_get_stub(); > - > - amdgpu_res_first(bo->tbo.resource, 0, amdgpu_bo_size(bo), &cursor); > - > - mutex_lock(&entity->lock); > - while (cursor.remaining) { > - struct dma_fence *next = NULL; > - u64 size; > - > - if (amdgpu_res_cleared(&cursor)) { > - amdgpu_res_next(&cursor, cursor.size); > - continue; > - } > - > - /* Never clear more than 256MiB at once to avoid timeouts */ > - size = min(cursor.size, 256ULL << 20); > - > - r = amdgpu_ttm_map_buffer(entity, &bo->tbo, bo->tbo.resource, &cursor, > - 0, false, &size, &addr); > - if (r) > - goto err; > - > - r = amdgpu_ttm_fill_mem(adev, entity, 0, addr, size, resv, > - &next, true, > - AMDGPU_KERNEL_JOB_ID_TTM_CLEAR_BUFFER); > - if (r) > - goto err; > - > - dma_fence_put(*fence); > - *fence = next; > - > - amdgpu_res_next(&cursor, size); > - } > -err: > - mutex_unlock(&entity->lock); > - > - return r; > -} > - > int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, We should probably rename the function to amdgpu_ttm_clear_buffer() while doing this. Apart from that looks good to me. Regards, Christian. > struct amdgpu_bo *bo, > uint32_t src_data, > struct dma_resv *resv, > - struct dma_fence **f, > + struct dma_fence **out_fence, > + bool consider_clear_status, > u64 k_job_id) > { > struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev); > @@ -2659,6 +2608,11 @@ int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > struct dma_fence *next; > uint64_t cur_size, to; > > + if (consider_clear_status && amdgpu_res_cleared(&dst)) { > + amdgpu_res_next(&dst, dst.size); > + continue; > + } > + > /* Never fill more than 256MiB at once to avoid timeouts */ > cur_size = min(dst.size, 256ULL << 20); > > @@ -2680,9 +2634,7 @@ int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > } > error: > mutex_unlock(&entity->lock); > - if (f) > - *f = dma_fence_get(fence); > - dma_fence_put(fence); > + *out_fence = fence; > return r; > } > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > index a6249252948b..436a3e09a178 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h > @@ -187,14 +187,12 @@ int amdgpu_copy_buffer(struct amdgpu_device *adev, > struct dma_resv *resv, > struct dma_fence **fence, > bool vm_needs_flush, uint32_t copy_flags); > -int amdgpu_ttm_clear_buffer(struct amdgpu_bo *bo, > - struct dma_resv *resv, > - struct dma_fence **fence); > int amdgpu_fill_buffer(struct amdgpu_ttm_buffer_entity *entity, > struct amdgpu_bo *bo, > uint32_t src_data, > struct dma_resv *resv, > - struct dma_fence **f, > + struct dma_fence **out_fence, > + bool consider_clear_status, > u64 k_job_id); > struct amdgpu_ttm_buffer_entity *amdgpu_ttm_next_clear_entity(struct amdgpu_device *adev); >

1 week, 6 days

Re: [PATCH] dma-buf: system_heap: Optimize sg_table-to-pages conversion in vmap

by Christian König

On 4/6/26 23:49, Barry Song (Xiaomi) wrote: > From: Xueyuan Chen <Xueyuan.chen21(a)gmail.com> > > Replace the heavy for_each_sgtable_page() iterator in system_heap_do_vmap() > with a more efficient nested loop approach. > > Instead of iterating page by page, we now iterate through the scatterlist > entries via for_each_sgtable_sg(). Because pages within a single sg entry > are physically contiguous, we can populate the page array with a in an > inner loop using simple pointer math. This save a lot of time. > > The WARN_ON check is also pulled out of the loop to save branch > instructions. > > Performance results mapping a 2GB buffer on Radxa O6: > - Before: ~1440000 ns > - After: ~232000 ns > (~84% reduction in iteration time, or ~6.2x faster) Well real question is why do you care about the vmap performance? That should basically only be used for fbdev emulation (except for VMGFX) and we absolutely don't care about performance there. Regards, Christian. > > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: Benjamin Gaignard <benjamin.gaignard(a)collabora.com> > Cc: Brian Starkey <Brian.Starkey(a)arm.com> > Cc: John Stultz <jstultz(a)google.com> > Cc: T.J. Mercier <tjmercier(a)google.com> > Cc: Christian König <christian.koenig(a)amd.com> > Signed-off-by: Xueyuan Chen <Xueyuan.chen21(a)gmail.com> > Signed-off-by: Barry Song (Xiaomi) <baohua(a)kernel.org> > --- > drivers/dma-buf/heaps/system_heap.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c > index b3650d8fd651..769f01f0cc96 100644 > --- a/drivers/dma-buf/heaps/system_heap.c > +++ b/drivers/dma-buf/heaps/system_heap.c > @@ -224,16 +224,21 @@ static void *system_heap_do_vmap(struct system_heap_buffer *buffer) > int npages = PAGE_ALIGN(buffer->len) / PAGE_SIZE; > struct page **pages = vmalloc(sizeof(struct page *) * npages); > struct page **tmp = pages; > - struct sg_page_iter piter; > void *vaddr; > + u32 i, j, count; > + struct page *base_page; > + struct scatterlist *sg; > > if (!pages) > return ERR_PTR(-ENOMEM); > > - for_each_sgtable_page(table, &piter, 0) { > - WARN_ON(tmp - pages >= npages); > - *tmp++ = sg_page_iter_page(&piter); > + for_each_sgtable_sg(table, sg, i) { > + base_page = sg_page(sg); > + count = sg->length >> PAGE_SHIFT; > + for (j = 0; j < count; j++) > + *tmp++ = base_page + j; > } > + WARN_ON(tmp - pages != npages); > > vaddr = vmap(pages, npages, VM_MAP, PAGE_KERNEL); > vfree(pages);

1 week, 6 days

← Newer
1
...
8
9
10
11
12
13
14
...
622
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig