CoreSight

coresight@lists.linaro.org

6 participants
2352 discussions

Re: [PATCH v1 2/4] coresight: Simplify sysfs accessors by using csdev_access abstraction

by James Clark

On 22/08/2022 18:37, Mathieu Poirier wrote: > Hi James, > > On Mon, Jul 25, 2022 at 03:52:19PM +0100, James Clark wrote: >> The coresight_device struct is available in the sysfs accessor, and this >> contains a csdev_access struct which can be used to access registers. >> Use this instead of passing in the type of each drvdata so that a common >> function can be shared between all the cs drivers. >> >> No functional changes. >> >> Signed-off-by: James Clark <james.clark(a)arm.com> >> --- >> drivers/hwtracing/coresight/coresight-catu.c | 18 +++++----- >> drivers/hwtracing/coresight/coresight-etb10.c | 19 +++++------ >> .../coresight/coresight-etm3x-sysfs.c | 23 ++++++------- >> drivers/hwtracing/coresight/coresight-priv.h | 14 ++++---- >> .../coresight/coresight-replicator.c | 7 ++-- >> drivers/hwtracing/coresight/coresight-stm.c | 27 +++++++-------- >> .../hwtracing/coresight/coresight-tmc-core.c | 33 ++++++++----------- >> include/linux/coresight.h | 18 ++++++++++ >> 8 files changed, 79 insertions(+), 80 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c >> index e0740c6dbd54..9d89c4054046 100644 >> --- a/drivers/hwtracing/coresight/coresight-catu.c >> +++ b/drivers/hwtracing/coresight/coresight-catu.c >> @@ -365,16 +365,14 @@ static const struct etr_buf_operations etr_catu_buf_ops = { >> .get_data = catu_get_data_etr_buf, >> }; >> >> -coresight_simple_reg32(struct catu_drvdata, devid, CORESIGHT_DEVID); >> -coresight_simple_reg32(struct catu_drvdata, control, CATU_CONTROL); >> -coresight_simple_reg32(struct catu_drvdata, status, CATU_STATUS); >> -coresight_simple_reg32(struct catu_drvdata, mode, CATU_MODE); >> -coresight_simple_reg32(struct catu_drvdata, axictrl, CATU_AXICTRL); >> -coresight_simple_reg32(struct catu_drvdata, irqen, CATU_IRQEN); >> -coresight_simple_reg64(struct catu_drvdata, sladdr, >> - CATU_SLADDRLO, CATU_SLADDRHI); >> -coresight_simple_reg64(struct catu_drvdata, inaddr, >> - CATU_INADDRLO, CATU_INADDRHI); >> +coresight_simple_reg32(devid, CORESIGHT_DEVID); >> +coresight_simple_reg32(control, CATU_CONTROL); >> +coresight_simple_reg32(status, CATU_STATUS); >> +coresight_simple_reg32(mode, CATU_MODE); >> +coresight_simple_reg32(axictrl, CATU_AXICTRL); >> +coresight_simple_reg32(irqen, CATU_IRQEN); >> +coresight_simple_reg64(sladdr, CATU_SLADDRLO, CATU_SLADDRHI); >> +coresight_simple_reg64(inaddr, CATU_INADDRLO, CATU_INADDRHI); >> >> static struct attribute *catu_mgmt_attrs[] = { >> &dev_attr_devid.attr, >> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c >> index efa39820acec..405bb3355cb1 100644 >> --- a/drivers/hwtracing/coresight/coresight-etb10.c >> +++ b/drivers/hwtracing/coresight/coresight-etb10.c >> @@ -655,17 +655,14 @@ static const struct file_operations etb_fops = { >> .llseek = no_llseek, >> }; >> >> -#define coresight_etb10_reg(name, offset) \ >> - coresight_simple_reg32(struct etb_drvdata, name, offset) >> - >> -coresight_etb10_reg(rdp, ETB_RAM_DEPTH_REG); >> -coresight_etb10_reg(sts, ETB_STATUS_REG); >> -coresight_etb10_reg(rrp, ETB_RAM_READ_POINTER); >> -coresight_etb10_reg(rwp, ETB_RAM_WRITE_POINTER); >> -coresight_etb10_reg(trg, ETB_TRG); >> -coresight_etb10_reg(ctl, ETB_CTL_REG); >> -coresight_etb10_reg(ffsr, ETB_FFSR); >> -coresight_etb10_reg(ffcr, ETB_FFCR); >> +coresight_simple_reg32(rdp, ETB_RAM_DEPTH_REG); >> +coresight_simple_reg32(sts, ETB_STATUS_REG); >> +coresight_simple_reg32(rrp, ETB_RAM_READ_POINTER); >> +coresight_simple_reg32(rwp, ETB_RAM_WRITE_POINTER); >> +coresight_simple_reg32(trg, ETB_TRG); >> +coresight_simple_reg32(ctl, ETB_CTL_REG); >> +coresight_simple_reg32(ffsr, ETB_FFSR); >> +coresight_simple_reg32(ffcr, ETB_FFCR); >> >> static struct attribute *coresight_etb_mgmt_attrs[] = { >> &dev_attr_rdp.attr, >> diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> index 68fcbf4ce7a8..12f8e8176c7e 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> @@ -1252,19 +1252,16 @@ static struct attribute *coresight_etm_attrs[] = { >> NULL, >> }; >> >> -#define coresight_etm3x_reg(name, offset) \ >> - coresight_simple_reg32(struct etm_drvdata, name, offset) >> - >> -coresight_etm3x_reg(etmccr, ETMCCR); >> -coresight_etm3x_reg(etmccer, ETMCCER); >> -coresight_etm3x_reg(etmscr, ETMSCR); >> -coresight_etm3x_reg(etmidr, ETMIDR); >> -coresight_etm3x_reg(etmcr, ETMCR); >> -coresight_etm3x_reg(etmtraceidr, ETMTRACEIDR); >> -coresight_etm3x_reg(etmteevr, ETMTEEVR); >> -coresight_etm3x_reg(etmtssvr, ETMTSSCR); >> -coresight_etm3x_reg(etmtecr1, ETMTECR1); >> -coresight_etm3x_reg(etmtecr2, ETMTECR2); >> +coresight_simple_reg32(etmccr, ETMCCR); >> +coresight_simple_reg32(etmccer, ETMCCER); >> +coresight_simple_reg32(etmscr, ETMSCR); >> +coresight_simple_reg32(etmidr, ETMIDR); >> +coresight_simple_reg32(etmcr, ETMCR); >> +coresight_simple_reg32(etmtraceidr, ETMTRACEIDR); >> +coresight_simple_reg32(etmteevr, ETMTEEVR); >> +coresight_simple_reg32(etmtssvr, ETMTSSCR); >> +coresight_simple_reg32(etmtecr1, ETMTECR1); >> +coresight_simple_reg32(etmtecr2, ETMTECR2); >> >> static struct attribute *coresight_etm_mgmt_attrs[] = { >> &dev_attr_etmccr.attr, >> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h >> index f2458b794ef3..cf8ae768106e 100644 >> --- a/drivers/hwtracing/coresight/coresight-priv.h >> +++ b/drivers/hwtracing/coresight/coresight-priv.h >> @@ -40,23 +40,23 @@ >> #define ETM_MODE_EXCL_KERN BIT(30) >> #define ETM_MODE_EXCL_USER BIT(31) >> >> -#define __coresight_simple_show(type, name, lo_off, hi_off) \ >> +#define __coresight_simple_show(name, lo_off, hi_off) \ >> static ssize_t name##_show(struct device *_dev, \ >> struct device_attribute *attr, char *buf) \ >> { \ >> - type *drvdata = dev_get_drvdata(_dev->parent); \ >> + struct coresight_device *csdev = container_of(_dev, struct coresight_device, dev); \ >> u64 val; \ >> pm_runtime_get_sync(_dev->parent); \ >> - val = coresight_read_reg_pair(drvdata->base, lo_off, hi_off); \ >> + val = csdev_access_relaxed_read_pair(&csdev->access, lo_off, hi_off); \ >> pm_runtime_put_sync(_dev->parent); \ >> return scnprintf(buf, PAGE_SIZE, "0x%llx\n", val); \ >> } \ >> static DEVICE_ATTR_RO(name) >> >> -#define coresight_simple_reg32(type, name, offset) \ >> - __coresight_simple_show(type, name, offset, -1) >> -#define coresight_simple_reg64(type, name, lo_off, hi_off) \ >> - __coresight_simple_show(type, name, lo_off, hi_off) >> +#define coresight_simple_reg32(name, offset) \ >> + __coresight_simple_show(name, offset, -1) >> +#define coresight_simple_reg64(name, lo_off, hi_off) \ >> + __coresight_simple_show(name, lo_off, hi_off) >> >> extern const u32 coresight_barrier_pkt[4]; >> #define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt)) >> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c >> index b86acbc74cf0..7cffcbb2ec42 100644 >> --- a/drivers/hwtracing/coresight/coresight-replicator.c >> +++ b/drivers/hwtracing/coresight/coresight-replicator.c >> @@ -196,11 +196,8 @@ static const struct coresight_ops replicator_cs_ops = { >> .link_ops = &replicator_link_ops, >> }; >> >> -#define coresight_replicator_reg(name, offset) \ >> - coresight_simple_reg32(struct replicator_drvdata, name, offset) >> - >> -coresight_replicator_reg(idfilter0, REPLICATOR_IDFILTER0); >> -coresight_replicator_reg(idfilter1, REPLICATOR_IDFILTER1); >> +coresight_simple_reg32(idfilter0, REPLICATOR_IDFILTER0); >> +coresight_simple_reg32(idfilter1, REPLICATOR_IDFILTER1); >> >> static struct attribute *replicator_mgmt_attrs[] = { >> &dev_attr_idfilter0.attr, >> diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c >> index bb14a3a8a921..4a31905604fe 100644 >> --- a/drivers/hwtracing/coresight/coresight-stm.c >> +++ b/drivers/hwtracing/coresight/coresight-stm.c >> @@ -634,21 +634,18 @@ static ssize_t traceid_store(struct device *dev, >> } >> static DEVICE_ATTR_RW(traceid); >> >> -#define coresight_stm_reg(name, offset) \ >> - coresight_simple_reg32(struct stm_drvdata, name, offset) >> - >> -coresight_stm_reg(tcsr, STMTCSR); >> -coresight_stm_reg(tsfreqr, STMTSFREQR); >> -coresight_stm_reg(syncr, STMSYNCR); >> -coresight_stm_reg(sper, STMSPER); >> -coresight_stm_reg(spter, STMSPTER); >> -coresight_stm_reg(privmaskr, STMPRIVMASKR); >> -coresight_stm_reg(spscr, STMSPSCR); >> -coresight_stm_reg(spmscr, STMSPMSCR); >> -coresight_stm_reg(spfeat1r, STMSPFEAT1R); >> -coresight_stm_reg(spfeat2r, STMSPFEAT2R); >> -coresight_stm_reg(spfeat3r, STMSPFEAT3R); >> -coresight_stm_reg(devid, CORESIGHT_DEVID); >> +coresight_simple_reg32(tcsr, STMTCSR); >> +coresight_simple_reg32(tsfreqr, STMTSFREQR); >> +coresight_simple_reg32(syncr, STMSYNCR); >> +coresight_simple_reg32(sper, STMSPER); >> +coresight_simple_reg32(spter, STMSPTER); >> +coresight_simple_reg32(privmaskr, STMPRIVMASKR); >> +coresight_simple_reg32(spscr, STMSPSCR); >> +coresight_simple_reg32(spmscr, STMSPMSCR); >> +coresight_simple_reg32(spfeat1r, STMSPFEAT1R); >> +coresight_simple_reg32(spfeat2r, STMSPFEAT2R); >> +coresight_simple_reg32(spfeat3r, STMSPFEAT3R); >> +coresight_simple_reg32(devid, CORESIGHT_DEVID); >> >> static struct attribute *coresight_stm_attrs[] = { >> &dev_attr_hwevent_enable.attr, >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c >> index d0276af82494..781d213526b7 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c >> @@ -251,25 +251,20 @@ static enum tmc_mem_intf_width tmc_get_memwidth(u32 devid) >> return memwidth; >> } >> >> -#define coresight_tmc_reg(name, offset) \ >> - coresight_simple_reg32(struct tmc_drvdata, name, offset) >> -#define coresight_tmc_reg64(name, lo_off, hi_off) \ >> - coresight_simple_reg64(struct tmc_drvdata, name, lo_off, hi_off) >> - >> -coresight_tmc_reg(rsz, TMC_RSZ); >> -coresight_tmc_reg(sts, TMC_STS); >> -coresight_tmc_reg(trg, TMC_TRG); >> -coresight_tmc_reg(ctl, TMC_CTL); >> -coresight_tmc_reg(ffsr, TMC_FFSR); >> -coresight_tmc_reg(ffcr, TMC_FFCR); >> -coresight_tmc_reg(mode, TMC_MODE); >> -coresight_tmc_reg(pscr, TMC_PSCR); >> -coresight_tmc_reg(axictl, TMC_AXICTL); >> -coresight_tmc_reg(authstatus, TMC_AUTHSTATUS); >> -coresight_tmc_reg(devid, CORESIGHT_DEVID); >> -coresight_tmc_reg64(rrp, TMC_RRP, TMC_RRPHI); >> -coresight_tmc_reg64(rwp, TMC_RWP, TMC_RWPHI); >> -coresight_tmc_reg64(dba, TMC_DBALO, TMC_DBAHI); >> +coresight_simple_reg32(rsz, TMC_RSZ); >> +coresight_simple_reg32(sts, TMC_STS); >> +coresight_simple_reg32(trg, TMC_TRG); >> +coresight_simple_reg32(ctl, TMC_CTL); >> +coresight_simple_reg32(ffsr, TMC_FFSR); >> +coresight_simple_reg32(ffcr, TMC_FFCR); >> +coresight_simple_reg32(mode, TMC_MODE); >> +coresight_simple_reg32(pscr, TMC_PSCR); >> +coresight_simple_reg32(axictl, TMC_AXICTL); >> +coresight_simple_reg32(authstatus, TMC_AUTHSTATUS); >> +coresight_simple_reg32(devid, CORESIGHT_DEVID); >> +coresight_simple_reg64(rrp, TMC_RRP, TMC_RRPHI); >> +coresight_simple_reg64(rwp, TMC_RWP, TMC_RWPHI); >> +coresight_simple_reg64(dba, TMC_DBALO, TMC_DBAHI); >> >> static struct attribute *coresight_tmc_mgmt_attrs[] = { >> &dev_attr_rsz.attr, >> diff --git a/include/linux/coresight.h b/include/linux/coresight.h >> index 9f445f09fcfe..c1bb93c7c1de 100644 >> --- a/include/linux/coresight.h >> +++ b/include/linux/coresight.h >> @@ -372,6 +372,24 @@ static inline u32 csdev_access_relaxed_read32(struct csdev_access *csa, >> return csa->read(offset, true, false); >> } >> >> +static inline u64 csdev_access_relaxed_read_pair(struct csdev_access *csa, >> + u32 lo_offset, u32 hi_offset) > > Parameters lo_offset and hi_offset are s32 in coresight_read_reg_pair()... Hi Mathieu, I probably should have mentioned this in the commit message. You're right that the previous version used signed values, but the csdev accessors in include/linux/coresight.h all use u32 and I had to add a new one in there for 'csdev_access_relaxed_read_pair()' which would have looked very out of place if it was the only one to used signed values. Because of this I also changed the 'not set' test for hi_offset from '< -1' to '== -1' which would also work with unsigned values. So although it looks different, it is still working the same way as before. I can think of some possible options to make it better: * Have csdev_access_relaxed_read_pair() be the only csdev_access_ function to take signed values * Keep the unsigned type but change the unset value of -1 to be UINT_MAX * Split the accessors into ones that are 64 bit pairs, and ones that are a single read. It's always known when it's defined whether it's a 'pair' or not, so technically this if statement with the 'not set' value isn't actually needed, you just use a different accessor type I was tempted to do the 3rd one during the refactor, but I wanted to keep it more like the original than not. I'm not a fan of the first option, I think that would be confusing to read the code and would look like a mistake. So I'm more in favour of 2 or 3. What are your thoughts? > >> +{ >> + u64 val; >> + >> + if (likely(csa->io_mem)) { >> + val = readl_relaxed(csa->base + lo_offset); >> + val |= (hi_offset == -1) ? 0 : >> + (u64)readl_relaxed(csa->base + hi_offset) << 32; >> + return val; >> + } >> + >> + val = csa->read(lo_offset, true, false); >> + val |= (hi_offset == -1) ? 0 : > > ... and hi_offset can't take on a negative value. This is just shorthand for UINT_MAX. I could change it to be more explicit (option 2 above)? > >> + (u64)csa->read(hi_offset, true, false) << 32; >> + return val; >> +} >> + >> static inline u32 csdev_access_read32(struct csdev_access *csa, u32 offset) >> { >> if (likely(csa->io_mem)) >> -- >> 2.28.0 >>

2 years, 8 months

[PATCH v2 00/13] coresight: Add new API to allocate trace source ID values

by Mike Leach

The current method for allocating trace source ID values to sources is to use a fixed algorithm for CPU based sources of (cpu_num * 2 + 0x10). The STM is allocated ID 0x1. This fixed algorithm is used in both the CoreSight driver code, and by perf when writing the trace metadata in the AUXTRACE_INFO record. The method needs replacing as currently:- 1. It is inefficient in using available IDs. 2. Does not scale to larger systems with many cores and the algorithm has no limits so will generate invalid trace IDs for cpu number > 44. Additionally requirements to allocate additional system IDs on some systems have been seen. This patch set introduces an API that allows the allocation of trace IDs in a dynamic manner. Architecturally reserved IDs are never allocated, and the system is limited to allocating only valid IDs. Each of the current trace sources ETM3.x, ETM4.x and STM is updated to use the new API. For the ETMx.x devices IDs are allocated on certain events a) When using sysfs, an ID will be allocated on hardware enable, or a read of sysfs TRCTRACEID register and freed when the sysfs reset is written. b) When using perf, ID is allocated on hardware enable, and freed on hardware disable. IDs are communicated using the AUX_OUTPUT_HW_ID packet. The ID allocator is notified when perf sessions start and stop so CPU based IDs are kept constant throughout any perf session. Note: This patchset breaks backward compatibility for perf record and perf report. Because the method for generating the AUXTRACE_INFO meta data has changed, using an older perf record will result in metadata that does not match the trace IDs used in the recorded trace data. This mismatch will cause subsequent decode to fail. The version of the AUXTRACE_INFO has been updated to reflect the fact that the trace source IDs are no longer present in the metadata. This will mean older versions of perf report cannot decode the file. Applies to coresight/next [c06475910b52] Tested on DB410c Changes since v1: (after feedback & discussion with Mathieu & Suzuki). 1) API has changed. The global trace ID map is managed internally, so it is no longer passed in to the API functions. 2) perf record does not use sysfs to find the trace IDs. These are now output as AUX_OUTPUT_HW_ID events. The drivers, perf record, and perf report have been updated accordingly to generate and handle these events. Mike Leach (13): coresight: trace-id: Add API to dynamically assign Trace ID values coresight: trace-id: update CoreSight core to use Trace ID API coresight: stm: Update STM driver to use Trace ID API coresight: etm4x: Update ETM4 driver to use Trace ID API coresight: etm3x: Update ETM3 driver to use Trace ID API coresight: etmX.X: stm: Remove unused legacy source Trace ID ops coresight: perf: traceid: Add perf notifiers for Trace ID perf: cs-etm: Move mapping of Trace ID and cpu into helper function perf: cs-etm: Update record event to use new Trace ID protocol kernel: events: Export perf_report_aux_output_id() perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet coresight: events: PERF_RECORD_AUX_OUTPUT_HW_ID used for Trace ID coresight: trace-id: Add debug & test macros to Trace ID allocation drivers/hwtracing/coresight/Makefile | 2 +- drivers/hwtracing/coresight/coresight-core.c | 49 +--- .../hwtracing/coresight/coresight-etm-perf.c | 17 ++ drivers/hwtracing/coresight/coresight-etm.h | 3 +- .../coresight/coresight-etm3x-core.c | 85 +++--- .../coresight/coresight-etm3x-sysfs.c | 28 +- .../coresight/coresight-etm4x-core.c | 65 ++++- .../coresight/coresight-etm4x-sysfs.c | 32 ++- drivers/hwtracing/coresight/coresight-etm4x.h | 3 + drivers/hwtracing/coresight/coresight-stm.c | 49 +--- .../hwtracing/coresight/coresight-trace-id.c | 263 ++++++++++++++++++ .../hwtracing/coresight/coresight-trace-id.h | 65 +++++ include/linux/coresight-pmu.h | 31 ++- include/linux/coresight.h | 3 - kernel/events/core.c | 1 + tools/include/linux/coresight-pmu.h | 31 ++- tools/perf/arch/arm/util/cs-etm.c | 21 +- .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 9 + tools/perf/util/cs-etm.c | 220 +++++++++++++-- tools/perf/util/cs-etm.h | 14 +- 20 files changed, 784 insertions(+), 207 deletions(-) create mode 100644 drivers/hwtracing/coresight/coresight-trace-id.c create mode 100644 drivers/hwtracing/coresight/coresight-trace-id.h -- 2.17.1

2 years, 8 months

Make Coresight Secure World Only

by finn.burmester＠student.uni-luebeck.de

Hey, I want to restrict access to the Coresight registers to the secure world, so the normal world OS can not tamper with the tracing. Is this generally possible, and if yes, how? I already tried to use the address space controller (TZC-400) with the memory-addresses of the registers, but that didn’t work, because it is only for protecting DDR-memory regions, as I later found out. Best regards Finn

2 years, 9 months

Re: [PATCH v8 1/2] drivers/coresight: Add UltraSoc System Memory Buffer driver

by hejunhao

On 2022/8/17 2:00, Randy Dunlap wrote: Hi Randy, Thanks for your comments. > Hi-- > > On 8/16/22 06:16, Junhao He wrote: >> diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig >> index 514a9b8086e3..4380eb1a0a73 100644 >> --- a/drivers/hwtracing/coresight/Kconfig >> +++ b/drivers/hwtracing/coresight/Kconfig >> @@ -201,4 +201,14 @@ config CORESIGHT_TRBE >> >> To compile this driver as a module, choose M here: the module will be >> called coresight-trbe. > Please insert a blank line here like it is done elsewhere. I will fix it in the next version. Thanks. >> +config ULTRASOC_SMB >> + tristate "Ultrasoc system memory buffer drivers" >> + depends on ACPI && ARM64 && CORESIGHT_LINKS_AND_SINKS >> + help >> + This driver provides support for the Ultrasoc system memory buffer (SMB). >> + SMB is responsible for receiving the trace data from Coresight ETM devices >> + and storing them to a system buffer. >> + >> + To compile this driver as a module, choose M here: the module will be >> + called ultrasoc-smb. >> endif > thanks. Regards, Junhao.

2 years, 9 months

[PATCH v8 0/2] Add support for UltraSoc System Memory Buffer

by Junhao He

Add support for UltraSoc System Memory Buffer. Change since v7: - Use the macros for register bit flags and numbers of resource. - Fix punctuation. - Update the Date tag and the KernelVersion tag in the document. - Link: https://lore.kernel.org/lkml/20220712091353.34540-1-hejunhao3@huawei.com/ Change since v6: - Modify the code style and driver description according to Suzuki's comment. - Modify configuration of "drvdata->reading", to void problems in open/read concurrency scenario. - Rename the macro of "SMB_FLOW_MASK". - Use the "handle->head" to determine the page number and offset. - Link: https://lore.kernel.org/linux-arm-kernel/20220606130223.57354-1-liuqi115@hu… Change since v5: - Address the comments from Suzuki, add some comments in SMB document, and modify configuration of "drvdata->reading", to void problems in multi-core concurrency scenario - Link: https://lore.kernel.org/linux-arm-kernel/20220416083953.52610-1-liuqi115@hu… Change since v4: - Add a simple document of SMB driver according to Suzuki's comment. - Address the comments from Suzuki. - Link: https://lore.kernel.org/linux-arm-kernel/20220128061755.31909-1-liuqi115@hu… Change since v3: - Modify the file header according to community specifications. - Address the comments from Mathieu. - Link: https://lore.kernel.org/linux-arm-kernel/20211118110016.40398-1-liuqi115@hu… Change since v2: - Move ultrasoc driver to drivers/hwtracing/coresight. - Link: https://lists.linaro.org/pipermail/coresight/2021-November/007310.html Change since v1: - Drop the document of UltraSoc according to Mathieu's comment. - Add comments to explain some private hardware settings. - Address the comments from Mathieu. - Link: https://lists.linaro.org/pipermail/coresight/2021-August/006842.html Change since RFC: - Move driver to drivers/hwtracing/coresight/ultrasoc. - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in basic tracing function. - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. - Address the comments from Mathieu and Suzuki. - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html Qi Liu (2): drivers/coresight: Add UltraSoc System Memory Buffer driver Documentation: Add document for UltraSoc SMB drivers .../sysfs-bus-coresight-devices-ultra_smb | 31 + .../trace/coresight/ultrasoc-smb.rst | 80 +++ drivers/hwtracing/coresight/Kconfig | 10 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/ultrasoc-smb.c | 636 ++++++++++++++++++ drivers/hwtracing/coresight/ultrasoc-smb.h | 115 ++++ 6 files changed, 873 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb create mode 100644 Documentation/trace/coresight/ultrasoc-smb.rst create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.c create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.h -- 2.33.0

2 years, 9 months

Regression with CTI driver on Arm Juno-r2 board

by Leo Yan

Hi Mike & all, [ + CoreSight Mailing List ] At my side, I found the perf cs-etm regression. When I execute cs-etm test with below commands: # perf test list ... 87: Check Arm CoreSight trace data recording and synthesized samples ... $ perf test -v 87 Then it's stuck and has no response. In the console, sometimes I can see the log: [ 94.248480] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: Apparently, there have lockup and introduces CPU stuck. But I didn't narrow down furthermore if is a hardware lockup or software lockup. After git bisect, it's narrowed down the regression is related to the commit: e7676a00bc52b994960f89b118b0d548e4542372 is the first bad commit commit e7676a00bc52b994960f89b118b0d548e4542372 Author: Mike Leach <mike.leach(a)linaro.org> Date: Wed Apr 13 22:49:25 2022 +0100 arm64: dts: juno: add CTI entries to device tree Add Coresight Cross Trigger Interface(CTI) entries to the device tree for all the Juno variants. Link: https://lore.kernel.org/r/20220413214925.30359-1-mike.leach@linaro.org Reviewed-by: Mathieu Poirier <mathieu.poirier(a)linaro.org> Signed-off-by: Mike Leach <mike.leach(a)linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla(a)arm.com> I built Linux kernel with below commands: $KERNEL=/kernel/path $OUT=/build/out/path pushd $KERNEL make defconfig O=$OUT ./scripts/config --file $OUT/.config -e CONFIG_BPF_SYSCALL ./scripts/config --file $OUT/.config -e CONFIG_BPF_JIT_ALWAYS_ON ./scripts/config --file $OUT/.config -e CONFIG_TRACEPOINTS ./scripts/config --file $OUT/.config -e CONFIG_KPROBES ./scripts/config --file $OUT/.config -e CONFIG_UPROBES ./scripts/config --file $OUT/.config -e CONFIG_KRETPROBES ./scripts/config --file $OUT/.config -e CONFIG_PROC_KCORE ./scripts/config --file $OUT/.config -e CONFIG_NOP_TRACER ./scripts/config --file $OUT/.config -e CONFIG_TRACER_MAX_TRACE ./scripts/config --file $OUT/.config -e CONFIG_RING_BUFFER ./scripts/config --file $OUT/.config -e CONFIG_EVENT_TRACING ./scripts/config --file $OUT/.config -e CONFIG_CONTEXT_SWITCH_TRACER ./scripts/config --file $OUT/.config -e CONFIG_TRACING ./scripts/config --file $OUT/.config -e CONFIG_GENERIC_TRACER ./scripts/config --file $OUT/.config -e CONFIG_FTRACE ./scripts/config --file $OUT/.config -e CONFIG_FUNCTION_TRACER ./scripts/config --file $OUT/.config -e CONFIG_FUNCTION_GRAPH_TRACER ./scripts/config --file $OUT/.config -e CONFIG_SCHED_TRACER ./scripts/config --file $OUT/.config -e CONFIG_FTRACE_SYSCALLS ./scripts/config --file $OUT/.config -e CONFIG_TRACER_SNAPSHOT ./scripts/config --file $OUT/.config -e CONFIG_KPROBE_EVENTS ./scripts/config --file $OUT/.config -e CONFIG_UPROBE_EVENTS ./scripts/config --file $OUT/.config -e CONFIG_BPF_EVENTS ./scripts/config --file $OUT/.config -e CONFIG_DYNAMIC_EVENTS ./scripts/config --file $OUT/.config -e CONFIG_PROBE_EVENTS ./scripts/config --file $OUT/.config -e CONFIG_DYNAMIC_FTRACE ./scripts/config --file $OUT/.config -e CONFIG_PID_IN_CONTEXTIDR ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_LINKS_AND_SINKS ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_LINK_AND_SINK_TMC ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_CATU ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_SINK_TPIU ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_SINK_ETBV10 ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_SOURCE_ETM4X ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_STM ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_CPU_DEBUG ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_CTI ./scripts/config --file $OUT/.config -e CONFIG_CORESIGHT_CTI_INTEGRATION_REGS ./scripts/config --file $OUT/.config -e CONFIG_DEBUG_INFO ./scripts/config --file $OUT/.config -e CONFIG_DEBUG_INFO_DWARF5 ./scripts/config --file $OUT/.config -e CONFIG_DEBUG_INFO_BTF ./scripts/config --file $OUT/.config -d CONFIG_DEBUG_INFO_REDUCED yes "" | make oldconfig O=$OUT make -j `nproc` Image dtbs O=$OUT popd When I have some free time, will come back to dig more for it. If have any suggestion, please let me know, I am glad to try and test at my side. Thanks, Leo

2 years, 9 months

Re: [PATCH] coresight: Fix possible deadlock with lock dependency

by Mike Leach

Hi Sudeep, On Thu, 21 Jul 2022 at 14:03, Sudeep Holla <sudeep.holla(a)arm.com> wrote: > > With lockdeps enabled, we get the following warning: > > ====================================================== > WARNING: possible circular locking dependency detected > ------------------------------------------------------ > kworker/u12:1/53 is trying to acquire lock: > ffff80000adce220 (coresight_mutex){+.+.}-{4:4}, at: coresight_set_assoc_ectdev_mutex+0x3c/0x5c > but task is already holding lock: > ffff80000add1f60 (ect_mutex){+.+.}-{4:4}, at: cti_probe+0x318/0x394 > > which lock already depends on the new lock. > the existing dependency chain (in reverse order) is: > > -> #1 (ect_mutex){+.+.}-{4:4}: > __mutex_lock_common+0xd8/0xe60 > mutex_lock_nested+0x44/0x50 > cti_add_assoc_to_csdev+0x4c/0x184 > coresight_register+0x2f0/0x314 > tmc_probe+0x33c/0x414 > > -> #0 (coresight_mutex){+.+.}-{4:4}: > __lock_acquire+0x1a20/0x32d0 > lock_acquire+0x160/0x308 > __mutex_lock_common+0xd8/0xe60 > mutex_lock_nested+0x44/0x50 > coresight_set_assoc_ectdev_mutex+0x3c/0x5c > cti_update_conn_xrefs+0x6c/0xf8 > cti_probe+0x33c/0x394 > > other info that might help us debug this: > Possible unsafe locking scenario: > CPU0 CPU1 > ---- ---- > lock(ect_mutex); > lock(coresight_mutex); > lock(ect_mutex); > lock(coresight_mutex); > *** DEADLOCK *** > > 4 locks held by kworker/u12:1/53: > #0: ((wq_completion)events_unbound){+.+.}-{0:0}, at: process_one_work+0x1fc/0x63c > #1: (deferred_probe_work){+.+.}-{0:0}, at: process_one_work+0x228/0x63c > #2: (&dev->mutex){....}-{4:4}, at: __device_attach+0x48/0x1a8 > #3: (ect_mutex){+.+.}-{4:4}, at: cti_probe+0x318/0x394 > > To fix the same, call cti_add_assoc_to_csdev without the holding > coresight_mutex and confine the locking while setting the associated > ect / cti device using coresight_set_assoc_ectdev_mutex(). > > Cc: Mathieu Poirier <mathieu.poirier(a)linaro.org> > Cc: Suzuki K Poulose <suzuki.poulose(a)arm.com> > Cc: Mike Leach <mike.leach(a)linaro.org> > Cc: Leo Yan <leo.yan(a)linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla(a)arm.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 7 ++++--- > drivers/hwtracing/coresight/coresight-cti-core.c | 5 +++-- > 2 files changed, 7 insertions(+), 5 deletions(-) > > Hi, > > I am not sure if I missed to consider something, but this is something > I think could be the fix. > > Regards, > Sudeep > I have been running with lockdep testing coresight for a number of weeks now, without encountering the same issue with CTIs. That said, I am on a DB410, and the code in question is designed to take different paths depending on whether the CTI or other device is discovered first, so this could well be something different in the discovery order between juno and DB410. The change looks perfectly fine to me. As such: Reviewed-by: Mike Leach <mike.leach(a)linaro.org> > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 1edfec1e9d18..275b4dce8401 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1659,14 +1659,15 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > ret = coresight_fixup_device_conns(csdev); > if (!ret) > ret = coresight_fixup_orphan_conns(csdev); > - if (!ret && cti_assoc_ops && cti_assoc_ops->add) > - cti_assoc_ops->add(csdev); > > out_unlock: > mutex_unlock(&coresight_mutex); > /* Success */ > - if (!ret) > + if (!ret) { > + if (cti_assoc_ops && cti_assoc_ops->add) > + cti_assoc_ops->add(csdev); > return csdev; > + } > > /* Unregister the device if needed */ > if (registered) { > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index 8988b2ed2ea6..1be92342b5b9 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -541,7 +541,7 @@ cti_match_fixup_csdev(struct cti_device *ctidev, const char *node_name, > /* > * Search the cti list to add an associated CTI into the supplied CS device > * This will set the association if CTI declared before the CS device. > - * (called from coresight_register() with coresight_mutex locked). > + * (called from coresight_register() without coresight_mutex locked). > */ > static void cti_add_assoc_to_csdev(struct coresight_device *csdev) > { > @@ -569,7 +569,8 @@ static void cti_add_assoc_to_csdev(struct coresight_device *csdev) > * if we found a matching csdev then update the ECT > * association pointer for the device with this CTI. > */ > - csdev->ect_dev = ect_item->csdev; > + coresight_set_assoc_ectdev_mutex(csdev->ect_dev, > + ect_item->csdev); > break; > } > } > -- > 2.37.1 > -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK

2 years, 9 months

[PATCH v7 00/14] perf: test: Add trace data quality tests for CoreSight

by carsten.haitzler＠foss.arm.com

From: Carsten Haitzler <carsten.haitzler(a)arm.com> This is a prelude to adding more tests to shell tests and in order to support putting those tests into subdirectories, I need to change the test code that scans/finds and runs them. To support subdirs I have to recurse so it's time to refactor the code to allow this and centralize the shell script finding into one location and only one single scan that builds a list of all the found tests in memory instead of it being duplicated in 3 places. This code also optimizes things like knowing the max width of desciption strings (as we can do that while we scan instead of a whole new pass of opening files). It also more cleanly filters scripts to see only *.sh files thus skipping random other files in directories like *~ backup files, other random junk/data files that may appear and the scripts must be executable to make the cut (this ensures the script lib dir is not seen as scripts to run). This avoids perf test running previous older versions of test scripts that are editor backup files as well as skipping perf.data files that may appear and so on. Signed-off-by: Carsten Haitzler <carsten.haitzler(a)arm.com> Carsten Haitzler (14): perf test: Refactor shell tests allowing subdirs perf test: Add CoreSight shell lib shared code for future tests perf test: Add build infra for perf test tools for CoreSight tests perf test: Add asm pureloop test tool perf test: Add asm pureloop test shell script perf test: Add git ignore for perf data generated by the CoreSight tests perf test: Add memcpy thread test tool perf test: Add memcpy thread test shell script perf test: Add thread loop test tool perf test: Add thread loop test shell scripts perf test: Add unroll thread test tool perf test: Add unroll thread test shell script perf test: Add git ignore for tmp and output files of CoreSight tests perf test: Add relevant documentation about CoreSight testing .../trace/coresight/coresight-perf.rst | 158 +++++++++++++ MAINTAINERS | 1 + tools/perf/.gitignore | 6 +- .../perf/Documentation/perf-arm-coresight.txt | 5 + tools/perf/Makefile.config | 2 + tools/perf/Makefile.perf | 17 +- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test-list.c | 207 ++++++++++++++++++ tools/perf/tests/builtin-test-list.h | 12 + tools/perf/tests/builtin-test.c | 152 ++----------- tools/perf/tests/shell/coresight/Makefile | 30 +++ .../tests/shell/coresight/Makefile.miniconfig | 14 ++ .../tests/shell/coresight/asm_pure_loop.sh | 18 ++ .../shell/coresight/asm_pure_loop/.gitignore | 1 + .../shell/coresight/asm_pure_loop/Makefile | 34 +++ .../coresight/asm_pure_loop/asm_pure_loop.S | 28 +++ .../shell/coresight/memcpy_thread/.gitignore | 1 + .../shell/coresight/memcpy_thread/Makefile | 33 +++ .../coresight/memcpy_thread/memcpy_thread.c | 79 +++++++ .../shell/coresight/memcpy_thread_16k_10.sh | 18 ++ .../shell/coresight/thread_loop/.gitignore | 1 + .../shell/coresight/thread_loop/Makefile | 33 +++ .../shell/coresight/thread_loop/thread_loop.c | 86 ++++++++ .../coresight/thread_loop_check_tid_10.sh | 19 ++ .../coresight/thread_loop_check_tid_2.sh | 19 ++ .../coresight/unroll_loop_thread/.gitignore | 1 + .../coresight/unroll_loop_thread/Makefile | 33 +++ .../unroll_loop_thread/unroll_loop_thread.c | 74 +++++++ .../shell/coresight/unroll_loop_thread_10.sh | 18 ++ tools/perf/tests/shell/lib/coresight.sh | 132 +++++++++++ 30 files changed, 1094 insertions(+), 139 deletions(-) create mode 100644 Documentation/trace/coresight/coresight-perf.rst create mode 100644 tools/perf/Documentation/perf-arm-coresight.txt create mode 100644 tools/perf/tests/builtin-test-list.c create mode 100644 tools/perf/tests/builtin-test-list.h create mode 100644 tools/perf/tests/shell/coresight/Makefile create mode 100644 tools/perf/tests/shell/coresight/Makefile.miniconfig create mode 100755 tools/perf/tests/shell/coresight/asm_pure_loop.sh create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c create mode 100755 tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh create mode 100644 tools/perf/tests/shell/coresight/thread_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/thread_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/thread_loop/thread_loop.c create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c create mode 100755 tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh create mode 100644 tools/perf/tests/shell/lib/coresight.sh -- 2.32.0

2 years, 9 months

[PATCH v6 00/14] perf: test: Add trace data quality tests for CoreSight

by carsten.haitzler＠foss.arm.com

From: "Carsten Haitzler (Rasterman)" <raster(a)rasterman.com> This is a prelude to adding more tests to shell tests and in order to support putting those tests into subdirectories, I need to change the test code that scans/finds and runs them. To support subdirs I have to recurse so it's time to refactor the code to allow this and centralize the shell script finding into one location and only one single scan that builds a list of all the found tests in memory instead of it being duplicated in 3 places. This code also optimizes things like knowing the max width of desciption strings (as we can do that while we scan instead of a whole new pass of opening files). It also more cleanly filters scripts to see only *.sh files thus skipping random other files in directories like *~ backup files, other random junk/data files that may appear and the scripts must be executable to make the cut (this ensures the script lib dir is not seen as scripts to run). This avoids perf test running previous older versions of test scripts that are editor backup files as well as skipping perf.data files that may appear and so on. Signed-off-by: Carsten Haitzler <carsten.haitzler(a)arm.com> Carsten Haitzler (Rasterman) (14): perf test: Refactor shell tests allowing subdirs perf test: Add CoreSight shell lib shared code for future tests perf test: Add build infra for perf test tools for CoreSight tests perf test: Add asm pureloop test tool perf test: Add asm pureloop test shell script perf test: Add git ignore for perf data generated by the CoreSight tests perf test: Add memcpy thread test tool perf test: Add memcpy thread test shell script perf test: Add thread loop test tool perf test: Add thread loop test shell scripts perf test: Add unroll thread test tool perf test: Add unroll thread test shell script perf test: Add git ignore for tmp and output files of CoreSight tests perf test: Add relevant documentation about CoreSight testing .../trace/coresight/coresight-perf.rst | 158 +++++++++++++ MAINTAINERS | 1 + tools/perf/.gitignore | 6 +- .../perf/Documentation/perf-arm-coresight.txt | 5 + tools/perf/Makefile.config | 2 + tools/perf/Makefile.perf | 17 +- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test-list.c | 207 ++++++++++++++++++ tools/perf/tests/builtin-test-list.h | 12 + tools/perf/tests/builtin-test.c | 152 ++----------- tools/perf/tests/shell/coresight/Makefile | 30 +++ .../tests/shell/coresight/Makefile.miniconfig | 14 ++ .../tests/shell/coresight/asm_pure_loop.sh | 18 ++ .../shell/coresight/asm_pure_loop/.gitignore | 1 + .../shell/coresight/asm_pure_loop/Makefile | 34 +++ .../coresight/asm_pure_loop/asm_pure_loop.S | 28 +++ .../shell/coresight/memcpy_thread/.gitignore | 1 + .../shell/coresight/memcpy_thread/Makefile | 33 +++ .../coresight/memcpy_thread/memcpy_thread.c | 79 +++++++ .../shell/coresight/memcpy_thread_16k_10.sh | 18 ++ .../shell/coresight/thread_loop/.gitignore | 1 + .../shell/coresight/thread_loop/Makefile | 33 +++ .../shell/coresight/thread_loop/thread_loop.c | 86 ++++++++ .../coresight/thread_loop_check_tid_10.sh | 19 ++ .../coresight/thread_loop_check_tid_2.sh | 19 ++ .../coresight/unroll_loop_thread/.gitignore | 1 + .../coresight/unroll_loop_thread/Makefile | 33 +++ .../unroll_loop_thread/unroll_loop_thread.c | 74 +++++++ .../shell/coresight/unroll_loop_thread_10.sh | 18 ++ tools/perf/tests/shell/lib/coresight.sh | 132 +++++++++++ 30 files changed, 1094 insertions(+), 139 deletions(-) create mode 100644 Documentation/trace/coresight/coresight-perf.rst create mode 100644 tools/perf/Documentation/perf-arm-coresight.txt create mode 100644 tools/perf/tests/builtin-test-list.c create mode 100644 tools/perf/tests/builtin-test-list.h create mode 100644 tools/perf/tests/shell/coresight/Makefile create mode 100644 tools/perf/tests/shell/coresight/Makefile.miniconfig create mode 100755 tools/perf/tests/shell/coresight/asm_pure_loop.sh create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c create mode 100755 tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh create mode 100644 tools/perf/tests/shell/coresight/thread_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/thread_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/thread_loop/thread_loop.c create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c create mode 100755 tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh create mode 100644 tools/perf/tests/shell/lib/coresight.sh -- 2.32.0

2 years, 9 months

[PATCH v5 00/14] A patch series improving data quality of perf test for CoreSight

by carsten.haitzler＠foss.arm.com

From: "Carsten Haitzler (Rasterman)" <raster(a)rasterman.com> This is a prelude to adding more tests to shell tests and in order to support putting those tests into subdirectories, I need to change the test code that scans/finds and runs them. To support subdirs I have to recurse so it's time to refactor the code to allow this and centralize the shell script finding into one location and only one single scan that builds a list of all the found tests in memory instead of it being duplicated in 3 places. This code also optimizes things like knowing the max width of desciption strings (as we can do that while we scan instead of a whole new pass of opening files). It also more cleanly filters scripts to see only *.sh files thus skipping random other files in directories like *~ backup files, other random junk/data files that may appear and the scripts must be executable to make the cut (this ensures the script lib dir is not seen as scripts to run). This avoids perf test running previous older versions of test scripts that are editor backup files as well as skipping perf.data files that may appear and so on. Signed-off-by: Carsten Haitzler <carsten.haitzler(a)arm.com> Carsten Haitzler (Rasterman) (14): perf test: Refactor shell tests allowing subdirs perf test: Add CoreSight shell lib shared code for future tests perf test: Add build infra for perf test tools for CoreSight tests perf test: Add asm pureloop test tool perf test: Add asm pureloop test shell script perf test: Add git ignore for perf data generated by the CoreSight tests perf test: Add memcpy thread test tool perf test: Add memcpy thread test shell script perf test: Add thread loop test tool perf test: Add thread loop test shell scripts perf test: Add unroll thread test tool perf test: Add unroll thread test shell script perf test: Add git ignore for tmp and output files of CoreSight tests perf test: Add relevant documentation about CoreSight testing .../trace/coresight/coresight-perf.rst | 160 ++++++++++++++ MAINTAINERS | 1 + tools/perf/.gitignore | 6 +- tools/perf/Documentation/arm-coresight.txt | 5 + tools/perf/Makefile.perf | 18 +- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test-list.c | 207 ++++++++++++++++++ tools/perf/tests/builtin-test-list.h | 12 + tools/perf/tests/builtin-test.c | 152 ++----------- tools/perf/tests/shell/coresight/Makefile | 30 +++ .../tests/shell/coresight/Makefile.miniconfig | 24 ++ .../tests/shell/coresight/asm_pure_loop.sh | 18 ++ .../shell/coresight/asm_pure_loop/.gitignore | 1 + .../shell/coresight/asm_pure_loop/Makefile | 34 +++ .../coresight/asm_pure_loop/asm_pure_loop.S | 28 +++ .../shell/coresight/memcpy_thread/.gitignore | 1 + .../shell/coresight/memcpy_thread/Makefile | 33 +++ .../coresight/memcpy_thread/memcpy_thread.c | 79 +++++++ .../shell/coresight/memcpy_thread_16k_10.sh | 18 ++ .../shell/coresight/thread_loop/.gitignore | 1 + .../shell/coresight/thread_loop/Makefile | 33 +++ .../shell/coresight/thread_loop/thread_loop.c | 86 ++++++++ .../coresight/thread_loop_check_tid_10.sh | 19 ++ .../coresight/thread_loop_check_tid_2.sh | 19 ++ .../coresight/unroll_loop_thread/.gitignore | 1 + .../coresight/unroll_loop_thread/Makefile | 33 +++ .../unroll_loop_thread/unroll_loop_thread.c | 74 +++++++ .../shell/coresight/unroll_loop_thread_10.sh | 18 ++ tools/perf/tests/shell/lib/coresight.sh | 132 +++++++++++ 29 files changed, 1105 insertions(+), 139 deletions(-) create mode 100644 Documentation/trace/coresight/coresight-perf.rst create mode 100644 tools/perf/Documentation/arm-coresight.txt create mode 100644 tools/perf/tests/builtin-test-list.c create mode 100644 tools/perf/tests/builtin-test-list.h create mode 100644 tools/perf/tests/shell/coresight/Makefile create mode 100644 tools/perf/tests/shell/coresight/Makefile.miniconfig create mode 100755 tools/perf/tests/shell/coresight/asm_pure_loop.sh create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/memcpy_thread/memcpy_thread.c create mode 100755 tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh create mode 100644 tools/perf/tests/shell/coresight/thread_loop/.gitignore create mode 100644 tools/perf/tests/shell/coresight/thread_loop/Makefile create mode 100644 tools/perf/tests/shell/coresight/thread_loop/thread_loop.c create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/.gitignore create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/Makefile create mode 100644 tools/perf/tests/shell/coresight/unroll_loop_thread/unroll_loop_thread.c create mode 100755 tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh create mode 100644 tools/perf/tests/shell/lib/coresight.sh -- 2.32.0

2 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight