CoreSight

coresight@lists.linaro.org

5 participants
2730 discussions

[PATCH] coresight: etm3x: Remove redundant NULL check on perf event attr

by James Clark

attr is derived from &event->attr, so it can never be NULL even if event were NULL, making the check dead code. The only caller, etm_enable_perf(), always passes a valid event anyway, so remove the check. Reported-by: Sashiko <sashiko-bot(a)kernel.org> Closes: https://sashiko.dev/#/bug/linux-c4ca0d3c-1e98-4965-aa46-da226c756b83 Signed-off-by: James Clark <james.clark(a)linaro.org> --- drivers/hwtracing/coresight/coresight-etm3x-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index b670a324bb41..755141691f69 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -313,9 +313,6 @@ static int etm_parse_event_config(struct etm_drvdata *drvdata, struct perf_event_attr *attr = &event->attr; u8 ts_level; - if (!attr) - return -EINVAL; - /* Clear configuration from previous run */ memset(curr_config, 0, sizeof(struct etm_config)); --- base-commit: 343cfcbb3ecfdb80aa576a428cfa3b65ad783842 change-id: 20261027-james-cs-redundant-null-check-b1489a0ba03c Best regards, -- James Clark <james.clark(a)linaro.org>

1 week, 6 days

Re: [PATCH v6] coresight: coresight.h: add '*' to kernel-doc lines

by Suzuki K Poulose

On Mon, 02 Nov 2026 09:57:51 -0800, Randy Dunlap wrote: > kernel-doc reports 2 (kernel-doc) lines in coresight.h that don't have > a beginning '*' in them, so fix these lines. > > Also convert struct coresight_trace_id_map to kernel-doc format to > remove another warning. > > Warning: include/linux/coresight.h:173 bad line: > connected to @src_port. NULL until the device is created > Warning: include/linux/coresight.h:177 bad line: > needs to be filtered. > Warning: include/linux/coresight.h:236 This comment starts with '/**', > but isn't a kernel-doc comment. > > [...] Applied, thanks! [1/1] coresight: coresight.h: add '*' to kernel-doc lines https://git.kernel.org/coresight/c/02ab6256e4f5 Best regards, -- Suzuki K Poulose <suzuki.poulose(a)arm.com>

1 week, 6 days

Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"

by James Clark

On 28/10/2026 18:31, Colin Ian King wrote: > There is a spelling mistake in a pr_err error message. Fix it. > > Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index bdcf94813129..65bce2450549 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm) > continue; > > if (!intlist__empty(etmq->traceid_list)) { > - pr_err("CS_ETM: Unformatted queue should't have trace ID\n"); > + pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n"); > return -EINVAL; > } > Reviewed-by: James Clark <james.clark(a)linaro.org>

1 week, 6 days

[PATCH v3 00/14] perf cs-etm: Fix bogus branch samples on exceptions

by Leo Yan

CoreSight currently models exception entry by changing the preceding instruction range into a taken branch. This can give an IRQ the source PC of an instruction that already retired and overwrite a real branch immediately before the exception. For an untaken B.LS followed by an IRQ, perf script currently reports: hw int 4000f8 => ffff800080010c80 b.ls #0x400118 ... iret ffff800080012284 => 4000fc eret The hardware trace supplies 0x4000fc as the preferred return address. For an IRQ, this is the architectural resume PC (Arm ARM, R_VBQMV). B.LS has retired, and the saved PC identifies the boundary before the following MOV. Using this PC as the IRQ source reflects the architectural state at exception entry: hw int 4000fc => ffff800080010c80 movz x2, #0x1796 ... iret ffff800080012284 => 4000fc eret The IRQ sample represents the transfer from this architectural execution position to the handler. The series synthesizes exception entries from exception packets, preserving the preceding branch and its outcome. The supporting changes: - Let decoders supply sample.ret_addr so later instruction fetching cannot change thread-stack return addresses. Apply this to Intel PT asynchronous samples as well. - Prepare packet ISA and instruction-size handling and share sample synthesis helpers. Mark untaken branches and break history when instruction memory is unavailable. - Add a thread-stack regression test and four AArch64 CoreSight tests. IRQs and page faults must resume at the entry PC; SVC and emulated MRS must resume four bytes later. Based on the AI search and test on my x86 machine, this matches perf's Intel PT handling of IRQs. Intel PT records the next instruction's IP in the FUP packet, and Perf uses that IP as the interrupt sample's source. This series is verified on Orion6 board with "perf test coresight". Signed-off-by: Leo Yan <leo.yan(a)arm.com> --- Changes in v3: - Introduced the pref_ret_addr/end_addr union (James). - Clarified zero-size A32/A64 exception handling and why T32 retains per-address instruction decoding (James). - Retreed missing exception pairs for up to three recordings, then fail instead of skipping (James). - Shorten the IRQ workload (James). - Fix FIFO argument quoting and remove redundant ShellCheck source directives (James). - Checked instruction length before copying bytes into sample->insn (Sashiko). - Retried MRS checks when instruction page faults may match the opcode filter (Sashiko). - Rebased onto the updated perf tree and collect review tags. - Link to v2: https://lore.kernel.org/r/20260923-perf_cs_etm_fix_non_taken-v2-0-6ab8c07a5… Changes in v2: - Rework the fix around exception packets to preserve both exception entries and preceding branches. - Add explicit return addresses and the Intel PT asynchronous-branch fix. - Split out packet/synthesis preparation, record not-taken branches and handle unreadable instruction memory. - Add thread-stack regression coverage and four CoreSight tests. - Link to v1: https://lore.kernel.org/r/20260713-perf_cs_etm_fix_non_taken-v1-0-4561607fc… --- Leo Yan (14): perf sample: Allow decoders to supply branch return addresses perf intel-pt: Preserve return addresses for asynchronous branches perf cs-etm: Break branch history when instruction memory is unavailable perf cs-etm: Centralize packet ISA initialization perf cs-etm: Use the recorded instruction size for A32 and A64 perf cs-etm: Mark branches that were not taken perf cs-etm: Factor out final instruction sample synthesis perf cs-etm: Centralize branch sample synthesis checks perf cs-etm: Classify exception calls using the exception packet perf cs-etm: Synthesize exception entries separately from branches perf tests: Check CoreSight IRQ entry and exit perf tests: Check CoreSight syscall entry and exit perf tests: Check CoreSight abort entry and exit perf tests: Check CoreSight emulated instruction entry and exit tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 3 + .../perf/tests/shell/coresight/abort_entry_exit.sh | 32 +++ tools/perf/tests/shell/coresight/irq_entry_exit.sh | 36 +++ .../tests/shell/coresight/syscall_entry_exit.sh | 32 +++ .../perf/tests/shell/coresight/trap_entry_exit.sh | 39 ++++ tools/perf/tests/shell/lib/coresight_exception.sh | 164 ++++++++++++++ tools/perf/tests/tests.h | 3 + tools/perf/tests/thread-stack.c | 106 +++++++++ tools/perf/tests/workloads/Build | 4 + tools/perf/tests/workloads/branch_not_taken_loop.c | 33 +++ tools/perf/tests/workloads/page_fault_loop.c | 37 ++++ tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 106 ++++++--- tools/perf/util/cs-etm.c | 246 +++++++++++---------- tools/perf/util/cs-etm.h | 6 +- tools/perf/util/intel-pt.c | 7 + tools/perf/util/sample.c | 1 + tools/perf/util/sample.h | 5 + tools/perf/util/thread-stack.c | 5 +- 19 files changed, 714 insertions(+), 152 deletions(-) --- base-commit: 4626d370ae89b8af4d46a45372b269f926ec662d change-id: 20260713-perf_cs_etm_fix_non_taken-5b4d7f73f41e Best regards, -- Leo Yan <leo.yan(a)arm.com>

1 week, 6 days

[PATCH v2 00/14] perf cs-etm: Fix bogus branch samples on exceptions

by Leo Yan

CoreSight currently models exception entry by changing the preceding instruction range into a taken branch. This can give an IRQ the source PC of an instruction that already retired and overwrite a real branch immediately before the exception. For an untaken B.LS followed by an IRQ, perf script currently reports: hw int 4000f8 => ffff800080010c80 b.ls #0x400118 ... iret ffff800080012284 => 4000fc eret The hardware trace supplies 0x4000fc as the preferred return address. For an IRQ, this is the architectural resume PC (Arm ARM, R_VBQMV). B.LS has retired, and the saved PC identifies the boundary before the following MOV. Using this PC as the IRQ source reflects the architectural state at exception entry: hw int 4000fc => ffff800080010c80 movz x2, #0x1796 ... iret ffff800080012284 => 4000fc eret The IRQ sample represents the transfer from this architectural execution position to the handler. The series synthesizes exception entries from exception packets, preserving the preceding branch and its outcome. The supporting changes: - Let decoders supply sample.ret_addr so later instruction fetching cannot change thread-stack return addresses. Apply this to Intel PT asynchronous samples as well. - Prepare packet ISA and instruction-size handling and share sample synthesis helpers. Mark untaken branches and break history when instruction memory is unavailable. - Add a thread-stack regression test and four AArch64 CoreSight tests. IRQs and page faults must resume at the entry PC; SVC and emulated MRS must resume four bytes later. Based on the AI search and test on my x86 machine, this matches perf's Intel PT handling of IRQs. Intel PT records the next instruction's IP in the FUP packet, and Perf uses that IP as the interrupt sample's source. This series is verified on Orion6 board with "perf test coresight". Signed-off-by: Leo Yan <leo.yan(a)arm.com> --- Changes in v2: - Rework the fix around exception packets to preserve both exception entries and preceding branches. - Add explicit return addresses and the Intel PT asynchronous-branch fix. - Split out packet/synthesis preparation, record not-taken branches and handle unreadable instruction memory. - Add thread-stack regression coverage and four CoreSight tests. - Link to v1: https://lore.kernel.org/r/20260713-perf_cs_etm_fix_non_taken-v1-0-4561607fc… --- Leo Yan (14): perf sample: Allow decoders to supply branch return addresses perf intel-pt: Preserve return addresses for asynchronous branches perf cs-etm: Break branch history when instruction memory is unavailable perf cs-etm: Centralize packet ISA initialization perf cs-etm: Use the recorded instruction size for A32 and A64 perf cs-etm: Mark branches that were not taken perf cs-etm: Factor out final instruction sample synthesis perf cs-etm: Centralize branch sample synthesis checks perf cs-etm: Classify exception calls using the exception packet perf cs-etm: Synthesize exception entries separately from branches perf tests: Check CoreSight IRQ entry and exit perf tests: Check CoreSight syscall entry and exit perf tests: Check CoreSight abort entry and exit perf tests: Check CoreSight emulated instruction entry and exit tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 3 + .../perf/tests/shell/coresight/abort_entry_exit.sh | 21 ++ tools/perf/tests/shell/coresight/irq_entry_exit.sh | 37 ++++ .../tests/shell/coresight/syscall_entry_exit.sh | 21 ++ .../perf/tests/shell/coresight/trap_entry_exit.sh | 24 +++ tools/perf/tests/shell/lib/coresight_exception.sh | 165 +++++++++++++++ tools/perf/tests/tests.h | 3 + tools/perf/tests/thread-stack.c | 106 ++++++++++ tools/perf/tests/workloads/Build | 4 + tools/perf/tests/workloads/branch_not_taken_loop.c | 33 +++ tools/perf/tests/workloads/page_fault_loop.c | 37 ++++ tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 106 +++++++--- tools/perf/util/cs-etm.c | 222 ++++++++++----------- tools/perf/util/cs-etm.h | 2 + tools/perf/util/intel-pt.c | 7 + tools/perf/util/sample.c | 1 + tools/perf/util/sample.h | 5 + tools/perf/util/thread-stack.c | 5 +- 19 files changed, 656 insertions(+), 147 deletions(-) --- base-commit: edd8a9fe2eca009599e013a29c421c7a6b5ad1b9 change-id: 20260713-perf_cs_etm_fix_non_taken-5b4d7f73f41e Best regards, -- Leo Yan <leo.yan(a)arm.com>

2 weeks, 3 days

[PATCH] coresight: handle runtime PM resume failures

by Yuanfang Zhang

When a CoreSight component's parent power domain, such as a CPU cluster genpd, fails to power on, runtime resume returns a negative error. Several call sites ignored that error and continued to access registers on an unpowered device, risking an external abort. Replace the remaining pm_runtime_get_sync() calls with pm_runtime_resume_and_get(), which restores the runtime PM usage count when resume fails. Abort before accessing hardware and propagate the error to the caller. In coresight_get_ref(), unwind the module and device references. In debug_enable_func(), roll back the CPUs that resumed successfully before the failure. Finally, release the mode acquired by stm_enable() if its runtime resume fails. Signed-off-by: Yuanfang Zhang <yuanfang.zhang(a)oss.qualcomm.com> --- This patch converts the remaining CoreSight pm_runtime_get_sync() users to pm_runtime_resume_and_get(), propagates resume failures before hardware access, and completes the related module, device, CPU and mode unwind paths. --- drivers/hwtracing/coresight/coresight-core.c | 13 ++++++++++--- drivers/hwtracing/coresight/coresight-cpu-debug.c | 10 +++++----- drivers/hwtracing/coresight/coresight-cti-sysfs.c | 10 ++++++++-- drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 10 ++++++++-- drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 5 ++++- drivers/hwtracing/coresight/coresight-funnel.c | 5 ++++- drivers/hwtracing/coresight/coresight-stm.c | 7 ++++++- drivers/hwtracing/coresight/coresight-sysfs.c | 11 +++++++++-- 8 files changed, 54 insertions(+), 17 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 928488a216d4eafa3cdb5f882ae5f44ddaff0448..ff93a017dbe22b01236ac2e5021da9b82890e72c 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -822,14 +822,16 @@ struct coresight_device *coresight_get_sink_by_id(u32 id) * * @csdev: The coresight device to get a reference on. * - * Return true in successful case and power up the device. - * Return false when failed to get reference of module. + * Return true on success and power up the device. + * Return false if a reference cannot be obtained or the device cannot be + * powered up. */ static bool coresight_get_ref(struct coresight_device *csdev) { struct device *dev = &csdev->dev; struct device *parent = csdev->dev.parent; struct device_driver *drv; + int ret; /* Make sure csdev can't go away */ get_device(dev); @@ -843,9 +845,14 @@ static bool coresight_get_ref(struct coresight_device *csdev) goto err_module; /* Make sure the device is powered on */ - pm_runtime_get_sync(parent); + ret = pm_runtime_resume_and_get(parent); + if (ret < 0) + goto err_pm; + return true; +err_pm: + module_put(drv->owner); err_module: put_device(parent); put_device(dev); diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c index 3a806c1d50eafb4249ab516ef846e437831b9681..39602d610e5b22ec4f165dbb126a7c06aea08eb0 100644 --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c @@ -429,19 +429,19 @@ static int debug_enable_func(void) if (!drvdata) continue; - ret = pm_runtime_get_sync(drvdata->dev); + ret = pm_runtime_resume_and_get(drvdata->dev); if (ret < 0) goto err; - else - cpumask_set_cpu(cpu, &mask); + + cpumask_set_cpu(cpu, &mask); } return 0; err: /* - * If pm_runtime_get_sync() has failed, need rollback on - * all the other CPUs that have been enabled before that. + * If runtime resume has failed, roll back all the other CPUs + * that have been enabled before that. */ for_each_cpu(cpu, &mask) { drvdata = per_cpu(debug_drvdata, cpu); diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c index 3fe2c916d228808233ef19e9213a0cc0ce3cf297..6886b8713368058b9cf33ab7fafb5f87e23c1ec9 100644 --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c @@ -167,8 +167,11 @@ static ssize_t coresight_cti_reg_show(struct device *dev, struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); struct cs_off_attribute *cti_attr = container_of(attr, struct cs_off_attribute, attr); u32 val = 0; + int ret; - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; scoped_guard(raw_spinlock_irqsave, &drvdata->spinlock) val = cti_read_single_reg(drvdata, cti_attr->off); @@ -185,11 +188,14 @@ static __maybe_unused ssize_t coresight_cti_reg_store(struct device *dev, struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); struct cs_off_attribute *cti_attr = container_of(attr, struct cs_off_attribute, attr); unsigned long val = 0; + int ret; if (kstrtoul(buf, 0, &val)) return -EINVAL; - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; scoped_guard(raw_spinlock_irqsave, &drvdata->spinlock) cti_write_single_reg(drvdata, cti_attr->off, val); diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c index b3c67e96a82a4995515457d1ac0a5b183b162f0f..b34e282ec4a5f37f7de1d2ff118042b47368acd7 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c @@ -47,8 +47,11 @@ static ssize_t etmsr_show(struct device *dev, { unsigned long flags, val; struct etm_drvdata *drvdata = dev_get_drvdata(dev->parent); + int ret; - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; spin_lock_irqsave(&drvdata->spinlock, flags); CS_UNLOCK(drvdata->csa.base); @@ -933,13 +936,16 @@ static ssize_t seq_curr_state_show(struct device *dev, unsigned long val, flags; struct etm_drvdata *drvdata = dev_get_drvdata(dev->parent); struct etm_config *config = &drvdata->config; + int ret; if (!coresight_get_mode(drvdata->csdev)) { val = config->seq_curr_state; goto out; } - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; spin_lock_irqsave(&drvdata->spinlock, flags); CS_UNLOCK(drvdata->csa.base); diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c index cc6cdd3ae29d502a2e67f07400de957b6dc71af6..55e05c20b302d4bf55c4df30c9ee6d6a1b5f1031 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c @@ -2457,10 +2457,13 @@ static ssize_t coresight_etm4x_reg_show(struct device *dev, { u32 val, offset; struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); + int ret; offset = coresight_etm4x_attr_to_offset(d_attr); - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; val = etmv4_cross_read(drvdata, offset); pm_runtime_put_sync(dev->parent); diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index 0abc11f0690c5272ebd55df9e98544e3b401cfe6..5824a1e4d046a3caf5b32ed1d8526b8bd7e9ca76 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -190,9 +190,12 @@ static ssize_t funnel_ctrl_show(struct device *dev, struct device_attribute *attr, char *buf) { u32 val; + int ret; struct funnel_drvdata *drvdata = dev_get_drvdata(dev->parent); - pm_runtime_get_sync(dev->parent); + ret = pm_runtime_resume_and_get(dev->parent); + if (ret < 0) + return ret; val = get_funnel_ctrl_hw(drvdata); diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 4e860519a73f6fff640090cf58298b89a31e6359..b9f15990ed994ea827c8e237d764e74d8d231ddd 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -196,6 +196,7 @@ static int stm_enable(struct coresight_device *csdev, struct perf_event *event, __maybe_unused struct coresight_path *path) { struct stm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); + int ret; if (mode != CS_MODE_SYSFS) return -EINVAL; @@ -205,7 +206,11 @@ static int stm_enable(struct coresight_device *csdev, struct perf_event *event, return -EBUSY; } - pm_runtime_get_sync(csdev->dev.parent); + ret = pm_runtime_resume_and_get(csdev->dev.parent); + if (ret < 0) { + coresight_set_mode(csdev, CS_MODE_DISABLED); + return ret; + } spin_lock(&drvdata->spinlock); stm_enable_hw(drvdata); diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtracing/coresight/coresight-sysfs.c index 4b010f8bc4c08da31b3d295be6c37b6d941629d2..5849dfbd9d0bd3ad10734919f78bc39cc968539c 100644 --- a/drivers/hwtracing/coresight/coresight-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-sysfs.c @@ -17,8 +17,12 @@ ssize_t coresight_simple_show_pair(struct device *_dev, struct coresight_device *csdev = container_of(_dev, struct coresight_device, dev); struct cs_pair_attribute *cs_attr = container_of(attr, struct cs_pair_attribute, attr); u64 val; + int ret; + + ret = pm_runtime_resume_and_get(_dev->parent); + if (ret < 0) + return ret; - pm_runtime_get_sync(_dev->parent); val = csdev_access_relaxed_read_pair(&csdev->access, cs_attr->lo_off, cs_attr->hi_off); pm_runtime_put_sync(_dev->parent); return sysfs_emit(buf, "0x%llx\n", val); @@ -31,8 +35,11 @@ ssize_t coresight_simple_show32(struct device *_dev, struct coresight_device *csdev = container_of(_dev, struct coresight_device, dev); struct cs_off_attribute *cs_attr = container_of(attr, struct cs_off_attribute, attr); u64 val; + int ret; - pm_runtime_get_sync(_dev->parent); + ret = pm_runtime_resume_and_get(_dev->parent); + if (ret < 0) + return ret; val = csdev_access_relaxed_read32(&csdev->access, cs_attr->off); pm_runtime_put_sync(_dev->parent); return sysfs_emit(buf, "0x%llx\n", val); --- base-commit: 08df884136f1c1197bab2a27814404fd329d9aac change-id: 20260911-b4-coresight-runtime-pm-failures-70f250927aeb Best regards, -- Yuanfang Zhang <yuanfang(a)qti.qualcomm.com>

2 weeks, 4 days

[PATCH 0/2] coresight: Retry failed HW_ID writes

by James Clark

Extracted from the last two commits from [1] as they were only conceptually related to that patchset, not functionally. This can be safely applied to the driver separately. [1] https://lore.kernel.org/linux-perf-users/20260821-james-cs-hw_id-output-fai… Signed-off-by: James Clark <james.clark(a)linaro.org> --- James Clark (2): perf/core: Return errors from perf_report_aux_output_id() coresight: Retry failed HW_ID writes drivers/hwtracing/coresight/coresight-etm-perf.c | 50 +++++++++++++++--------- include/linux/perf_event.h | 2 +- kernel/events/core.c | 6 ++- 3 files changed, 36 insertions(+), 22 deletions(-) --- base-commit: 75ba5c486ea071d44d3f61318c88a7793bc768d4 change-id: 20261001-james-cs-retry-hw_id-8f1ec3cf2db3 Best regards, -- James Clark <james.clark(a)linaro.org>

2 weeks, 4 days

Re: [PATCH v2] perf: arm_spe: Support heterogeneous ACPI systems

by Jeremy Linton

Hi, This largely looks reasonable, some comments inline. On 10/20/26 9:03 PM, Johnny.Fan wrote: > From: "Johnny.Fan" <Johnny.Fan(a)cixtech.com> > > On heterogeneous ACPI systems, not all CPUs implement SPE, and the > ones that do may use different PPIs. The MADT describes this per > GICC entry: a CPU without SPE reports a zero SPE overflow interrupt, > and the PPTT hetero id identifies CPUs of the same implementation. > > The current code registers a single platform device and gives up if > the GICC entries disagree on either the hetero id or the interrupt, > so SPE is unavailable on such systems even though the firmware > describes it. > > Group the CPUs by (hetero id, SPE interrupt) and register one > platform device per group. A GSI may be shared between groups with > non-overlapping CPU masks, so only unregister the GSI mapping when > no other group uses the same interrupt, as the mapping is not > reference counted. > > These synthetic devices have no fwnode, so the firmware-described > IRQ affinity cannot tell which CPUs implement the feature. Pass the > CPU mask as platform data and have the drivers prefer it over the > IRQ affinity when present. > > Apply the same treatment to TRBE, which shares this registration > code. TRBE must also pass a stable copy of the mask to > request_percpu_irq_affinity(), since supported_cpus is pruned as > CPUs are probed. > > Tested on a CIX sky1 SoC with heterogeneous SPE support. > > Signed-off-by: Johnny.Fan <Johnny.Fan(a)cixtech.com> > Reviewed-by: Fugang Duan <fugang.duan(a)cixtech.com> > --- > drivers/hwtracing/coresight/coresight-trbe.c | 22 +- > drivers/perf/arm_pmu_acpi.c | 211 ++++++++++++------- It makes sense to split the device creation portion in arm_pmu_acpi.c into its own patch separate from the consumption IMHO. > drivers/perf/arm_spe_pmu.c | 10 +- > include/linux/perf/arm_pmu.h | 10 + > 4 files changed, 176 insertions(+), 77 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index c7cbca45f2de..0c4bc8fbcaf3 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -158,6 +158,7 @@ struct trbe_drvdata { > struct hlist_node hotplug_node; > int irq; > cpumask_t supported_cpus; > + cpumask_t irq_affinity; > enum cpuhp_state trbe_online; > struct platform_device *pdev; > }; > @@ -1533,6 +1534,8 @@ static void arm_trbe_remove_cpuhp(struct trbe_drvdata *drvdata) > static int arm_trbe_probe_irq(struct platform_device *pdev, > struct trbe_drvdata *drvdata) > { > + const struct arm_pmu_acpi_dev_data *acpi_data = > + dev_get_platdata(&pdev->dev); > const struct cpumask *affinity; > int ret; > > @@ -1547,14 +1550,27 @@ static int arm_trbe_probe_irq(struct platform_device *pdev, > return -EINVAL; > } > > - cpumask_copy(&drvdata->supported_cpus, affinity); > + /* > + * The ACPI path has no fwnode describing which CPUs implement TRBE, > + * so it passes the mask explicitly. DT devices still use the > + * firmware-described IRQ affinity. > + */ > + cpumask_copy(&drvdata->supported_cpus, > + acpi_data ? &acpi_data->cpus : affinity); > + > + /* > + * supported_cpus gets pruned as CPUs are probed, so keep a stable > + * copy for the IRQ action. > + */ > + cpumask_copy(&drvdata->irq_affinity, &drvdata->supported_cpus); > > drvdata->handle = alloc_percpu(struct perf_output_handle *); > if (!drvdata->handle) > return -ENOMEM; > > - ret = request_percpu_irq_affinity(drvdata->irq, arm_trbe_irq_handler, DRVNAME, > - affinity, drvdata->handle); > + ret = request_percpu_irq_affinity(drvdata->irq, arm_trbe_irq_handler, > + DRVNAME, &drvdata->irq_affinity, > + drvdata->handle); > if (ret) { > free_percpu(drvdata->handle); > return ret; > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > index ca6bf8f86cfe..fdf39673648f 100644 > --- a/drivers/perf/arm_pmu_acpi.c > +++ b/drivers/perf/arm_pmu_acpi.c > @@ -12,6 +12,8 @@ > #include <linux/irqdesc.h> > #include <linux/percpu.h> > #include <linux/perf/arm_pmu.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > > #include <asm/cpu.h> > #include <asm/cputype.h> > @@ -68,91 +70,165 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > acpi_unregister_gsi(gsi); > } > > -static int __maybe_unused > -arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, > - u16 (*parse_gsi)(struct acpi_madt_generic_interrupt *)) > +struct arm_pmu_acpi_group { > + int hetid; > + u16 gsi; > + struct cpumask cpus; > +}; > + > +static int arm_acpi_find_group(struct arm_pmu_acpi_group *groups, int nr_groups, > + int hetid, u16 gsi) > { > - int cpu, this_hetid, hetid, irq, ret; > - u16 this_gsi = 0, gsi = 0; > + int i; > > - /* > - * Ensure that platform device must have IORESOURCE_IRQ > - * resource to hold gsi interrupt. > - */ > - if (pdev->num_resources != 1) > - return -ENXIO; > + for (i = 0; i < nr_groups; i++) { > + if (groups[i].hetid == hetid && groups[i].gsi == gsi) > + return i; > + } > + > + return -1; > +} > + > +static bool arm_acpi_gsi_is_shared(struct arm_pmu_acpi_group *groups, > + int nr_groups, int idx) > +{ > + int i; > + > + for (i = 0; i < nr_groups; i++) { > + if (i != idx && groups[i].gsi == groups[idx].gsi) > + return true; > + } > + > + return false; > +} > + > +static int arm_acpi_register_group(struct arm_pmu_acpi_group *group, > + const char *name, bool gsi_shared) > +{ > + struct arm_pmu_acpi_dev_data data = { }; > + struct platform_device *pdev; > + struct resource res; > + int irq, ret; > + > + irq = acpi_register_gsi(NULL, group->gsi, ACPI_LEVEL_SENSITIVE, > + ACPI_ACTIVE_HIGH); > + if (irq < 0) > + return irq; > + > + pdev = platform_device_alloc(name, PLATFORM_DEVID_AUTO); > + if (!pdev) { > + ret = -ENOMEM; > + goto err_unreg; > + } > > - if (pdev->resource[0].flags != IORESOURCE_IRQ) > - return -ENXIO; > + res = DEFINE_RES_IRQ(irq); > + data.cpus = group->cpus; > > + ret = platform_device_add_resources(pdev, &res, 1); > + if (ret) > + goto err_put; > + > + ret = platform_device_add_data(pdev, &data, sizeof(data)); > + if (ret) > + goto err_put; > + > + ret = platform_device_add(pdev); > + if (!ret) > + return 0; > + > +err_put: > + platform_device_put(pdev); > +err_unreg: > /* > - * Sanity check all the GICC tables for the same interrupt > - * number. For now, only support homogeneous ACPI machines. > + * The GSI mapping is not reference counted, so only drop it if no > + * other group shares it. > */ > + if (!gsi_shared) > + acpi_unregister_gsi(group->gsi); This is a bit odd, if whatever fails, and gets here happens on all the paths associated with the shared GSI, then that GSI is never unregistered and the resource is leaked. > + > + return ret; > +} > + > +static int __maybe_unused > +arm_acpi_register_pmu_devices(const char *name, u8 len, > + u16 (*parse_gsi)(struct acpi_madt_generic_interrupt *)) > +{ > + struct arm_pmu_acpi_group *groups; > + int cpu, i, nr_cpus = 0, nr_groups = 0, nr_devices = 0; > + int last_err = 0, ret; > + > for_each_possible_cpu(cpu) { > struct acpi_madt_generic_interrupt *gicc; > > gicc = acpi_cpu_get_madt_gicc(cpu); > if (gicc->header.length < len) > - return gsi ? -ENXIO : 0; > - > - this_gsi = parse_gsi(gicc); > - this_hetid = find_acpi_cpu_topology_hetero_id(cpu); > - if (!gsi) { > - hetid = this_hetid; > - gsi = this_gsi; > - } else if (hetid != this_hetid || gsi != this_gsi) { > - pr_warn("ACPI: %s: must be homogeneous\n", pdev->name); > - return -ENXIO; > - } > + continue; This continue seems like a mistake, if the firmware has provided unreliable tables we should abort all device creation, even if that means some subset of the SPE devices which appear to be correct aren't created. > + if (parse_gsi(gicc)) > + nr_cpus++; > } > > - if (!this_gsi) > + if (!nr_cpus) > return 0; > > - irq = acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH); > - if (irq < 0) { > - pr_warn("ACPI: %s Unable to register interrupt: %d\n", pdev->name, gsi); > - return -ENXIO; > - } > + groups = kcalloc(nr_cpus, sizeof(*groups), GFP_KERNEL); And this seemed a bit chunky because in theory this could be NR_CPUS, which made me initially say, skip counting the cores and just allocate the max, then I realized its close to having kcalloc() failures if there are a lot of cores in the machine since this allocation becomes multiple MB. I think we are creating a future headache and need something smarter than counting the number of cores with valid SPE/TRBE interrupts. > + if (!groups) > + return -ENOMEM; > > - pdev->resource[0].start = irq; > - ret = platform_device_register(pdev); > - if (ret) > - acpi_unregister_gsi(gsi); > + for_each_possible_cpu(cpu) { > + struct acpi_madt_generic_interrupt *gicc; > + int hetid; > + u16 gsi; > > - return ret; > -} > + gicc = acpi_cpu_get_madt_gicc(cpu); > + if (gicc->header.length < len) > + continue; same continue issue here as above> > -#if IS_ENABLED(CONFIG_ARM_SPE_PMU) > -static struct resource spe_resources[] = { > - { > - /* irq */ > - .flags = IORESOURCE_IRQ, > + gsi = parse_gsi(gicc); > + if (!gsi) > + continue; > + > + hetid = find_acpi_cpu_topology_hetero_id(cpu); If groups were say a linked list (or something else dynamic) you could just use the failure case here to allocate the next entry and simply skip the first loop iteration above counting cpus. > + i = arm_acpi_find_group(groups, nr_groups, hetid, gsi); > + if (i < 0) { > + i = nr_groups++; > + groups[i].hetid = hetid; > + groups[i].gsi = gsi; > + } > + > + cpumask_set_cpu(cpu, &groups[i].cpus); > } > -}; > > -static struct platform_device spe_dev = { > - .name = ARMV8_SPE_PDEV_NAME, > - .id = -1, > - .resource = spe_resources, > - .num_resources = ARRAY_SIZE(spe_resources) > -}; > + for (i = 0; i < nr_groups; i++) { > + ret = arm_acpi_register_group(&groups[i], name, > + arm_acpi_gsi_is_shared(groups, > + nr_groups, i)); > + if (ret) { > + pr_warn("ACPI: %s: %*pbl: add device failed (%d)\n", > + name, cpumask_pr_args(&groups[i].cpus), ret); > + last_err = ret; > + } else { > + nr_devices++; > + } > + } > + > + kfree(groups); > + > + return nr_devices ? 0 : last_err; > +} > > +#if IS_ENABLED(CONFIG_ARM_SPE_PMU) > static u16 arm_spe_parse_gsi(struct acpi_madt_generic_interrupt *gicc) > { > return gicc->spe_interrupt; > } > > -/* > - * For lack of a better place, hook the normal PMU MADT walk > - * and create a SPE device if we detect a recent MADT with > - * a homogeneous PPI mapping. > - */ > static void arm_spe_acpi_register_device(void) > { > - int ret = arm_acpi_register_pmu_device(&spe_dev, ACPI_MADT_GICC_SPE, > - arm_spe_parse_gsi); > + int ret; > + > + ret = arm_acpi_register_pmu_devices(ARMV8_SPE_PDEV_NAME, > + ACPI_MADT_GICC_SPE, > + arm_spe_parse_gsi); > if (ret) > pr_warn("ACPI: SPE: Unable to register device\n"); > } > @@ -163,20 +239,6 @@ static inline void arm_spe_acpi_register_device(void) > #endif /* CONFIG_ARM_SPE_PMU */ > > #if IS_ENABLED(CONFIG_CORESIGHT_TRBE) > -static struct resource trbe_resources[] = { > - { > - /* irq */ > - .flags = IORESOURCE_IRQ, > - } > -}; > - > -static struct platform_device trbe_dev = { > - .name = ARMV8_TRBE_PDEV_NAME, > - .id = -1, > - .resource = trbe_resources, > - .num_resources = ARRAY_SIZE(trbe_resources) > -}; > - > static u16 arm_trbe_parse_gsi(struct acpi_madt_generic_interrupt *gicc) > { > return gicc->trbe_interrupt; > @@ -184,8 +246,11 @@ static u16 arm_trbe_parse_gsi(struct acpi_madt_generic_interrupt *gicc) > > static void arm_trbe_acpi_register_device(void) > { > - int ret = arm_acpi_register_pmu_device(&trbe_dev, ACPI_MADT_GICC_TRBE, > - arm_trbe_parse_gsi); > + int ret; > + > + ret = arm_acpi_register_pmu_devices(ARMV8_TRBE_PDEV_NAME, > + ACPI_MADT_GICC_TRBE, > + arm_trbe_parse_gsi); > if (ret) > pr_warn("ACPI: TRBE: Unable to register device\n"); > } > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > index b70f3fedf028..712b7f187301 100644 > --- a/drivers/perf/arm_spe_pmu.c > +++ b/drivers/perf/arm_spe_pmu.c > @@ -1330,6 +1330,8 @@ static void arm_spe_pmu_dev_teardown(struct arm_spe_pmu *spe_pmu) > static int arm_spe_pmu_irq_probe(struct arm_spe_pmu *spe_pmu) > { > struct platform_device *pdev = spe_pmu->pdev; > + const struct arm_pmu_acpi_dev_data *acpi_data = > + dev_get_platdata(&pdev->dev); > const struct cpumask *affinity; > int irq; > > @@ -1342,7 +1344,13 @@ static int arm_spe_pmu_irq_probe(struct arm_spe_pmu *spe_pmu) > return -EINVAL; > } > > - cpumask_copy(&spe_pmu->supported_cpus, affinity); > + /* > + * The ACPI path has no fwnode describing which CPUs implement SPE, > + * so it passes the mask explicitly. DT devices still use the > + * firmware-described IRQ affinity. > + */ > + cpumask_copy(&spe_pmu->supported_cpus, > + acpi_data ? &acpi_data->cpus : affinity); > > spe_pmu->irq = irq; > return 0; > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index 02d2c7f45b52..7f1c03c55025 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -8,6 +8,7 @@ > #ifndef __ARM_PMU_H__ > #define __ARM_PMU_H__ > > +#include <linux/cpumask.h> > #include <linux/interrupt.h> > #include <linux/perf_event.h> > #include <linux/platform_device.h> > @@ -199,6 +200,15 @@ void armpmu_free_irq(struct arm_pmu * __percpu *armpmu, int irq, int cpu); > #define ARMV8_SPE_PDEV_NAME "arm,spe-v1" > #define ARMV8_TRBE_PDEV_NAME "arm,trbe" > > +/* > + * Per-device CPU mask passed by the ACPI MADT walk. The synthetic > + * platform devices have no fwnode, so the IRQ affinity cannot describe > + * which CPUs actually implement the feature. > + */ > +struct arm_pmu_acpi_dev_data { > + struct cpumask cpus; > +}; > + > /* Why does everything I do descend into this? */ > #define __GEN_PMU_FORMAT_ATTR(cfg, lo, hi) \ > (lo) == (hi) ? #cfg ":" #lo "\n" : #cfg ":" #lo "-" #hi Thanks for working on this. Jeremy

2 weeks, 4 days

Re: [PATCH v2 2/4] coresight: syscfg: Match feature capabilities separately from device class

by Leo Yan

On Mon, Oct 12, 2026 at 04:05:21PM -0700, Amir Ayupov wrote: [...] > --- a/drivers/hwtracing/coresight/coresight-config.h > +++ b/drivers/hwtracing/coresight/coresight-config.h > @@ -30,6 +30,12 @@ > #define CS_CFG_MATCH_CLASS_SRC_ALL 0x0001 /* match any source */ > #define CS_CFG_MATCH_CLASS_SRC_ETM4 0x0002 /* match any ETMv4 device */ It is good to introduce a marco: #define CS_CFG_MATCH_CLASS_MASK GENMASK_U32(7, 0) > +/* > + * flags defining device capabilities a feature can require. A feature loads on > + * a device that matches one of its classes and has all of its capabilities. > + */ > +#define CS_CFG_MATCH_CAP_MASK 0x0000ff00 To make the mask explicitly 32-bit unsigned: #define CS_CFG_MATCH_CAP_MASK GENMASK_U32(15, 8) > + > /* flags defining device instance matching - used in config match desc data. */ > #define CS_CFG_MATCH_INST_ANY 0x80000000 /* any instance of a class */ Not an issue with this patch, but CS_CFG_MATCH_INST_ANY appears to be unused and could be removed in a separate cleanup patch. > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c > index a816c22c87bc8..1545d64afec01 100644 > --- a/drivers/hwtracing/coresight/coresight-syscfg.c > +++ b/drivers/hwtracing/coresight/coresight-syscfg.c > @@ -172,7 +172,21 @@ cscfg_alloc_csdev_feat(struct coresight_device *csdev, struct cscfg_feature_desc > } > > /* load one feature into one coresight device */ > +/* > + * A feature matches a device that shares one of its class flags and has all of > + * the capability flags it requires. > + */ > +static bool cscfg_match_feat_csdev(u32 feat_flags, u32 csdev_flags) > +{ > + u32 caps = feat_flags & CS_CFG_MATCH_CAP_MASK; > + > + return (feat_flags & csdev_flags & ~CS_CFG_MATCH_CAP_MASK) && > + (csdev_flags & caps) == caps; For clearer comparison conditions: /* Class type must be matches */ if ((feat_flags & CS_CFG_MATCH_CLASS_MASK) != (csdev_flags & CS_CFG_MATCH_CLASS_MASK) return false; /* No required capabilities miss from the device */ if (feat_flags & ~csdev_flags & CS_CFG_MATCH_CAP_MASK) return false; return true; Thanks, Leo

2 weeks, 5 days

Re: [PATCH] [v1] coresight: funnel: inport schedule by priority can not take work

by Leo Yan

Hi, On Sun, Oct 25, 2026 at 09:13:07PM +0800, Chao Xu wrote: > Before enable funnel, priority must be set. Changing the port > priorities in real time is not supported. > If the priority control register is written when one or more of ports > are enable, then the write is silently rejected. Could you cite the relevant documentation in commit log? The CoreSight SoC-600 TRM, section 9.11.2, PRIORITYCONTROL, a funnel rejects priority register writes whenever any port is enabled. The current sequence therefore prevent the configured priorities from taking effect. Write the priority register before enabling the first port. > Signed-off-by: Chao Xu <xuchao066(a)163.com> > --- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index af40814ce560..17f985798d7f 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -66,8 +66,8 @@ static int dynamic_funnel_enable_hw(struct funnel_drvdata *drvdata, int port) > functl &= ~FUNNEL_HOLDTIME_MASK; > functl |= FUNNEL_HOLDTIME; > functl |= (1 << port); > - writel_relaxed(functl, drvdata->base + FUNNEL_FUNCTL); > writel_relaxed(drvdata->priority, drvdata->base + FUNNEL_PRICTL); > + writel_relaxed(functl, drvdata->base + FUNNEL_FUNCTL); Please move the priority write into the first port branch: /* Claim the device only when we enable the first slave */ if (!(functl & FUNNEL_ENSx_MASK)) { rc = coresight_claim_device_unlocked(csdev); if (rc) goto done; /* Update priorities while all ports are disabled */ writel_relaxed(drvdata->priority, drvdata->base + FUNNEL_PRICTL); } Thanks, Leo

2 weeks, 5 days

← Newer
1
2
3
4
5
6
7
8
...
273
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight