CoreSight

coresight@lists.linaro.org

2601 discussions

Re: [PATCH v5 1/3] coresight: tpda: add sysfs nodes for tpda cross-trigger configuration

by Suzuki K Poulose

On 19/12/2025 10:04, Jie Gan wrote: > From: Tao Zhang <tao.zhang(a)oss.qualcomm.com> > > Introduce sysfs nodes to configure cross-trigger parameters for TPDA. > These registers define the characteristics of cross-trigger packets, > including generation frequency and flag values. > > Signed-off-by: Tao Zhang <tao.zhang(a)oss.qualcomm.com> > Reviewed-by: James Clark <james.clark(a)linaro.org> > Co-developed-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > .../ABI/testing/sysfs-bus-coresight-devices-tpda | 43 +++++++ > drivers/hwtracing/coresight/coresight-tpda.c | 138 ++++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tpda.h | 69 ++++++++++- > 3 files changed, 243 insertions(+), 7 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda > new file mode 100644 > index 000000000000..a7855922328e > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda > @@ -0,0 +1,43 @@ > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/trig_async_enable > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger synchronization sequence interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/trig_flag_ts_enable > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger FLAG packet request interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/trig_freq_enable > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger FREQ packet request interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/freq_ts_enable > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable the timestamp for all FREQ packets. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/global_flush_req > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Set global (all ports) flush request bit. The bit remains set until a > + global flush request sequence completes. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_cr/cmbchan_mode > +Date: December 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Configure the CMB/MCMB channel mode for all enabled ports. > + Value 0 means raw channel mapping mode. Value 1 means channel pair marking mode. > diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtracing/coresight/coresight-tpda.c > index 3a3825d27f86..d25a8bcfb3d4 100644 > --- a/drivers/hwtracing/coresight/coresight-tpda.c > +++ b/drivers/hwtracing/coresight/coresight-tpda.c > @@ -137,12 +137,32 @@ static int tpda_get_element_size(struct tpda_drvdata *drvdata, > /* Settings pre enabling port control register */ > static void tpda_enable_pre_port(struct tpda_drvdata *drvdata) > { > - u32 val; > + u32 val = 0; > > - val = readl_relaxed(drvdata->base + TPDA_CR); > - val &= ~TPDA_CR_ATID; > val |= FIELD_PREP(TPDA_CR_ATID, drvdata->atid); > + if (drvdata->trig_async) > + val |= TPDA_CR_SRIE; > + > + if (drvdata->trig_flag_ts) > + val |= TPDA_CR_FLRIE; > + > + if (drvdata->trig_freq) > + val |= TPDA_CR_FRIE; > + > + if (drvdata->freq_ts) > + val |= TPDA_CR_FREQTS; > + > + if (drvdata->cmbchan_mode) > + val |= TPDA_CR_CMBCHANMODE; > + > writel_relaxed(val, drvdata->base + TPDA_CR); > + > + /* > + * If FLRIE bit is set, set the master and channel > + * id as zero > + */ > + if (drvdata->trig_flag_ts) > + writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); > } > > static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) > @@ -258,6 +278,116 @@ static const struct coresight_ops tpda_cs_ops = { > .link_ops = &tpda_link_ops, > }; > > +/* Read cross-trigger register member */ > +static ssize_t tpda_trig_sysfs_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct tpda_trig_sysfs_attribute *tpda_attr = > + container_of(attr, struct tpda_trig_sysfs_attribute, attr); > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + unsigned long val; > + > + guard(spinlock)(&drvdata->spinlock); > + switch (tpda_attr->mem) { > + case FLREQ: > + if (!drvdata->csdev->refcnt) > + return -EINVAL; > + > + val = readl_relaxed(drvdata->base + TPDA_CR); > + /* read global flush request bit only */ > + val &= TPDA_CR_FLREQ; > + return sysfs_emit(buf, "%lu\n", val); > + case FREQTS: > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->freq_ts); > + case FRIE: > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_freq); > + case FLRIE: > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_flag_ts); > + case SRIE: > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_async); > + case CMBCHANMODE: > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->cmbchan_mode); > + > + } > + return -EINVAL; > +} > + > +static ssize_t tpda_trig_sysfs_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + struct tpda_trig_sysfs_attribute *tpda_attr = > + container_of(attr, struct tpda_trig_sysfs_attribute, attr); > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + ssize_t ret = -EINVAL; + unsigned long val; > + > + if (kstrtoul(buf, 0, &val)) > + return ret; return -EINVAL; > + > + guard(spinlock)(&drvdata->spinlock); > + switch (tpda_attr->mem) { > + case FLREQ: > + if (!drvdata->csdev->refcnt || !val) > + return ret; return -EINVAL; > + > + val = readl_relaxed(drvdata->base + TPDA_CR); CS_UNLOCK before readl ? I didn't mean the global_flush_req to be unified with the rest. Obviously it has different access semantics. > + /* set global flush request bit */ > + val |= TPDA_CR_FLREQ; > + CS_UNLOCK(drvdata->base); > + writel_relaxed(val, drvdata->base + TPDA_CR); > + CS_LOCK(drvdata->base); > + ret = size; Please remove this from all the cases and explicitly return -EINVAL in the error cases. > + break; > + case FREQTS: > + drvdata->freq_ts = !!val; > + ret = size; > + break; > + case FRIE: > + drvdata->trig_freq = !!val; > + ret = size; > + break; > + case FLRIE: > + drvdata->trig_flag_ts = !!val; > + ret = size; > + break; > + case SRIE: > + drvdata->trig_async = !!val; > + ret = size; > + break; > + case CMBCHANMODE: > + drvdata->cmbchan_mode = !!val; > + ret = size; > + break; > + default: return -EINVAL; > + break; > + } > + > + return ret; return size; > +} > + > +static struct attribute *tpda_global_cr_attrs[] = { > + tpda_trig_sysfs_rw(global_flush_req, FLREQ), > + tpda_trig_sysfs_rw(freq_ts_enable, FREQTS), > + tpda_trig_sysfs_rw(trig_freq_enable, FRIE), > + tpda_trig_sysfs_rw(trig_flag_ts_enable, FLRIE), > + tpda_trig_sysfs_rw(trig_async_enable, SRIE), > + tpda_trig_sysfs_rw(cmbchan_mode, CMBCHANMODE), > + NULL, > +}; > + > +static struct attribute_group tpda_global_cr_attr_grp = { > + .attrs = tpda_global_cr_attrs, > + .name = "global_cr", > +}; > + > +static const struct attribute_group *tpda_attr_grps[] = { > + &tpda_global_cr_attr_grp, > + NULL, > +}; > + > static int tpda_init_default_data(struct tpda_drvdata *drvdata) > { > int atid; > @@ -273,6 +403,7 @@ static int tpda_init_default_data(struct tpda_drvdata *drvdata) > return atid; > > drvdata->atid = atid; > + drvdata->freq_ts = true; > return 0; > } > > @@ -316,6 +447,7 @@ static int tpda_probe(struct amba_device *adev, const struct amba_id *id) > desc.ops = &tpda_cs_ops; > desc.pdata = adev->dev.platform_data; > desc.dev = &adev->dev; > + desc.groups = tpda_attr_grps; > desc.access = CSDEV_ACCESS_IOMEM(base); > drvdata->csdev = coresight_register(&desc); > if (IS_ERR(drvdata->csdev)) > diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtracing/coresight/coresight-tpda.h > index c6af3d2da3ef..8a075cfbc3cc 100644 > --- a/drivers/hwtracing/coresight/coresight-tpda.h > +++ b/drivers/hwtracing/coresight/coresight-tpda.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023,2025 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > #ifndef _CORESIGHT_CORESIGHT_TPDA_H > @@ -8,6 +8,30 @@ > > #define TPDA_CR (0x000) > #define TPDA_Pn_CR(n) (0x004 + (n * 4)) > +#define TPDA_FPID_CR (0x084) > + > +/* Cross trigger Global (all ports) flush request bit */ > +#define TPDA_CR_FLREQ BIT(0) > +/* Cross trigger FREQ packets timestamp bit */ > +#define TPDA_CR_FREQTS BIT(2) > +/* Cross trigger FREQ packet request bit */ > +#define TPDA_CR_FRIE BIT(3) > +/* Cross trigger FLAG packet request interface bit */ > +#define TPDA_CR_FLRIE BIT(4) > +/* Cross trigger synchronization bit */ > +#define TPDA_CR_SRIE BIT(5) > +/* Bits 6 ~ 12 is for atid value */ > +#define TPDA_CR_ATID GENMASK(12, 6) > +/* Bits 13 ~ 19 is for mid value */ > +/* Assign a unique master ID to identify the TPDA device */ > +#define TPDA_CR_MID GENMASK(19, 13) Where do we use this ? Does this need to be preserved ? Is this programmable ? Suzuki > +/* > + * Channel mode bit of the packetization of CMB/MCB traffic > + * 0 - raw channel mapping mode > + * 1 - channel pair marking mode > + */ > +#define TPDA_CR_CMBCHANMODE BIT(20) > + > /* Aggregator port enable bit */ > #define TPDA_Pn_CR_ENA BIT(0) > /* Aggregator port CMB data set element size bit */ > @@ -17,9 +41,6 @@ > > #define TPDA_MAX_INPORTS 32 > > -/* Bits 6 ~ 12 is for atid value */ > -#define TPDA_CR_ATID GENMASK(12, 6) > - > /** > * struct tpda_drvdata - specifics associated to an TPDA component > * @base: memory mapped base address for this component. > @@ -29,6 +50,11 @@ > * @enable: enable status of the component. > * @dsb_esize Record the DSB element size. > * @cmb_esize Record the CMB element size. > + * @trig_async: Enable/disable cross trigger synchronization sequence interface. > + * @trig_flag_ts: Enable/disable cross trigger FLAG packet request interface. > + * @trig_freq: Enable/disable cross trigger FREQ packet request interface. > + * @freq_ts: Enable/disable the timestamp for all FREQ packets. > + * @cmbchan_mode: Configure the CMB/MCMB channel mode. > */ > struct tpda_drvdata { > void __iomem *base; > @@ -38,6 +64,41 @@ struct tpda_drvdata { > u8 atid; > u32 dsb_esize; > u32 cmb_esize; > + bool trig_async; > + bool trig_flag_ts; > + bool trig_freq; > + bool freq_ts; > + bool cmbchan_mode; > +}; > + > +/* Enumerate members of global control register(cr) */ > +enum tpda_cr_mem { > + FLREQ, > + FREQTS, > + FRIE, > + FLRIE, > + SRIE, > + CMBCHANMODE > +}; > + > +/** > + * struct tpda_trig_sysfs_attribute - Record the member variables of cross > + * trigger register that need to be operated by sysfs file > + * @attr: The device attribute > + * @mem: The member in the control register data structure > + */ > +struct tpda_trig_sysfs_attribute { > + struct device_attribute attr; > + enum tpda_cr_mem mem; > }; > > +#define tpda_trig_sysfs_rw(name, mem) \ > + (&((struct tpda_trig_sysfs_attribute[]) { \ > + { \ > + __ATTR(name, 0644, tpda_trig_sysfs_show, \ > + tpda_trig_sysfs_store), \ > + mem, \ > + } \ > + })[0].attr.attr) > + > #endif /* _CORESIGHT_CORESIGHT_TPDA_H */ >

1 week, 5 days

Re: [PATCH v8 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU

by Suzuki K Poulose

On 19/12/2025 02:05, Jie Gan wrote: > > > On 12/19/2025 7:19 AM, Suzuki K Poulose wrote: >> On 18/12/2025 10:17, Krzysztof Kozlowski wrote: >>> On 12/12/2025 02:12, Jie Gan wrote: >>>> >>>> >>>> On 12/11/2025 9:37 PM, Rob Herring wrote: >>>>> On Thu, Dec 11, 2025 at 02:10:44PM +0800, Jie Gan wrote: >>>>>> Add an interrupt property to CTCU device. The interrupt will be >>>>>> triggered >>>>>> when the data size in the ETR buffer exceeds the threshold of the >>>>>> BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL >>>>>> register >>>>>> of CTCU device will enable the interrupt. >>>>>> >>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> >>>>>> Reviewed-by: Mike Leach <mike.leach(a)linaro.org> >>>>>> Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> >>>>>> --- >>>>>> .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 17 ++ >>>>>> + ++++++++++++++ >>>>>> 1 file changed, 17 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight- >>>>>> ctcu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight- >>>>>> ctcu.yaml >>>>>> index c969c16c21ef..90f88cc6cd3e 100644 >>>>>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>>>> @@ -39,6 +39,16 @@ properties: >>>>>> items: >>>>>> - const: apb >>>>>> + interrupts: >>>>>> + items: >>>>>> + - description: Byte cntr interrupt for the first etr device >>>>>> + - description: Byte cntr interrupt for the second etr device >> >> This is really vague. How do you define first vs second ? Probe order ? >> No way. This must be the "port" number to which the ETR is connected >> to the CTCU. IIUC, there is a config area for each ETR (e.g., trace id >> filter) connected to the CTCU. I was under the assumption that they >> are identified as "ports" (input ports). I don't really understand how >> this interrupt mapping works now. Please explain it clearly. >> > > Sorry for the misunderstanding. > > Each ETR device should have its own interrupt line and an IRQ register > within the CTCU device, as defined by the specification. In existing > projects, the maximum supported number of ETR devices is 2. > > Each interrupt is directly mapped to a specific ETR device, for example: > tmc@1000 → interrupt line 0 > tmc@1001 → interrupt line 1 > > The suggestion to identify devices by ‘ports’ is much clearer than my > previous explanation, as it explicitly shows which device is connected > to which port. Thanks for confirming. > >>>>>> + >>>>>> + interrupt-names: >>>>>> + items: >>>>>> + - const: etrirq0 >>>>>> + - const: etrirq1 >>>>> >>>>> Names are kind of pointless when it is just foo<index>. >>>> >>>> Hi Rob, >>>> >>>> I was naming them as etr0/etr1. Are these names acceptable? >>> >>> Obviously irq is redundant, but how does etr0 solves the problem of >>> calling it foo0? >>> >>> I don't think you really read Rob's comment. >>> >>>> The interrupts are assigned exclusively to a specific ETR device. >>>> >>>> But Suzuki is concerned that this might cause confusion because the ETR >>>> device is named randomly in the driver. Suzuki suggested using ‘port-0’ >>>> and ‘port-1’ and would also like to hear your feedback on these names. >>> >>> There is no confusion here. Writing bindings luckily clarifies this what >>> the indices in the array mean. >> >> The point is there are "n" interrupts. Question is, could there be more >> devices(ETRs) connected to the CTCU than "n". >> >> e.g., Lets CTCU can control upto 4 ETRs and on a particular system, the >> >> TMC-ETR0 -> CTCU-Port0 >> >> TMC-ETR1 -> CTCU-Port2 >> TMC-ETR2 -> CTCU-Port3 >> >> Now, how many interrupts are described in the DT ? How do we map which >> interrupts correspond to the CTCU-Portn. (Finding the TMC-ETRx back >> from the port is possible, with the topology). >> > > Got your point and it's much clearer. > >> This is what I raised in the previous version. Again, happy to hear >> if there is a standard way to describe the interrupts. >> >> Suzuki >> >> >>> >>>> >>>> Usually, the probe sequence follows the order of the addresses. In our >>>> specification, ‘ETR0’ is always probed before ‘ETR1’ because its >>>> address >>>> is lower. >>> >>> How is this even relevant? You are answering to something completely >>> different, so I don't think you really tried to understand review. >>> > > My previous explanation was definitely unclear. As Suzuki suggested, > mapping the interrupt to the port number (to identify the relevant > device based on topology) makes sense and provides a much easier way to > understand the relationship between the interrupt and the ETR device. > > So with the suggestion, here is the new description about the interrupts: > > interrupts: > items: > - description: Interrupt for the ETR device connected to in-port0. > - description: Interrupt for the ETR device connected to in-port1. > > interrupt-names: > items: > - const: port0 > - const: port1 Which brings us back to the question I posted in the previous version. Do we really need a "name" or are there other ways to define, a sparse list of interrupts ? Suzuki > > Thanks, > Jie > >>> >>> >>> Best regards, >>> Krzysztof >> >

1 week, 5 days

Re: [PATCH v2 00/12] coresight: Add CPU cluster funnel/replicator/tmc support

by yuanfang zhang

On 12/18/2025 7:33 PM, Sudeep Holla wrote: > On Thu, Dec 18, 2025 at 12:09:40AM -0800, Yuanfang Zhang wrote: >> This patch series adds support for CoreSight components local to CPU clusters, >> including funnel, replicator, and TMC, which reside within CPU cluster power >> domains. These components require special handling due to power domain >> constraints. >> > > Could you clarify why PSCI-based power domains associated with clusters in > domain-idle-states cannot address these requirements, given that PSCI CPU-idle > OSI mode was originally intended to support them? My understanding of this > patch series is that OSI mode is unable to do so, which, if accurate, appears > to be a flaw that should be corrected. It is due to the particular characteristics of the CPU cluster power domain.Runtime PM for CPU devices works little different, it is mostly used to manage hierarchical CPU topology (PSCI OSI mode) to talk with genpd framework to manage the last CPU handling in cluster. It doesn’t really send IPI to wakeup CPU device (It don’t have .power_on/.power_off) callback implemented which gets invoked from .runtime_resume callback. This behavior is aligned with the upstream Kernel. > >> Unlike system-level CoreSight devices, these components share the CPU cluster's >> power domain. When the cluster enters low-power mode (LPM), their registers >> become inaccessible. Notably, `pm_runtime_get` alone cannot bring the cluster >> out of LPM, making standard register access unreliable. >> > > Are these devices the only ones on the system that are uniquely bound to > cluster-level power domains? If not, what additional devices share this > dependency so that we can understand how they are managed in comparison? > Yes, devices like ETM and TRBE also share this power domain and access constraint. Their drivers naturally handle enablement/disablement on the specific CPU they belong to (e.g., via hotplug callbacks or existing smp_call_function paths). >> To address this, the series introduces: >> - Identifying cluster-bound devices via a new `qcom,cpu-bound-components` >> device tree property. > > Really, no please. > Our objective is to determine which CoreSight components are physically locate within the CPU cluster power domain. Would it be acceptable to derive this relationship from the existing power-domains binding? For example, if a Funnel or Replicator node is linked to a power-domains entry that specifies a cpumask, the driver could recognize this shared dependency and automatically apply the appropriate cluster-aware behavior. thanks, yuanfang.

1 week, 6 days

Re: [PATCH v8 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU

by Suzuki K Poulose

On 18/12/2025 10:17, Krzysztof Kozlowski wrote: > On 12/12/2025 02:12, Jie Gan wrote: >> >> >> On 12/11/2025 9:37 PM, Rob Herring wrote: >>> On Thu, Dec 11, 2025 at 02:10:44PM +0800, Jie Gan wrote: >>>> Add an interrupt property to CTCU device. The interrupt will be triggered >>>> when the data size in the ETR buffer exceeds the threshold of the >>>> BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL register >>>> of CTCU device will enable the interrupt. >>>> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> >>>> Reviewed-by: Mike Leach <mike.leach(a)linaro.org> >>>> Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> >>>> --- >>>> .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 17 +++++++++++++++++ >>>> 1 file changed, 17 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>> index c969c16c21ef..90f88cc6cd3e 100644 >>>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>> @@ -39,6 +39,16 @@ properties: >>>> items: >>>> - const: apb >>>> >>>> + interrupts: >>>> + items: >>>> + - description: Byte cntr interrupt for the first etr device >>>> + - description: Byte cntr interrupt for the second etr device This is really vague. How do you define first vs second ? Probe order ? No way. This must be the "port" number to which the ETR is connected to the CTCU. IIUC, there is a config area for each ETR (e.g., trace id filter) connected to the CTCU. I was under the assumption that they are identified as "ports" (input ports). I don't really understand how this interrupt mapping works now. Please explain it clearly. >>>> + >>>> + interrupt-names: >>>> + items: >>>> + - const: etrirq0 >>>> + - const: etrirq1 >>> >>> Names are kind of pointless when it is just foo<index>. >> >> Hi Rob, >> >> I was naming them as etr0/etr1. Are these names acceptable? > > Obviously irq is redundant, but how does etr0 solves the problem of > calling it foo0? > > I don't think you really read Rob's comment. > >> The interrupts are assigned exclusively to a specific ETR device. >> >> But Suzuki is concerned that this might cause confusion because the ETR >> device is named randomly in the driver. Suzuki suggested using ‘port-0’ >> and ‘port-1’ and would also like to hear your feedback on these names. > > There is no confusion here. Writing bindings luckily clarifies this what > the indices in the array mean. The point is there are "n" interrupts. Question is, could there be more devices(ETRs) connected to the CTCU than "n". e.g., Lets CTCU can control upto 4 ETRs and on a particular system, the TMC-ETR0 -> CTCU-Port0 TMC-ETR1 -> CTCU-Port2 TMC-ETR2 -> CTCU-Port3 Now, how many interrupts are described in the DT ? How do we map which interrupts correspond to the CTCU-Portn. (Finding the TMC-ETRx back from the port is possible, with the topology). This is what I raised in the previous version. Again, happy to hear if there is a standard way to describe the interrupts. Suzuki > >> >> Usually, the probe sequence follows the order of the addresses. In our >> specification, ‘ETR0’ is always probed before ‘ETR1’ because its address >> is lower. > > How is this even relevant? You are answering to something completely > different, so I don't think you really tried to understand review. > > > > Best regards, > Krzysztof

1 week, 6 days

Re: [PATCH v8 2/8] coresight: core: add a new API to retrieve the helper device

by Suzuki K Poulose

On 11/12/2025 06:10, Jie Gan wrote: > Retrieving the helper device of the specific coresight device based on > its helper_subtype because a single coresight device may has multiple types > of the helper devices. > > Reviewed-by: Mike Leach <mike.leach(a)linaro.org> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 35 ++++++++++++++++++++++++++++ > drivers/hwtracing/coresight/coresight-priv.h | 2 ++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 0e8448784c62..667883ccb4b7 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -585,6 +585,41 @@ struct coresight_device *coresight_get_sink(struct coresight_path *path) > } > EXPORT_SYMBOL_GPL(coresight_get_sink); > > +/** > + * coresight_get_helper: find the helper device of the assigned csdev. > + * > + * @csdev: The csdev the helper device is conntected to. > + * @type: helper_subtype of the expected helper device. > + * > + * Retrieve the helper device for the specific csdev based on its > + * helper_subtype. > + * > + * Return: the helper's csdev upon success or NULL for fail. > + */ > +struct coresight_device *coresight_get_helper(struct coresight_device *csdev, > + enum coresight_dev_subtype_helper subtype) We have almost a similar function in coresight-core.c : coresight_find_output_type(pdata, type, subtype). Please could we reuse that, instead of adding similar funcitons ? Please be careful about the mutex. Suzuki > +{ > + int i; > + struct coresight_device *helper; > + > + /* protect the connections */ > + mutex_lock(&coresight_mutex); > + for (i = 0; i < csdev->pdata->nr_outconns; ++i) { > + helper = csdev->pdata->out_conns[i]->dest_dev; > + if (!helper || !coresight_is_helper(helper)) > + continue; > + > + if (helper->subtype.helper_subtype == subtype) { > + mutex_unlock(&coresight_mutex); > + return helper; > + } > + } > + mutex_unlock(&coresight_mutex); > + > + return NULL; > +} > +EXPORT_SYMBOL_GPL(coresight_get_helper); > + > /** > * coresight_get_in_port: Find the input port number at @csdev where a @remote > * device is connected to. > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index cbf80b83e5ce..8e39a4dc7256 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -157,6 +157,8 @@ void coresight_path_assign_trace_id(struct coresight_path *path, > enum cs_mode mode); > int coresight_get_in_port(struct coresight_device *csdev, > struct coresight_device *remote); > +struct coresight_device *coresight_get_helper(struct coresight_device *csdev, > + enum coresight_dev_subtype_helper subtype); > > #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X) > int etm_readl_cp14(u32 off, unsigned int *val); >

1 week, 6 days

Re: [PATCH v4 1/3] coresight: tpda: add sysfs nodes for tpda cross-trigger configuration

by Suzuki K Poulose

On 28/10/2025 02:02, Jie Gan wrote: > From: Tao Zhang <tao.zhang(a)oss.qualcomm.com> > > Introduce sysfs nodes to configure cross-trigger parameters for TPDA. > These registers define the characteristics of cross-trigger packets, > including generation frequency and flag values. > > Signed-off-by: Tao Zhang <tao.zhang(a)oss.qualcomm.com> > Reviewed-by: James Clark <james.clark(a)linaro.org> > Co-developed-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > .../ABI/testing/sysfs-bus-coresight-devices-tpda | 43 ++++ > drivers/hwtracing/coresight/coresight-tpda.c | 230 +++++++++++++++++++++ > drivers/hwtracing/coresight/coresight-tpda.h | 27 ++- > 3 files changed, 299 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda > new file mode 100644 > index 000000000000..80e4b05a1ab4 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda > @@ -0,0 +1,43 @@ > +What: /sys/bus/coresight/devices/<tpda-name>/trig_async_enable > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger synchronization sequence interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/trig_flag_ts_enable > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger FLAG packet request interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/trig_freq_enable > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable cross trigger FREQ packet request interface. > + > +What: /sys/bus/coresight/devices/<tpda-name>/freq_ts_enable > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Enable/disable the timestamp for all FREQ packets. > + > +What: /sys/bus/coresight/devices/<tpda-name>/global_flush_req > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Set global (all ports) flush request bit. The bit remains set until a > + global flush request sequence completes. > + > +What: /sys/bus/coresight/devices/<tpda-name>/cmbchan_mode > +Date: October 2025 > +KernelVersion: 6.19 > +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> > +Description: > + (RW) Configure the CMB/MCMB channel mode for all enabled ports. > + Value 0 means raw channel mapping mode. Value 1 means channel pair marking mode. > diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtracing/coresight/coresight-tpda.c > index 333b3cb23685..a9a27bcc65a1 100644 > --- a/drivers/hwtracing/coresight/coresight-tpda.c > +++ b/drivers/hwtracing/coresight/coresight-tpda.c > @@ -147,9 +147,37 @@ static void tpda_enable_pre_port(struct tpda_drvdata *drvdata) > u32 val; > > val = readl_relaxed(drvdata->base + TPDA_CR); > + val &= ~TPDA_CR_MID; > val &= ~TPDA_CR_ATID; See, below. > val |= FIELD_PREP(TPDA_CR_ATID, drvdata->atid); > + if (drvdata->trig_async) > + val |= TPDA_CR_SRIE; > + else > + val &= ~TPDA_CR_SRIE; > + if (drvdata->trig_flag_ts) > + val |= TPDA_CR_FLRIE; > + else > + val &= ~TPDA_CR_FLRIE; > + if (drvdata->trig_freq) > + val |= TPDA_CR_FRIE; > + else > + val &= ~TPDA_CR_FRIE; > + if (drvdata->freq_ts) > + val |= TPDA_CR_FREQTS; > + else > + val &= ~TPDA_CR_FREQTS; > + if (drvdata->cmbchan_mode) > + val |= TPDA_CR_CMBCHANMODE; > + else > + val &= ~TPDA_CR_CMBCHANMODE; Could we clear all of the bits that are configurable in one go in the beginning and set the appropriate ones based on the setting ? i.e.: Do we really need to retain any values ? And if not, why not start with a fresh set of values and avoid the read ? > writel_relaxed(val, drvdata->base + TPDA_CR); > + > + /* > + * If FLRIE bit is set, set the master and channel > + * id as zero > + */ > + if (drvdata->trig_flag_ts) > + writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); > } > > static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) > @@ -265,6 +293,206 @@ static const struct coresight_ops tpda_cs_ops = { > .link_ops = &tpda_link_ops, > }; > > +static ssize_t trig_async_enable_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_async); > +} > + > +static ssize_t trig_async_enable_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + unsigned long val; > + > + if (kstrtoul(buf, 0, &val)) > + return -EINVAL; > + > + guard(spinlock)(&drvdata->spinlock); > + drvdata->trig_async = !!val; > + > + return size; > +} > +static DEVICE_ATTR_RW(trig_async_enable); ... > +static DEVICE_ATTR_RW(trig_flag_ts_enable); ... > +static DEVICE_ATTR_RW(trig_freq_enable); ... > +static DEVICE_ATTR_RW(freq_ts_enable); These attribute are boolean and looks like we could save some space on code by using dev_ext_attribute. see tpdm_simple_dataset_rw()/tpdm_simple_dataset_ro() . You could #define TPDA_TRIG_ASYNC 0 #define TPDA_TRIG_FLAG_TS 1 #define TPDA_TRIG_FREQ 2 tpda_trig_sysfs_show/store() bool *ptr; switch (eattr->var) { case TPDA_TRIG_ASYNC: ptr = &drvdata->trig_async; break; case TPDA_TRIG_FLAG_TS: ptr = &drvdata->trig_flag_ts; break; ... } > + > +static ssize_t global_flush_req_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + unsigned long val; > + > + if (!drvdata->csdev->refcnt) > + return -EINVAL; > + > + guard(spinlock)(&drvdata->spinlock); > + CS_UNLOCK(drvdata->base); > + val = readl_relaxed(drvdata->base + TPDA_CR); > + CS_LOCK(drvdata->base); > + /* Only read value for bit 0 */ > + val &= BIT(0); > + > + return sysfs_emit(buf, "%lu\n", val); > +} > + > +static ssize_t global_flush_req_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + unsigned long val; > + > + if (kstrtoul(buf, 0, &val)) > + return -EINVAL; > + > + if (!drvdata->csdev->refcnt || !val) > + return -EINVAL; > + > + guard(spinlock)(&drvdata->spinlock); > + CS_UNLOCK(drvdata->base); > + val = readl_relaxed(drvdata->base + TPDA_CR); > + /* Only set bit 0 */ > + val |= BIT(0); What is BIT 0 ? Please document it > + writel_relaxed(val, drvdata->base + TPDA_CR); > + CS_LOCK(drvdata->base); > + > + return size; > +} > +static DEVICE_ATTR_RW(global_flush_req); > + > +static ssize_t cmbchan_mode_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + > + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->cmbchan_mode); > +} > + > +static ssize_t cmbchan_mode_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); > + unsigned long val; > + > + if (kstrtoul(buf, 0, &val)) > + return -EINVAL; > + > + guard(spinlock)(&drvdata->spinlock); > + drvdata->cmbchan_mode = !!val; > + > + return size; > +} > +static DEVICE_ATTR_RW(cmbchan_mode); Even this could go to the dev_ext_attribute magic and reuse a single show/store. > + > +static struct attribute *tpda_attrs[] = { > + &dev_attr_trig_async_enable.attr, > + &dev_attr_trig_flag_ts_enable.attr, > + &dev_attr_trig_freq_enable.attr, > + &dev_attr_freq_ts_enable.attr, > + &dev_attr_global_flush_req.attr, > + &dev_attr_cmbchan_mode.attr, > + NULL, > +}; > diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtracing/coresight/coresight-tpda.h > index c6af3d2da3ef..0be625fb52fd 100644 > --- a/drivers/hwtracing/coresight/coresight-tpda.h > +++ b/drivers/hwtracing/coresight/coresight-tpda.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023,2025 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > #ifndef _CORESIGHT_CORESIGHT_TPDA_H > @@ -8,6 +8,19 @@ > > #define TPDA_CR (0x000) > #define TPDA_Pn_CR(n) (0x004 + (n * 4)) > +#define TPDA_FPID_CR (0x084) > + > +/* Cross trigger FREQ packets timestamp bit */ > +#define TPDA_CR_FREQTS BIT(2) > +/* Cross trigger FREQ packet request bit */ > +#define TPDA_CR_FRIE BIT(3) > +/* Cross trigger FLAG packet request interface bit */ > +#define TPDA_CR_FLRIE BIT(4) > +/* Cross trigger synchronization bit */ > +#define TPDA_CR_SRIE BIT(5) > +/* Packetize CMB/MCMB traffic bit */ > +#define TPDA_CR_CMBCHANMODE BIT(20) > + Why are these not clubbed with the other TPDA_CR_ defintions ? > /* Aggregator port enable bit */ > #define TPDA_Pn_CR_ENA BIT(0) > /* Aggregator port CMB data set element size bit */ > @@ -19,6 +32,8 @@ > > /* Bits 6 ~ 12 is for atid value */ > #define TPDA_CR_ATID GENMASK(12, 6) > +/* Bits 13 ~ 19 is for mid value */ > +#define TPDA_CR_MID GENMASK(19, 13) > > /** > * struct tpda_drvdata - specifics associated to an TPDA component > @@ -29,6 +44,11 @@ > * @enable: enable status of the component. > * @dsb_esize Record the DSB element size. > * @cmb_esize Record the CMB element size. > + * @trig_async: Enable/disable cross trigger synchronization sequence interface. > + * @trig_flag_ts: Enable/disable cross trigger FLAG packet request interface. > + * @trig_freq: Enable/disable cross trigger FREQ packet request interface. > + * @freq_ts: Enable/disable the timestamp for all FREQ packets. > + * @cmbchan_mode: Configure the CMB/MCMB channel mode. > */ > struct tpda_drvdata { > void __iomem *base; > @@ -38,6 +58,11 @@ struct tpda_drvdata { > u8 atid; > u32 dsb_esize; > u32 cmb_esize; > + bool trig_async; > + bool trig_flag_ts; > + bool trig_freq; > + bool freq_ts; > + bool cmbchan_mode; > }; > > #endif /* _CORESIGHT_CORESIGHT_TPDA_H */ Suzuki

1 week, 6 days

Re: [PATCH v1] dt-binding: Update oss email address for Coresight documents

by Suzuki K Poulose

On Tue, 02 Sep 2025 12:21:43 +0800, Jie Gan wrote: > Update the OSS email addresses across all Coresight documents, as the > previous addresses have been deprecated. > > Applied, thanks! [1/1] dt-binding: Update oss email address for Coresight documents https://git.kernel.org/coresight/c/7009646d937f Best regards, -- Suzuki K Poulose <suzuki.poulose(a)arm.com>

1 week, 6 days

Re: [PATCH v4 1/3] coresight: tpda: add sysfs nodes for tpda cross-trigger configuration

by Suzuki K Poulose

On 18/12/2025 06:22, Jie Gan wrote: > > > On 10/28/2025 10:02 AM, Jie Gan wrote: >> From: Tao Zhang <tao.zhang(a)oss.qualcomm.com> >> >> Introduce sysfs nodes to configure cross-trigger parameters for TPDA. >> These registers define the characteristics of cross-trigger packets, >> including generation frequency and flag values. >> >> Signed-off-by: Tao Zhang <tao.zhang(a)oss.qualcomm.com> >> Reviewed-by: James Clark <james.clark(a)linaro.org> >> Co-developed-by: Jie Gan <jie.gan(a)oss.qualcomm.com> >> Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> >> --- >> .../ABI/testing/sysfs-bus-coresight-devices-tpda | 43 ++++ >> drivers/hwtracing/coresight/coresight-tpda.c | 230 +++++++++++ >> ++++++++++ >> drivers/hwtracing/coresight/coresight-tpda.h | 27 ++- >> 3 files changed, 299 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices- >> tpda b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda >> new file mode 100644 >> index 000000000000..80e4b05a1ab4 >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda > > Gentle reminder. > > Do I need update the date and the kernelVersion of the sysfs node? > (target 7.0?) Leave it with me, I can fix it up. Apologies for missing this out. Suzuki > > Thanks, > Jie > > >> @@ -0,0 +1,43 @@ >> +What: /sys/bus/coresight/devices/<tpda-name>/trig_async_enable >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Enable/disable cross trigger synchronization sequence >> interface. >> + >> +What: /sys/bus/coresight/devices/<tpda-name>/trig_flag_ts_enable >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Enable/disable cross trigger FLAG packet request interface. >> + >> +What: /sys/bus/coresight/devices/<tpda-name>/trig_freq_enable >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Enable/disable cross trigger FREQ packet request interface. >> + >> +What: /sys/bus/coresight/devices/<tpda-name>/freq_ts_enable >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Enable/disable the timestamp for all FREQ packets. >> + >> +What: /sys/bus/coresight/devices/<tpda-name>/global_flush_req >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Set global (all ports) flush request bit. The bit >> remains set until a >> + global flush request sequence completes. >> + >> +What: /sys/bus/coresight/devices/<tpda-name>/cmbchan_mode >> +Date: October 2025 >> +KernelVersion: 6.19 >> +Contact: Jinlong Mao <jinlong.mao(a)oss.qualcomm.com>, Tao Zhang >> <tao.zhang(a)oss.qualcomm.com>, Jie Gan <jie.gan(a)oss.qualcomm.com> >> +Description: >> + (RW) Configure the CMB/MCMB channel mode for all enabled ports. >> + Value 0 means raw channel mapping mode. Value 1 means channel >> pair marking mode. >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/ >> hwtracing/coresight/coresight-tpda.c >> index 333b3cb23685..a9a27bcc65a1 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.c >> +++ b/drivers/hwtracing/coresight/coresight-tpda.c >> @@ -147,9 +147,37 @@ static void tpda_enable_pre_port(struct >> tpda_drvdata *drvdata) >> u32 val; >> val = readl_relaxed(drvdata->base + TPDA_CR); >> + val &= ~TPDA_CR_MID; >> val &= ~TPDA_CR_ATID; >> val |= FIELD_PREP(TPDA_CR_ATID, drvdata->atid); >> + if (drvdata->trig_async) >> + val |= TPDA_CR_SRIE; >> + else >> + val &= ~TPDA_CR_SRIE; >> + if (drvdata->trig_flag_ts) >> + val |= TPDA_CR_FLRIE; >> + else >> + val &= ~TPDA_CR_FLRIE; >> + if (drvdata->trig_freq) >> + val |= TPDA_CR_FRIE; >> + else >> + val &= ~TPDA_CR_FRIE; >> + if (drvdata->freq_ts) >> + val |= TPDA_CR_FREQTS; >> + else >> + val &= ~TPDA_CR_FREQTS; >> + if (drvdata->cmbchan_mode) >> + val |= TPDA_CR_CMBCHANMODE; >> + else >> + val &= ~TPDA_CR_CMBCHANMODE; >> writel_relaxed(val, drvdata->base + TPDA_CR); >> + >> + /* >> + * If FLRIE bit is set, set the master and channel >> + * id as zero >> + */ >> + if (drvdata->trig_flag_ts) >> + writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); >> } >> static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) >> @@ -265,6 +293,206 @@ static const struct coresight_ops tpda_cs_ops = { >> .link_ops = &tpda_link_ops, >> }; >> +static ssize_t trig_async_enable_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_async); >> +} >> + >> +static ssize_t trig_async_enable_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + drvdata->trig_async = !!val; >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(trig_async_enable); >> + >> +static ssize_t trig_flag_ts_enable_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_flag_ts); >> +} >> + >> +static ssize_t trig_flag_ts_enable_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + drvdata->trig_flag_ts = !!val; >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(trig_flag_ts_enable); >> + >> +static ssize_t trig_freq_enable_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_freq); >> +} >> + >> +static ssize_t trig_freq_enable_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + drvdata->trig_freq = !!val; >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(trig_freq_enable); >> + >> +static ssize_t freq_ts_enable_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->freq_ts); >> +} >> + >> +static ssize_t freq_ts_enable_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + drvdata->freq_ts = !!val; >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(freq_ts_enable); >> + >> +static ssize_t global_flush_req_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (!drvdata->csdev->refcnt) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + CS_UNLOCK(drvdata->base); >> + val = readl_relaxed(drvdata->base + TPDA_CR); >> + CS_LOCK(drvdata->base); >> + /* Only read value for bit 0 */ >> + val &= BIT(0); >> + >> + return sysfs_emit(buf, "%lu\n", val); >> +} >> + >> +static ssize_t global_flush_req_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + if (!drvdata->csdev->refcnt || !val) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + CS_UNLOCK(drvdata->base); >> + val = readl_relaxed(drvdata->base + TPDA_CR); >> + /* Only set bit 0 */ >> + val |= BIT(0); >> + writel_relaxed(val, drvdata->base + TPDA_CR); >> + CS_LOCK(drvdata->base); >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(global_flush_req); >> + >> +static ssize_t cmbchan_mode_show(struct device *dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->cmbchan_mode); >> +} >> + >> +static ssize_t cmbchan_mode_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t size) >> +{ >> + struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + unsigned long val; >> + >> + if (kstrtoul(buf, 0, &val)) >> + return -EINVAL; >> + >> + guard(spinlock)(&drvdata->spinlock); >> + drvdata->cmbchan_mode = !!val; >> + >> + return size; >> +} >> +static DEVICE_ATTR_RW(cmbchan_mode); >> + >> +static struct attribute *tpda_attrs[] = { >> + &dev_attr_trig_async_enable.attr, >> + &dev_attr_trig_flag_ts_enable.attr, >> + &dev_attr_trig_freq_enable.attr, >> + &dev_attr_freq_ts_enable.attr, >> + &dev_attr_global_flush_req.attr, >> + &dev_attr_cmbchan_mode.attr, >> + NULL, >> +}; >> + >> +static struct attribute_group tpda_attr_grp = { >> + .attrs = tpda_attrs, >> +}; >> + >> +static const struct attribute_group *tpda_attr_grps[] = { >> + &tpda_attr_grp, >> + NULL, >> +}; >> + >> static int tpda_init_default_data(struct tpda_drvdata *drvdata) >> { >> int atid; >> @@ -280,6 +508,7 @@ static int tpda_init_default_data(struct >> tpda_drvdata *drvdata) >> return atid; >> drvdata->atid = atid; >> + drvdata->freq_ts = true; >> return 0; >> } >> @@ -323,6 +552,7 @@ static int tpda_probe(struct amba_device *adev, >> const struct amba_id *id) >> desc.ops = &tpda_cs_ops; >> desc.pdata = adev->dev.platform_data; >> desc.dev = &adev->dev; >> + desc.groups = tpda_attr_grps; >> desc.access = CSDEV_ACCESS_IOMEM(base); >> drvdata->csdev = coresight_register(&desc); >> if (IS_ERR(drvdata->csdev)) >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/ >> hwtracing/coresight/coresight-tpda.h >> index c6af3d2da3ef..0be625fb52fd 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.h >> +++ b/drivers/hwtracing/coresight/coresight-tpda.h >> @@ -1,6 +1,6 @@ >> /* SPDX-License-Identifier: GPL-2.0 */ >> /* >> - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights >> reserved. >> + * Copyright (c) 2023,2025 Qualcomm Innovation Center, Inc. All >> rights reserved. >> */ >> #ifndef _CORESIGHT_CORESIGHT_TPDA_H >> @@ -8,6 +8,19 @@ >> #define TPDA_CR (0x000) >> #define TPDA_Pn_CR(n) (0x004 + (n * 4)) >> +#define TPDA_FPID_CR (0x084) >> + >> +/* Cross trigger FREQ packets timestamp bit */ >> +#define TPDA_CR_FREQTS BIT(2) >> +/* Cross trigger FREQ packet request bit */ >> +#define TPDA_CR_FRIE BIT(3) >> +/* Cross trigger FLAG packet request interface bit */ >> +#define TPDA_CR_FLRIE BIT(4) >> +/* Cross trigger synchronization bit */ >> +#define TPDA_CR_SRIE BIT(5) >> +/* Packetize CMB/MCMB traffic bit */ >> +#define TPDA_CR_CMBCHANMODE BIT(20) >> + >> /* Aggregator port enable bit */ >> #define TPDA_Pn_CR_ENA BIT(0) >> /* Aggregator port CMB data set element size bit */ >> @@ -19,6 +32,8 @@ >> /* Bits 6 ~ 12 is for atid value */ >> #define TPDA_CR_ATID GENMASK(12, 6) >> +/* Bits 13 ~ 19 is for mid value */ >> +#define TPDA_CR_MID GENMASK(19, 13) >> /** >> * struct tpda_drvdata - specifics associated to an TPDA component >> @@ -29,6 +44,11 @@ >> * @enable: enable status of the component. >> * @dsb_esize Record the DSB element size. >> * @cmb_esize Record the CMB element size. >> + * @trig_async: Enable/disable cross trigger synchronization >> sequence interface. >> + * @trig_flag_ts: Enable/disable cross trigger FLAG packet request >> interface. >> + * @trig_freq: Enable/disable cross trigger FREQ packet request >> interface. >> + * @freq_ts: Enable/disable the timestamp for all FREQ packets. >> + * @cmbchan_mode: Configure the CMB/MCMB channel mode. >> */ >> struct tpda_drvdata { >> void __iomem *base; >> @@ -38,6 +58,11 @@ struct tpda_drvdata { >> u8 atid; >> u32 dsb_esize; >> u32 cmb_esize; >> + bool trig_async; >> + bool trig_flag_ts; >> + bool trig_freq; >> + bool freq_ts; >> + bool cmbchan_mode; >> }; >> #endif /* _CORESIGHT_CORESIGHT_TPDA_H */ >> >

1 week, 6 days

[PATCH] stm class: Fix Kconfig symbols

by Leo Yan

Kconfig symbols must not include the CONFIG_ prefix. Remove the CONFIG_ prefix for default values to work. Fixes: a02509f301c6 ("stm class: Factor out default framing protocol") Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support") Signed-off-by: Leo Yan <leo.yan(a)arm.com> --- drivers/hwtracing/stm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..cd7f0b0f3fbebc74775d8835187e49e5bd21d646 100644 --- a/drivers/hwtracing/stm/Kconfig +++ b/drivers/hwtracing/stm/Kconfig @@ -13,7 +13,7 @@ if STM config STM_PROTO_BASIC tristate "Basic STM framing protocol driver" - default CONFIG_STM + default STM help This is a simple framing protocol for sending data over STM devices. This was the protocol that the STM framework used @@ -28,7 +28,7 @@ config STM_PROTO_BASIC config STM_PROTO_SYS_T tristate "MIPI SyS-T STM framing protocol driver" - default CONFIG_STM + default STM help This is an implementation of MIPI SyS-T protocol to be used over the STP transport. In addition to the data payload, it --- base-commit: 40fbbd64bba6c6e7a72885d2f59b6a3be9991eeb change-id: 20251216-fix_stm_kconfig-a72f40c7612c Best regards, -- Leo Yan <leo.yan(a)arm.com>

2 weeks

Re: [PATCH v3 05/12] perf evsel: Add a helper to get the value of a config field

by James Clark

On 16/12/2025 22:44, Ian Rogers wrote: > On Fri, Dec 12, 2025 at 7:32 AM James Clark <james.clark(a)linaro.org> wrote: >> >> This will be used by aux PMUs to read an already written value for >> configuring their events and for also testing. >> >> Its helper pmu_format_unpack() does the opposite of the existing >> pmu_format_value() so rename that one to pmu_format_pack() so it's clear >> how they are related. >> >> Signed-off-by: James Clark <james.clark(a)linaro.org> >> --- >> tools/perf/util/evsel.h | 2 ++ >> tools/perf/util/pmu.c | 77 ++++++++++++++++++++++++++++++++++++++++++------- >> 2 files changed, 68 insertions(+), 11 deletions(-) >> >> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h >> index a08130ff2e47a887b19f6c47bfa9f51e0c40d226..092904a61ec7afdc59253f9b78a9fe8b7cb5bfa7 100644 >> --- a/tools/perf/util/evsel.h >> +++ b/tools/perf/util/evsel.h >> @@ -575,6 +575,8 @@ void evsel__uniquify_counter(struct evsel *counter); >> ((((src) >> (pos)) & ((1ull << (size)) - 1)) << (63 - ((pos) + (size) - 1))) >> >> u64 evsel__bitfield_swap_branch_flags(u64 value); >> +int evsel__get_config_val(struct perf_pmu *pmu, struct evsel *evsel, >> + const char *config_name, u64 *val); >> void evsel__set_config_if_unset(struct perf_pmu *pmu, struct evsel *evsel, >> const char *config_name, u64 val); >> >> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c >> index 514cba91f5d99b399d2d6a1e350971660c54a9fc..ef7358ad1fb955f29f2e68b3d0ce711754e4d67c 100644 >> --- a/tools/perf/util/pmu.c >> +++ b/tools/perf/util/pmu.c >> @@ -144,8 +144,8 @@ struct perf_pmu_format { >> }; >> >> static int pmu_aliases_parse(struct perf_pmu *pmu); >> -static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, >> - bool zero); >> +static void pmu_format_pack(unsigned long *format, __u64 value, __u64 *v, >> + bool zero); >> static struct perf_pmu_format *pmu_find_format(const struct list_head *formats, >> const char *name); >> >> @@ -1377,6 +1377,61 @@ bool evsel__is_aux_event(const struct evsel *evsel) >> return pmu && pmu->auxtrace; >> } >> >> +/* >> + * Unpacks a raw config[n] value using the sparse bitfield that defines a >> + * format attr. For example "config1:1,6-7,44" defines a 4 bit value across non >> + * contiguous bits and this function returns those 4 bits as a value. >> + */ >> +static u64 pmu_format_unpack(u64 format, u64 config_val) >> +{ >> + int val_bit = 0; >> + u64 res = 0; >> + int fmt_bit; >> + >> + for_each_set_bit(fmt_bit, &format, PERF_PMU_FORMAT_BITS) { >> + if (test_bit(fmt_bit, &config_val)) >> + res |= BIT_ULL(val_bit); >> + >> + val_bit++; >> + } >> + return res; >> +} >> + >> +int evsel__get_config_val(struct perf_pmu *pmu, struct evsel *evsel, >> + const char *config_name, u64 *val) > > nits: > This is an evsel__ function but the evsel is the 2nd argument not the first. > Why pass the PMU and not just read evsel->pmu (or better evsel__find_pmu) ? That makes sense, I can do that. > Why not place this in evsel.c to match the header file declaration? This was for consistency with evsel__set_config_if_unset() that Arnaldo moved to pmu.c because of an issue with the Python bindings [1]. That doesn't seem to be an issue any more so I could move both to evsel.c. That would require making the following things public: struct perf_pmu_format pmu_format_pack() pmu_format_unpack() pmu_find_format() Probably not the end of the world though? [1]: https://lore.kernel.org/all/ZEbAS2yx2fguW60w@kernel.org/ > The evsel could be likely be const. > Will do > Thanks, > Ian > >> +{ >> + struct perf_pmu_format *format = pmu_find_format(&pmu->format, config_name); >> + u64 bits = perf_pmu__format_bits(pmu, config_name); >> + >> + if (!format || !bits) { >> + pr_err("Unknown/empty format name: %s\n", config_name); >> + *val = 0; >> + return -EINVAL; >> + } >> + >> + switch (format->value) { >> + case PERF_PMU_FORMAT_VALUE_CONFIG: >> + *val = pmu_format_unpack(bits, evsel->core.attr.config); >> + return 0; >> + case PERF_PMU_FORMAT_VALUE_CONFIG1: >> + *val = pmu_format_unpack(bits, evsel->core.attr.config1); >> + return 0; >> + case PERF_PMU_FORMAT_VALUE_CONFIG2: >> + *val = pmu_format_unpack(bits, evsel->core.attr.config2); >> + return 0; >> + case PERF_PMU_FORMAT_VALUE_CONFIG3: >> + *val = pmu_format_unpack(bits, evsel->core.attr.config3); >> + return 0; >> + case PERF_PMU_FORMAT_VALUE_CONFIG4: >> + *val = pmu_format_unpack(bits, evsel->core.attr.config4); >> + return 0; >> + default: >> + pr_err("Unknown format value: %d\n", format->value); >> + *val = 0; >> + return -EINVAL; >> + } >> +} >> + >> /* >> * Set @config_name to @val as long as the user hasn't already set or cleared it >> * by passing a config term on the command line. >> @@ -1432,7 +1487,7 @@ void evsel__set_config_if_unset(struct perf_pmu *pmu, struct evsel *evsel, >> return; >> >> /* Otherwise replace it */ >> - pmu_format_value(&bits, val, vp, /*zero=*/true); >> + pmu_format_pack(&bits, val, vp, /*zero=*/true); >> } >> >> static struct perf_pmu_format * >> @@ -1477,8 +1532,8 @@ int perf_pmu__format_type(struct perf_pmu *pmu, const char *name) >> * Sets value based on the format definition (format parameter) >> * and unformatted value (value parameter). >> */ >> -static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, >> - bool zero) >> +static void pmu_format_pack(unsigned long *format, __u64 value, __u64 *v, >> + bool zero) >> { >> unsigned long fbit, vbit; >> >> @@ -1595,23 +1650,23 @@ static int pmu_config_term(const struct perf_pmu *pmu, >> switch (term->type_term) { >> case PARSE_EVENTS__TERM_TYPE_CONFIG: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> - pmu_format_value(bits, term->val.num, &attr->config, zero); >> + pmu_format_pack(bits, term->val.num, &attr->config, zero); >> break; >> case PARSE_EVENTS__TERM_TYPE_CONFIG1: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> - pmu_format_value(bits, term->val.num, &attr->config1, zero); >> + pmu_format_pack(bits, term->val.num, &attr->config1, zero); >> break; >> case PARSE_EVENTS__TERM_TYPE_CONFIG2: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> - pmu_format_value(bits, term->val.num, &attr->config2, zero); >> + pmu_format_pack(bits, term->val.num, &attr->config2, zero); >> break; >> case PARSE_EVENTS__TERM_TYPE_CONFIG3: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> - pmu_format_value(bits, term->val.num, &attr->config3, zero); >> + pmu_format_pack(bits, term->val.num, &attr->config3, zero); >> break; >> case PARSE_EVENTS__TERM_TYPE_CONFIG4: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> - pmu_format_value(bits, term->val.num, &attr->config4, zero); >> + pmu_format_pack(bits, term->val.num, &attr->config4, zero); >> break; >> case PARSE_EVENTS__TERM_TYPE_LEGACY_HARDWARE_CONFIG: >> assert(term->type_val == PARSE_EVENTS__TERM_TYPE_NUM); >> @@ -1749,7 +1804,7 @@ static int pmu_config_term(const struct perf_pmu *pmu, >> */ >> } >> >> - pmu_format_value(format->bits, val, vp, zero); >> + pmu_format_pack(format->bits, val, vp, zero); >> return 0; >> } >> >> >> -- >> 2.34.1 >>

2 weeks

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight