- Linux-kselftest-mirror - lists.linaro.org

[PATCH] selftests/tpm: Fix runtime error

by Jarkko Sakkinen

There is some random clutter in test_smoke.sh: ./test_smoke.sh: line 3: self.flags: command not found Remove it. Fixes: b32694cd0724 ("Kernel selftests: tpm2: check for tpm support") Cc: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> --- I rely on these tests and this was not even cc'd to me and obviously was untested. There is neither reviewed-by nor tested-by tags in the commit (not to mention some cosmetic things like short summary formatted wrong and the extra newline character). Please do not do this next time. Thanks. tools/testing/selftests/tpm2/test_smoke.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index b630c7b5950a..e55d3e400666 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -1,11 +1,9 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -self.flags = flags # Kselftest framework requirement - SKIP code is 4. ksft_skip=4 - if [ -f /dev/tpm0 ] ; then python -m unittest -v tpm2_tests.SmokeTest python -m unittest -v tpm2_tests.AsyncTest -- 2.25.1

4 years, 8 months

2
3
0 0

Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

by Luis Chamberlain

On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: > +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) > + > +#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ > +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf_priv > +int request_firmware_into_buf_priv(const struct firmware **firmware_p, > + const char *name, struct device *device, > + void *buf, size_t size, > + size_t offset, unsigned int pread_flags); > + > +#else > + > +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf > + > +#endif > + > +#endif Please clean this up, the code must reflect only the code upstream. No config stuff like this should be used on the driver. I had to stop my review here. Luis

4 years, 8 months

3
4
0 0

stable-rc 4.19: NETDEV WATCHDOG: eth0 (asix): transmit queue 0 timed out - net/sched/sch_generic.c:466 dev_watchdog

by Naresh Kamboju

While running selftests bpf test_sysctl on stable rc 4.19 branch kernel on arm64 hikey device. The following warning was noticed. [ 118.957395] test_bpf: #296 BPF_MAXINSNS: exec all MSH [ 148.966435] ------------[ cut here ]------------ [ 148.988349] NETDEV WATCHDOG: eth0 (asix): transmit queue 0 timed out [ 149.000832] WARNING: CPU: 0 PID: 0 at /usr/src/kernel/net/sched/sch_generic.c:466 dev_watchdog+0x2b4/0x2c0 [ 149.016470] Modules linked in: test_bpf(+) wl18xx wlcore mac80211 cfg80211 crc32_ce hci_uart crct10dif_ce btbcm snd_soc_audio_graph_card bluetooth snd_soc_simple_card_utils adv7511 cec wlcore_sdio kirin_drm dw_drm_dsi rfkill drm_kms_helper drm drm_panel_orientation_quirks fuse [last unloaded: test_bpf] [ 149.056507] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.121-rc1 #1 [ 149.069594] Hardware name: HiKey Development Board (DT) [ 149.081514] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 149.093062] pc : dev_watchdog+0x2b4/0x2c0 [ 149.103862] lr : dev_watchdog+0x2b4/0x2c0 [ 149.114575] sp : ffff000008003d10 [ 149.124613] x29: ffff000008003d10 x28: 0000000000000002 [ 149.136698] x27: 0000000000000001 x26: 00000000ffffffff [ 149.148810] x25: 0000000000000180 x24: ffff800074c654b8 [ 149.160891] x23: ffff800074c65460 x22: ffff8000748dd680 [ 149.172993] x21: ffff00000974a000 x20: ffff800074c65000 [ 149.185065] x19: 0000000000000000 x18: ffffffffffffffff [ 149.197172] x17: 0000000000000000 x16: 0000000000000000 [ 149.209243] x15: 0000000000000001 x14: ffff000009062cd8 [ 149.221234] x13: 0000000045a6fc2a x12: ffff00000975b630 [ 149.233166] x11: 00000000ffffffff x10: ffff00000974fa48 [ 149.245023] x9 : ffff0000097e3000 x8 : ffff00000974fa48 [ 149.256818] x7 : ffff000008173694 x6 : ffff800077ee62d0 [ 149.268639] x5 : ffff800077ee62d0 x4 : 0000000000000000 [ 149.280412] x3 : ffff800077eef6c8 x2 : 0000000000000103 [ 149.292120] x1 : d13523b333b73d00 x0 : 0000000000000000 [ 149.303783] Call trace: [ 149.312481] dev_watchdog+0x2b4/0x2c0 [ 149.322463] call_timer_fn+0xbc/0x3f0 [ 149.332463] expire_timers+0x104/0x220 [ 149.342493] run_timer_softirq+0xec/0x1a8 [ 149.352784] __do_softirq+0x114/0x554 [ 149.362668] irq_exit+0x144/0x150 [ 149.372235] __handle_domain_irq+0x6c/0xc0 [ 149.382633] gic_handle_irq+0x60/0xb0 [ 149.392606] el1_irq+0xb4/0x130 [ 149.402031] cpuidle_enter_state+0xbc/0x3f0 [ 149.412572] cpuidle_enter+0x34/0x48 [ 149.422539] call_cpuidle+0x44/0x78 [ 149.432410] do_idle+0x228/0x2a8 [ 149.441959] cpu_startup_entry+0x2c/0x30 [ 149.452185] rest_init+0x25c/0x270 [ 149.461821] start_kernel+0x468/0x494 [ 149.471659] irq event stamp: 5706193 [ 149.481376] hardirqs last enabled at (5706192): [<ffff00000817376c>] console_unlock+0x424/0x638 [ 149.496628] hardirqs last disabled at (5706193): [<ffff000008081490>] do_debug_exception+0xf8/0x1d0 [ 149.512207] softirqs last enabled at (5706160): [<ffff0000080f94a8>] _local_bh_enable+0x28/0x48 [ 149.527590] softirqs last disabled at (5706161): [<ffff0000080f9bb4>] irq_exit+0x144/0x150 [ 149.542410] ---[ end trace 4c7bd8e08a6a3d65 ]--- [ 177.828500] jited:1 1366234 PASS ref: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.120-… metadata: git branch: linux-4.19.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git make_kernelversion: 4.19.121-rc1 kernel-config: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/hikey/lkft/linux-st… -- Linaro LKFT https://lkft.linaro.org

4 years, 8 months

1
1
0 0

[ANN] linux-arts v2.0 update

by Shuah Khan

linux-arts git has been updated with the new reproducers from https://github.com/dvyukov/syzkaller-repros.git - a total of 1138 new linux reproducers - new script to collect reprogs from file system - updates to README.md - Updates to README on how linux-arts is synced with syzkaller-repros.git This update can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-arts.git thanks, -- Shuah ----------------------------------------------------- Author: Shuah Khan <skhan(a)linuxfoundation.org linux-arts: Update README with process information Author: Dmitry Vyukov <dvyukov(a)google.com linux: add 170 new repros from syzbot Author: Dmitry Vyukov <dvyukov(a)google.com> linux: add 270 new local repros Author: Jukka Kaartinen <jukka.kaartinen(a)unikie.com> Add reproducers from local builds Author: Jukka Kaartinen <jukka.kaartinen(a)unikie.com> Add script to collect reprogs from file system Author: Dmitry Vyukov <dvyukov(a)google.com> Update README.md Author: Dmitry Vyukov <dvyukov(a)google.com> update linux reproducers -----------------------------------------------------

4 years, 8 months

1
0
0 0

x86_64: 5.6.0: locking/lockdep.c:1155 lockdep_register_key

by Naresh Kamboju

On Linux mainline kernel 5.6.0 running kselftest on i386 kernel running on x86_64 devices we have noticed this kernel warning. [ 0.000000] Linux version 5.6.0 (oe-user@oe-host) (gcc version 7.3.0 (GCC)) #1 SMP Mon Apr 6 17:31:22 UTC 2020 <> [ 143.321511] ------------[ cut here ]------------ [ 143.326180] WARNING: CPU: 1 PID: 1515 at /usr/src/kernel/kernel/locking/lockdep.c:1155 lockdep_register_key+0x150/0x180 [ 143.336958] Modules linked in: sch_ingress veth algif_hash x86_pkg_temp_thermal fuse [ 143.344698] CPU: 1 PID: 1515 Comm: ip Tainted: G W 5.6.0 #1 [ 143.351562] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 143.359034] EIP: lockdep_register_key+0x150/0x180 [ 143.363739] Code: ff ff a1 88 4c 2a dc 85 c0 0f 85 ef fe ff ff 68 27 02 f9 db 68 a5 7a f7 db e8 0c 5b fa ff 0f 0b 59 58 e9 d7 fe ff ff 8d 76 00 <0f> 0b 8d 65 f8 5b 5e 5d c3 8d b4 26 00 00 00 00 89 c2 b8 68 68 99 [ 143.382485] EAX: 00000001 EBX: dc329ea8 ECX: 00000001 EDX: dc3299a8 [ 143.388751] ESI: 00000001 EDI: c7316000 EBP: c610fe10 ESP: c610fe08 [ 143.395014] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00010202 [ 143.401792] CR0: 80050033 CR2: b7dd70c0 CR3: 20672000 CR4: 003406d0 [ 143.408051] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 [ 143.414315] DR6: fffe0ff0 DR7: 00000400 [ 143.418144] Call Trace: [ 143.420592] alloc_netdev_mqs+0xc6/0x3c0 [ 143.424520] __ip_tunnel_create+0xa1/0x1d0 [ 143.428614] ? ipgre_tap_setup+0x50/0x50 [ 143.432535] ? mutex_lock_nested+0x19/0x20 [ 143.436634] ip_tunnel_init_net+0x125/0x340 [ 143.440823] erspan_init_net+0x1d/0x20 [ 143.444580] ops_init+0x34/0x180 [ 143.447815] setup_net+0xe7/0x230 [ 143.451134] copy_net_ns+0xe0/0x210 [ 143.454625] create_new_namespaces+0xf5/0x290 [ 143.458984] unshare_nsproxy_namespaces+0x47/0xa0 [ 143.463691] ksys_unshare+0x19e/0x330 [ 143.467354] ? __might_fault+0x41/0x80 [ 143.471102] __ia32_sys_unshare+0xf/0x20 [ 143.475026] do_fast_syscall_32+0x7f/0x330 [ 143.479126] entry_SYSENTER_32+0xaa/0x102 [ 143.483135] EIP: 0xb7f77ce1 [ 143.485926] Code: 5e 5d c3 8d b6 00 00 00 00 b8 40 42 0f 00 eb c1 8b 04 24 c3 8b 1c 24 c3 8b 34 24 c3 8b 3c 24 c3 90 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 143.504662] EAX: ffffffda EBX: 40000000 ECX: 080a8b31 EDX: 00000000 [ 143.510920] ESI: 00000001 EDI: bf833230 EBP: bf830fc0 ESP: bf830f7c [ 143.517177] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000292 [ 143.523959] irq event stamp: 5894 [ 143.527275] hardirqs last enabled at (5893): [<dbc0225a>] _raw_spin_unlock_irqrestore+0x2a/0x50 [ 143.536054] hardirqs last disabled at (5894): [<dae019dc>] trace_hardirqs_off_thunk+0xc/0x10 [ 143.544487] softirqs last enabled at (5882): [<dba45069>] inet6_fill_ifla6_attrs+0x3b9/0x400 [ 143.553004] softirqs last disabled at (5880): [<dba4504b>] inet6_fill_ifla6_attrs+0x39b/0x400 [ 143.561514] ---[ end trace dbec531a9fb3b99c ]--- Full test log, https://lkft.validation.linaro.org/scheduler/job/1341969#L5766 -- Linaro LKFT https://lkft.linaro.org

4 years, 8 months

2
3
0 0

[PATCH] kselftests: dmabuf-heaps: Fix confused return value on expected error testing

by John Stultz

When I added the expected error testing, I forgot I need to set the return to zero when we successfully see an error. Without this change we only end up testing a single heap before the test quits. Cc: Shuah Khan <shuah(a)kernel.org> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> Cc: Brian Starkey <brian.starkey(a)arm.com> Cc: Laura Abbott <labbott(a)redhat.com> Cc: "Andrew F. Davis" <afd(a)ti.com> Cc: linux-kselftest(a)vger.kernel.org Signed-off-by: John Stultz <john.stultz(a)linaro.org> --- tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c index cd5e1f602ac9..909da9cdda97 100644 --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c @@ -351,6 +351,7 @@ static int test_alloc_errors(char *heap_name) } printf("Expected error checking passed\n"); + ret = 0; out: if (dmabuf_fd >= 0) close(dmabuf_fd); -- 2.17.1

4 years, 8 months

2
1
0 0

[PATCH v3 6/6] security: apparmor: default KUNIT_* fragments to KUNIT_ALL_TESTS

by Anders Roxell

This makes it easier to enable all KUnit fragments. Adding 'if !KUNIT_ALL_TESTS' so individual tests can not be turned off. Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in menuconfig. Reviewed-by: David Gow <davidgow(a)google.com> Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- security/apparmor/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/apparmor/Kconfig b/security/apparmor/Kconfig index 0fe336860773..03fae1bd48a6 100644 --- a/security/apparmor/Kconfig +++ b/security/apparmor/Kconfig @@ -70,8 +70,9 @@ config SECURITY_APPARMOR_DEBUG_MESSAGES the kernel message buffer. config SECURITY_APPARMOR_KUNIT_TEST - bool "Build KUnit tests for policy_unpack.c" + bool "Build KUnit tests for policy_unpack.c" if !KUNIT_ALL_TESTS depends on KUNIT=y && SECURITY_APPARMOR + default KUNIT_ALL_TESTS help This builds the AppArmor KUnit tests. -- 2.20.1

4 years, 8 months

2
1
0 0

[PATCH v3 5/6] fs: ext4: default KUNIT_* fragments to KUNIT_ALL_TESTS

by Anders Roxell

This makes it easier to enable all KUnit fragments. Adding 'if !KUNIT_ALL_TESTS' so individual tests can not be turned off. Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in menuconfig. Reviewed-by: David Gow <davidgow(a)google.com> Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- fs/ext4/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig index 2a592e38cdfe..bc7815158503 100644 --- a/fs/ext4/Kconfig +++ b/fs/ext4/Kconfig @@ -103,9 +103,10 @@ config EXT4_DEBUG echo 1 > /sys/module/ext4/parameters/mballoc_debug config EXT4_KUNIT_TESTS - tristate "KUnit tests for ext4" + tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS select EXT4_FS depends on KUNIT + default KUNIT_ALL_TESTS help This builds the ext4 KUnit tests. -- 2.20.1

4 years, 8 months

2
1
0 0

[PATCH v3 4/6] drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS

by Anders Roxell

This makes it easier to enable all KUnit fragments. Adding 'if !KUNIT_ALL_TESTS' so individual tests can not be turned off. Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in menuconfig. Reviewed-by: David Gow <davidgow(a)google.com> Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- drivers/base/Kconfig | 3 ++- drivers/base/test/Kconfig | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 5f0bc74d2409..8d7001712062 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -149,8 +149,9 @@ config DEBUG_TEST_DRIVER_REMOVE test this functionality. config PM_QOS_KUNIT_TEST - bool "KUnit Test for PM QoS features" + bool "KUnit Test for PM QoS features" if !KUNIT_ALL_TESTS depends on KUNIT=y + default KUNIT_ALL_TESTS config HMEM_REPORTING bool diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig index 305c7751184a..ba225eb1b761 100644 --- a/drivers/base/test/Kconfig +++ b/drivers/base/test/Kconfig @@ -9,5 +9,6 @@ config TEST_ASYNC_DRIVER_PROBE If unsure say N. config KUNIT_DRIVER_PE_TEST - bool "KUnit Tests for property entry API" + bool "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS depends on KUNIT=y + default KUNIT_ALL_TESTS -- 2.20.1

4 years, 8 months

1
0
0 0

[PATCH v3 3/6] lib: Kconfig.debug: default KUNIT_* fragments to KUNIT_ALL_TESTS

by Anders Roxell

This makes it easier to enable all KUnit fragments. Adding 'if !KUNIT_ALL_TESTS' so individual tests can not be turned off. Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in menuconfig. Reviewed-by: David Gow <davidgow(a)google.com> Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- lib/Kconfig.debug | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 21d9c5f6e7ec..1f4ab7a2bdee 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2064,8 +2064,9 @@ config TEST_SYSCTL If unsure, say N. config SYSCTL_KUNIT_TEST - tristate "KUnit test for sysctl" + tristate "KUnit test for sysctl" if !KUNIT_ALL_TESTS depends on KUNIT + default KUNIT_ALL_TESTS help This builds the proc sysctl unit test, which runs on boot. Tests the API contract and implementation correctness of sysctl. @@ -2075,8 +2076,9 @@ config SYSCTL_KUNIT_TEST If unsure, say N. config LIST_KUNIT_TEST - tristate "KUnit Test for Kernel Linked-list structures" + tristate "KUnit Test for Kernel Linked-list structures" if !KUNIT_ALL_TESTS depends on KUNIT + default KUNIT_ALL_TESTS help This builds the linked list KUnit test suite. It tests that the API and basic functionality of the list_head type -- 2.20.1

4 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror