- Linux-kselftest-mirror - lists.linaro.org

[GIT PULL] Kselftest update for Linux 6.5-rc1

by Shuah Khan

Hi Linus, Please pull the following Kselftest update for Linux 6.5-rc1. This kselftest update for Linux 6.5-rc1 consists of: - change to allow runners to override the timeout This change is made to avoid future increases of long timeouts - several other spelling and cleanups - a new subtest to video_device_test - enhancements to test coverage in clone3 test - other fixes to ftrace and cpufreq tests diff is attached. thanks, -- Shuah ---------------------------------------------------------------- The following changes since commit 858fd168a95c5b9669aac8db6c14a9aeab446375: Linux 6.4-rc6 (2023-06-11 14:35:30 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-next-6.5-rc1 for you to fetch changes up to 8cd0d8633e2de4e6dd9ddae7980432e726220fdb: selftests/ftace: Fix KTAP output ordering (2023-06-12 16:40:22 -0600) ---------------------------------------------------------------- linux-kselftest-next-6.5-rc1 This kselftest update for Linux 6.5-rc1 consists of: - change to allow runners to override the timeout This change is made to avoid future increases of long timeouts - several other spelling and cleanups - a new subtest to video_device_test - enhancements to test coverage in clone3 test - other fixes to ftrace and cpufreq tests ---------------------------------------------------------------- Akanksha J N (1): selftests/ftrace: Add new test case which checks for optimized probes Colin Ian King (2): selftests: prctl: Fix spelling mistake "anonynous" -> "anonymous" kselftest: vDSO: Fix accumulation of uninitialized ret when CLOCK_REALTIME is undefined Ivan Orlov (1): selftests: media_tests: Add new subtest to video_device_test Luis Chamberlain (1): selftests: allow runners to override the timeout Mark Brown (2): selftests/cpufreq: Don't enable generic lock debugging options selftests/ftace: Fix KTAP output ordering Rishabh Bhatnagar (1): kselftests: Sort the collections list to avoid duplicate tests Tobias Klauser (1): selftests/clone3: test clone3 with exit signal in flags Ziqi Zhao (1): selftest: pidfd: Omit long and repeating outputs Documentation/dev-tools/kselftest.rst | 22 ++++ tools/testing/selftests/clone3/clone3.c | 5 +- tools/testing/selftests/cpufreq/config | 8 -- tools/testing/selftests/ftrace/ftracetest | 2 +- .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 +++++++ tools/testing/selftests/kselftest/runner.sh | 11 +- .../selftests/media_tests/video_device_test.c | 111 +++++++++++++++------ tools/testing/selftests/pidfd/pidfd.h | 1 - tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 + tools/testing/selftests/pidfd/pidfd_test.c | 3 +- .../selftests/prctl/set-anon-vma-name-test.c | 2 +- tools/testing/selftests/run_kselftest.sh | 7 +- .../selftests/vDSO/vdso_test_clock_getres.c | 4 +- 13 files changed, 166 insertions(+), 45 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc ----------------------------------------------------------------

2 years, 4 months

4
4
0 0

[PATCH 0/2] Restrict address space for sv39,sv48,sv57

by Charlie Jenkins

Make sv39 the default address space for mmap as some applications currently depend on this assumption. The RISC-V specification enforces that bits outside of the virtual address range are not used, so restricting the size of the default address space as such should be temporary. A hint address passed to mmap will cause the largest address space that fits entirely into the hint to be used. If the hint is less than or equal to 1<<38, a 39-bit address will be used. After an address space is completely full, the next smallest address space will be used. Documentation is also added to the RISC-V virtual memory section to explain these changes. Charlie Jenkins (2): RISC-V: mm: Restrict address space for sv39,sv48,sv57 RISC-V: mm: Update documentation and include test Documentation/riscv/vm-layout.rst | 20 ++++++++ arch/riscv/include/asm/elf.h | 2 +- arch/riscv/include/asm/pgtable.h | 21 ++++++-- arch/riscv/include/asm/processor.h | 41 +++++++++++++--- tools/testing/selftests/riscv/Makefile | 2 +- tools/testing/selftests/riscv/mm/Makefile | 22 +++++++++ .../selftests/riscv/mm/testcases/mmap.c | 49 +++++++++++++++++++ 7 files changed, 144 insertions(+), 13 deletions(-) create mode 100644 tools/testing/selftests/riscv/mm/Makefile create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap.c base-commit: eef509789cecdce895020682192d32e8bac790e8 -- 2.34.1

2 years, 4 months

3
5
0 0

[PATCH v4 0/7] Optimize mremap during mutual alignment within PMD

by Joel Fernandes (Google)

Hello! Here is v4 of the mremap start address optimization / fix for exec warning. It took me a while to write a test that catches the issue me/Linus discussed in the last version. And I verified kernel crashes without the check. See below. The main changes in this series is: Care to be taken to move purely within a VMA, in other words this check in call_align_down(): if (vma->vm_start != addr_masked) return false; As an example of why this is needed: Consider the following range which is 2MB aligned and is a part of a larger 10MB range which is not shown. Each character is 256KB below making the source and destination 2MB each. The lower case letters are moved (s to d) and the upper case letters are not moved. |DDDDddddSSSSssss| If we align down 'ssss' to start from the 'SSSS', we will end up destroying SSSS. The above if statement prevents that and I verified it. I also added a test for this in the last patch. History of patches ================== v3->v4: 1. Make sure to check address to align is beginning of VMA 2. Add test to check this (test fails with a kernel crash if we don't do this). v2->v3: 1. Masked address was stored in int, fixed it to unsigned long to avoid truncation. 2. We now handle moves happening purely within a VMA, a new test is added to handle this. 3. More code comments. v1->v2: 1. Trigger the optimization for mremaps smaller than a PMD. I tested by tracing that it works correctly. 2. Fix issue with bogus return value found by Linus if we broke out of the above loop for the first PMD itself. v1: Initial RFC. Description of patches ====================== These patches optimizes the start addresses in move_page_tables() and tests the changes. It addresses a warning [1] that occurs due to a downward, overlapping move on a mutually-aligned offset within a PMD during exec. By initiating the copy process at the PMD level when such alignment is present, we can prevent this warning and speed up the copying process at the same time. Linus Torvalds suggested this idea. Please check the individual patches for more details. thanks, - Joel [1] https://lore.kernel.org/all/ZB2GTBD%2FLWTrkOiO@dhcp22.suse.cz/ Joel Fernandes (Google) (7): mm/mremap: Optimize the start addresses in move_page_tables() mm/mremap: Allow moves within the same VMA for stack selftests: mm: Fix failure case when new remap region was not found selftests: mm: Add a test for mutually aligned moves > PMD size selftests: mm: Add a test for remapping to area immediately after existing mapping selftests: mm: Add a test for remapping within a range selftests: mm: Add a test for moving from an offset from start of mapping fs/exec.c | 2 +- include/linux/mm.h | 2 +- mm/mremap.c | 63 ++++- tools/testing/selftests/mm/mremap_test.c | 301 +++++++++++++++++++---- 4 files changed, 319 insertions(+), 49 deletions(-) -- 2.41.0.rc2.161.g9c6817b8e7-goog

2 years, 4 months

5
17
0 0

[linux-next:master] BUILD REGRESSION 53cdf865f90ba922a854c65ed05b519f9d728424

by kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 53cdf865f90ba922a854c65ed05b519f9d728424 Add linux-next specific files for 20230627 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306122223.HHER4zOo-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306212119.fBNByIyn-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306260401.qZlYQpV2-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) arch/parisc/kernel/pdt.c:66:6: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] drivers/char/mem.c:164:25: error: implicit declaration of function 'unxlate_dev_mem_ptr'; did you mean 'xlate_dev_mem_ptr'? [-Werror=implicit-function-declaration] drivers/gpu/drm/i915/soc/intel_gmch.c:41:13: warning: variable 'mchbar_addr' set but not used [-Wunused-but-set-variable] drivers/mfd/max77541.c:176:18: warning: cast to smaller integer type 'enum max7754x_ids' from 'const void *' [-Wvoid-pointer-to-enum-cast] lib/kunit/executor_test.c:138:4: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] lib/kunit/test.c:775:38: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] Unverified Error/Warning (likely false positive, please contact us if interested): drivers/usb/cdns3/cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead net/wireless/scan.c:373 cfg80211_gen_new_ie() warn: potential spectre issue 'sub->data' [r] net/wireless/scan.c:397 cfg80211_gen_new_ie() warn: possible spectre second half. 'ext_id' {standard input}: Error: local label `"2" (instance number 9 of a fb label)' is not defined {standard input}:1097: Error: pcrel too far {standard input}:13: Error: symbol `__export_symbol_alpha_mv' is already defined Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-randconfig-r024-20230627 | `-- standard-input:Error:symbol-__export_symbol_alpha_mv-is-already-defined |-- i386-randconfig-m021-20230627 | |-- net-wireless-scan.c-cfg80211_gen_new_ie()-warn:possible-spectre-second-half.-ext_id | `-- net-wireless-scan.c-cfg80211_gen_new_ie()-warn:potential-spectre-issue-sub-data-r |-- parisc-allnoconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-allyesconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-defconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r012-20230627 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r013-20230627 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r052-20230627 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc64-defconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- riscv-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- riscv-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- sh-allmodconfig | |-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr | |-- standard-input:Error:local-label-(instance-number-of-a-fb-label)-is-not-defined | `-- standard-input:Error:pcrel-too-far |-- sh-j2_defconfig | `-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr |-- sh-randconfig-r015-20230627 | `-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr |-- sh-rsk7203_defconfig | `-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr `-- x86_64-buildonly-randconfig-r001-20230627 `-- drivers-gpu-drm-i915-soc-intel_gmch.c:warning:variable-mchbar_addr-set-but-not-used clang_recent_errors |-- arm-randconfig-r031-20230627 | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- hexagon-randconfig-r041-20230627 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- powerpc-randconfig-r023-20230627 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- riscv-randconfig-r042-20230627 | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type `-- x86_64-randconfig-r011-20230627 `-- drivers-mfd-max77541.c:warning:cast-to-smaller-integer-type-enum-max7754x_ids-from-const-void elapsed time: 725m configs tested: 137 configs skipped: 7 tested configs: alpha allyesconfig gcc alpha defconfig gcc alpha randconfig-r004-20230627 gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-r043-20230627 gcc arm allmodconfig gcc arm allyesconfig gcc arm assabet_defconfig gcc arm bcm2835_defconfig clang arm defconfig gcc arm lpc32xx_defconfig clang arm multi_v7_defconfig gcc arm pxa910_defconfig gcc arm randconfig-r031-20230627 clang arm randconfig-r035-20230627 clang arm randconfig-r046-20230627 gcc arm spear13xx_defconfig clang arm versatile_defconfig clang arm64 alldefconfig gcc arm64 allyesconfig gcc arm64 defconfig gcc arm64 randconfig-r003-20230627 gcc csky defconfig gcc hexagon randconfig-r041-20230627 clang hexagon randconfig-r045-20230627 clang i386 allyesconfig gcc i386 buildonly-randconfig-r004-20230627 gcc i386 buildonly-randconfig-r005-20230627 gcc i386 buildonly-randconfig-r006-20230627 gcc i386 debian-10.3 gcc i386 defconfig gcc i386 randconfig-i001-20230627 gcc i386 randconfig-i002-20230627 gcc i386 randconfig-i003-20230627 gcc i386 randconfig-i004-20230627 gcc i386 randconfig-i005-20230627 gcc i386 randconfig-i006-20230627 gcc i386 randconfig-i011-20230627 clang i386 randconfig-i012-20230627 clang i386 randconfig-i013-20230627 clang i386 randconfig-i014-20230627 clang i386 randconfig-i015-20230627 clang i386 randconfig-i016-20230627 clang loongarch allmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc loongarch randconfig-r024-20230627 gcc loongarch randconfig-r032-20230627 gcc m68k allmodconfig gcc m68k allyesconfig gcc m68k defconfig gcc m68k stmark2_defconfig gcc m68k sun3x_defconfig gcc microblaze defconfig gcc mips allmodconfig gcc mips allyesconfig gcc mips mtx1_defconfig clang mips randconfig-r022-20230627 gcc mips xway_defconfig gcc nios2 defconfig gcc nios2 randconfig-r014-20230627 gcc nios2 randconfig-r026-20230627 gcc openrisc randconfig-r005-20230627 gcc openrisc randconfig-r016-20230627 gcc parisc allyesconfig gcc parisc defconfig gcc parisc randconfig-r012-20230627 gcc parisc randconfig-r013-20230627 gcc parisc64 defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc klondike_defconfig gcc powerpc makalu_defconfig gcc powerpc mpc8315_rdb_defconfig clang powerpc mpc834x_itxgp_defconfig clang powerpc mpc836x_rdk_defconfig clang powerpc mvme5100_defconfig clang powerpc pasemi_defconfig gcc powerpc randconfig-r023-20230627 clang powerpc tqm8540_defconfig clang powerpc tqm8548_defconfig gcc riscv allmodconfig gcc riscv allnoconfig gcc riscv allyesconfig gcc riscv defconfig gcc riscv randconfig-r042-20230627 clang riscv rv32_defconfig gcc s390 allmodconfig gcc s390 allyesconfig gcc s390 defconfig gcc s390 randconfig-r021-20230627 clang s390 randconfig-r044-20230627 clang sh allmodconfig gcc sh dreamcast_defconfig gcc sh j2_defconfig gcc sh r7780mp_defconfig gcc sh randconfig-r015-20230627 gcc sh rsk7203_defconfig gcc sh rts7751r2dplus_defconfig gcc sh sdk7780_defconfig gcc sh se7751_defconfig gcc sparc allyesconfig gcc sparc defconfig gcc sparc64 randconfig-r001-20230627 gcc sparc64 randconfig-r025-20230627 gcc um allmodconfig clang um allnoconfig clang um allyesconfig clang um defconfig gcc um i386_defconfig gcc um x86_64_defconfig gcc x86_64 allyesconfig gcc x86_64 buildonly-randconfig-r001-20230627 gcc x86_64 buildonly-randconfig-r002-20230627 gcc x86_64 buildonly-randconfig-r003-20230627 gcc x86_64 defconfig gcc x86_64 kexec gcc x86_64 randconfig-r011-20230627 clang x86_64 randconfig-x001-20230627 clang x86_64 randconfig-x002-20230627 clang x86_64 randconfig-x003-20230627 clang x86_64 randconfig-x004-20230627 clang x86_64 randconfig-x005-20230627 clang x86_64 randconfig-x006-20230627 clang x86_64 randconfig-x011-20230627 gcc x86_64 randconfig-x012-20230627 gcc x86_64 randconfig-x013-20230627 gcc x86_64 randconfig-x014-20230627 gcc x86_64 randconfig-x015-20230627 gcc x86_64 randconfig-x016-20230627 gcc x86_64 rhel-8.3-rust clang x86_64 rhel-8.3 gcc xtensa alldefconfig gcc xtensa common_defconfig gcc xtensa randconfig-r002-20230627 gcc xtensa randconfig-r006-20230627 gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

2 years, 4 months

1
0
0 0

[GIT PULL] KUnit next update for Linux 6.5-rc1

by Shuah Khan

Hi Linus, Please pull the following KUnit next update for Linux 6.5-rc1. This KUnit update for Linux 6.5-rc1 consists of: - kunit_add_action() API to defer a call until test exit. - Update document to add kunit_add_action() usage notes. - Changes to always run cleanup from a test kthread. - Documentation updates to clarify cleanup usage - assertions should not be used in cleanup - Documentation update to clearly indicate that exit functions should run even if init fails - Several fixes and enhancements to existing tests. diff is attached. thanks, -- Shuah ---------------------------------------------------------------- The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-kunit-6.5-rc1 for you to fetch changes up to 2e66833579ed759d7b7da1a8f07eb727ec6e80db: MAINTAINERS: Add source tree entry for kunit (2023-06-15 09:16:01 -0600) ---------------------------------------------------------------- linux-kselftest-kunit-6.5-rc1 This KUnit update for Linux 6.5-rc1 consists of: - kunit_add_action() API to defer a call until test exit. - Update document to add kunit_add_action() usage notes. - Changes to always run cleanup from a test kthread. - Documentation updates to clarify cleanup usage - assertions should not be used in cleanup - Documentation update to clearly indicate that exit functions should run even if init fails - Several fixes and enhancements to existing tests. ---------------------------------------------------------------- Daniel Latypov (1): kunit: tool: undo type subscripts for subprocess.Popen David Gow (11): kunit: Always run cleanup from a test kthread Documentation: kunit: Note that assertions should not be used in cleanup Documentation: kunit: Warn that exit functions run even if init fails kunit: example: Provide example exit functions kunit: Add kunit_add_action() to defer a call until test exit kunit: executor_test: Use kunit_add_action() kunit: kmalloc_array: Use kunit_add_action() Documentation: kunit: Add usage notes for kunit_add_action() kunit: Fix obsolete name in documentation headers (func->action) kunit: Move kunit_abort() call out of kunit_do_failed_assertion() Documentation: kunit: Rename references to kunit_abort() Geert Uytterhoeven (1): Documentation: kunit: Modular tests should not depend on KUNIT=y Michal Wajdeczko (3): kunit/test: Add example test showing parameterized testing kunit: Fix reporting of the skipped parameterized tests kunit: Update kunit_print_ok_not_ok function SeongJae Park (1): MAINTAINERS: Add source tree entry for kunit Takashi Sakamoto (1): Documentation: Kunit: add MODULE_LICENSE to sample code Documentation/dev-tools/kunit/architecture.rst | 4 +- Documentation/dev-tools/kunit/start.rst | 7 +- Documentation/dev-tools/kunit/usage.rst | 69 ++++++++++- MAINTAINERS | 2 + include/kunit/resource.h | 92 +++++++++++++++ include/kunit/test.h | 34 ++++-- lib/kunit/executor_test.c | 11 +- lib/kunit/kunit-example-test.c | 56 +++++++++ lib/kunit/kunit-test.c | 88 +++++++++++++- lib/kunit/resource.c | 99 ++++++++++++++++ lib/kunit/test.c | 157 ++++++++++++++----------- tools/testing/kunit/kunit_kernel.py | 6 +- tools/testing/kunit/mypy.ini | 6 + tools/testing/kunit/run_checks.py | 2 +- 14 files changed, 538 insertions(+), 95 deletions(-) create mode 100644 tools/testing/kunit/mypy.ini ----------------------------------------------------------------

2 years, 4 months

2
1
0 0

[PATCH 0/4] rseq selftests updates

by Mathieu Desnoyers

Hi Shuah, This series contains updates to the rseq selftests. * A typo in the Makefile prevents the basic_percpu_ops_mm_cid_test to use the mm_cid field. * Fix load-acquire/store-release macros which were buggy on arm64. (this depends on commit "Implement rseq_unqual_scalar_typeof"). * The change "Use rseq_unqual_scalar_typeof in macros" is not a fix per se, but improves the assembler generated. Can you pick these in the selftests tree please ? Thanks, Mathieu Mathieu Desnoyers (4): selftests/rseq: Fix CID_ID typo in Makefile selftests/rseq: Implement rseq_unqual_scalar_typeof selftests/rseq: Fix arm64 buggy load-acquire/store-release macros selftests/rseq: Use rseq_unqual_scalar_typeof in macros tools/testing/selftests/rseq/Makefile | 2 +- tools/testing/selftests/rseq/compiler.h | 26 ++++++++++ tools/testing/selftests/rseq/rseq-arm.h | 4 +- tools/testing/selftests/rseq/rseq-arm64.h | 58 ++++++++++++----------- tools/testing/selftests/rseq/rseq-mips.h | 4 +- tools/testing/selftests/rseq/rseq-ppc.h | 4 +- tools/testing/selftests/rseq/rseq-riscv.h | 6 +-- tools/testing/selftests/rseq/rseq-s390.h | 4 +- tools/testing/selftests/rseq/rseq-x86.h | 4 +- 9 files changed, 70 insertions(+), 42 deletions(-) -- 2.25.1

2 years, 4 months

1
4
0 0

[PATCH bpf-next v3 0/7] Add SO_REUSEPORT support for TC bpf_sk_assign

by Lorenz Bauer

We want to replace iptables TPROXY with a BPF program at TC ingress. To make this work in all cases we need to assign a SO_REUSEPORT socket to an skb, which is currently prohibited. This series adds support for such sockets to bpf_sk_assing. I did some refactoring to cut down on the amount of duplicate code. The key to this is to use INDIRECT_CALL in the reuseport helpers. To show that this approach is not just beneficial to TC sk_assign I removed duplicate code for bpf_sk_lookup as well. Changes from v1: - Correct commit abbrev length (Kuniyuki) - Reduce duplication (Kuniyuki) - Add checks on sk_state (Martin) - Split exporting inet[6]_lookup_reuseport into separate patch (Eric) Joint work with Daniel Borkmann. Signed-off-by: Lorenz Bauer <lmb(a)isovalent.com> --- Changes in v3: - Fix warning re udp_ehashfn and udp6_ehashfn (Simon) - Return higher scoring connected UDP reuseport sockets (Kuniyuki) - Fix ipv6 module builds - Link to v2: https://lore.kernel.org/r/20230613-so-reuseport-v2-0-b7c69a342613@isovalent… --- Daniel Borkmann (1): selftests/bpf: Test that SO_REUSEPORT can be used with sk_assign helper Lorenz Bauer (6): udp: re-score reuseport groups when connected sockets are present net: export inet_lookup_reuseport and inet6_lookup_reuseport net: document inet[6]_lookup_reuseport sk_state requirements net: remove duplicate reuseport_lookup functions net: remove duplicate sk_lookup helpers bpf, net: Support SO_REUSEPORT sockets with bpf_sk_assign include/net/inet6_hashtables.h | 84 ++++++++- include/net/inet_hashtables.h | 77 +++++++- include/net/sock.h | 7 +- include/net/udp.h | 8 + include/uapi/linux/bpf.h | 3 - net/core/filter.c | 2 - net/ipv4/inet_hashtables.c | 70 +++++--- net/ipv4/udp.c | 88 ++++----- net/ipv6/inet6_hashtables.c | 73 +++++--- net/ipv6/udp.c | 98 ++++------ tools/include/uapi/linux/bpf.h | 3 - tools/testing/selftests/bpf/network_helpers.c | 3 + .../selftests/bpf/prog_tests/assign_reuse.c | 197 +++++++++++++++++++++ .../selftests/bpf/progs/test_assign_reuse.c | 142 +++++++++++++++ 14 files changed, 676 insertions(+), 179 deletions(-) --- base-commit: 970308a7b544fa1c7ee98a2721faba3765be8dd8 change-id: 20230613-so-reuseport-e92c526173ee Best regards, -- Lorenz Bauer <lmb(a)isovalent.com>

2 years, 4 months

3
16
0 0

[PATCH] selftests: timers: set-timer-lat: Remove unneeded semicolon

by baomingtong001＠208suo.com

./tools/testing/selftests/timers/set-timer-lat.c:83:2-3: Unneeded semicolon Signed-off-by: Mingtong Bao <baomingtong001(a)208suo.com> --- tools/testing/selftests/timers/set-timer-lat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c index 50da45437daa..d60bbcad487f 100644 --- a/tools/testing/selftests/timers/set-timer-lat.c +++ b/tools/testing/selftests/timers/set-timer-lat.c @@ -80,7 +80,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } -- 2.40.1

2 years, 4 months

2
1
0 0

[PATCH v3 0/9] cgroup/cpuset: Support remote partitions

by Waiman Long

v3: - [v2] https://lore.kernel.org/lkml/20230531163405.2200292-1-longman@redhat.com/ - Change the new control file from root-only "cpuset.cpus.reserve" to non-root "cpuset.cpus.exclusive" which lists the set of exclusive CPUs distributed down the hierarchy. - Add a patch to restrict boot-time isolated CPUs to isolated partitions only. - Update the test_cpuset_prs.sh test script and documentation accordingly. v2: - [v1] https://lore.kernel.org/lkml/20230412153758.3088111-1-longman@redhat.com/ - Dropped the special "isolcpus" partition in v1 - Add the root only "cpuset.cpus.reserve" control file for reserving CPUs used for remote isolated partitions. - Update the test_cpuset_prs.sh test script and documentation accordingly. This patch series introduces a new cpuset control file "cpuset.cpus.exclusive" which must be a subset of "cpuset.cpus" and the parent's "cpuset.cpus.exclusive". This control file lists the exclusive CPUs to be distributed down the hierarchy. Any one of the exclusive CPUs can only be distributed to at most one child cpuset. Unlike "cpuset.cpus", invalid input to "cpuset.cpus.exclusive" will be rejected with an error. This new control file has no effect on the behavior of the cpuset until it turns into a partition root. At that point, its effective CPUs will be set to its exclusive CPUs unless some of them are offline. This patch series also introduces a new category of cpuset partition called remote partitions. The existing partition category where the partition roots have to be clustered around the root cgroup in a hierarchical way is now referred to as local partitions. A remote partition can be formed far from the root cgroup with no partition root parent. While local partitions can be created without touching "cpuset.cpus.exclusive" as it can be set automatically if a cpuset becomes a local partition root. Properly set "cpuset.cpus.exclusive" values down the hierarchy are required to create a remote partition. Both scheduling and isolated partitions can be formed in a remote partition. A local partition can be created under a remote partition. A remote partition, however, cannot be formed under a local partition for now. Modern container orchestration tools like Kubernetes use the cgroup hierarchy to manage different containers. And it is relying on other middleware like systemd to help managing it. If a container needs to use isolated CPUs, it is hard to get those with the local partitions as it will require the administrative parent cgroup to be a partition root too which tool like systemd may not be ready to manage. With this patch series, we allow the creation of remote partition far from the root. The container management tool can manage the "cpuset.cpus.exclusive" file without impacting the other cpuset files that are managed by other middlewares. Of course, invalid "cpuset.cpus.exclusive" values will be rejected and changes to "cpuset.cpus" can affect the value of "cpuset.cpus.exclusive" due to the requirement that it has to be a subset of the former control file. Waiman Long (9): cgroup/cpuset: Inherit parent's load balance state in v2 cgroup/cpuset: Extract out CS_CPU_EXCLUSIVE & CS_SCHED_LOAD_BALANCE handling cgroup/cpuset: Improve temporary cpumasks handling cgroup/cpuset: Allow suppression of sched domain rebuild in update_cpumasks_hier() cgroup/cpuset: Add cpuset.cpus.exclusive for v2 cgroup/cpuset: Introduce remote partition cgroup/cpuset: Check partition conflict with housekeeping setup cgroup/cpuset: Documentation update for partition cgroup/cpuset: Extend test_cpuset_prs.sh to test remote partition Documentation/admin-guide/cgroup-v2.rst | 100 +- kernel/cgroup/cpuset.c | 1352 ++++++++++++----- .../selftests/cgroup/test_cpuset_prs.sh | 398 +++-- 3 files changed, 1297 insertions(+), 553 deletions(-) -- 2.31.1

2 years, 4 months

2
11
0 0

[linux-next:master] BUILD REGRESSION 60e7c4a25da68cd826719b685babbd23e73b85b0

by kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 60e7c4a25da68cd826719b685babbd23e73b85b0 Add linux-next specific files for 20230626 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306122223.HHER4zOo-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306262024.HUr6WfyW-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) arch/parisc/kernel/pdt.c:66:6: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] drivers/char/mem.c:164:25: error: implicit declaration of function 'unxlate_dev_mem_ptr'; did you mean 'xlate_dev_mem_ptr'? [-Werror=implicit-function-declaration] drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: declaration of 'struct seq_file' will not be visible outside of this function [-Werror,-Wvisibility] drivers/gpu/drm/i915/display/intel_display_power.h:256:70: error: declaration of 'struct seq_file' will not be visible outside of this function [-Werror,-Wvisibility] lib/kunit/executor_test.c:138:4: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] lib/kunit/test.c:775:38: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] Unverified Error/Warning (likely false positive, please contact us if interested): drivers/usb/cdns3/cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead fs/btrfs/volumes.c:6407 btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6244) lib/kunit/test.c:336 __kunit_abort() warn: ignoring unreachable code. {standard input}: Error: local label `"2" (instance number 9 of a fb label)' is not defined {standard input}:1097: Error: pcrel too far Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- i386-randconfig-m021-20230625 | `-- fs-btrfs-volumes.c-btrfs_map_block()-error:we-previously-assumed-mirror_num_ret-could-be-null-(see-line-) |-- parisc-allyesconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-defconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-generic-64bit_defconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r012-20230626 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r026-20230626 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc-randconfig-r053-20230625 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- parisc64-defconfig | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo |-- powerpc-randconfig-m041-20230625 | `-- lib-kunit-test.c-__kunit_abort()-warn:ignoring-unreachable-code. |-- riscv-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- riscv-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- sh-allmodconfig | |-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr | |-- standard-input:Error:local-label-(instance-number-of-a-fb-label)-is-not-defined | `-- standard-input:Error:pcrel-too-far |-- sh-rsk7201_defconfig | `-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr |-- sh-se7619_defconfig | `-- drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr `-- sparc64-randconfig-r053-20230625 `-- net-bluetooth-hci_conn.c:WARNING-opportunity-for-kmemdup clang_recent_errors |-- arm-randconfig-r016-20230626 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- hexagon-randconfig-r041-20230626 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- i386-randconfig-i004-20230626 | `-- drivers-gpu-drm-i915-display-intel_display_power.h:error:declaration-of-struct-seq_file-will-not-be-visible-outside-of-this-function-Werror-Wvisibility |-- um-randconfig-r024-20230626 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type `-- x86_64-randconfig-r004-20230626 `-- drivers-gpu-drm-i915-display-intel_display_power.h:error:declaration-of-struct-seq_file-will-not-be-visible-outside-of-this-function-Werror-Wvisibility elapsed time: 1076m configs tested: 124 configs skipped: 8 tested configs: alpha allyesconfig gcc alpha defconfig gcc alpha randconfig-r002-20230626 gcc alpha randconfig-r036-20230626 gcc arc allyesconfig gcc arc defconfig gcc arc nsim_700_defconfig gcc arc randconfig-r023-20230626 gcc arc randconfig-r043-20230626 gcc arm allmodconfig gcc arm allyesconfig gcc arm aspeed_g4_defconfig clang arm defconfig gcc arm footbridge_defconfig gcc arm h3600_defconfig gcc arm imx_v4_v5_defconfig clang arm ixp4xx_defconfig clang arm multi_v7_defconfig gcc arm mxs_defconfig clang arm netwinder_defconfig clang arm randconfig-r003-20230626 gcc arm randconfig-r006-20230626 gcc arm randconfig-r016-20230626 clang arm randconfig-r034-20230626 gcc arm randconfig-r046-20230626 clang arm s5pv210_defconfig clang arm spear3xx_defconfig clang arm64 allyesconfig gcc arm64 defconfig gcc arm64 randconfig-r031-20230626 clang csky defconfig gcc csky randconfig-r013-20230626 gcc hexagon randconfig-r041-20230626 clang hexagon randconfig-r045-20230626 clang i386 alldefconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-r004-20230626 clang i386 buildonly-randconfig-r005-20230626 clang i386 buildonly-randconfig-r006-20230626 clang i386 debian-10.3 gcc i386 defconfig gcc i386 randconfig-i001-20230626 clang i386 randconfig-i002-20230626 clang i386 randconfig-i003-20230626 clang i386 randconfig-i004-20230626 clang i386 randconfig-i005-20230626 clang i386 randconfig-i006-20230626 clang i386 randconfig-i011-20230626 gcc i386 randconfig-i012-20230626 gcc i386 randconfig-i013-20230626 gcc i386 randconfig-i014-20230626 gcc i386 randconfig-i015-20230626 gcc i386 randconfig-i016-20230626 gcc loongarch allmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc m68k allmodconfig gcc m68k allyesconfig gcc m68k defconfig gcc m68k hp300_defconfig gcc m68k randconfig-r011-20230626 gcc m68k randconfig-r015-20230626 gcc microblaze randconfig-r005-20230626 gcc mips allmodconfig gcc mips allyesconfig gcc mips ath79_defconfig clang mips ip22_defconfig clang mips loongson2k_defconfig clang mips malta_defconfig clang mips malta_qemu_32r6_defconfig clang mips maltaaprp_defconfig clang mips randconfig-r035-20230626 gcc nios2 defconfig gcc nios2 randconfig-r032-20230626 gcc openrisc defconfig gcc openrisc simple_smp_defconfig gcc parisc allyesconfig gcc parisc defconfig gcc parisc generic-64bit_defconfig gcc parisc randconfig-r012-20230626 gcc parisc randconfig-r026-20230626 gcc parisc64 defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc arches_defconfig gcc powerpc currituck_defconfig gcc powerpc pcm030_defconfig gcc powerpc randconfig-r021-20230626 gcc powerpc socrates_defconfig clang riscv alldefconfig clang riscv allmodconfig gcc riscv allnoconfig gcc riscv allyesconfig gcc riscv defconfig gcc riscv randconfig-r042-20230626 gcc riscv rv32_defconfig gcc s390 allmodconfig gcc s390 allyesconfig gcc s390 defconfig gcc s390 randconfig-r044-20230626 gcc sh allmodconfig gcc sh defconfig gcc sh rsk7201_defconfig gcc sh se7619_defconfig gcc sh sh7785lcr_32bit_defconfig gcc sparc allyesconfig gcc sparc defconfig gcc um allmodconfig clang um allnoconfig clang um allyesconfig clang um defconfig gcc um i386_defconfig gcc um randconfig-r024-20230626 clang um x86_64_defconfig gcc x86_64 allyesconfig gcc x86_64 buildonly-randconfig-r001-20230626 clang x86_64 buildonly-randconfig-r002-20230626 clang x86_64 buildonly-randconfig-r003-20230626 clang x86_64 defconfig gcc x86_64 kexec gcc x86_64 randconfig-r022-20230626 gcc x86_64 rhel-8.3-rust clang x86_64 rhel-8.3 gcc xtensa generic_kc705_defconfig gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror