[Linaro-mm-sig] Re: [PATCH v2 002/110] vfs: widen inode hash/lookup functions to u64

On Mon 02-03-26 15:23:46, Jeff Layton wrote:

Change the inode hash/lookup VFS API functions to accept u64 parameters instead of unsigned long for inode numbers and hash values. This is preparation for widening i_ino itself to u64, which will allow filesystems to store full 64-bit inode numbers on 32-bit architectures.

Since unsigned long implicitly widens to u64 on all architectures, this change is backward-compatible with all existing callers.

In dump_mapping(), change the local ino variable to kino_t and use the PRIino format macro, since this variable holds an i_ino value. In init_special_inode(), also switch to PRIino.

Signed-off-by: Jeff Layton jlayton@kernel.org

Looks good. Feel free to add:

Reviewed-by: Jan Kara jack@suse.cz

Honza