[Linaro-mm-sig] Re: [PATCH v2 104/110] fsnotify: replace PRIino with %llu/%llx format strings

On Mon 02-03-26 15:25:28, Jeff Layton wrote:

Now that i_ino is u64 and the PRIino format macro has been removed, replace all uses in fsnotify with the concrete format strings.

Signed-off-by: Jeff Layton jlayton@kernel.org

Looks good. Feel free to add:

Reviewed-by: Jan Kara jack@suse.cz

Honza

---

fs/notify/fdinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c index 586eaa7f65a4a61b892fb9c39e6a0d81e025b790..0f731eddeb8be74113361f45aa4fca2943395e9d 100644 --- a/fs/notify/fdinfo.c +++ b/fs/notify/fdinfo.c @@ -84,7 +84,7 @@ static void inotify_fdinfo(struct seq_file *m, struct fsnotify_mark *mark) inode_mark = container_of(mark, struct inotify_inode_mark, fsn_mark); inode = igrab(fsnotify_conn_inode(mark->connector)); if (inode) {

• seq_printf(m, "inotify wd:%x ino:%" PRIino "x sdev:%x mask:%x ignored_mask:0 ",
  

• seq_printf(m, "inotify wd:%x ino:%llx sdev:%x mask:%x ignored_mask:0 ",
     inode_mark->wd, inode->i_ino, inode->i_sb->s_dev,
     inotify_mark_user_mask(mark));
  

  show_mark_fhandle(m, inode);

@@ -111,7 +111,7 @@ static void fanotify_fdinfo(struct seq_file *m, struct fsnotify_mark *mark) inode = igrab(fsnotify_conn_inode(mark->connector)); if (!inode) return;

• seq_printf(m, "fanotify ino:%" PRIino "x sdev:%x mflags:%x mask:%x ignored_mask:%x ",
  

• seq_printf(m, "fanotify ino:%llx sdev:%x mflags:%x mask:%x ignored_mask:%x ",
     inode->i_ino, inode->i_sb->s_dev,
     mflags, mark->mask, mark->ignore_mask);
  

  show_mark_fhandle(m, inode);

-- 2.53.0