On Wed, Nov 26, 2025 at 02:19:12PM +0100, Philipp Stanner wrote:
The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.
Ignore dma_fence_signal()'s return code.
Suggested-by: Christian König christian.koenig@amd.com Signed-off-by: Philipp Stanner phasta@kernel.org
drivers/gpu/drm/xe/xe_hw_fence.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_fence.c b/drivers/gpu/drm/xe/xe_hw_fence.c index b2a0c46dfcd4..959b30dde724 100644 --- a/drivers/gpu/drm/xe/xe_hw_fence.c +++ b/drivers/gpu/drm/xe/xe_hw_fence.c @@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) { struct xe_hw_fence *fence, *next; unsigned long flags;
- int err; bool tmp;
if (XE_WARN_ON(!list_empty(&irq->pending))) { @@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) spin_lock_irqsave(&irq->lock, flags); list_for_each_entry_safe(fence, next, &irq->pending, irq_link) { list_del_init(&fence->irq_link);
err = dma_fence_signal_locked(&fence->dma);
XE_WARN_ON(dma_fence_test_signaled_flag(&fence->dma));dma_fence_signal_locked(&fence->dma);
If you also want fix Xe to use dma_fence_test_signaled_flag in all places where we manually check DMA_FENCE_FLAG_SIGNALED_BIT, I'm not going to complain. Ofc I can also do this in follow if patch when patch #1 merges too.
Anyways this patch LGTM: Reviewed-by: Matthew Brost matthew.brost@intel.com
dma_fence_put(&fence->dma);
XE_WARN_ON(err);-- 2.49.0