linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

[PATCH PMQA] android: move pmqa to system/bin path

by Sanjay Singh Rawat

- execute permission for utils is removed when they are copied to data/benchmark, moving pmqa to system/bin resolves this issue. - bug 156 Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.org> --- Android.mk | 2 +- cpufreq/Android.mk | 2 +- cpuhotplug/Android.mk | 4 ++-- cpuidle/Android.mk | 4 ++-- cputopology/Android.mk | 2 +- include/Android.mk | 2 +- suspend/Android.mk | 2 +- thermal/Android.mk | 2 +- utils/Android.mk | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Android.mk b/Android.mk index a3b785d..ba81e8f 100644 --- a/Android.mk +++ b/Android.mk @@ -7,5 +7,5 @@ LOCAL_MODULE_TAGS := eng LOCAL_MODULE_CLASS := tests LOCAL_MODULE := Switches.sh LOCAL_SRC_FILES := ../../external/pm-qa/Switches.sh -LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa +LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa include $(BUILD_PREBUILT) diff --git a/cpufreq/Android.mk b/cpufreq/Android.mk index bd07fae..15d6d9e 100644 --- a/cpufreq/Android.mk +++ b/cpufreq/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/cpuhotplug/Android.mk b/cpuhotplug/Android.mk index 7095044..fabb70a 100644 --- a/cpuhotplug/Android.mk +++ b/cpuhotplug/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef @@ -24,7 +24,7 @@ define $(module_name)_etc_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk index 07972de..1d1292c 100644 --- a/cpuidle/Android.mk +++ b/cpuidle/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef @@ -23,5 +23,5 @@ systemtarball: cpuidle_killer LOCAL_SRC_FILES:= cpuidle_killer.c LOCAL_STATIC_LIBRARIES := libcutils libc LOCAL_MODULE_TAGS := tests -LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) +LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) diff --git a/cputopology/Android.mk b/cputopology/Android.mk index d8cc159..d5b5480 100644 --- a/cputopology/Android.mk +++ b/cputopology/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/include/Android.mk b/include/Android.mk index 9560fc1..efb20f2 100644 --- a/include/Android.mk +++ b/include/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_etc_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/suspend/Android.mk b/suspend/Android.mk index fc85f6d..f44f9ff 100644 --- a/suspend/Android.mk +++ b/suspend/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/thermal/Android.mk b/thermal/Android.mk index de4edbf..4614630 100644 --- a/thermal/Android.mk +++ b/thermal/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_add_executable LOCAL_MODULE := $1.sh systemtarball: $1.sh LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_PREBUILT) endef diff --git a/utils/Android.mk b/utils/Android.mk index 8c9c644..7c1cd99 100644 --- a/utils/Android.mk +++ b/utils/Android.mk @@ -10,7 +10,7 @@ define $(module_name)_etc_add_executable LOCAL_MODULE := $1 systemtarball: $1 LOCAL_SRC_FILES := $1.c - LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) + LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name) include $(BUILD_EXECUTABLE) endef -- 1.8.3.2

10 years, 9 months

[PATCH PMQA] suspend: use generic function to check root user

by Sanjay Singh Rawat

- command (id) to check root user returns different output format for ubuntu and android. Using generic function to avoid build errors. - bug 166 Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.org> --- include/suspend_functions.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/suspend_functions.sh b/include/suspend_functions.sh index 1e8a793..3be29f5 100644 --- a/include/suspend_functions.sh +++ b/include/suspend_functions.sh @@ -33,6 +33,7 @@ # - hongbo.zhang(a)linaro.org, March, 2012 # +source ./functions.sh LOGDIR='/var/lib/pm-utils' LOGFILE="$LOGDIR/stress.log" @@ -44,9 +45,10 @@ pm_trace=1 timer_sleep=20 # root is needed to fiddle with the clock and use the rtc wakeups. -if [ $(id -u) -ne 0 ]; then - log_skip "run as non-root" - exit 0 +is_root +if [ $? -ne 0 ]; then + log_skip "user is not root" + exit 0 fi # Ensure the log directory exists. -- 1.8.3.2

10 years, 9 months

[PATCH PM-QA v2] Refactor pass/fail/skip code in PM-QA

by Lisa Nguyen

Focus on returning the results of each test script rather than the results of each subtest. This will help to keep the number of PM-QA test results consistent across multiple boards regardless of number of frequencies, cores, etc. Examples before the refactoring: https://validation.linaro.org/dashboard/streams /anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/ Examples after the refactoring: https://validation.linaro.org/dashboard/streams/anonymous /lisatn/bundles/3451b80ed9ba8a813b109dac1c41b09f0445f819/ Once this patch is accepted and merged, then there will be a follow up patch to update the pwrmgmt test definition, so LAVA can record PM-QA results accurately. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Changes from v1 to v2: - Rewrite test_status_show() function - Add description and log_skip() function in thermal_05 - Moved skip/fail/pass counts to log_end() function cpufreq/cpufreq_07.sh | 2 +- include/functions.sh | 35 ++++++++++++++++++++++++++++++----- thermal/thermal_05.sh | 1 + thermal/thermal_06.sh | 2 +- 4 files changed, 33 insertions(+), 7 deletions(-) diff --git a/cpufreq/cpufreq_07.sh b/cpufreq/cpufreq_07.sh index f8f9e8e..b65d212 100755 --- a/cpufreq/cpufreq_07.sh +++ b/cpufreq/cpufreq_07.sh @@ -74,7 +74,7 @@ check_ondemand() { supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "ondemand") if [ -z "$supported" ]; then log_skip "ondemand not supported" - exit 0 + return 0 fi save_governors diff --git a/include/functions.sh b/include/functions.sh index 417c725..d06fb4e 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -32,14 +32,31 @@ INC=0 CPU= pass_count=0 fail_count=0 +skip_count=0 +test_script_status="pass" test_status_show() { - echo "-------- total = $(($pass_count + $fail_count))" - echo "-------- pass = $pass_count" - # report failure only if it is there - if [ $fail_count -ne 0 ] ; then - echo "-------- fail = $fail_count" + if [ "$fail_count" -ne "0" ]; then + test_script_status="fail" + else + if [ "$skip_count" -ne "0" ]; then + if [ "$pass_count" -ne "0"]; then + test_script_status="pass" + else + test_script_status="skip" + fi + fi + fi + + echo " " + if [[ "$test_script_status" == "fail" ]]; then + echo "$TEST_NAME: fail" + elif [[ "$test_script_status" == "skip" ]]; then + echo "$TEST_NAME: skip" + else + echo "$TEST_NAME: pass" fi + echo " " } log_begin() { @@ -49,6 +66,14 @@ log_begin() { log_end() { printf "$*\n" + + if [[ "$*" == "Err" ]]; then + fail_count=$(($fail_count + 1)) + elif [[ "$*" == "skip" ]]; then + skip_count=$(($fail_count + 1)) + else + pass_count=$(($pass_count + 1)) + fi } log_skip() { diff --git a/thermal/thermal_05.sh b/thermal/thermal_05.sh index 05f83d1..c621b49 100755 --- a/thermal/thermal_05.sh +++ b/thermal/thermal_05.sh @@ -36,6 +36,7 @@ verify_cpufreq_cooling_device_action() { local cpufreq_cdev=$(cat $dirpath/type) cat $dirpath/type | grep cpufreq if [ $? -ne 0 ] ; then + log_skip "Cannot find cpufreq in $cdev_name..." return 0 fi diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 92c987a..d8877f0 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -30,7 +30,7 @@ source ../include/thermal_functions.sh if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" - exit 0 + return 0 fi TEST_LOOP=100 -- 1.7.9.5

10 years, 9 months

[RFC PATCH PM-QA] Refactor pass/fail/skip code in PM-QA

by Lisa Nguyen

Focus on returning the results of each test script rather than the results of each subtest. This will help to keep the number of pm-qa test results consistent across multiple boards regardless of number of frequencies, cores, etc. Examples before the refactoring: https://validation.linaro.org/dashboard/streams /anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/ Examples after the refactoring: https://validation.linaro.org/dashboard/streams/anonymous /lisatn/bundles/3451b80ed9ba8a813b109dac1c41b09f0445f819/ Questions and comments are highly encouraged as it's possible that the logic can be improved, or my explanation can be clearer. Also, once the final version of this patch is accepted and merged, then there will be a follow up patch to update the pwrmgmt test definition, so LAVA can record PM-QA results accurately. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- cpufreq/cpufreq_09.sh | 2 +- include/functions.sh | 22 +++++++++++++++++++--- include/thermal_functions.sh | 6 +++++- thermal/thermal_06.sh | 2 +- 4 files changed, 26 insertions(+), 6 deletions(-) diff --git a/cpufreq/cpufreq_09.sh b/cpufreq/cpufreq_09.sh index 7b65eec..62c953d 100755 --- a/cpufreq/cpufreq_09.sh +++ b/cpufreq/cpufreq_09.sh @@ -65,7 +65,7 @@ save_governors supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "powersave") if [ -z "$supported" ]; then log_skip "powersave not supported" - exit 0 + return 0 fi trap "restore_governors; sigtrap" SIGHUP SIGINT SIGTERM diff --git a/include/functions.sh b/include/functions.sh index 417c725..a4625ad 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -32,14 +32,29 @@ INC=0 CPU= pass_count=0 fail_count=0 +skip_count=0 +test_script_status="true" test_status_show() { - echo "-------- total = $(($pass_count + $fail_count))" - echo "-------- pass = $pass_count" # report failure only if it is there if [ $fail_count -ne 0 ] ; then - echo "-------- fail = $fail_count" + test_script_status="false" + elif [[ $skip_count -ne 0 && $fail_count -eq 0 ]] ; then + test_script_status="skip" + elif [[ $pass_count -ne 0 && $skip_count -ne 0 ]] ; then + test_script_status="pass" fi + + #print test script result + echo " " + if [[ $test_script_status == "true" ]]; then + echo $TEST_NAME: "pass" + elif [[ $test_script_status == "skip" ]]; then + echo $TEST_NAME: "skip" + else + echo $TEST_NAME: "fail" + fi + echo " " } log_begin() { @@ -54,6 +69,7 @@ log_end() { log_skip() { log_begin "$@" log_end "skip" + skip_count=$(($skip_count + 1)) } for_each_cpu() { diff --git a/include/thermal_functions.sh b/include/thermal_functions.sh index a51240b..a719487 100644 --- a/include/thermal_functions.sh +++ b/include/thermal_functions.sh @@ -44,11 +44,12 @@ check_valid_temp() { if [ $temp_val -gt 0 ]; then log_end "Ok" + pass_count=$(($pass_count + 1)) return 0 fi log_end "Err" - + fail_count=$(($fail_count + 1)) return 1 } @@ -126,10 +127,12 @@ check_valid_binding() { log_begin "checking $descr" if [ $trip_point_val -ge $trip_point_max ]; then log_end "Err" + fail_count=$(($fail_count + 1)) return 1 fi log_end "Ok" + pass_count=$(($pass_count + 1)) return 0 } @@ -165,6 +168,7 @@ for_each_cooling_device() { devices=$(ls $THERMAL_PATH | grep "cooling_device['$MAX_CDEV']") if [ "$devices" == "" ]; then log_skip "no cooling devices" + skip_count=$(($skip_count + 1)) return 0 fi diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 92c987a..d8877f0 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -30,7 +30,7 @@ source ../include/thermal_functions.sh if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" - exit 0 + return 0 fi TEST_LOOP=100 -- 1.7.9.5

10 years, 9 months

[PATCH POWERTOP] Remove temporary file created during calibration

by Mohammad Merajul Islam Molla

powertop creates temporary file in /tmp folder during calibration. Simply closing does not remove these files. Instead use unlink to remove the file. diff --git a/src/calibrate/calibrate.cpp b/src/calibrate/calibrate.cpp index db368e0..1336c3f 100644 --- a/src/calibrate/calibrate.cpp +++ b/src/calibrate/calibrate.cpp @@ -242,7 +242,7 @@ static void *burn_disk(void *dummy) write(fd, buffer, 64*1024); fdatasync(fd); } - close(fd); + unlink(filename); return NULL; } -- Thanks, -Meraj

10 years, 9 months

[ACTIVITY] Week 30

by Koen Kooi

== Progress == * OE baseline work (CARD-787: 80%) * Release (10%) * Update release scripts * Downloads page discussion == Plans == * Release == Issues ==

10 years, 9 months

[Activity] Week 30

by Dileep Katta

== Progress == * Enabling UEFI Fastboot on Panda - on hold (CARD-198: 0 %) * CARD 1103: Flash support on u-boot fastboot (CARD-1103: 100%) - Added oem format functionality, DFU Initialization - Fixed partition related issues - restructured the code as per Rob’s comments, sent the code for review - Testing the changes for flashing command, fixing the issues in the process == Plans == * CARD-198: Start working on the activity on Panda/BBB, depending on availability of board (20%) * CARD 1103: Send the patches for review to u-boot mailing list and upstream. (CARD-1103: 80%) - testing the changes and working on stabilization of flashing functionality - Need to break the code into meaningful patches to upstream == Issues == * None

10 years, 9 months

[ACTIVITY] week 30

by Bernhard Rosenkränzer

== Progress == * traveled to Cambridge, ran aarch64 tests * started on toolchain 2014.07 builds * helped with android-on-armv8 2014.07 release * investigated some aarch64 specific problems in android == Plans == * finish toolchain 2014.07 builds * Update NDK to 10 == Issues == * need aarch64 hardware * visiting my sister next week, connectivity will probably be limited

10 years, 9 months

[Activity] week 30

by Riku Voipio

== Progress == * Completing Xen CI loop for ARMv8 (CARD-736: 20%) * Fixed linaro kernel module version mismatch (BUG-1300023 20%) * Looked into "unhandled level X translation fault" errors reported on OE rootfs (30%) * Experimented on gcov testing (BUG-1307704 20%) == Plans == * vacation week == Issues ==

10 years, 9 months

[ACTIVITY] Week 30

by Harigopal Gollamudi

== Progress == DEVPLAT-2 61: Migration of Android Builds from 4.4.3 to 4.4.4 == Plans == 1. Vayu Board is booting up. Looking into the issue present in Android 4.4.3 bootup 2. Migration of Vayu from 4.4.3 to 4.4.4, as It has original android booting problem on Vayu. 3. Test the ARMv8 premerge CI 3.14 locally == Issues == Non e

10 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev