linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

[PATCH] Check the terminal window size is greater or equal to 80 columns

by Daniel Lezcano

All the output assumes the terminal width is 80 cols min, check the terminal size in order to detect a smaller terminal and prevent to have a nested output. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- idlestat.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/idlestat.c b/idlestat.c index a0ef2dd..245be9e 100644 --- a/idlestat.c +++ b/idlestat.c @@ -34,6 +34,7 @@ #include <sched.h> #include <string.h> #include <float.h> +#include <sys/ioctl.h> #include <sys/time.h> #include <sys/types.h> #include <sys/resource.h> @@ -1380,6 +1381,23 @@ static int execute(int argc, char *argv[], char *const envp[], return -1; } +static int check_window_size(void) +{ + struct winsize winsize; + + /* Output is redirected */ + if (!isatty(STDOUT_FILENO)) + return 0; + + /* Get terminal window size */ + ioctl(STDOUT_FILENO, TIOCGWINSZ, &winsize); + + if (winsize.ws_col >= 80) + return 0; + + return -1; +} + int main(int argc, char *argv[], char *const envp[]) { struct cpuidle_datas *datas; @@ -1397,6 +1415,12 @@ int main(int argc, char *argv[], char *const envp[]) return -1; } + if (check_window_size()) { + fprintf(stderr, "The terminal must be at least " + "80 columns wide\n"); + return -1; + } + /* init cpu topoinfo */ init_cpu_topo_info(); -- 1.7.9.5

10 years, 9 months

[PATCH PM-QA v4] Refactor pass/fail/skip code in PM-QA

by Lisa Nguyen

Focus on returning the results of each test script rather than the results of each subtest. This will help to keep the number of PM-QA test results consistent across multiple boards regardless of number of frequencies, cores, etc. Examples before the refactoring: https://validation.linaro.org/dashboard/streams /anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/ Examples after the refactoring: https://validation.linaro.org/dashboard/streams/anonymous /lisatn/bundles/076a3f890e58727f01a23e30d6eb438172b69c7d/ Once this patch is accepted and merged, then there will be a follow up patch to update the pwrmgmt test definition, so LAVA can record PM-QA results accurately. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Changes from v3 to v4: - Fix syntax errors that were undetected (e.g. space between a condition and end square bracket in an if statement) that affected the pass/fail/skip count Change from v2 to v3: - Fix a silly increment error for skip count cause I didn't look closely enough Changes from v1 to v2: - Rewrite test_status_show() function - Add description and log_skip() function in thermal_05 - Moved skip/fail/pass counts to log_end() function cpufreq/cpufreq_07.sh | 2 +- include/functions.sh | 35 ++++++++++++++++++++++++++++++----- thermal/thermal_05.sh | 3 ++- thermal/thermal_06.sh | 2 +- 4 files changed, 34 insertions(+), 8 deletions(-) diff --git a/cpufreq/cpufreq_07.sh b/cpufreq/cpufreq_07.sh index f8f9e8e..b65d212 100755 --- a/cpufreq/cpufreq_07.sh +++ b/cpufreq/cpufreq_07.sh @@ -74,7 +74,7 @@ check_ondemand() { supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "ondemand") if [ -z "$supported" ]; then log_skip "ondemand not supported" - exit 0 + return 0 fi save_governors diff --git a/include/functions.sh b/include/functions.sh index 417c725..3f5acf4 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -32,14 +32,31 @@ INC=0 CPU= pass_count=0 fail_count=0 +skip_count=0 +test_script_status="pass" test_status_show() { - echo "-------- total = $(($pass_count + $fail_count))" - echo "-------- pass = $pass_count" - # report failure only if it is there - if [ $fail_count -ne 0 ] ; then - echo "-------- fail = $fail_count" + if [ $fail_count -ne 0 ]; then + test_script_status="fail" + else + if [ $skip_count -ne 0 ]; then + if [ $pass_count -ne 0 ]; then + test_script_status="pass" + else + test_script_status="skip" + fi + fi + fi + + echo " " + if [[ "$test_script_status" == "fail" ]]; then + echo "$TEST_NAME: fail" + elif [[ "$test_script_status" == "skip" ]]; then + echo "$TEST_NAME: skip" + else + echo "$TEST_NAME: pass" fi + echo " " } log_begin() { @@ -49,6 +66,14 @@ log_begin() { log_end() { printf "$*\n" + + if [[ "$*" == "Err" ]]; then + fail_count=$((fail_count + 1)) + elif [[ "$*" == "skip" ]]; then + skip_count=$((skip_count + 1)) + else + pass_count=$((pass_count + 1)) + fi } log_skip() { diff --git a/thermal/thermal_05.sh b/thermal/thermal_05.sh index 05f83d1..52a0ac2 100755 --- a/thermal/thermal_05.sh +++ b/thermal/thermal_05.sh @@ -36,7 +36,8 @@ verify_cpufreq_cooling_device_action() { local cpufreq_cdev=$(cat $dirpath/type) cat $dirpath/type | grep cpufreq if [ $? -ne 0 ] ; then - return 0 + log_skip "Cannot find cpufreq in $cdev_name..." + return 0 fi local max_state=$(cat $dirpath/max_state) diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 92c987a..d8877f0 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -30,7 +30,7 @@ source ../include/thermal_functions.sh if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" - exit 0 + return 0 fi TEST_LOOP=100 -- 1.7.9.5

10 years, 9 months

[PATCH PMQA] cpufreq: consider sampling rate to calculate scaling time

by Sanjay Singh Rawat

- add the governor sampling rate with the frequency transition latency to make sure tansition happens. - bug 77 Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.org> --- include/functions.sh | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/functions.sh b/include/functions.sh index 417c725..5823a81 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -123,6 +123,17 @@ wait_latency() { local dirpath=$CPU_PATH/$cpu/cpufreq local latency= local nrfreq= + local sampling_rate= + local sleep_time= + local gov=$(cat $dirpath/scaling_governor) + + # consider per-policy governor case + if [ -e $CPU_PATH/$cpu/cpufreq/$gov ]; then + sampling_rate=$(cat $CPU_PATH/$cpu/cpufreq/$gov/sampling_rate) + else + sampling_rate=$(cat $CPU_PATH/cpufreq/$gov/sampling_rate) + fi + sampling_rate=$((sampling_rate * 1000)) # unit nsec latency=$(cat $dirpath/cpuinfo_transition_latency) if [ $? -ne 0 ]; then @@ -135,7 +146,10 @@ wait_latency() { fi nrfreq=$((nrfreq + 1)) - ../utils/nanosleep $(($nrfreq * $latency)) + + sleep_time=$(($latency + $sampling_rate)) + + ../utils/nanosleep $(($nrfreq * $sleep_time)) } frequnit() { -- 1.8.3.2

10 years, 9 months

[Activity] Week 31

by Dileep Katta

== Progress == * Enabling UEFI Fastboot on Panda - on hold (CARD-198: 0 %) * CARD 1103: Flash support on u-boot fastboot (CARD-1103: 100%) - Fixed build errors on omap3 beagle config - consolidated the patches into two, and submitted patches for review http://lists.denx.de/pipermail/u-boot/2014-August/185194.html http://lists.denx.de/pipermail/u-boot/2014-August/185195.html == Plans == * CARD-198: Start working on the activity on Panda/BBB (40%) * CARD 1103: Send the patches for review to u-boot mailing list and upstream. (CARD-1103: 60%) - Fix the review comments and code standard related issues == Issues == * None

10 years, 9 months

[ACTIVITY] week 31

by Vishal Bhoj

== Progress == * 14.07 Release (card-789, 30%) * LSK-CI for 3.14 (CARD-789, 10%) * Integrating VPS in android-build ci (CARD-789, 20%) == Plans == * Finish VPS integration. == Issues == * None Regards, Vishal

10 years, 9 months

[ACTIVITY] Week 31

by Koen Kooi

== Progress == * OE baseline work (CARD-787: 10%) * Release (90%) == Plans == * CARD-1566 <https://cards.linaro.org/browse/CARD-1566> * integrate 2014.08 toolchain == Issues == * People keep forgetting to put me in CC: for release issues causing premature escalation

10 years, 9 months

[PATCH V2 idlestat 01/12] Fix CPU affinity mask

by Daniel Lezcano

From: Patrick Bellasi <patrick.bellasi(a)arm.com> To properly identify the initial PState of each CPU, the idlestat_wake_all function is used to force an idle state exit on all CPUs by pinning idlestat on each CPUs. However, this routine forgets to recover the original mask at the end of the pinning process. This patch solve this issue, by properly recovering the original CPU affinity mask. Moreover, it avoids to wake up CPUs that will not be used to run the workload. Signed-off-by: Patrick Bellasi <patrick.bellasi(a)arm.com> Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- idlestat.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/idlestat.c b/idlestat.c index 0e0e1df..2a0c549 100644 --- a/idlestat.c +++ b/idlestat.c @@ -1210,6 +1210,7 @@ static int idlestat_wake_all(void) { int rcpu, i, ret; cpu_set_t cpumask; + cpu_set_t original_cpumask; ret = sysconf(_SC_NPROCESSORS_CONF); if (ret < 0) @@ -1219,18 +1220,28 @@ static int idlestat_wake_all(void) if (rcpu < 0) return -1; + /* Keep track of the CPUs we will run on */ + sched_getaffinity(0, sizeof(original_cpumask), &original_cpumask); + for (i = 0; i < ret; i++) { /* Pointless to wake up ourself */ if (i == rcpu) continue; + /* Pointless to wake CPUs we will not run on */ + if (!CPU_ISSET(i, &original_cpumask)) + continue; + CPU_ZERO(&cpumask); CPU_SET(i, &cpumask); sched_setaffinity(0, sizeof(cpumask), &cpumask); } + /* Enable all the CPUs of the original mask */ + sched_setaffinity(0, sizeof(original_cpumask), &original_cpumask); + return 0; } -- 1.7.9.5

10 years, 9 months

[ACTIVITY] week 31

by Bernhard Rosenkränzer

== Progress == * Toolchain 2014.07 builds * NDK 10 update work * Bionic Aarch64 code reviews * cbuildv2 test builds == Plans == * Finish NDK 10 update today * Get cbuildv2 builds working == Issues == * Currently visiting my sister, limited connectivity

10 years, 9 months

[PATCH PM-QA v3] Refactor pass/fail/skip code in PM-QA

by Lisa Nguyen

Focus on returning the results of each test script rather than the results of each subtest. This will help to keep the number of PM-QA test results consistent across multiple boards regardless of number of frequencies, cores, etc. Examples before the refactoring: https://validation.linaro.org/dashboard/streams /anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/ Examples after the refactoring: https://validation.linaro.org/dashboard/streams/anonymous /lisatn/bundles/3451b80ed9ba8a813b109dac1c41b09f0445f819/ Once this patch is accepted and merged, then there will be a follow up patch to update the pwrmgmt test definition, so LAVA can record PM-QA results accurately. Signed-off-by: Lisa Nguyen <lisa.nguyen(a)linaro.org> --- Change from v2 to v3: - Fix a silly increment error for skip count cause I didn't look closely enough Changes from v1 to v2: - Rewrite test_status_show() function - Add description and log_skip() function in thermal_05 - Moved skip/fail/pass counts to log_end() function cpufreq/cpufreq_07.sh | 2 +- include/functions.sh | 35 ++++++++++++++++++++++++++++++----- thermal/thermal_05.sh | 1 + thermal/thermal_06.sh | 2 +- 4 files changed, 33 insertions(+), 7 deletions(-) diff --git a/cpufreq/cpufreq_07.sh b/cpufreq/cpufreq_07.sh index f8f9e8e..b65d212 100755 --- a/cpufreq/cpufreq_07.sh +++ b/cpufreq/cpufreq_07.sh @@ -74,7 +74,7 @@ check_ondemand() { supported=$(cat $CPU_PATH/cpu0/cpufreq/scaling_available_governors | grep "ondemand") if [ -z "$supported" ]; then log_skip "ondemand not supported" - exit 0 + return 0 fi save_governors diff --git a/include/functions.sh b/include/functions.sh index 417c725..763f413 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -32,14 +32,31 @@ INC=0 CPU= pass_count=0 fail_count=0 +skip_count=0 +test_script_status="pass" test_status_show() { - echo "-------- total = $(($pass_count + $fail_count))" - echo "-------- pass = $pass_count" - # report failure only if it is there - if [ $fail_count -ne 0 ] ; then - echo "-------- fail = $fail_count" + if [ "$fail_count" -ne "0" ]; then + test_script_status="fail" + else + if [ "$skip_count" -ne "0" ]; then + if [ "$pass_count" -ne "0"]; then + test_script_status="pass" + else + test_script_status="skip" + fi + fi + fi + + echo " " + if [[ "$test_script_status" == "fail" ]]; then + echo "$TEST_NAME: fail" + elif [[ "$test_script_status" == "skip" ]]; then + echo "$TEST_NAME: skip" + else + echo "$TEST_NAME: pass" fi + echo " " } log_begin() { @@ -49,6 +66,14 @@ log_begin() { log_end() { printf "$*\n" + + if [[ "$*" == "Err" ]]; then + fail_count=$(($fail_count + 1)) + elif [[ "$*" == "skip" ]]; then + skip_count=$(($skip_count + 1)) + else + pass_count=$(($pass_count + 1)) + fi } log_skip() { diff --git a/thermal/thermal_05.sh b/thermal/thermal_05.sh index 05f83d1..c621b49 100755 --- a/thermal/thermal_05.sh +++ b/thermal/thermal_05.sh @@ -36,6 +36,7 @@ verify_cpufreq_cooling_device_action() { local cpufreq_cdev=$(cat $dirpath/type) cat $dirpath/type | grep cpufreq if [ $? -ne 0 ] ; then + log_skip "Cannot find cpufreq in $cdev_name..." return 0 fi diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 92c987a..d8877f0 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -30,7 +30,7 @@ source ../include/thermal_functions.sh if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" - exit 0 + return 0 fi TEST_LOOP=100 -- 1.7.9.5

10 years, 9 months

[PATCH idlestat 01/12] Fix CPU affinity mask

by Daniel Lezcano

10 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev