HI Wookie, On Tue, 4 Dec 2018 at 08:50, Wookey wookey@wookware.org wrote:

On 2018-11-30 11:28 +0000, Mike Leach wrote:

...

Patch release incorporating build dependency updates from pull request #14 Minor change to auto-fdo document.

No functionality changes.

Debian package updated: https://buildd.debian.org/status/package.php?p=libopencsd

Found a couple more typos in the process. Patch here: https://sources.debian.org/src/libopencsd/0.10.1-1/debian/patches/fixtypos.p... (Extention, inteface x2)

Thanks, I'll ensure this gets into the next release.

BTW the docs now say "See [autofdo.md](@ref AutoFDO) for details and scripts. (`./tests/auto-fdo/autofdo.md`)."

Which is fine if you have the source in front of you. Should this be shipped in the doc package (or libopencsd-bin 'utils' package) so it's easily available to users? I had assumed that stuff in the 'test' dir was for running tests after the build, so not very useful to ship. This seems slightly different. Advice on if any of the rest of that stuff should really be in the package and not just the source would be welcome.

tests/autofdo.md and tests/record.sh

For now I am comfortable with the script not being part of the distro - the script only works on a specialised kernel that includes an enhanced ETM driver. Users will have to be au-fait with this and rebuild their kernel, so requiring them to have access to the OpenCSD source too is not too much of a leap. In time we hope that this script will become redundant as we introduce additional measures for programming ETMs in the complex configuration required by AutoFDO.

The autofdo.md is compiled into the main docs help files so no need to distribute this explicitly.

Thanks

Mike

Wookey

Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ _______________________________________________ CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight