Jie Gan jie.gan@oss.qualcomm.com writes:

From: Carl Worth carl@os.amperecomputing.com

The handle is essential for retrieving the AUX_EVENT of each CPU and is required in perf mode. It has been added to the coresight_path so that dependent devices can access it from the path when needed.

I'd still like to have the original command I used to trigger the bug in the commit message. I really like having reproduction steps captured in commit messages when I look back at commits in the future. So, that was:

perf record -e cs_etm//k -C 0-9 dd if=/dev/zero of=/dev/null

/**

• struct coresight_path - data needed by enable/disable path

• • @path_list: path from source to sink.
• • @trace_id: trace_id of the whole path.

• • @path_list: path from source to sink.
• • @trace_id: trace_id of the whole path.
• • struct perf_output_handle: handle of the aux_event.
  */

Fixing to "@handle" was mentioned in another comment already.

Something about the above still feels a little off to me. It feels like we're throwing new data into a structure just because it happens to be conveniently at hand for the code paths we're needing, and not because it really _belongs_ there.

Or, maybe it's the right place for it, and the cause of my concern is that "path" is an overly-narrow name in struct coresight_path?

But if a renaming of this structure would improve the code, I'd also be fine with that happening in a subsequent commit, so I won't try to hold up the current series based on that.

-Carl