CoreSight

coresight@lists.linaro.org

6 participants
2343 discussions

by Mathieu Poirier

Good day to all, Suzuki and Leo have recently posted patches to unify the way funnel and replicators are supported. Those patches prompted me to have a closer look at the bindings we currently use. At this time we have: Non configurable replicator: "coresight-replicator" Configurable replicator: "coresight-dynamic-replicator" Non Configurable funnel: "coresight-static-funnel" (public but not merged yet) Configurable funnel: "coresight-funnel" This is quite confusing to me and I suggest the following: Non configurable replicator: "coresight-static-replicator" Configurable replicator: "coresight-dynamic-replicator" Non Configurable funnel: "coresight-static-funnel" Configurable funnel: "coresight-dynamic-funnel" Current bindings would be kept around for backward compatibility but marked as obsolete in the coresight DT bindings document. Leo has stepped forward to do the work and Rob Herring (DT maintainer) is on board with the idea. All we need is to settle on a naming convention, hence this email. Regards, Mathieu

6 years, 1 month

Re: Help with Jetson TX2 Coresight

by Wojciech Żmuda

Hi Srdjan, > Hello, > > I have a Jetson TX2 board which has dual-core NVIDIA Denver2 + quad-core ARM Cortex-A57. > > nVidia recently released a new SDK package (which they call JetPack, based on Ubuntu and 4.9 Kernel). out of the box it comes with coresight disabled, so I had to recompile the kernel in order to enable it. Coresight kind of works, I'm getting some data out of it, but I'm trying to use Perf in order to do the tracing. > > The issue I'm facing is that when I execute: > > perf record -e cs_etm/(a)8030000.etf/u --per-thread uname > > it works properly, and I'm getting great reports, but if I omit the --per-thread parameter I'm getting the: > failed to mmap with 12 (Cannot allocate memory) Mainline Linux does not yet contain CPU-wide tracing. If you use mainline or older, you can trace only single-thread applications in per-thread mode. Skipping --per-thread flag is equivalent to specifying --all-cpus flag and this mode is not yet supported in mainline. Mathieu and friends are working on CPU-wide tracing and their v2 patch set has just appeared on this list. You can try to cherry-pick their patches on your branch. Then, you will be able to use --cpu <n> and --all-cpus. I did that (with v1) and I can confirm it works well. > > mmap error also happens if I want to record already running process with --pid parameter. I tried that yesterday and it worked for me. Please mind I'm using Linux 5.1-rc1 (cloned about a week ago) with CPU-wide tracing patch set by Linaro. CoreSight development goes rapidly, so it's a good idea to keep up with this list and Linux mainline changelog, because interesting changes may appear any day. > > If I specify the number of the cpu: > perf record -e cs_etm/(a)8030000.etf/u --cpu 0 uname > > then recording works but when I try to do perf report it says: > 0x228 [0x40]: failed to process type: 7 > > What might be interesting to mention is that the processors on this system are arranged in weird combination. cpu 0,3,4,5 are ARM cores which have coresight on them, and cpu 1,2 are Denver cores without coresight. I'm suspecting that this might create some issues. I'm not an expert, but I don't think it would matter. If Denver cores don't have CoreSight, that probably means they don't have ETMs connected, thus they will not generate any trace data. I don't know if Linux can schedule processes on them. If not, I see no harm - your program will be traced no matter what CPU kernel puts it on. If it can, the worst case would be empty trace. You can save yourself from the latter by scheduling your process with taskset to the main cores only, omitting Denvers. But again, it's just my educated guess and I'd wait for the second opinion of the wise people residing here. Regards, Wojciech > > Do you have any ideas on how to proceed to diagnose the issue? > > Thank you.

6 years, 1 month

[PATCH 00/25] coresight: Support for ACPI bindings

by Suzuki K Poulose

This series adds the support for CoreSight devices on ACPI based platforms. The device connections are encoded as _DSD graph property[0], with CoreSight specific extensions to indicate the direction of data flow as described in [1]. Components attached to CPUs are listed as child devices of the corresponding CPU, removing explicit links to the CPU like we do in the DT. As a prepartion for the ACPI support, we merge the driver for dynamic and non-programmable replicators. We introduce platform independent helpers to parse the platform supplied information. Thus we rename the platform handling code from: of_coresight.c => coresight-platform.c The CoreSight driver creates shadow devices that appear on the Coresight bus, in addition to the real devices (e.g, AMBA bus devices). The name of these devices match the real device. This makes the device name a bit cryptic for ACPI platform. So this series also introduces a generic platform agnostic device naming scheme for the shadow Coresight devices. Towards this we also make changes to the way we lookup devices to resolve the connections, as we can't use the names to identify the devices. So, we use the "fwnode_handle" of the real device for the device lookups. Towards that we clean up the drivers to keep track of the "CoreSight" device rather than the "real" device. However, all real operations, like DMA allocation, Power management etc. must be performed on the real device which is the parent of the shadow device. Finally we add the support for parsing the ACPI platform data. The power management support is missing in the ACPI (and this is not specific to CoreSight). The firmware must ensure that the respective power domains are turned on. Applies on v5.1-rc1 Tested on a Juno-r0 board with ACPI bindings patch (Patch 26/25) added on top of [2]. You would need to make sure that the debug power domain is turned on before the Linux kernel boots. (e.g, connect the DS-5 to the Juno board while at UEFI). arm32 code is only compile tested. [0] ACPI Device Graphs using _DSD (Not available online yet, approved but awaiting publish and eventually should be linked at). https://uefi.org/sites/default/files/resources/_DSD-implementation-guide-to… [1] https://developer.arm.com/docs/den0067/latest/acpi-for-coresighttm-10-platf… [2] https://github.com/tianocore/edk2-platforms.git Suzuki K Poulose (25): coresight: tmc: Report DMA setup failures coresight: dynamic-replicator: Clean up error handling coresight: replicator: Prepare for merging with dynamic-replicator coresight: dynamic-replicator: Prepare for merging with static replicator coresight: Merge the static and dynamic replicator drivers coresight: funnel: Clean up device book keeping coresight: replicator: Cleanup device tracking coresight: tmc: Clean up device specific data coresight: catu: Cleanup device specific data coresight: tpiu: Clean up device specific data coresight: stm: Cleanup device specific data coresight: etm: Clean up device specific data coresight: etb10: Clean up device specific data coresight: Rename of_coresight to coresight-platform coresight: etm3x: Rearrange cp14 access detection coresight: stm: Rearrange probing the stimulus area coresight: tmc-etr: Rearrange probing default buffer size coresight: Introduce generic platform data helper coresight: Make device to CPU mapping generic coresight: platform: Use fwnode handle for device search coresight: Use fwnode handle instead of device names coresight: Use platform agnostic names coresight: stm: ACPI support for parsing stimulus base coresight: Support for ACPI bindings coresight: acpi: Support for components drivers/acpi/acpi_amba.c | 9 + drivers/hwtracing/coresight/Kconfig | 8 - drivers/hwtracing/coresight/Makefile | 4 +- drivers/hwtracing/coresight/coresight-catu.c | 38 +- drivers/hwtracing/coresight/coresight-catu.h | 1 - drivers/hwtracing/coresight/coresight-cpu-debug.c | 3 +- .../coresight/coresight-dynamic-replicator.c | 255 -------- drivers/hwtracing/coresight/coresight-etb10.c | 23 +- drivers/hwtracing/coresight/coresight-etm3x.c | 23 +- drivers/hwtracing/coresight/coresight-etm4x.c | 19 +- drivers/hwtracing/coresight/coresight-funnel.c | 27 +- drivers/hwtracing/coresight/coresight-platform.c | 723 +++++++++++++++++++++ drivers/hwtracing/coresight/coresight-priv.h | 2 + drivers/hwtracing/coresight/coresight-replicator.c | 255 ++++++-- drivers/hwtracing/coresight/coresight-stm.c | 119 +++- drivers/hwtracing/coresight/coresight-tmc-etr.c | 26 +- drivers/hwtracing/coresight/coresight-tmc.c | 71 +- drivers/hwtracing/coresight/coresight-tpiu.c | 29 +- drivers/hwtracing/coresight/coresight.c | 77 ++- drivers/hwtracing/coresight/of_coresight.c | 297 --------- include/linux/coresight.h | 43 +- 21 files changed, 1287 insertions(+), 765 deletions(-) delete mode 100644 drivers/hwtracing/coresight/coresight-dynamic-replicator.c create mode 100644 drivers/hwtracing/coresight/coresight-platform.c delete mode 100644 drivers/hwtracing/coresight/of_coresight.c ACPI bindings for Juno-r0 (applies on [2] above) Suzuki K Poulose (1): edk2-platform: juno: Update ACPI CoreSight Bindings Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 241 +++++++++++++++++++++++++++++++ 1 file changed, 241 insertions(+) Cc: "Rafael J. Wysocki" <rjw(a)rjwysocki.net> -- 2.7.4

6 years, 1 month

[PATCH v3 0/2] CoreSight: Support static funnel

by Leo Yan

Since before there have no platforms use static funnel in mainline kernel (though maybe some in-house SoC has used it but didn't upstream for mainline kernel yet so we don't be aware for it), when enable CoreSight DT binding for hikey960, we found the SoC uses the static funnel in the link path and but it's not supported in CoreSight funnel driver. So the first patch is to update DT documentation to support static funnel (we call it as non-configurable funnel in documentation); the second patch is to support the static funnel in the CoreSight funnel driver. Credits to Suzuki shared code for CoreSight replicator refactoring, the static funnel related implementation heavily follows up the same fashion in Suzuki's replicator code. This patch set has been rebased on CoreSight next branch [1] with latest commit d5d246a56af0 ("coresight: Merge the static and dynamic replicator drivers") and tested on Hikey960 with perf commands: # perf record -e cs_etm/(a)20010000.etf/ --per-thread ./main # perf report --tui P.s. in this version, Hikey960 CoreSight DT binding has not been included and will be sent out separately. [1] https://git.linaro.org/kernel/coresight.git/log/?h=next Leo Yan (2): dt-bindings: arm: coresight: Support static funnel coresight: funnel: Support static funnel .../devicetree/bindings/arm/coresight.txt | 45 ++++++- .../hwtracing/coresight/coresight-funnel.c | 112 +++++++++++++----- 2 files changed, 127 insertions(+), 30 deletions(-) -- 2.17.1

6 years, 1 month

Empty trace in TMC-ETR on Xilinx Zynq US+ MPSoC

by Wojciech Żmuda

Hello CoreSight team, I'm trying to bring up TMC-ETR on Xilinx Zynq Ultrascale+ and I ran into some troubles. I hope you may have some ideas on where to look next. Detailed CoreSight topology of Zynq US+ MPSoC may be found in ug1085-zynq-ultrascale-trm.pdf (easy to google), but to make this discussion easier, I'll try to sketch it below: [2x C-R5] [4x C-A53] | | [2x ETMs] [4x ETM] | | [Funnel0] [Funnel1] [STM] | | | | [TMC-ETF 4kB] | | | | [--------------------ATB----------------] | [Funnel2] | [TMC-ETF 8 KB] | [Replicator] | | [TMC-ETR] [TPIU] I can happily use perf to trace Cortex-A53 cores and get trace data from the upmost ETF (the 4kB one). However, I feel like I often get buffer overflows (thanks Mathieu for this hypothesis) overwriting my trace with new data during the session. To overcome this I'd like to use either the second ETF or, preferably, ETR with significantly larger buffer. The problem is, I'm not able to get any trace from ETR. Observations: 1. It is possible to choose ETR as sink in perf - there is no error and the session starts. 2. There are no CoreSight related errors in dmesg. 3. By examining TMC-ETR memory mapped registers (busybox devmem 0x...) I can see that indeed perf sees the device and configures it properly. I've added some prints around struct etr_buf manipulations in TMC drivers and I can actually see that buffer address and size saved into this structure are programmed into TMC, as the same values appear in its registers. I can also see that the enable bit is set high when tracing starts and low when perf returns. 4. There is never any useful data in AUXTRACE sections of perf.data. When tracing with --per-thread I observe that the size of the section grows significantly the longer I trace: ' ... CoreSight ETM Trace data: size xxx bytes' with xxx exceeding kBytes. However, all I get is: 0xd60 [0x8]: event: 68 . . ... raw event: size 8 bytes . 0000: 44 00 00 00 00 00 08 00 D....... 0xd60 [0x8]: PERF_RECORD_FINISHED_ROUND With --all-cpus, I always get ' ... CoreSight ETM Trace data: size 16 bytes' no matter how long the tracing session is. Interestingly, the data part does not change - it's always the same 8 bytes each time I try using ETR as sink, regardless --per-thread or --all-cpus mode. 5. Each time I print etr_buf contents in tmc_etr_sync_flat_buf() or tmc_etr_sync_sg_buf(), I can see that the buffer, no matter how big, gets only 16 bytes of data on each sync. I wonder if this issue may point to SMMU issues. I can see in juno-base.dtsi in Linux mainline that the ETR node (and only this one from the CS family) has iommus=< > property pointing to smmu_etr: etr@20070000 { compatible = "arm,coresight-tmc", "arm,primecell"; reg = <0 0x20070000 0 0x1000>; iommus = <&smmu_etr 0>; ... I tried to mimic this behaviour on my platform by adding similar reference to the only SMMU node defined in xilinx/zynqmp.dtsi. In my case it's iommus = <&smmu 0xc5>; since there is no dedicated SMMU for ETR (and I don't see it in TRM) and 0xc5 is stream ID calculated from the CoreSight master ID (TRM Chapter 16, Table 16-11). I can see in dmesg that SMMU is enabled and ETR is added to iommu group 0, but this does not change the behaviour. I'd appreciate any suggestions if this direction seem worth further debugging. Another interesting observation is that I'm actually unable to access anything below the 4k ETF in the topology I sketched. I can't use ETF2 nor STM via sysfs. I wonder if there is some ATB configuration that may be worth checking as well? I would appreciate any suggestions where to look next. Thanks and best regards, Wojciech

6 years, 1 month

Help with Jetson TX2 Coresight

by Srdjan Stokic

Hello, I have a Jetson TX2 board which has dual-core NVIDIA Denver2 + quad-core ARM Cortex-A57. nVidia recently released a new SDK package (which they call JetPack, based on Ubuntu and 4.9 Kernel). out of the box it comes with coresight disabled, so I had to recompile the kernel in order to enable it. Coresight kind of works, I'm getting some data out of it, but I'm trying to use Perf in order to do the tracing. The issue I'm facing is that when I execute: perf record -e cs_etm/(a)8030000.etf/u --per-thread uname it works properly, and I'm getting great reports, but if I omit the --per-thread parameter I'm getting the: failed to mmap with 12 (Cannot allocate memory) mmap error also happens if I want to record already running process with --pid parameter. If I specify the number of the cpu: perf record -e cs_etm/(a)8030000.etf/u --cpu 0 uname then recording works but when I try to do perf report it says: 0x228 [0x40]: failed to process type: 7 What might be interesting to mention is that the processors on this system are arranged in weird combination. cpu 0,3,4,5 are ARM cores which have coresight on them, and cpu 1,2 are Denver cores without coresight. I'm suspecting that this might create some issues. Do you have any ideas on how to proceed to diagnose the issue? Thank you.

6 years, 1 month

[RFC 00/20] coresight: Add support for CPU-wide trace scenarios

by Mathieu Poirier

This patchset adds support for CPU-wide trace scenarios and as such, it is now possible to issue the following commands: # perf record -e cs_etm/(a)20070000.etr/ -C 2,3 $COMMAND # perf record -e cs_etm/(a)20070000.etr/ -a $COMMAND The above will trace all instructions executed by a given processor for as long as $COMMAND hasn't returned. The solution is designed to work for both 1:1 and N:1 source/sink topologies, though the former hasn't been tested for lack of access to HW. Most of the changes revolve around allowing more than one event to use a sink when operated from perf. More specifically the first event to use a sink switches it on while the last one is tasked to aggregate traces and switching off the device. This is the kernel part of the solution, with the user space portion to be released in a separate set. All the patches have been rebased on yesterday's linux next and hosted here[1]. Everything has been tested on Juno. I have not CC'ed the kernel mailing list because of the ongoing merge window. Review and comments would be most appreciated. Regards, Mathieu [1]. https://git.linaro.org/people/mathieu.poirier/coresight.git/log/?h=next-201… Mathieu Poirier (20): coresight: pmu: Adding ITRACE property to cs_etm PMU coresight: etm4x: Add kernel configuration for CONTEXTID coresight: etm4x: Configure tracers to emit timestamps coresight: Adding return code to sink::disable() operation coresight: Move reference counting inside sink drivers coresight: Refactor sink::disable() functions coresight: Refactor sink::update() functions coresight: perf: Refactor function etm_setup_aux() coresight: perf: Refactor function free_event_data() coresight: Introduce the notion of process ID to the framework coresight: tmc-etr: Refactor function tmc_etr_setup_perf_buf() coresight: tmc-etr: Introduce the notion of process ID to ETR devices coresight: tmc-etr: Allow events to use the same ETR buffer coresight: tmc-etr: Add support for CPU-wide trace scenarios coresight: tmc-etf: Add support for CPU-wide trace scenarios coresight: etb10: Add support for CPU-wide trace scenarios coresight: Refactor sink::alloc_buffer() functions coresight: Add function coresight_sink_is_shared() coresight: tmc-etr: Make ETR aware of topology coresight: Use event->cpu to determine session type drivers/hwtracing/coresight/coresight-etb10.c | 79 +++++- .../hwtracing/coresight/coresight-etm-perf.c | 47 +++- drivers/hwtracing/coresight/coresight-etm4x.c | 114 +++++++- drivers/hwtracing/coresight/coresight-priv.h | 1 + .../hwtracing/coresight/coresight-tmc-etf.c | 84 ++++-- .../hwtracing/coresight/coresight-tmc-etr.c | 265 +++++++++++++++--- drivers/hwtracing/coresight/coresight-tmc.c | 4 + drivers/hwtracing/coresight/coresight-tmc.h | 11 + drivers/hwtracing/coresight/coresight-tpiu.c | 9 +- drivers/hwtracing/coresight/coresight.c | 53 +++- include/linux/coresight-pmu.h | 2 + include/linux/coresight.h | 8 +- tools/include/linux/coresight-pmu.h | 2 + 13 files changed, 568 insertions(+), 111 deletions(-) -- 2.17.1

6 years, 1 month

Marketing Executives

by Leslie Atkins

Hi, Can I send you a sample of one of our B2B email list based on your requirement? Data Fields includes: Contact name, Company name, Job Title, Website, Industry, SIC Code, Email address, Direct mail address, Telephone number, Revenue Size, Employee Size, etc. Kindly just share your requirements by filling in the below table: Industries : _____________? (Any Industry) Job Titles : _____________? (Any Titles) Geography: _____________? (Any Location) I'll come up with the data counts, costs & few sample contacts for your review. Awaiting your response, Best Regards Leslie Atkins Data Analyst

6 years, 1 month

[PATCH 1/3] docs: Document new compilation flag for kernel v5.1 and beyond

by Mathieu Poirier

Starting with the v5.1 kernel cycle compiling the perf tools (on and off target) requires the addition of a new CORESIGHT=1 command line flag. See the following commit for details: 1c3b28fd7ae8 ("perf coresight: Do not test for libopencsd by default") Signed-off-by: Mathieu Poirier <mathieu.poirier(a)linaro.org> --- HOWTO.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/HOWTO.md b/HOWTO.md index 551b085c9c78..3b93b3d392aa 100644 --- a/HOWTO.md +++ b/HOWTO.md @@ -21,10 +21,10 @@ supplemented with modifications to the CoreSight framework and drivers to be usable by the Perf core. The remaining out of tree patches are being upstreamed incrementally. -From there compiling the perf tools with `make -C tools/perf` will yield a -`perf` executable that will support CoreSight trace collection. Note that if -traces are to be decompressed *off* target, there is no need to download and -compile the openCSD library (on the target). +From there compiling the perf tools with `make -C tools/perf CORESIGHT=1` will +yield a `perf` executable that will support CoreSight trace collection. Note +that if traces are to be decompressed *off* target, there is no need to download +and compile the openCSD library (on the target). Before launching a trace run a sink that will collect trace data needs to be identified. All CoreSight blocks identified by the framework are registed in @@ -306,7 +306,7 @@ and needs to be installed on a system prior to compilation. Information about the status of the openCSD library on a system is given at compile time by the perf tools build script: - linaro@t430:~/linaro/linux-kernel$ make VF=1 -C tools/perf + linaro@t430:~/linaro/linux-kernel$ make CORESIGHT=1 VF=1 -C tools/perf Auto-detecting system features: ... dwarf: [ on ] ... dwarf_getlocations: [ on ] -- 2.17.1

6 years, 1 month

Re: [Linaro/OpenCSD] ‘OCSD_INSTR_WFI_WFE’ not handled in switch (#17)

by Mike Leach

Hi, The OCSD_INSTR_WFI_WFE instruction sub-type is added to the library headers from version 0.11.0 of openCSD to support later ETMv4 versions. This does require an update to the perf code in cs-etm-decoder.c to add this value into the handling code in the default part of the case statement - e.g.:- case OCSD_INSTR_ISB: case OCSD_INSTR_DSB_DMB: + case OCSD_INSTR_WFI_WFE: case OCSD_INSTR_OTHER: default: The perf-opencsd master branch has not had an update to cover this yet. The present perf decode does not use this value. If you do not specifically need ETMv4.3 support for authenticated pointer trace then it is safe to use the latest v0.10.x decoder with the perf-opencsd. Otherwise you will need to patch locally till a patch is made available in the repository, or the upstream perf supports the later OpenCSD. Regards Mike On Tue, 19 Mar 2019 at 07:46, Solomon <notifications(a)github.com> wrote: > > After installing the OpenCSD library, I tried to compile perf from perf-opencsd. I used the command make VF=1 -C tools/perf. However, I got the following error: > > CC util/intel-pt-decoder/intel-pt-log.o > > CC util/cs-etm-decoder/cs-etm-decoder.o > > util/cs-etm-decoder/cs-etm-decoder.c: In function ‘cs_etm_decoder__buffer_range’: > > util/cs-etm-decoder/cs-etm-decoder.c:370:2: error: enumeration value ‘OCSD_INSTR_WFI_WFE’ not handled in switch [-Werror=switch-enum] > > switch (elem->last_i_type) { > > ^~~~~~ > > CC util/intel-pt-decoder/intel-pt-decoder.o > > cc1: all warnings being treated as errors > > Has anyone had the same issue before? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK

6 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight