Y2038

y2038@lists.linaro.org

1132 discussions

[PATCH v2] Staging: fbtbt: Replace timespec with ktime_t

by Ksenija Stanojevic

struct timespec will overflow in year 2038, so replace it with ktime_t. And replace functions that use struct timespec, timespec_sub with ktime_sub. Also use monotonic time instead of real time, by replacing getnstimeofday with ktime_get, to be more robust against leap seconds and settimeofday() calls. Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic(a)gmail.com> --- Changes in v2: -use ktime_t instead timespec64 -use ktime_sub instead timespec64_sub -use monotonic instead real-time. drivers/staging/fbtft/fbtft-core.c | 35 +++++++++++++---------------------- drivers/staging/fbtft/fbtft.h | 2 +- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 7f5fa3d..a1645e1 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -365,16 +365,15 @@ static void fbtft_update_display(struct fbtft_par *par, unsigned start_line, unsigned end_line) { size_t offset, len; - struct timespec ts_start, ts_end, ts_fps, ts_duration; - long fps_ms, fps_us, duration_ms, duration_us; - long fps, throughput; + ktime_t ts_start, ts_end, ts_fps; + long long fps, throughput; bool timeit = false; int ret = 0; if (unlikely(par->debug & (DEBUG_TIME_FIRST_UPDATE | DEBUG_TIME_EACH_UPDATE))) { if ((par->debug & DEBUG_TIME_EACH_UPDATE) || ((par->debug & DEBUG_TIME_FIRST_UPDATE) && !par->first_update_done)) { - getnstimeofday(&ts_start); + ts_start = ktime_get(); timeit = true; } } @@ -411,30 +410,22 @@ static void fbtft_update_display(struct fbtft_par *par, unsigned start_line, __func__); if (unlikely(timeit)) { - getnstimeofday(&ts_end); - if (par->update_time.tv_nsec == 0 && par->update_time.tv_sec == 0) { - par->update_time.tv_sec = ts_start.tv_sec; - par->update_time.tv_nsec = ts_start.tv_nsec; - } - ts_fps = timespec_sub(ts_start, par->update_time); - par->update_time.tv_sec = ts_start.tv_sec; - par->update_time.tv_nsec = ts_start.tv_nsec; - fps_ms = (ts_fps.tv_sec * 1000) + ((ts_fps.tv_nsec / 1000000) % 1000); - fps_us = (ts_fps.tv_nsec / 1000) % 1000; - fps = fps_ms * 1000 + fps_us; + ts_end = ktime_get(); + if (par->update_time.tv64 == 0) + par->update_time = ts_start; + + ts_fps = ktime_sub(ts_start, par->update_time); + par->update_time = ts_start; + fps = ktime_to_us(ts_fps); fps = fps ? 1000000 / fps : 0; - ts_duration = timespec_sub(ts_end, ts_start); - duration_ms = (ts_duration.tv_sec * 1000) + ((ts_duration.tv_nsec / 1000000) % 1000); - duration_us = (ts_duration.tv_nsec / 1000) % 1000; - throughput = duration_ms * 1000 + duration_us; + throughput = ktime_us_delta(ts_end, ts_start); throughput = throughput ? (len * 1000) / throughput : 0; throughput = throughput * 1000 / 1024; dev_info(par->info->device, - "Display update: %ld kB/s (%ld.%.3ld ms), fps=%ld (%ld.%.3ld ms)\n", - throughput, duration_ms, duration_us, - fps, fps_ms, fps_us); + "Display update: %lld kB/s, fps=%lld\n", + throughput, fps); par->first_update_done = true; } } diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 7e9a506..8107f55 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fbtft/fbtft.h @@ -251,7 +251,7 @@ struct fbtft_par { } gamma; unsigned long debug; bool first_update_done; - struct timespec update_time; + ktime_t update_time; bool bgr; void *extra; }; -- 1.9.1

9 years, 6 months

Re: [Y2038] [PATCH 12/12] [RFC] can: avoid using timeval for uapi

by Arnd Bergmann

On Tuesday 06 October 2015 11:05:32 Marc Kleine-Budde wrote: > On 10/06/2015 10:32 AM, Arnd Bergmann wrote: > > On Monday 05 October 2015 20:51:08 Oliver Hartkopp wrote: > >> > >> I double checked some (more) BCM applications I have access to. > >> > >> E.g. https://github.com/linux-can/can-tests > >> > >> When you do a 'git grep ival1' there you get something like > >> > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_sec = 1; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_usec = 0; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_sec = 0; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_usec = 0; > >> tst-bcm-dump.c: msg.msg_head.ival1.tv_sec = timeout / 1000000; > >> tst-bcm-dump.c: msg.msg_head.ival1.tv_usec = timeout % 1000000; > >> (..) > >> > >> So the usual way to assign values to ival1 and ival2 is NOT to assign an > >> existing struct timeval but to directly assign its tv_[u]sec elements. > > > > Ok, very good. > > > >> I applied your bcm.h changes to my local can-tests tree and it compiles > >> without any problems - as expected. I don't see any serious drawback with your > >> idea. I wonder whether developers would ever notice this change ... > >> > >>> We could address problem a) by using '__u32' or 'int' members > >>> rather than 'long', but that would have a more significant > >>> downside in also breaking support for all existing 64-bit user > >>> binaries that might be using this interface, which is likely > >>> not acceptable. > >> > >> Indeed. > >> > >>> Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> > >>> Cc: Oliver Hartkopp <socketcan(a)hartkopp.net> > >> > >> Thanks for your good suggestion to make the BCM API y2038 proof! > >> > >> Acked-by: Oliver Hartkopp <socketcan(a)hartkopp.net> > > > > Thanks. > > > > What is the normal path for CAN patches? Should I resend with your > > Ack and without the RFC for Marc to pick it up? > > You can add my: > > Acked-by: Marc Kleine-Budde <mkl(a)pengutronix.de> > > add upstream the 2038 fixes as a block. Davem already picked up the first 10 of the series. If you don't mind, I'd prefer if you could take this one into your tree so I have it off my list. I have 200 other patches in various states and more getting added. Arnd

9 years, 6 months

Shipment delivery problem #000595513

by FedEx 2Day

Dear Customer, This is to confirm that one or more of your parcels has been shipped. Shipment Label is attached to this email. Sincerely, Randy Caldwell, FedEx Operation Manager.

9 years, 6 months

Problems with item delivery, n.00000492166

by FedEx International Next Flight

Dear Customer, Courier was unable to deliver the parcel to you. Delivery Label is attached to this email. Thanks and best regards, Don West, FedEx Station Agent.

9 years, 6 months

Courier was unable to deliver the parcel, ID0000105794

by FedEx International Economy

Dear Customer, We could not deliver your item. You can review complete details of your order in the find attached. Kind regards, Eric Chandler, Sr. Operation Agent.

9 years, 6 months

Unable to deliver your item, #0000323419

by FedEx International Ground

Dear Customer, We could not deliver your item. Shipment Label is attached to email. Thank you for choosing FedEx, Scott Nolan, Sr. Station Agent.

9 years, 6 months

[PATCH v4] Staging: olpc_dcon: Replace timespec with ktime_t

by Ksenija Stanojevic

Struct timespec will overflow in year 2038, here it will not cause an overflow because it is used with timespec_sub, but still has to be removed as part of y2038 changes. Replace it with ktime_t. Also use monotonic instead of real-time by replacing functions getnstimeofday with ktime_get. Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic(a)gmail.com> Reviewed-by: Arnd Bergmann <arnd(a)arndb.de> --- Changes in v4: -fix checkpatch.pl errors/warnings introduced by changes made in v3. Changes in v3: -fix commit message (ktime_sub -> ktime_get) Changes in v2: -use ktime_t instead timespec64 -use ktime_sub instead timespec64_sub -use monotonic instead real-time. drivers/staging/olpc_dcon/olpc_dcon.c | 27 +++++++++++++-------------- drivers/staging/olpc_dcon/olpc_dcon.h | 4 ++-- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index d115f5c..9038e0b 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.c +++ b/drivers/staging/olpc_dcon/olpc_dcon.c @@ -238,13 +238,12 @@ static void dcon_sleep(struct dcon_priv *dcon, bool sleep) */ static void dcon_load_holdoff(struct dcon_priv *dcon) { - struct timespec delta_t, now; + ktime_t delta_t, now; while (1) { - getnstimeofday(&now); - delta_t = timespec_sub(now, dcon->load_time); - if (delta_t.tv_sec != 0 || - delta_t.tv_nsec > NSEC_PER_MSEC * 20) { + now = ktime_get(); + delta_t = ktime_sub(now, dcon->load_time); + if (ktime_to_ns(delta_t) > NSEC_PER_MSEC * 20) { break; } mdelay(4); @@ -325,19 +324,19 @@ static void dcon_source_switch(struct work_struct *work) /* And turn off the DCON */ pdata->set_dconload(1); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); pr_info("The CPU has control\n"); break; case DCON_SOURCE_DCON: { - struct timespec delta_t; + ktime_t delta_t; pr_info("dcon_source_switch to DCON\n"); /* Clear DCONLOAD - this implies that the DCON is in control */ pdata->set_dconload(0); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); wait_event_timeout(dcon->waitq, dcon->switched, HZ/2); @@ -355,14 +354,14 @@ static void dcon_source_switch(struct work_struct *work) * deassert and reassert, and hope for the best. * see http://dev.laptop.org/ticket/9664 */ - delta_t = timespec_sub(dcon->irq_time, dcon->load_time); - if (dcon->switched && delta_t.tv_sec == 0 && - delta_t.tv_nsec < NSEC_PER_MSEC * 20) { + delta_t = ktime_sub(dcon->irq_time, dcon->load_time); + if (dcon->switched && ktime_to_ns(delta_t) + < NSEC_PER_MSEC * 20) { pr_err("missed loading, retrying\n"); pdata->set_dconload(1); mdelay(41); pdata->set_dconload(0); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); mdelay(41); } } @@ -742,7 +741,7 @@ irqreturn_t dcon_interrupt(int irq, void *id) case 2: /* switch to DCON mode */ case 1: /* switch to CPU mode */ dcon->switched = true; - getnstimeofday(&dcon->irq_time); + dcon->irq_time = ktime_get(); wake_up(&dcon->waitq); break; @@ -756,7 +755,7 @@ irqreturn_t dcon_interrupt(int irq, void *id) */ if (dcon->curr_src != dcon->pending_src && !dcon->switched) { dcon->switched = true; - getnstimeofday(&dcon->irq_time); + dcon->irq_time = ktime_get(); wake_up(&dcon->waitq); pr_debug("switching w/ status 0/0\n"); } else { diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h index d06e19d..215e7ec 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.h +++ b/drivers/staging/olpc_dcon/olpc_dcon.h @@ -79,8 +79,8 @@ struct dcon_priv { /* Variables used during switches */ bool switched; - struct timespec irq_time; - struct timespec load_time; + ktime_t irq_time; + ktime_t load_time; /* Current output type; true == mono, false == color */ bool mono; -- 1.9.1

9 years, 6 months

Courier was unable to deliver the parcel, ID00297501

by FedEx SmartPost

Dear Customer, We could not deliver your item. Please, open email attachment to print shipment label. Yours faithfully, Herbert Higgins, FedEx Operation Manager.

9 years, 6 months

[PATCH v3] Staging: olpc_dcon: Replace timespec with ktime_t

by Ksenija Stanojevic

Struct timespec will overflow in year 2038, here it will not cause an overflow because it is used with timespec_sub, but still has to be removed as part of y2038 changes. Replace it with ktime_t. Also use monotonic instead of real-time by replacing functions getnstimeofday with ktime_get. Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic(a)gmail.com> --- Changes in v3: -fix commit message (ktime_sub -> ktime_get) Changes in v2: -use ktime_t instead timespec64 -use ktime_sub instead timespec64_sub -use monotonic instead real-time. drivers/staging/olpc_dcon/olpc_dcon.c | 27 +++++++++++++-------------- drivers/staging/olpc_dcon/olpc_dcon.h | 4 ++-- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index d115f5c..2dc5d36 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.c +++ b/drivers/staging/olpc_dcon/olpc_dcon.c @@ -238,13 +238,12 @@ static void dcon_sleep(struct dcon_priv *dcon, bool sleep) */ static void dcon_load_holdoff(struct dcon_priv *dcon) { - struct timespec delta_t, now; + ktime_t delta_t, now; while (1) { - getnstimeofday(&now); - delta_t = timespec_sub(now, dcon->load_time); - if (delta_t.tv_sec != 0 || - delta_t.tv_nsec > NSEC_PER_MSEC * 20) { + now = ktime_get(); + delta_t = ktime_sub(now, dcon->load_time); + if (ktime_to_ns(delta_t) > NSEC_PER_MSEC * 20) { break; } mdelay(4); @@ -325,19 +324,19 @@ static void dcon_source_switch(struct work_struct *work) /* And turn off the DCON */ pdata->set_dconload(1); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); pr_info("The CPU has control\n"); break; case DCON_SOURCE_DCON: { - struct timespec delta_t; + ktime_t delta_t; pr_info("dcon_source_switch to DCON\n"); /* Clear DCONLOAD - this implies that the DCON is in control */ pdata->set_dconload(0); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); wait_event_timeout(dcon->waitq, dcon->switched, HZ/2); @@ -355,14 +354,14 @@ static void dcon_source_switch(struct work_struct *work) * deassert and reassert, and hope for the best. * see http://dev.laptop.org/ticket/9664 */ - delta_t = timespec_sub(dcon->irq_time, dcon->load_time); - if (dcon->switched && delta_t.tv_sec == 0 && - delta_t.tv_nsec < NSEC_PER_MSEC * 20) { + delta_t = ktime_sub(dcon->irq_time, dcon->load_time); + if (dcon->switched && + ktime_to_ns(delta_t) < NSEC_PER_MSEC * 20) { pr_err("missed loading, retrying\n"); pdata->set_dconload(1); mdelay(41); pdata->set_dconload(0); - getnstimeofday(&dcon->load_time); + dcon->load_time = ktime_get(); mdelay(41); } } @@ -742,7 +741,7 @@ irqreturn_t dcon_interrupt(int irq, void *id) case 2: /* switch to DCON mode */ case 1: /* switch to CPU mode */ dcon->switched = true; - getnstimeofday(&dcon->irq_time); + dcon->irq_time = ktime_get(); wake_up(&dcon->waitq); break; @@ -756,7 +755,7 @@ irqreturn_t dcon_interrupt(int irq, void *id) */ if (dcon->curr_src != dcon->pending_src && !dcon->switched) { dcon->switched = true; - getnstimeofday(&dcon->irq_time); + dcon->irq_time = ktime_get(); wake_up(&dcon->waitq); pr_debug("switching w/ status 0/0\n"); } else { diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h index d06e19d..215e7ec 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.h +++ b/drivers/staging/olpc_dcon/olpc_dcon.h @@ -79,8 +79,8 @@ struct dcon_priv { /* Variables used during switches */ bool switched; - struct timespec irq_time; - struct timespec load_time; + ktime_t irq_time; + ktime_t load_time; /* Current output type; true == mono, false == color */ bool mono; -- 1.9.1

9 years, 6 months

[PATCH 0/5] y2038 conversion for ntp/pps and sfc driver

by Arnd Bergmann

When trying to build a kernel with time_t commented out, I found that the ntp subsystem still relies on timespec for its pps handling. This series addresses this and converts all the code to use timespec64 instead, step by step. There is one device driver that interacts with this code directly (rather than only through the ptp subsystem), so I have to convert that driver at the same time. The patches should ideally stay together as a series, but they do span multiple subsystems, so I'm also looking for the right person to merge them. Please review. Thanks, Arnd Arnd Bergmann (5): ntp/pps: use timespec64 for hardpps() ntp/pps: replace getnstime_raw_and_real with 64-bit version ntp: use timespec64 in sync_cmos_clock ntp/pps: use y2038 safe types in pps_event_time net: sfc: avoid using timespec drivers/net/ethernet/sfc/ptp.c | 30 +++++++++++++++--------------- drivers/pps/kapi.c | 4 ++-- include/linux/pps_kernel.h | 16 ++++++++-------- include/linux/timekeeping.h | 4 ++-- include/linux/timex.h | 2 +- kernel/time/ntp.c | 16 ++++++++-------- kernel/time/ntp_internal.h | 2 +- kernel/time/timekeeping.c | 14 +++++++------- 8 files changed, 44 insertions(+), 44 deletions(-) -- 2.1.0.rc2

9 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038