On 9/12/26 08:29, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 7.2.6 release. There are 1815 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. [...]
My builds failed while compiling perf:
ui/browsers/hists.c: In function ‘evsel__hists_browse’: ui/browsers/hists.c:3191:41: error: ‘hotkey_act’ undeclared (first use in this function) 3191 | memset(&hotkey_act, 0, sizeof(hotkey_act)); | ^~~~~~~~~~ ui/browsers/hists.c:3191:41: note: each undeclared identifier is reported only once for each function it appears in
Reverting "perf ui hists: In report UI ensure thread is set with reference counting" fixes this. Haven't tried, but maybe including bd86119c3ee6ed ("perf ui hists: Fix dso_filter reference leak and exit zoom cleanup") will fix this, too.
That got me a little further, but then I ran into this:
tools/perf/util/python.c: In function ‘pyrf_evsel__open’: tools/perf/util/python.c:1104:9: error: implicit declaration of function ‘CHECK_INITIALIZED’ [-Wimplicit-function-declaration] 1104 | CHECK_INITIALIZED(evsel, "evsel"); | ^~~~~~~~~~~~~~~~~ tools/perf/util/python.c: In function ‘pyrf_evsel__set_tracking’: tools/perf/util/python.c:1295:9: error: implicit declaration of function ‘CHECK_INITIALIZED_INT’ [-Wimplicit-function-declaration] 1295 | CHECK_INITIALIZED_INT(pevsel->evsel, "evsel"); | ^~~~~~~~~~~~~~~~~~~~~
Only looked briefly, but didn't spot a simple way to work around that through a simple revert or two (but it's quite likely I missed something).
Ciao, Thorsten