- Linux-stable-mirror - lists.linaro.org

[PATCH v3] usb: udc: core: Use lock when write to soft_connect

by Thinh Nguyen

Use lock to guard against concurrent access for soft-connect/disconnect operations when writing to soft_connect sysfs. Cc: stable(a)vger.kernel.org Fixes: 2ccea03a8f7e ("usb: gadget: introduce UDC Class") Signed-off-by: Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> --- Changes in v3: - Improve flow: avoid assigning "ret = n" early Changes in v2: - Consolidate mutex_unlock to a single place using "goto out" drivers/usb/gadget/udc/core.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 6a62bbd01324..ea114f922ccf 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1529,10 +1529,13 @@ static ssize_t soft_connect_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t n) { struct usb_udc *udc = container_of(dev, struct usb_udc, dev); + ssize_t ret; + mutex_lock(&udc_lock); if (!udc->driver) { dev_err(dev, "soft-connect without a gadget driver\n"); - return -EOPNOTSUPP; + ret = -EOPNOTSUPP; + goto out; } if (sysfs_streq(buf, "connect")) { @@ -1543,10 +1546,14 @@ static ssize_t soft_connect_store(struct device *dev, usb_gadget_udc_stop(udc); } else { dev_err(dev, "unsupported command '%s'\n", buf); - return -EINVAL; + ret = -EINVAL; + goto out; } - return n; + ret = n; +out: + mutex_unlock(&udc_lock); + return ret; } static DEVICE_ATTR_WO(soft_connect); base-commit: 4e0dcf62ab4cf917d0cbe751b8bf229a065248d4 -- 2.28.0

4 years, 7 months

2
1
0 0

Re: [PATCH v2] usb: udc: core: Use lock when write to soft_connect

by Greg Kroah-Hartman

On Thu, Jan 14, 2021 at 09:03:53AM +0200, Andy Shevchenko wrote: > On Thursday, January 14, 2021, Ahmed S. Darwish <a.darwish(a)linutronix.de> > wrote: > > > On Wed, Jan 13, 2021 at 07:38:28PM -0800, Thinh Nguyen wrote: > > ... > > > @@ -1543,10 +1546,12 @@ static ssize_t soft_connect_store(struct device > > *dev, > > > usb_gadget_udc_stop(udc); > > > } else { > > > dev_err(dev, "unsupported command '%s'\n", buf); > > > - return -EINVAL; > > > + ret = -EINVAL; > > > } > > > > > > - return n; > > > > Should be ret = n; here. Why? That happened higher up in the patch. thanks, greg k-h

4 years, 7 months

1
0
0 0

[PATCH v2] usb: udc: core: Use lock when write to soft_connect

by Thinh Nguyen

Use lock to guard against concurrent access for soft-connect/disconnect operations when writing to soft_connect sysfs. Cc: stable(a)vger.kernel.org Fixes: 2ccea03a8f7e ("usb: gadget: introduce UDC Class") Signed-off-by: Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> --- Changes in v2: - Consolidate mutex_unlock to a single place using "goto out" drivers/usb/gadget/udc/core.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 6a62bbd01324..3363f5c282f1 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1529,10 +1529,13 @@ static ssize_t soft_connect_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t n) { struct usb_udc *udc = container_of(dev, struct usb_udc, dev); + ssize_t ret = n; + mutex_lock(&udc_lock); if (!udc->driver) { dev_err(dev, "soft-connect without a gadget driver\n"); - return -EOPNOTSUPP; + ret = -EOPNOTSUPP; + goto out; } if (sysfs_streq(buf, "connect")) { @@ -1543,10 +1546,12 @@ static ssize_t soft_connect_store(struct device *dev, usb_gadget_udc_stop(udc); } else { dev_err(dev, "unsupported command '%s'\n", buf); - return -EINVAL; + ret = -EINVAL; } - return n; +out: + mutex_unlock(&udc_lock); + return ret; } static DEVICE_ATTR_WO(soft_connect); base-commit: 4e0dcf62ab4cf917d0cbe751b8bf229a065248d4 -- 2.28.0

4 years, 7 months

3
2
0 0

Re: [PATCH v2] usb: udc: core: Use lock when write to soft_connect

by Thinh Nguyen

Andy Shevchenko wrote: > > > On Thursday, January 14, 2021, Ahmed S. Darwish > <a.darwish(a)linutronix.de <mailto:a.darwish@linutronix.de>> wrote: > > On Wed, Jan 13, 2021 at 07:38:28PM -0800, Thinh Nguyen wrote: > ... > > @@ -1543,10 +1546,12 @@ static ssize_t soft_connect_store(struct > device *dev, > > usb_gadget_udc_stop(udc); > > } else { > > dev_err(dev, "unsupported command '%s'\n", buf); > > - return -EINVAL; > > + ret = -EINVAL; > > } > > > > - return n; > > > > Should be ret = n; here. > > > > +out: > > + mutex_unlock(&udc_lock); > > + return ret; > > } > > This is *very* tricky: the return value will be easily broken if > someone > adds any code later after the else body and before the "out" label. > > > > +1 and it’s not good pattern to assign return value at the definition > time (see comment above ). > > > -- > With Best Regards, > Andy Shevchenko > > Good point. I didn't think about that. Thanks guys. Thinh

4 years, 7 months

1
0
0 0

Re: [PATCH bpf-next] bpf: reject too big ctx_size_in for raw_tp test run

by Yonghong Song

On 1/12/21 3:42 PM, Song Liu wrote: > syzbot reported a WARNING for allocating too big memory: > > WARNING: CPU: 1 PID: 8484 at mm/page_alloc.c:4976 __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5011 > Modules linked in: > CPU: 1 PID: 8484 Comm: syz-executor862 Not tainted 5.11.0-rc2-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:__alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:4976 > Code: 00 00 0c 00 0f 85 a7 00 00 00 8b 3c 24 4c 89 f2 44 89 e6 c6 44 24 70 00 48 89 6c 24 58 e8 d0 d7 ff ff 49 89 c5 e9 ea fc ff ff <0f> 0b e9 b5 fd ff ff 89 74 24 14 4c 89 4c 24 08 4c 89 74 24 18 e8 > RSP: 0018:ffffc900012efb10 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: 1ffff9200025df66 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000140dc0 > RBP: 0000000000140dc0 R08: 0000000000000000 R09: 0000000000000000 > R10: ffffffff81b1f7e1 R11: 0000000000000000 R12: 0000000000000014 > R13: 0000000000000014 R14: 0000000000000000 R15: 0000000000000000 > FS: 000000000190c880(0000) GS:ffff8880b9e00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f08b7f316c0 CR3: 0000000012073000 CR4: 00000000001506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > alloc_pages_current+0x18c/0x2a0 mm/mempolicy.c:2267 > alloc_pages include/linux/gfp.h:547 [inline] > kmalloc_order+0x2e/0xb0 mm/slab_common.c:837 > kmalloc_order_trace+0x14/0x120 mm/slab_common.c:853 > kmalloc include/linux/slab.h:557 [inline] > kzalloc include/linux/slab.h:682 [inline] > bpf_prog_test_run_raw_tp+0x4b5/0x670 net/bpf/test_run.c:282 > bpf_prog_test_run kernel/bpf/syscall.c:3120 [inline] > __do_sys_bpf+0x1ea9/0x4f10 kernel/bpf/syscall.c:4398 > do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > RIP: 0033:0x440499 > Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00 > RSP: 002b:00007ffe1f3bfb18 EFLAGS: 00000246 ORIG_RAX: 0000000000000141 > RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440499 > RDX: 0000000000000048 RSI: 0000000020000600 RDI: 000000000000000a > RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401ca0 > R13: 0000000000401d30 R14: 0000000000000000 R15: 0000000000000000 > > This is because we didn't filter out too big ctx_size_in. Fix it by > rejecting ctx_size_in that are bigger than MAX_BPF_FUNC_ARGS (12) u64 > numbers. > > Reported-by: syzbot+4f98876664c7337a4ae6(a)syzkaller.appspotmail.com > Fixes: 1b4d60ec162f ("bpf: Enable BPF_PROG_TEST_RUN for raw_tracepoint") > Cc: stable(a)vger.kernel.org # v5.10+ > Signed-off-by: Song Liu <songliubraving(a)fb.com> Maybe this should target to bpf tree? Acked-by: Yonghong Song <yhs(a)fb.com>

4 years, 7 months

3
3
0 0

[PATCH] tracing/kprobes: Do the notrace functions check without kprobes on ftrace

by ChunyouTang

From: Masami Hiramatsu <mhiramat(a)kernel.org> Enable the notrace function check on the architecture which doesn't support kprobes on ftrace but support dynamic ftrace. This notrace function check is not only for the kprobes on ftrace but also sw-breakpoint based kprobes. Thus there is no reason to limit this check for the arch which supports kprobes on ftrace. This also changes the dependency of Kconfig. Because kprobe event uses the function tracer's address list for identifying notrace function, if the CONFIG_DYNAMIC_FTRACE=n, it can not check whether the target function is notrace or not. Link: https://lkml.kernel.org/r/20210105065730.2634785-1-naveen.n.rao@linux.vnet.… Link: https://lkml.kernel.org/r/161007957862.114704.4512260007555399463.stgit@dev… Cc: stable(a)vger.kernel.org Fixes: 45408c4f92506 ("tracing: kprobes: Prohibit probing on notrace function") Acked-by: Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com> Signed-off-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- kernel/trace/Kconfig | 2 +- kernel/trace/trace_kprobe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index d5a19413d4f8..c1a62ae7e812 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -538,7 +538,7 @@ config KPROBE_EVENTS config KPROBE_EVENTS_ON_NOTRACE bool "Do NOT protect notrace function from kprobe events" depends on KPROBE_EVENTS - depends on KPROBES_ON_FTRACE + depends on DYNAMIC_FTRACE default n help This is only for the developers who want to debug ftrace itself diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 9c31f42245e9..e6fba1798771 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -434,7 +434,7 @@ static int disable_trace_kprobe(struct trace_event_call *call, return 0; } -#if defined(CONFIG_KPROBES_ON_FTRACE) && \ +#if defined(CONFIG_DYNAMIC_FTRACE) && \ !defined(CONFIG_KPROBE_EVENTS_ON_NOTRACE) static bool __within_notrace_func(unsigned long addr) { -- 2.30.0.windows.1

4 years, 7 months

2
1
0 0

[PATCH] tracing/kprobes: Do the notrace functions check without kprobes on ftrace

by ChunyouTang

From: Masami Hiramatsu <mhiramat(a)kernel.org> Enable the notrace function check on the architecture which doesn't support kprobes on ftrace but support dynamic ftrace. This notrace function check is not only for the kprobes on ftrace but also sw-breakpoint based kprobes. Thus there is no reason to limit this check for the arch which supports kprobes on ftrace. This also changes the dependency of Kconfig. Because kprobe event uses the function tracer's address list for identifying notrace function, if the CONFIG_DYNAMIC_FTRACE=n, it can not check whether the target function is notrace or not. Link: https://lkml.kernel.org/r/20210105065730.2634785-1-naveen.n.rao@linux.vnet.… Link: https://lkml.kernel.org/r/161007957862.114704.4512260007555399463.stgit@dev… Cc: stable(a)vger.kernel.org Fixes: 45408c4f92506 ("tracing: kprobes: Prohibit probing on notrace function") Acked-by: Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com> Signed-off-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- kernel/trace/Kconfig | 2 +- kernel/trace/trace_kprobe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index d5a19413d4f8..c1a62ae7e812 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -538,7 +538,7 @@ config KPROBE_EVENTS config KPROBE_EVENTS_ON_NOTRACE bool "Do NOT protect notrace function from kprobe events" depends on KPROBE_EVENTS - depends on KPROBES_ON_FTRACE + depends on DYNAMIC_FTRACE default n help This is only for the developers who want to debug ftrace itself diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 9c31f42245e9..e6fba1798771 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -434,7 +434,7 @@ static int disable_trace_kprobe(struct trace_event_call *call, return 0; } -#if defined(CONFIG_KPROBES_ON_FTRACE) && \ +#if defined(CONFIG_DYNAMIC_FTRACE) && \ !defined(CONFIG_KPROBE_EVENTS_ON_NOTRACE) static bool __within_notrace_func(unsigned long addr) { -- 2.30.0.windows.1

4 years, 7 months

1
0
0 0

[PATCH] usb: udc: core: Use lock for soft_connect

by Thinh Nguyen

Use lock to guard against concurrent access for soft-connect/disconnect operations when writing to soft_connect sysfs. Cc: stable(a)vger.kernel.org Fixes: 2ccea03a8f7e ("usb: gadget: introduce UDC Class") Signed-off-by: Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> --- drivers/usb/gadget/udc/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 6a62bbd01324..44c67e765167 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1530,7 +1530,9 @@ static ssize_t soft_connect_store(struct device *dev, { struct usb_udc *udc = container_of(dev, struct usb_udc, dev); + mutex_lock(&udc_lock); if (!udc->driver) { + mutex_unlock(&udc_lock); dev_err(dev, "soft-connect without a gadget driver\n"); return -EOPNOTSUPP; } @@ -1542,10 +1544,12 @@ static ssize_t soft_connect_store(struct device *dev, usb_gadget_disconnect(udc->gadget); usb_gadget_udc_stop(udc); } else { + mutex_unlock(&udc_lock); dev_err(dev, "unsupported command '%s'\n", buf); return -EINVAL; } + mutex_unlock(&udc_lock); return n; } static DEVICE_ATTR_WO(soft_connect); base-commit: 4e0dcf62ab4cf917d0cbe751b8bf229a065248d4 -- 2.28.0

4 years, 7 months

3
4
0 0

[PATCH 4.19 00/77] 4.19.167-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.167 release. There are 77 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 13 Jan 2021 13:00:19 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.167-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.167-rc1 Paolo Bonzini <pbonzini(a)redhat.com> KVM: x86: fix shift out of bounds reported by UBSAN Ying-Tsun Huang <ying-tsun.huang(a)amd.com> x86/mtrr: Correct the range check before performing MTRR type lookups Florian Westphal <fw(a)strlen.de> netfilter: xt_RATEEST: reject non-null terminated string from userspace Vasily Averin <vvs(a)virtuozzo.com> netfilter: ipset: fix shift-out-of-bounds in htable_bits() Subash Abhinov Kasiviswanathan <subashab(a)codeaurora.org> netfilter: x_tables: Update remaining dereference to RCU Roger Pau Monne <roger.pau(a)citrix.com> xen/pvh: correctly setup the PV EFI interface for dom0 Bard Liao <yung-chuan.liao(a)linux.intel.com> Revert "device property: Keep secondary firmware node secondary by type" Filipe Manana <fdmanana(a)suse.com> btrfs: send: fix wrong file path when there is an inode with a pending rmdir Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Fix speaker volume control on Lenovo C940 bo liu <bo.liu(a)senarytech.com> ALSA: hda/conexant: add a new hda codec CX11970 Takashi Iwai <tiwai(a)suse.de> ALSA: hda/via: Fix runtime PM for Clevo W35xSS Dan Williams <dan.j.williams(a)intel.com> x86/mm: Fix leak of pmd ptlock Johan Hovold <johan(a)kernel.org> USB: serial: keyspan_pda: remove unused variable Eddie Hung <eddie.hung(a)mediatek.com> usb: gadget: configfs: Fix use-after-free issue with udc_name Chandana Kishori Chiluveru <cchiluve(a)codeaurora.org> usb: gadget: configfs: Preserve function ordering after bind failure Sriharsha Allenki <sallenki(a)codeaurora.org> usb: gadget: Fix spinlock lockup on usb_function_deactivate Yang Yingliang <yangyingliang(a)huawei.com> USB: gadget: legacy: fix return error code in acm_ms_bind() Manish Narani <manish.narani(a)xilinx.com> usb: gadget: u_ether: Fix MTU size mismatch with RX packet size Zqiang <qiang.zhang(a)windriver.com> usb: gadget: function: printer: Fix a memory leak for interface descriptor Jerome Brunet <jbrunet(a)baylibre.com> usb: gadget: f_uac2: reset wMaxPacketSize Arnd Bergmann <arnd(a)arndb.de> usb: gadget: select CONFIG_CRC32 Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Fix UBSAN warnings for MIDI jacks Johan Hovold <johan(a)kernel.org> USB: usblp: fix DMA to stack Johan Hovold <johan(a)kernel.org> USB: yurex: fix control-URB timeout handling Bjørn Mork <bjorn(a)mork.no> USB: serial: option: add Quectel EM160R-GL Daniel Palmer <daniel(a)0x0f.com> USB: serial: option: add LongSung M5710 module support Johan Hovold <johan(a)kernel.org> USB: serial: iuu_phoenix: fix DMA from stack Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: uas: Add PNY USB Portable SSD to unusual_uas Randy Dunlap <rdunlap(a)infradead.org> usb: usbip: vhci_hcd: protect shift size Michael Grzeschik <m.grzeschik(a)pengutronix.de> USB: xhci: fix U1/U2 handling for hardware with XHCI_INTEL_HOST quirk set Yu Kuai <yukuai3(a)huawei.com> usb: chipidea: ci_hdrc_imx: add missing put_device() call in usbmisc_get_init_data() Serge Semin <Sergey.Semin(a)baikalelectronics.ru> usb: dwc3: ulpi: Use VStsDone to detect PHY regs access completion Tetsuo Handa <penguin-kernel(a)i-love.sakura.ne.jp> USB: cdc-wdm: Fix use after free in service_outstanding_interrupt(). Sean Young <sean(a)mess.org> USB: cdc-acm: blacklist another IR Droid device taehyun.cho <taehyun.cho(a)samsung.com> usb: gadget: enable super speed plus Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> staging: mt7621-dma: Fix a resource leak in an error handling path Ard Biesheuvel <ardb(a)kernel.org> crypto: ecdh - avoid buffer overflow in ecdh_set_secret() Dexuan Cui <decui(a)microsoft.com> video: hyperv_fb: Fix the mmap() regression for v5.4.y and older Hans de Goede <hdegoede(a)redhat.com> Bluetooth: revert: hci_h5: close serdev device and free hu in h5_close Florian Fainelli <f.fainelli(a)gmail.com> net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE Antoine Tenart <atenart(a)kernel.org> net-sysfs: take the rtnl lock when accessing xps_rxqs_map and num_tc Antoine Tenart <atenart(a)kernel.org> net-sysfs: take the rtnl lock when storing xps_rxqs Randy Dunlap <rdunlap(a)infradead.org> net: sched: prevent invalid Scell_log shift count Yunjian Wang <wangyunjian(a)huawei.com> vhost_net: fix ubuf refcount incorrectly when sendmsg fails Heiner Kallweit <hkallweit1(a)gmail.com> r8169: work around power-saving bug on some chip versions Bjørn Mork <bjorn(a)mork.no> net: usb: qmi_wwan: add Quectel EM160R-GL Roland Dreier <roland(a)kernel.org> CDC-NCM: remove "connected" log message Xie He <xie.he.0141(a)gmail.com> net: hdlc_ppp: Fix issues when mod_timer is called while timer is running Cong Wang <cong.wang(a)bytedance.com> erspan: fix version 1 check in gre_parse_header() Yunjian Wang <wangyunjian(a)huawei.com> net: hns: fix return value check in __lb_other_process() Guillaume Nault <gnault(a)redhat.com> ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst() Yunjian Wang <wangyunjian(a)huawei.com> tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS Grygorii Strashko <grygorii.strashko(a)ti.com> net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered Antoine Tenart <atenart(a)kernel.org> net-sysfs: take the rtnl lock when accessing xps_cpus_map and num_tc Antoine Tenart <atenart(a)kernel.org> net-sysfs: take the rtnl lock when storing xps_cpus Dinghao Liu <dinghao.liu(a)zju.edu.cn> net: ethernet: Fix memleak in ethoc_probe John Wang <wangzhiqiang.bj(a)bytedance.com> net/ncsi: Use real net-device for response handler Petr Machata <me(a)pmachata.org> net: dcb: Validate netlink message in DCB handler Jeff Dike <jdike(a)akamai.com> virtio_net: Fix recursive call to cpus_read_lock() Manish Chopra <manishc(a)marvell.com> qede: fix offload for IPIP tunnel packets Stefan Chulski <stefanc(a)marvell.com> net: mvpp2: Fix GoP port 3 Networking Complex Control configurations Dan Carpenter <dan.carpenter(a)oracle.com> atm: idt77252: call pci_disable_device() on error path Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> ethernet: ucc_geth: set dev->max_mtu to 1518 Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> ethernet: ucc_geth: fix use-after-free in ucc_geth_remove() Stefan Chulski <stefanc(a)marvell.com> net: mvpp2: prs: fix PPPoE with ipv6 packet parse Stefan Chulski <stefanc(a)marvell.com> net: mvpp2: Add TCAM entry to drop flow control pause frames Sylwester Dziedziuch <sylwesterx.dziedziuch(a)intel.com> i40e: Fix Error I40E_AQ_RC_EINVAL when removing VFs Alexey Dobriyan <adobriyan(a)gmail.com> proc: fix lookup in /proc/net subdirectories after setns(2) Alexey Dobriyan <adobriyan(a)gmail.com> proc: change ->nlink under proc_subdir_lock Linus Torvalds <torvalds(a)linux-foundation.org> depmod: handle the case of /sbin/depmod without /sbin in PATH Huang Shijie <sjhuang(a)iluvatar.ai> lib/genalloc: fix the overflow when size is too big Bart Van Assche <bvanassche(a)acm.org> scsi: scsi_transport_spi: Set RQF_PM for domain validation commands Bart Van Assche <bvanassche(a)acm.org> scsi: ide: Do not set the RQF_PREEMPT flag for sense requests Adrian Hunter <adrian.hunter(a)intel.com> scsi: ufs-pci: Ensure UFS device is in PowerDown mode for suspend-to-disk ->poweroff() Bean Huo <beanhuo(a)micron.com> scsi: ufs: Fix wrong print message in dev_err() Yunfeng Ye <yeyunfeng(a)huawei.com> workqueue: Kick a worker based on the actual activation of delayed works Dominique Martinet <asmadeus(a)codewreck.org> kbuild: don't hardcode depmod path ------------- Diffstat: Makefile | 6 +- arch/x86/kernel/cpu/mtrr/generic.c | 6 +- arch/x86/kvm/mmu.h | 2 +- arch/x86/mm/pgtable.c | 2 + arch/x86/xen/efi.c | 12 ++-- arch/x86/xen/enlighten_pv.c | 2 +- arch/x86/xen/enlighten_pvh.c | 4 ++ arch/x86/xen/xen-ops.h | 4 +- crypto/ecdh.c | 3 +- drivers/atm/idt77252.c | 2 +- drivers/base/core.c | 2 +- drivers/bluetooth/hci_h5.c | 8 +-- drivers/ide/ide-atapi.c | 1 - drivers/ide/ide-io.c | 5 -- drivers/net/ethernet/broadcom/bcmsysport.c | 1 + drivers/net/ethernet/ethoc.c | 3 +- drivers/net/ethernet/freescale/ucc_geth.c | 3 +- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++ drivers/net/ethernet/intel/i40e/i40e.h | 3 + drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++++ drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 38 +++++++++++- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.h | 2 +- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 ++ drivers/net/ethernet/realtek/r8169.c | 6 +- drivers/net/ethernet/ti/cpts.c | 2 + drivers/net/tun.c | 2 +- drivers/net/usb/cdc_ncm.c | 3 - drivers/net/usb/qmi_wwan.c | 1 + drivers/net/virtio_net.c | 12 ++-- drivers/net/wan/hdlc_ppp.c | 7 +++ drivers/scsi/scsi_transport_spi.c | 27 ++++++--- drivers/scsi/ufs/ufshcd-pci.c | 34 ++++++++++- drivers/scsi/ufs/ufshcd.c | 2 +- drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +- drivers/usb/chipidea/ci_hdrc_imx.c | 6 +- drivers/usb/class/cdc-acm.c | 4 ++ drivers/usb/class/cdc-wdm.c | 16 ++++- drivers/usb/class/usblp.c | 21 ++++++- drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/ulpi.c | 2 +- drivers/usb/gadget/Kconfig | 2 + drivers/usb/gadget/composite.c | 10 +++- drivers/usb/gadget/configfs.c | 19 ++++-- drivers/usb/gadget/function/f_printer.c | 1 + drivers/usb/gadget/function/f_uac2.c | 69 +++++++++++++++++----- drivers/usb/gadget/function/u_ether.c | 9 +-- drivers/usb/gadget/legacy/acm_ms.c | 4 +- drivers/usb/host/xhci.c | 24 ++++---- drivers/usb/misc/yurex.c | 3 + drivers/usb/serial/iuu_phoenix.c | 20 +++++-- drivers/usb/serial/keyspan_pda.c | 2 - drivers/usb/serial/option.c | 3 + drivers/usb/storage/unusual_uas.h | 7 +++ drivers/usb/usbip/vhci_hcd.c | 2 + drivers/vhost/net.c | 6 +- drivers/video/fbdev/hyperv_fb.c | 6 +- fs/btrfs/send.c | 49 +++++++++------ fs/proc/generic.c | 55 +++++++++++------ fs/proc/internal.h | 7 +++ fs/proc/proc_net.c | 16 ----- include/linux/proc_fs.h | 8 ++- include/net/red.h | 4 +- kernel/workqueue.c | 13 +++- lib/genalloc.c | 25 ++++---- net/core/net-sysfs.c | 65 ++++++++++++++++---- net/dcb/dcbnl.c | 2 + net/ipv4/fib_frontend.c | 2 +- net/ipv4/gre_demux.c | 2 +- net/ipv4/netfilter/arp_tables.c | 2 +- net/ipv4/netfilter/ip_tables.c | 2 +- net/ipv6/netfilter/ip6_tables.c | 2 +- net/ncsi/ncsi-rsp.c | 2 +- net/netfilter/ipset/ip_set_hash_gen.h | 20 ++----- net/netfilter/xt_RATEEST.c | 3 + net/sched/sch_choke.c | 2 +- net/sched/sch_gred.c | 2 +- net/sched/sch_red.c | 2 +- net/sched/sch_sfq.c | 2 +- scripts/depmod.sh | 2 + sound/pci/hda/hda_intel.c | 2 - sound/pci/hda/patch_conexant.c | 1 + sound/pci/hda/patch_realtek.c | 6 ++ sound/pci/hda/patch_via.c | 13 ++++ sound/usb/midi.c | 4 ++ 86 files changed, 556 insertions(+), 230 deletions(-)

4 years, 7 months

9
87
0 0

stable-rc/queue/4.14 baseline: 148 runs, 6 regressions (v4.14.215-1-gbdd6da9c099fa)

by kernelci.org bot

stable-rc/queue/4.14 baseline: 148 runs, 6 regressions (v4.14.215-1-gbdd6da9c099fa) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 1 qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.14/kernel/v4.14.21… Test: baseline Tree: stable-rc Branch: queue/4.14 Describe: v4.14.215-1-gbdd6da9c099fa URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: bdd6da9c099fa41b822740b94b650800357d68e4 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ panda | arm | lab-collabora | gcc-8 | omap2plus_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff6afaa2ebfb6929c94cca Results: 3 PASS, 1 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.dmesg.emerg: https://kernelci.org/test/case/id/5fff6afaa2ebfb6929c94ccf new failure (last pass: v4.14.214-56-g995bc2469cc73) 2 lines 2021-01-13 21:49:42.453000+00:00 kern :emerg : BUG: spinlock bad magic on CPU#0, udevd/105 2021-01-13 21:49:42.463000+00:00 kern :emerg : lock: emif_lock+0x0/0xffffed34 [emif], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff67f989688710f1c94cdb Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.login: https://kernelci.org/test/case/id/5fff67f989688710f1c94cdc failing since 61 days (last pass: v4.14.206-21-g787a7a3ca16c, first fail: v4.14.206-22-ga949bf40fb01) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-broonie | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff681cd5b4e2f799c94cdf Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.login: https://kernelci.org/test/case/id/5fff681cd5b4e2f799c94ce0 failing since 61 days (last pass: v4.14.206-21-g787a7a3ca16c, first fail: v4.14.206-22-ga949bf40fb01) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff680b919b53b141c94cf9 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.login: https://kernelci.org/test/case/id/5fff680b919b53b141c94cfa failing since 61 days (last pass: v4.14.206-21-g787a7a3ca16c, first fail: v4.14.206-22-ga949bf40fb01) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff6c199c64223945c94cc5 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.login: https://kernelci.org/test/case/id/5fff6c199c64223945c94cc6 failing since 61 days (last pass: v4.14.206-21-g787a7a3ca16c, first fail: v4.14.206-22-ga949bf40fb01) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+-----------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-linaro-lkft | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/5fff67cb6f856b3e44c94cfd Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… HTML log: https://storage.kernelci.org//stable-rc/queue-4.14/v4.14.215-1-gbdd6da9c099… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-4-g97706c5d… * baseline.login: https://kernelci.org/test/case/id/5fff67cb6f856b3e44c94cfe failing since 61 days (last pass: v4.14.206-21-g787a7a3ca16c, first fail: v4.14.206-22-ga949bf40fb01)

4 years, 7 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror