- Linux-stable-mirror - lists.linaro.org

[PATCH net v2] vmxnet3: move rss code block under eop descriptor

by Ronak Doshi

Commit b3973bb40041 ("vmxnet3: set correct hash type based on rss information") added hashType information into skb. However, rssType field is populated for eop descriptor. This patch moves the RSS codeblock under eop descritor. Cc: stable(a)vger.kernel.org Fixes: b3973bb40041 ("vmxnet3: set correct hash type based on rss information") Signed-off-by: Ronak Doshi <doshir(a)vmware.com> Acked-by: Peng Li <lpeng(a)vmware.com> Acked-by: Guolin Yang <gyang(a)vmware.com> --- v1->v2: added Fixes tag and CC stable --- drivers/net/vmxnet3/vmxnet3_drv.c | 50 +++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 56267c327f0b..682987040ea8 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -1546,31 +1546,6 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, rxd->len = rbi->len; } -#ifdef VMXNET3_RSS - if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE && - (adapter->netdev->features & NETIF_F_RXHASH)) { - enum pkt_hash_types hash_type; - - switch (rcd->rssType) { - case VMXNET3_RCD_RSS_TYPE_IPV4: - case VMXNET3_RCD_RSS_TYPE_IPV6: - hash_type = PKT_HASH_TYPE_L3; - break; - case VMXNET3_RCD_RSS_TYPE_TCPIPV4: - case VMXNET3_RCD_RSS_TYPE_TCPIPV6: - case VMXNET3_RCD_RSS_TYPE_UDPIPV4: - case VMXNET3_RCD_RSS_TYPE_UDPIPV6: - hash_type = PKT_HASH_TYPE_L4; - break; - default: - hash_type = PKT_HASH_TYPE_L3; - break; - } - skb_set_hash(ctx->skb, - le32_to_cpu(rcd->rssHash), - hash_type); - } -#endif skb_record_rx_queue(ctx->skb, rq->qid); skb_put(ctx->skb, rcd->len); @@ -1653,6 +1628,31 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, u32 mtu = adapter->netdev->mtu; skb->len += skb->data_len; +#ifdef VMXNET3_RSS + if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE && + (adapter->netdev->features & NETIF_F_RXHASH)) { + enum pkt_hash_types hash_type; + + switch (rcd->rssType) { + case VMXNET3_RCD_RSS_TYPE_IPV4: + case VMXNET3_RCD_RSS_TYPE_IPV6: + hash_type = PKT_HASH_TYPE_L3; + break; + case VMXNET3_RCD_RSS_TYPE_TCPIPV4: + case VMXNET3_RCD_RSS_TYPE_TCPIPV6: + case VMXNET3_RCD_RSS_TYPE_UDPIPV4: + case VMXNET3_RCD_RSS_TYPE_UDPIPV6: + hash_type = PKT_HASH_TYPE_L4; + break; + default: + hash_type = PKT_HASH_TYPE_L3; + break; + } + skb_set_hash(skb, + le32_to_cpu(rcd->rssHash), + hash_type); + } +#endif vmxnet3_rx_csum(adapter, skb, (union Vmxnet3_GenericDesc *)rcd); skb->protocol = eth_type_trans(skb, adapter->netdev); -- 2.11.0

2 years, 9 months

1
0
0 0

[PATCH] randstruct: disable Clang 15 support

by Eric Biggers

From: Eric Biggers <ebiggers(a)google.com> The randstruct support released in Clang 15 is unsafe to use due to a bug that can cause miscompilations: "-frandomize-layout-seed inconsistently randomizes all-function-pointers structs" (https://github.com/llvm/llvm-project/issues/60349). It has been fixed on the Clang 16 release branch, so add a Clang version check. Fixes: 035f7f87b729 ("randstruct: Enable Clang support") Cc: stable(a)vger.kernel.org Signed-off-by: Eric Biggers <ebiggers(a)google.com> --- security/Kconfig.hardening | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening index 53baa95cb644f..0f295961e7736 100644 --- a/security/Kconfig.hardening +++ b/security/Kconfig.hardening @@ -281,6 +281,9 @@ endmenu config CC_HAS_RANDSTRUCT def_bool $(cc-option,-frandomize-layout-seed-file=/dev/null) + # Randstruct was first added in Clang 15, but it isn't safe to use until + # Clang 16 due to https://github.com/llvm/llvm-project/issues/60349 + depends on !CC_IS_CLANG || CLANG_VERSION >= 160000 choice prompt "Randomize layout of sensitive kernel structures" base-commit: 4ec5183ec48656cec489c49f989c508b68b518e3 -- 2.39.1

2 years, 9 months

5
4
0 0

[PATCH v3] usb: core: add quirk for Alcor Link AK9563 smartcard reader

by Mark Pearson

The Alcor Link AK9563 smartcard reader used on some Lenovo platforms doesn't work. If LPM is enabled the reader will provide an invalid usb config descriptor. Added quirk to disable LPM. Verified fix on Lenovo P16 G1 and T14 G3 Tested-by: Miroslav Zatko <mzatko(a)mirexoft.com> Tested-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Cc: stable(a)vger.kernel.org Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Signed-off-by: Mark Pearson <mpearson-lenovo(a)squebb.ca> --- Changes in v3: Send correct update that should have been in v2 Changes in v2: Put entry in correct position in quirks list. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 079e183cf3bf..934b3d997702 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -526,6 +526,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* DJI CineSSD */ { USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM }, + /* Alcor Link AK9563 SC Reader used in 2022 Lenovo ThinkPads */ + { USB_DEVICE(0x2ce3, 0x9563), .driver_info = USB_QUIRK_NO_LPM }, + /* DELL USB GEN2 */ { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM | USB_QUIRK_RESET_RESUME }, -- 2.39.1

2 years, 9 months

1
0
0 0

[PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader

by Mark Pearson

The Alcor Link AK9563 smartcard reader used on some Lenovo platforms doesn't work. If LPM is enabled the reader will provide an invalid usb config descriptor. Added quirk to disable LPM. Verified fix on Lenovo P16 G1 and T14 G3 Tested-by: Miroslav Zatko <mzatko(a)mirexoft.com> Tested-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Cc: stable(a)vger.kernel.org Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Signed-off-by: Mark Pearson <mpearson-lenovo(a)squebb.ca> --- Changes in v2: Put entry in correct position in quirks list. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 079e183cf3bf..9b1c56646ac5 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -535,6 +535,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Alcor Link AK9563 SC Reader used in 2022 Lenovo ThinkPads */ + { USB_DEVICE(0x2ce3, 0x9563), .driver_info = USB_QUIRK_NO_LPM }, + { } /* terminating entry must be last */ }; -- 2.39.1

2 years, 9 months

2
2
0 0

YOUR URGENT ATTENTION

by MS NADAGE LASSOU

Greetings. I am Ms Nadage lassou,I have something important to tell before is too late Thanks, i will send you the details once i hear from you. Regards. Ms Nadage Lassou

2 years, 9 months

1
0
0 0

[PATCH] usb: core: add quirk for Alcor Link AK9563 smartcard reader

by Mark Pearson

The Alcor Link AK9563 smartcard reader used on some Lenovo platforms doesn't work. If LPM is enabled the reader will provide an invalid usb config descriptor. Added quirk to disable LPM. Verified fix on Lenovo P16 G1 and T14 G3 Tested-by: Miroslav Zatko <mzatko(a)mirexoft.com> Tested-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Cc: stable(a)vger.kernel.org Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Signed-off-by: Mark Pearson <mpearson-lenovo(a)squebb.ca> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 079e183cf3bf..9b1c56646ac5 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -535,6 +535,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Alcor Link AK9563 SC Reader used in 2022 Lenovo ThinkPads */ + { USB_DEVICE(0x2ce3, 0x9563), .driver_info = USB_QUIRK_NO_LPM }, + { } /* terminating entry must be last */ }; -- 2.39.1

2 years, 9 months

2
2
0 0

[PATCH v2] iommu/vt-d: Fix PASID directory pointer coherency

by Jacob Pan

On platforms that do not support IOMMU Extended capability bit 0 Page-walk Coherency, CPU caches are not snooped when IOMMU is accessing any translation structures. IOMMU access goes only directly to memory. Intel IOMMU code was missing a flush for the PASID table directory that resulted in the unrecoverable fault as shown below. This patch adds clflush calls whenever activating and updating a PASID table directory to ensure cache coherency. On the reverse direction, there's no need to clflush the PASID directory pointer when we deactivate a context entry in that IOMMU hardware will not see the old PASID directory pointer after we clear the context entry. PASID directory entries are also never freed once allocated. [ 0.555386] DMAR: DRHD: handling fault status reg 3 [ 0.555805] DMAR: [DMA Read NO_PASID] Request device [00:0d.2] fault addr 0x1026a4000 [fault reason 0x51] SM: Present bit in Directory Entry is clear [ 0.556348] DMAR: Dump dmar1 table entries for IOVA 0x1026a4000 [ 0.556348] DMAR: scalable mode root entry: hi 0x0000000102448001, low 0x0000000101b3e001 [ 0.556348] DMAR: context entry: hi 0x0000000000000000, low 0x0000000101b4d401 [ 0.556348] DMAR: pasid dir entry: 0x0000000101b4e001 [ 0.556348] DMAR: pasid table entry[0]: 0x0000000000000109 [ 0.556348] DMAR: pasid table entry[1]: 0x0000000000000001 [ 0.556348] DMAR: pasid table entry[2]: 0x0000000000000000 [ 0.556348] DMAR: pasid table entry[3]: 0x0000000000000000 [ 0.556348] DMAR: pasid table entry[4]: 0x0000000000000000 [ 0.556348] DMAR: pasid table entry[5]: 0x0000000000000000 [ 0.556348] DMAR: pasid table entry[6]: 0x0000000000000000 [ 0.556348] DMAR: pasid table entry[7]: 0x0000000000000000 [ 0.556348] DMAR: PTE not present at level 4 Cc: <stable(a)vger.kernel.org> Fixes: 0bbeb01a4faf ("iommu/vt-d: Manage scalalble mode PASID tables") Reported-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Signed-off-by: Ashok Raj <ashok.raj(a)intel.com> Signed-off-by: Jacob Pan <jacob.jun.pan(a)linux.intel.com> --- v2: Add clflush to PASID directory update case (Baolu, Kevin review) --- drivers/iommu/intel/iommu.c | 2 ++ drivers/iommu/intel/pasid.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 59df7e42fd53..161342e7149d 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -1976,6 +1976,8 @@ static int domain_context_mapping_one(struct dmar_domain *domain, pds = context_get_sm_pds(table); context->lo = (u64)virt_to_phys(table->table) | context_pdts(pds); + if (!ecap_coherent(iommu->ecap)) + clflush_cache_range(table->table, sizeof(u64)); /* Setup the RID_PASID field: */ context_set_sm_rid2pasid(context, PASID_RID2PASID); diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c index fb3c7020028d..bcb2e6f23742 100644 --- a/drivers/iommu/intel/pasid.c +++ b/drivers/iommu/intel/pasid.c @@ -216,6 +216,8 @@ static struct pasid_entry *intel_pasid_get_entry(struct device *dev, u32 pasid) goto retry; } } + if (!ecap_coherent(info->iommu->ecap)) + clflush_cache_range(&dir[dir_index], sizeof(u64)); return &entries[index]; } -- 2.25.1

2 years, 9 months

2
2
0 0

Sveiciens jums,

by Sandrina Omaru

Sveiciens jums, Es izsaku to dziļā cieņā un pazemīgā padevībā. Es lūdzu izteikt dažas turpmākās rindiņas jūsu laipnai izskatīšanai. Es ceru, ka jūs veltīsit dažas vērtīgās minūtes, lai ar līdzjūtību izlasītu šo aicinājumu. Man jāatzīst, ka ar lielām cerībām, prieku un entuziasmu rakstu jums šo e-pasta ziņojumu, kuru zinu un ticībā ticu, ka tam noteikti jāatrod jūsu veselība. Es esmu Sandrina Omaru jaunkundze, nelaiķa Viljamsa Omaru meita. Pirms mana tēva nāves viņš man piezvanīja un informēja, ka viņam ir trīs miljoni sešsimt tūkstošu eiro. (3 600 000,00 eiro) viņš noguldīja privātā banka šeit, Abidžanas Kotdivuārā. Viņš man teica, ka noguldījis naudu uz mana vārda, kā arī iedeva visus nepieciešamos juridiskos dokumentus par šo noguldījumu bankā, esmu bakalaura un īsti nezinu, ko darīt. Tagad es vēlos godīgu un DIEVA baidošu partneri ārzemēs, kuram ar viņa palīdzību varētu pārskaitīt šo naudu un pēc darījuma es atbraukšu un pastāvīgi dzīvošu jūsu valstī līdz tikmēr, ka man būs ērti atgriezties mājās, ja es to darīšu. vēlme. Tas ir tāpēc, ka šeit, Kotdivuāras krastā, nemitīgās politiskās krīzes dēļ esmu daudz cietis. Lūdzu, apsveriet to un sazinieties ar mani pēc iespējas ātrāk. Nekavējoties apstiprināšu jūsu vēlmi, nosūtīšu jums savu attēlu, kā arī informēšu sīkāku informāciju par šo lietu. Ar cieņu, Sandrina Omaru jaunkundze

2 years, 9 months

1
0
0 0

[PATCH net 0/6] mptcp: fixes for v6.2

by Matthieu Baerts

Patch 1 clears resources earlier if there is no more reasons to keep MPTCP sockets alive. Patches 2 and 3 fix some locking issues visible in some rare corner cases: the linked issues should be quite hard to reproduce. Patch 4 makes sure subflows are correctly cleaned after the end of a connection. Patch 5 and 6 improve the selftests stability when running in a slow environment by transfering data for a longer period on one hand and by stopping the tests when all expected events have been observed on the other hand. All these patches fix issues introduced before v6.2. Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> --- Matthieu Baerts (1): selftests: mptcp: stop tests earlier Paolo Abeni (5): mptcp: do not wait for bare sockets' timeout mptcp: fix locking for setsockopt corner-case mptcp: fix locking for in-kernel listener creation mptcp: be careful on subflow status propagation on errors selftests: mptcp: allow more slack for slow test-case net/mptcp/pm_netlink.c | 10 ++++++---- net/mptcp/protocol.c | 9 +++++++++ net/mptcp/sockopt.c | 11 +++++++++-- net/mptcp/subflow.c | 12 ++++++++++-- tools/testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++++++++----- 5 files changed, 51 insertions(+), 13 deletions(-) --- base-commit: 811d581194f7412eda97acc03d17fc77824b561f change-id: 20230207-upstream-net-20230207-various-fix-6-2-1848a75bbbe6 Best regards, -- Matthieu Baerts <matthieu.baerts(a)tessares.net>

2 years, 9 months

2
7
0 0

[PATCH] randstruct: temporarily disable clang support

by Eric Biggers

From: Eric Biggers <ebiggers(a)google.com> Randstruct with clang is currently unsafe to use in any clang release that supports it, due to a clang bug that is causing miscompilations: "-frandomize-layout-seed inconsistently randomizes all-function-pointers structs" (https://github.com/llvm/llvm-project/issues/60349). Disable it temporarily until the bug is fixed and the fix is released in a clang version that can be checked for. Fixes: 035f7f87b729 ("randstruct: Enable Clang support") Cc: stable(a)vger.kernel.org Signed-off-by: Eric Biggers <ebiggers(a)google.com> --- security/Kconfig.hardening | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening index 53baa95cb644..aad16187148c 100644 --- a/security/Kconfig.hardening +++ b/security/Kconfig.hardening @@ -280,7 +280,8 @@ config ZERO_CALL_USED_REGS endmenu config CC_HAS_RANDSTRUCT - def_bool $(cc-option,-frandomize-layout-seed-file=/dev/null) + # Temporarily disabled due to https://github.com/llvm/llvm-project/issues/60349 + def_bool n choice prompt "Randomize layout of sensitive kernel structures" base-commit: 7b753a909f426f2789d9db6f357c3d59180a9354 -- 2.39.1

2 years, 9 months

4
4
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror