- Linux-stable-mirror - lists.linaro.org

[Linux-stable-mirror] BUG warnings in 4.14.9

by Chris Rankin

Hi, I've just raised https://bugzilla.kernel.org/show_bug.cgi?id=198271 because the new 4.14.9 kernel is generating lots of BUG warnings, e.g. [ 35.069924] BUG: using smp_processor_id() in preemptible [00000000] code: avahi-daemon/761 [ 35.078187] caller is ip6_pol_route+0x46b/0x509 [ipv6] [ 35.083340] CPU: 5 PID: 761 Comm: avahi-daemon Tainted: G I 4.14.9 #1 [ 35.091176] Hardware name: Gigabyte Technology Co., Ltd. EX58-UD3R/EX58-UD3R, BIOS FB 05/04/2009 [ 35.100181] Call Trace: [ 35.102709] dump_stack+0x46/0x59 [ 35.106095] check_preemption_disabled+0xca/0xda [ 35.110786] ip6_pol_route+0x46b/0x509 [ipv6] [ 35.115224] fib6_rule_lookup+0x15/0x4b [ipv6] [ 35.119745] ip6_dst_lookup_tail+0x11d/0x18f [ipv6] [ 35.124702] ip6_dst_lookup_flow+0x30/0x6f [ipv6] [ 35.129481] udpv6_sendmsg+0x5c5/0xa10 [ipv6] [ 35.133914] ? ip_reply_glue_bits+0x48/0x48 [ 35.138187] ? rw_copy_check_uvector+0x6d/0xf9 [ 35.142701] ? sock_sendmsg+0x28/0x34 [ 35.146393] sock_sendmsg+0x28/0x34 [ 35.149912] ___sys_sendmsg+0x1b4/0x246 [ 35.153821] ? poll_select_copy_remaining+0x104/0x104 [ 35.158995] ? current_time+0x11/0x52 [ 35.162738] ? pipe_write+0x353/0x365 [ 35.166483] ? __sys_sendmsg+0x3c/0x5d [ 35.170304] __sys_sendmsg+0x3c/0x5d [ 35.173909] do_syscall_64+0x4a/0xe1 [ 35.177482] entry_SYSCALL64_slow_path+0x25/0x25 [ 35.177484] RIP: 0033:0x7f963d7097b7 [ 35.177485] RSP: 002b:00007ffff7ffbd18 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 35.177486] RAX: ffffffffffffffda RBX: 000000000000000d RCX: 00007f963d7097b7 [ 35.177487] RDX: 0000000000000000 RSI: 00007ffff7ffbde0 RDI: 000000000000000d [ 35.177487] RBP: 0000000000000000 R08: 0000000000000001 R09: 00007ffff7ffbd42 [ 35.177488] R10: 0000000000000002 R11: 0000000000000246 R12: 00007ffff7ffbde0 [ 35.177489] R13: 000055e4e1af29cc R14: 000000000000000d R15: 0000000000000002 [ 35.177565] IN=eth0 OUT= MAC= SRC=fe80:0000:0000:0000:0224:1dff:fecd:0f3a DST=ff02:0000:0000:0000:0000:0000:0000:00fb LEN=245 TC=0 HOPLIMIT=255 FLOWLBL=147873 PROTO=UDP SPT=5353 DPT=5353 LEN=205 Cheers, Chris

7 years, 4 months

5
7
0 0

Re: [Linux-stable-mirror] [PATCH 4.14 015/159] bitops: Add clear/set_bit32() to linux/bitops.h

by Greg Kroah-Hartman

On Tue, Dec 26, 2017 at 09:41:36PM +0000, Ben Hutchings wrote: > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Andi Kleen <ak(a)linux.intel.com> > > > > commit cbe96375025e14fc76f9ed42ee5225120d7210f8 upstream. > > > > Add two simple wrappers around set_bit/clear_bit() that accept > > the common case of an u32 array. This avoids writing > > casts in all callers. > > These won't work correctly on big-endian 64-bit systems. They are also > unsafe to use on u32 arrays with an odd length, on 64-bit systems. > This is why lib/bitmap.c has conversion functions for u32 arrays. I end up deleteing these later in the patch series, just like upstream did, so all should be ok, right? thanks, greg k-h

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] Please apply commit 14c47b54b0d9 ("objtool: Fix 64-bit build on 32-bit host") on 4.14

by Sven Joachim

In 4.14.9, CONFIG_UNWINDER_ORC=y has been made the default on x86_64. Unfortunately, this option has turned out to be broken when building the kernel with a 32-bit userland. It has been fixed in 4.15-rc3 by commit 14c47b54b0d9 ("objtool: Fix 64-bit build on 32-bit host"). Could you please pick up that commit in the 4.14 series? Cheers, Sven

7 years, 4 months

2
1
0 0

[Linux-stable-mirror] v4.9.72 build: 0 failures 0 warnings (v4.9.72)

by Build bot for Mark Brown

Tree/Branch: v4.9.72 Git describe: v4.9.72 Commit: 2df3979310 Linux 4.9.72 Build Time: 100 min 59 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] v4.4.108 build: 0 failures 0 warnings (v4.4.108)

by Build bot for Mark Brown

Tree/Branch: v4.4.108 Git describe: v4.4.108 Commit: 03028e068a Linux 4.4.108 Build Time: 86 min 51 sec Passed: 9 / 9 (100.00 %) Failed: 0 / 9 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] v4.14.9 build: 0 failures 1 warnings (v4.14.9)

by Build bot for Mark Brown

Tree/Branch: v4.14.9 Git describe: v4.14.9 Commit: dad5c1402c Linux 4.14.9 Build Time: 118 min 56 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 1 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : x86_64-allnoconfig ------------------------------------------------------------------------------- Warnings Summary: 1 1 warning: objtool: x86 instruction decoder differs from kernel =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- x86_64-allnoconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: warning: objtool: x86 instruction decoder differs from kernel ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] Build failures in v4.1.y-stable-queue

by Guenter Roeck

Spread across multiple platforms and architectures. Guenter --- arch/arm/mach-omap2/omap-headsmp.S: Assembler messages: arch/arm/mach-omap2/omap-headsmp.S:60: Error: bad instruction `badr r0,hyp_boot' I seem to recall this. Most likely the patch introducing the 'badr' macro is missing. --- drivers/tty/serial/atmel_serial.c: In function 'atmel_flush_buffer': drivers/tty/serial/atmel_serial.c:1871:12: error: 'struct atmel_uart_port' has no member named 'tx_len' --- arch/arm64/kernel/hw_breakpoint.c: In function ‘watchpoint_handler’: arch/arm64/include/asm/uaccess.h:109:30: error: implicit declaration of function ‘sign_extend64’ Another dim recall. Another missing patch ? --- arch/mips/kernel/genex.S:219: Error: absolute expression required `li $9,_IRQ_STACK_SIZE' --- arch/mips/kernel/branch.c: In function '__compute_return_epc_for_insn': arch/mips/kernel/branch.c:509:5: error: label 'sigill_r2r6' used but not defined --- arch/mips/kernel/process.c: In function 'unwind_stack': arch/mips/kernel/process.c:558:3: error: implicit declaration of function 'on_irq_stack' arch/mips/kernel/process.c:559:32: error: 'irq_stack' undeclared --- arch/nios2/kernel/setup.c:198:2: error: implicit declaration of function ‘early_init_fdt_reserve_self’

7 years, 4 months

1
0
0 0

Re: [Linux-stable-mirror] [patch 1/4] timer: Use deferrable base independent of base::nohz_active

by Frederic Weisbecker

On Fri, Dec 22, 2017 at 03:51:12PM +0100, Thomas Gleixner wrote: > From: Anna-Maria Gleixner <anna-maria(a)linutronix.de> > > During boot and before base::nohz_active is set in the timer bases, deferrable > timers are enqueued into the standard timer base. This works correctly as > long as base::nohz_active is false. > > Once it base::nohz_active is set and a timer which was enqueued before that > is accessed the lock selector code choses the lock of the deferred > base. This causes unlocked access to the standard base and in case the > timer is removed it does not clear the pending flag in the standard base > bitmap which causes get_next_timer_interrupt() to return bogus values. > > To prevent that, the deferrable timers must be enqueued in the deferrable > base, even when base::nohz_active is not set. Those deferrable timers also > need to be expired unconditional. > > Fixes: 500462a9de65 ("timers: Switch to a non-cascading wheel") > Signed-off-by: Anna-Maria Gleixner <anna-maria(a)linutronix.de> > Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> > Cc: stable(a)vger.kernel.org > Cc: rt(a)linutronix.de Nice catch! Reviewed-by: Frederic Weisbecker <frederic(a)kernel.org> Thanks!

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] v3.18.90 build: 0 failures 1 warnings (v3.18.90)

by Build bot for Mark Brown

Tree/Branch: v3.18.90 Git describe: v3.18.90 Commit: 8da23652fa Linux 3.18.90 Build Time: 66 min 55 sec Passed: 9 / 9 (100.00 %) Failed: 0 / 9 ( 0.00 %) Errors: 0 Warnings: 1 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 2 warnings 0 mismatches : x86_64-defconfig ------------------------------------------------------------------------------- Warnings Summary: 1 2 ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- x86_64-defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] [PATCH] x86, nmi, dumpstack: Fix panic when syscall interruptted by nmi

by 王元良

While syscall got interrupted by NMI, it is possible to get userspace stack pointer if the esp/rsp register is not switched by syscall entry handler. In that case, show_stack_log_lvl did not judge the situation, kernel panic could occurr by the stack dump code. PID: 1538 TASK: ffff882f68d13240 CPU: 31 COMMAND: "syslog-ng" [exception RIP: show_stack_log_lvl+265] RIP: ffffffff81017579 RSP: ffff882fbf1e5da8 RFLAGS: 00010046 RAX: 00007ffe9c495f10 RBX: 00007ffe9c495f08 RCX: 0000000000000000 RDX: ffff882fbf1e3fc0 RSI: ffff882fbf1e5ef8 RDI: 0000000000000000 RBP: ffff882fbf1e5df8 R8: ffff882fbf1dffc0 R9: ffffffff81d073d2 R10: 00000000000ab840 R11: 0000000000100000 R12: ffff882fbf1e5ef8 R13: 0000000000000000 R14: ffffffff8185286e R15: 0000000000000000 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 [exception RIP: system_call] RIP: ffffffff81647950 RSP: 00007ffe9c495f08 RFLAGS: 00000046 RAX: 00000000000000e8 RBX: 0000000000625400 RCX: 00007fc072cd62a3 RDX: 0000000000000009 RSI: 00007ffe9c495f10 RDI: 0000000000000004 RBP: 00007ffe9c495fd0 R8: 000000000000b0ee R9: 000000000000b0f1 R10: 0000000000000c4e R11: 0000000000000246 R12: 0000000000625458 R13: 0000000000625450 R14: 00007ffe9c495fe0 R15: 00007ffe9c496020 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 --- --- RIP: 00007fc072cd626a RSP: 00007ffe9c495f70 RFLAGS: 00000293 RAX: 0000000000000000 RBX: ffffffff816479c9 RCX: 0000000000000010 RDX: 0000000000000007 RSI: 0000000000000001 RDI: 0000000000000004 RBP: 00007ffe9c495fd0 R8: 000000000000b0ee R9: 000000000000b0f1 R10: 00007ffe9c495ec0 R11: 0000000000000246 R12: 00007ffe9c496020 R13: 00007ffe9c495ec0 R14: 0000000000625450 R15: 0000000000000001 ORIG_RAX: 00000000000000e9 CS: 0033 SS: 002b Add to judge this scenario in show_stack_log_lvl. Signed-off-by: Yuanliang Wang <yuanliang.wyl(a)alibaba-inc.com> --- arch/x86/kernel/dumpstack_32.c | 10 +++++++++- arch/x86/kernel/dumpstack_64.c | 10 +++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c index f2a1770..8a1264e 100644 --- a/arch/x86/kernel/dumpstack_32.c +++ b/arch/x86/kernel/dumpstack_32.c @@ -60,6 +60,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs, { unsigned long *stack; int i; + unsigned long s; if (sp == NULL) { if (task) @@ -74,7 +75,14 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs, break; if (i && ((i % STACKSLOTS_PER_LINE) == 0)) pr_cont("\n"); - pr_cont(" %08lx", *stack++); + if (stack < (unsigned long *)PAGE_OFFSET + || probe_kernel_address(stack, s)) { + printk_once(KERN_ERR "sp %p is user space addr\n", + stack); + pr_cont(" %016lx", s); + stack++; + } else + pr_cont(" %08lx", *stack++); touch_nmi_watchdog(); } pr_cont("\n"); diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c index addb207..4446ebc 100644 --- a/arch/x86/kernel/dumpstack_64.c +++ b/arch/x86/kernel/dumpstack_64.c @@ -203,6 +203,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs, unsigned long *irq_stack_end; unsigned long *irq_stack; unsigned long *stack; + unsigned long s; int cpu; int i; @@ -236,7 +237,14 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs, } if (i && ((i % STACKSLOTS_PER_LINE) == 0)) pr_cont("\n"); - pr_cont(" %016lx", *stack++); + if (stack < (unsigned long *)PAGE_OFFSET + || probe_kernel_address(stack, s)) { + printk_once(KERN_ERR "sp %p is user space addr\n", + stack); + pr_cont(" %016lx", s); + stack++; + } else + pr_cont(" %016lx", *stack++); touch_nmi_watchdog(); } preempt_enable(); -- 1.8.3.1

7 years, 4 months

2
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror