- Linux-stable-mirror - lists.linaro.org

Patch "i40iw: Allocate a sdbuf per CQP WQE" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled i40iw: Allocate a sdbuf per CQP WQE to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: i40iw-allocate-a-sdbuf-per-cqp-wqe.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Chien Tin Tung <chien.tin.tung(a)intel.com> Date: Tue, 21 Nov 2017 16:18:30 -0600 Subject: i40iw: Allocate a sdbuf per CQP WQE From: Chien Tin Tung <chien.tin.tung(a)intel.com> [ Upstream commit 100d6de2ced538c539d923dc14a1b5cbae234503 ] Currently there is only one sdbuf per Control QP (CQP) for programming Segment Descriptor (SD). If multiple SD work requests are posted simultaneously, the sdbuf is reused by all WQEs and new WQEs can corrupt previous WQEs sdbuf leading to incorrect SD programming. Fix this by allocating one sdbuf per CQP SQ WQE. When an SD command is posted, it will use the corresponding sdbuf for the WQE. Fixes: 86dbcd0f12e9 ("i40iw: add file to handle cqp calls") Signed-off-by: Chien Tin Tung <chien.tin.tung(a)intel.com> Signed-off-by: Shiraz Saleem <shiraz.saleem(a)intel.com> Signed-off-by: Jason Gunthorpe <jgg(a)mellanox.com> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 43 +++++++++++++++++++++---------- drivers/infiniband/hw/i40iw/i40iw_d.h | 4 ++ 2 files changed, 33 insertions(+), 14 deletions(-) --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c @@ -506,7 +506,7 @@ static enum i40iw_status_code i40iw_sc_c ret_code = i40iw_allocate_dma_mem(cqp->dev->hw, &cqp->sdbuf, - 128, + I40IW_UPDATE_SD_BUF_SIZE * cqp->sq_size, I40IW_SD_BUF_ALIGNMENT); if (ret_code) @@ -589,14 +589,15 @@ void i40iw_sc_cqp_post_sq(struct i40iw_s } /** - * i40iw_sc_cqp_get_next_send_wqe - get next wqe on cqp sq - * @cqp: struct for cqp hw - * @wqe_idx: we index of cqp ring + * i40iw_sc_cqp_get_next_send_wqe_idx - get next WQE on CQP SQ and pass back the index + * @cqp: pointer to CQP structure + * @scratch: private data for CQP WQE + * @wqe_idx: WQE index for next WQE on CQP SQ */ -u64 *i40iw_sc_cqp_get_next_send_wqe(struct i40iw_sc_cqp *cqp, u64 scratch) +static u64 *i40iw_sc_cqp_get_next_send_wqe_idx(struct i40iw_sc_cqp *cqp, + u64 scratch, u32 *wqe_idx) { u64 *wqe = NULL; - u32 wqe_idx; enum i40iw_status_code ret_code; if (I40IW_RING_FULL_ERR(cqp->sq_ring)) { @@ -609,21 +610,33 @@ u64 *i40iw_sc_cqp_get_next_send_wqe(stru cqp->sq_ring.size); return NULL; } - I40IW_ATOMIC_RING_MOVE_HEAD(cqp->sq_ring, wqe_idx, ret_code); + I40IW_ATOMIC_RING_MOVE_HEAD(cqp->sq_ring, *wqe_idx, ret_code); cqp->dev->cqp_cmd_stats[OP_REQUESTED_COMMANDS]++; if (ret_code) return NULL; - if (!wqe_idx) + if (!*wqe_idx) cqp->polarity = !cqp->polarity; - wqe = cqp->sq_base[wqe_idx].elem; - cqp->scratch_array[wqe_idx] = scratch; + wqe = cqp->sq_base[*wqe_idx].elem; + cqp->scratch_array[*wqe_idx] = scratch; I40IW_CQP_INIT_WQE(wqe); return wqe; } /** + * i40iw_sc_cqp_get_next_send_wqe - get next wqe on cqp sq + * @cqp: struct for cqp hw + * @scratch: private data for CQP WQE + */ +u64 *i40iw_sc_cqp_get_next_send_wqe(struct i40iw_sc_cqp *cqp, u64 scratch) +{ + u32 wqe_idx; + + return i40iw_sc_cqp_get_next_send_wqe_idx(cqp, scratch, &wqe_idx); +} + +/** * i40iw_sc_cqp_destroy - destroy cqp during close * @cqp: struct for cqp hw */ @@ -3534,8 +3547,10 @@ static enum i40iw_status_code cqp_sds_wq u64 *wqe; int mem_entries, wqe_entries; struct i40iw_dma_mem *sdbuf = &cqp->sdbuf; + u64 offset; + u32 wqe_idx; - wqe = i40iw_sc_cqp_get_next_send_wqe(cqp, scratch); + wqe = i40iw_sc_cqp_get_next_send_wqe_idx(cqp, scratch, &wqe_idx); if (!wqe) return I40IW_ERR_RING_FULL; @@ -3548,8 +3563,10 @@ static enum i40iw_status_code cqp_sds_wq LS_64(mem_entries, I40IW_CQPSQ_UPESD_ENTRY_COUNT); if (mem_entries) { - memcpy(sdbuf->va, &info->entry[3], (mem_entries << 4)); - data = sdbuf->pa; + offset = wqe_idx * I40IW_UPDATE_SD_BUF_SIZE; + memcpy((char *)sdbuf->va + offset, &info->entry[3], + mem_entries << 4); + data = (u64)sdbuf->pa + offset; } else { data = 0; } --- a/drivers/infiniband/hw/i40iw/i40iw_d.h +++ b/drivers/infiniband/hw/i40iw/i40iw_d.h @@ -1516,7 +1516,7 @@ enum i40iw_alignment { I40IW_AEQ_ALIGNMENT = 0x100, I40IW_CEQ_ALIGNMENT = 0x100, I40IW_CQ0_ALIGNMENT = 0x100, - I40IW_SD_BUF_ALIGNMENT = 0x100 + I40IW_SD_BUF_ALIGNMENT = 0x80 }; #define I40IW_WQE_SIZE_64 64 @@ -1524,6 +1524,8 @@ enum i40iw_alignment { #define I40IW_QP_WQE_MIN_SIZE 32 #define I40IW_QP_WQE_MAX_SIZE 128 +#define I40IW_UPDATE_SD_BUF_SIZE 128 + #define I40IW_CQE_QTYPE_RQ 0 #define I40IW_CQE_QTYPE_SQ 1 Patches currently in stable-queue which might be from chien.tin.tung(a)intel.com are queue-4.14/i40iw-allocate-a-sdbuf-per-cqp-wqe.patch

7 years, 4 months

1
0
0 0

Patch "hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: hippi-fix-a-fix-a-possible-sleep-in-atomic-bug-in-rr_close.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Jia-Ju Bai <baijiaju1990(a)163.com> Date: Tue, 12 Dec 2017 16:49:52 +0800 Subject: hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close From: Jia-Ju Bai <baijiaju1990(a)163.com> [ Upstream commit 6e266610eb6553cfb7e7eb5d11914bd01509c406 ] The driver may sleep under a spinlock. The function call path is: rr_close (acquire the spinlock) free_irq --> may sleep To fix it, free_irq is moved to the place without holding the spinlock. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia-Ju Bai <baijiaju1990(a)163.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/hippi/rrunner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c @@ -1381,8 +1381,8 @@ static int rr_close(struct net_device *d rrpriv->info_dma); rrpriv->info = NULL; - free_irq(pdev->irq, dev); spin_unlock_irqrestore(&rrpriv->lock, flags); + free_irq(pdev->irq, dev); return 0; } Patches currently in stable-queue which might be from baijiaju1990(a)163.com are queue-4.14/hippi-fix-a-fix-a-possible-sleep-in-atomic-bug-in-rr_close.patch

7 years, 4 months

1
0
0 0

Patch "gpio: davinci: Assign first bank regs for unbanked case" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled gpio: davinci: Assign first bank regs for unbanked case to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: gpio-davinci-assign-first-bank-regs-for-unbanked-case.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Keerthy <j-keerthy(a)ti.com> Date: Fri, 10 Nov 2017 16:43:17 +0530 Subject: gpio: davinci: Assign first bank regs for unbanked case From: Keerthy <j-keerthy(a)ti.com> [ Upstream commit 7f8e2a85c1b0bd440ffe87be82c79fdc319e8291 ] As per the re-design assign the first bank regs for unbanked irq case. This was missed out in the original patch. Signed-off-by: Keerthy <j-keerthy(a)ti.com> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct u32 mask; d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data); - g = (struct davinci_gpio_regs __iomem *)d->regs; + g = (struct davinci_gpio_regs __iomem *)d->regs[0]; mask = __gpio_mask(data->irq - d->base_irq); if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)) Patches currently in stable-queue which might be from j-keerthy(a)ti.com are queue-4.14/gpio-davinci-assign-first-bank-regs-for-unbanked-case.patch queue-4.14/arm-am33xx-prm-remove-am33xx_pwrdm_read_prev_pwrst-function.patch

7 years, 4 months

1
0
0 0

Patch "gpio: 74x164: Fix crash during .remove()" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled gpio: 74x164: Fix crash during .remove() to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: gpio-74x164-fix-crash-during-.remove.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Geert Uytterhoeven <geert+renesas(a)glider.be> Date: Tue, 21 Nov 2017 15:18:10 +0100 Subject: gpio: 74x164: Fix crash during .remove() From: Geert Uytterhoeven <geert+renesas(a)glider.be> [ Upstream commit a158531f3c92467df0e93e000d58185acae78a6e ] Commit 7ebc194d0fd4bb0f ("gpio: 74x164: Introduce 'enable-gpios' property") added a new member gpiod_oe to the end of the struct gen_74x164_chip, after the zero-length buffer array. However, this buffer is a flexible array, allocated together with the structure during .probe(). As the buffer is no longer the last member, writing to it corrupts the newly added member after it. During device removal, the corrupted member will be used as a pointer, leading to a crash. This went unnoticed, as the flexible array was declared as "buffer[0]" instead of "buffer[]", and thus did not trigger a "flexible array member not at end of struct" error from gcc. Move the gpiod_oe field up to fix this, and drop the zero from the array size to prevent future similar bugs. Fixes: 7ebc194d0fd4bb0f ("gpio: 74x164: Introduce 'enable-gpios' property") Signed-off-by: Geert Uytterhoeven <geert+renesas(a)glider.be> Reviewed-by: Fabio Estevam <fabio.estevam(a)nxp.com> Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpio/gpio-74x164.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpio-74x164.c +++ b/drivers/gpio/gpio-74x164.c @@ -23,6 +23,7 @@ struct gen_74x164_chip { struct gpio_chip gpio_chip; struct mutex lock; + struct gpio_desc *gpiod_oe; u32 registers; /* * Since the registers are chained, every byte sent will make @@ -31,8 +32,7 @@ struct gen_74x164_chip { * register at the end of the transfer. So, to have a logical * numbering, store the bytes in reverse order. */ - u8 buffer[0]; - struct gpio_desc *gpiod_oe; + u8 buffer[]; }; static int __gen_74x164_write_config(struct gen_74x164_chip *chip) Patches currently in stable-queue which might be from geert+renesas(a)glider.be are queue-4.14/gpio-74x164-fix-crash-during-.remove.patch queue-4.14/pci-rcar-fix-use-after-free-in-probe-error-path.patch

7 years, 4 months

1
0
0 0

Patch "gianfar: fix a flooded alignment reports because of padding issue." has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled gianfar: fix a flooded alignment reports because of padding issue. to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: gianfar-fix-a-flooded-alignment-reports-because-of-padding-issue.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Zumeng Chen <zumeng.chen(a)gmail.com> Date: Mon, 4 Dec 2017 11:22:02 +0800 Subject: gianfar: fix a flooded alignment reports because of padding issue. From: Zumeng Chen <zumeng.chen(a)gmail.com> [ Upstream commit 58117672943734715bbe7565ac9f062effa524f0 ] According to LS1021A RM, the value of PAL can be set so that the start of the IP header in the receive data buffer is aligned to a 32-bit boundary. Normally, setting PAL = 2 provides minimal padding to ensure such alignment of the IP header. However every incoming packet's 8-byte time stamp will be inserted into the packet data buffer as padding alignment bytes when hardware time stamping is enabled. So we set the padding 8+2 here to avoid the flooded alignment faults: root@128:~# cat /proc/cpu/alignment User: 0 System: 17539 (inet_gro_receive+0x114/0x2c0) Skipped: 0 Half: 0 Word: 0 DWord: 0 Multi: 17539 User faults: 2 (fixup) Also shown when exception report enablement CPU: 0 PID: 161 Comm: irq/66-eth1_g0_ Not tainted 4.1.21-rt13-WR8.0.0.0_preempt-rt #16 Hardware name: Freescale LS1021A [<8001b420>] (unwind_backtrace) from [<8001476c>] (show_stack+0x20/0x24) [<8001476c>] (show_stack) from [<807cfb48>] (dump_stack+0x94/0xac) [<807cfb48>] (dump_stack) from [<80025d70>] (do_alignment+0x720/0x958) [<80025d70>] (do_alignment) from [<80009224>] (do_DataAbort+0x40/0xbc) [<80009224>] (do_DataAbort) from [<80015398>] (__dabt_svc+0x38/0x60) Exception stack(0x86ad1cc0 to 0x86ad1d08) 1cc0: f9b3e080 86b3d072 2d78d287 00000000 866816c0 86b3d05e 86e785d0 00000000 1ce0: 00000011 0000000e 80840ab0 86ad1d3c 86ad1d08 86ad1d08 806d7fc0 806d806c 1d00: 40070013 ffffffff [<80015398>] (__dabt_svc) from [<806d806c>] (inet_gro_receive+0x114/0x2c0) [<806d806c>] (inet_gro_receive) from [<80660eec>] (dev_gro_receive+0x21c/0x3c0) [<80660eec>] (dev_gro_receive) from [<8066133c>] (napi_gro_receive+0x44/0x17c) [<8066133c>] (napi_gro_receive) from [<804f0538>] (gfar_clean_rx_ring+0x39c/0x7d4) [<804f0538>] (gfar_clean_rx_ring) from [<804f0bf4>] (gfar_poll_rx_sq+0x58/0xe0) [<804f0bf4>] (gfar_poll_rx_sq) from [<80660b10>] (net_rx_action+0x27c/0x43c) [<80660b10>] (net_rx_action) from [<80033638>] (do_current_softirqs+0x1e0/0x3dc) [<80033638>] (do_current_softirqs) from [<800338c4>] (__local_bh_enable+0x90/0xa8) [<800338c4>] (__local_bh_enable) from [<8008025c>] (irq_forced_thread_fn+0x70/0x84) [<8008025c>] (irq_forced_thread_fn) from [<800805e8>] (irq_thread+0x16c/0x244) [<800805e8>] (irq_thread) from [<8004e490>] (kthread+0xe8/0x104) [<8004e490>] (kthread) from [<8000fda8>] (ret_from_fork+0x14/0x2c) Signed-off-by: Zumeng Chen <zumeng.chen(a)gmail.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/ethernet/freescale/gianfar.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1378,9 +1378,11 @@ static int gfar_probe(struct platform_de gfar_init_addr_hash_table(priv); - /* Insert receive time stamps into padding alignment bytes */ + /* Insert receive time stamps into padding alignment bytes, and + * plus 2 bytes padding to ensure the cpu alignment. + */ if (priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER) - priv->padding = 8; + priv->padding = 8 + DEFAULT_PADDING; if (dev->features & NETIF_F_IP_CSUM || priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER) Patches currently in stable-queue which might be from zumeng.chen(a)gmail.com are queue-4.14/gianfar-fix-a-flooded-alignment-reports-because-of-padding-issue.patch

7 years, 4 months

1
0
0 0

Patch "gianfar: Disable EEE autoneg by default" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled gianfar: Disable EEE autoneg by default to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: gianfar-disable-eee-autoneg-by-default.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Claudiu Manoil <claudiu.manoil(a)nxp.com> Date: Thu, 7 Dec 2017 18:44:23 +0200 Subject: gianfar: Disable EEE autoneg by default From: Claudiu Manoil <claudiu.manoil(a)nxp.com> [ Upstream commit b6b5e8a691185606dfffff3198c89e3b4fd9d4f6 ] This controller does not support EEE, but it may connect to a PHY which supports EEE and advertises EEE by default, while its link partner also advertises EEE. If this happens, the PHY enters low power mode when the traffic rate is low and causes packet loss. This patch disables EEE advertisement by default for any PHY that gianfar connects to, to prevent the above unwanted outcome. Signed-off-by: Shaohui Xie <Shaohui.Xie(a)nxp.com> Tested-by: Yangbo Lu <Yangbo.lu(a)nxp.com> Signed-off-by: Claudiu Manoil <claudiu.manoil(a)nxp.com> Reviewed-by: Andrew Lunn <andrew(a)lunn.ch> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/net/ethernet/freescale/gianfar.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1792,6 +1792,7 @@ static int init_phy(struct net_device *d GFAR_SUPPORTED_GBIT : 0; phy_interface_t interface; struct phy_device *phydev; + struct ethtool_eee edata; priv->oldlink = 0; priv->oldspeed = 0; @@ -1816,6 +1817,10 @@ static int init_phy(struct net_device *d /* Add support for flow control, but don't advertise it by default */ phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); + /* disable EEE autoneg, EEE not supported by eTSEC */ + memset(&edata, 0, sizeof(struct ethtool_eee)); + phy_ethtool_set_eee(phydev, &edata); + return 0; } Patches currently in stable-queue which might be from claudiu.manoil(a)nxp.com are queue-4.14/gianfar-disable-eee-autoneg-by-default.patch

7 years, 4 months

1
0
0 0

Patch "drm/vc4: Release fence after signalling" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled drm/vc4: Release fence after signalling to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: drm-vc4-release-fence-after-signalling.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Stefan Schake <stschake(a)gmail.com> Date: Sat, 2 Dec 2017 18:40:39 +0100 Subject: drm/vc4: Release fence after signalling From: Stefan Schake <stschake(a)gmail.com> [ Upstream commit babc8110057cb9ca542c3c1666cbda4e8ccf9250 ] We were never releasing the initial fence reference that is obtained through dma_fence_init. Link: https://github.com/anholt/linux/issues/122 Fixes: cdec4d361323 ("drm/vc4: Expose dma-buf fences for V3D rendering.") Signed-off-by: Stefan Schake <stschake(a)gmail.com> Signed-off-by: Eric Anholt <eric(a)anholt.net> Reviewed-by: Eric Anholt <eric(a)anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/1512236444-301-1-git-send-ema… Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/vc4/vc4_gem.c | 4 +++- drivers/gpu/drm/vc4/vc4_irq.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -829,8 +829,10 @@ vc4_complete_exec(struct drm_device *dev /* If we got force-completed because of GPU reset rather than * through our IRQ handler, signal the fence now. */ - if (exec->fence) + if (exec->fence) { dma_fence_signal(exec->fence); + dma_fence_put(exec->fence); + } if (exec->bo) { for (i = 0; i < exec->bo_count; i++) --- a/drivers/gpu/drm/vc4/vc4_irq.c +++ b/drivers/gpu/drm/vc4/vc4_irq.c @@ -139,6 +139,7 @@ vc4_irq_finish_render_job(struct drm_dev list_move_tail(&exec->head, &vc4->job_done_list); if (exec->fence) { dma_fence_signal_locked(exec->fence); + dma_fence_put(exec->fence); exec->fence = NULL; } vc4_submit_next_render_job(dev); Patches currently in stable-queue which might be from stschake(a)gmail.com are queue-4.14/drm-vc4-release-fence-after-signalling.patch

7 years, 4 months

1
0
0 0

Patch "drm/armada: fix leak of crtc structure" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled drm/armada: fix leak of crtc structure to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: drm-armada-fix-leak-of-crtc-structure.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Russell King <rmk+kernel(a)armlinux.org.uk> Date: Fri, 8 Dec 2017 12:16:22 +0000 Subject: drm/armada: fix leak of crtc structure From: Russell King <rmk+kernel(a)armlinux.org.uk> [ Upstream commit 33cd3c07a976e11c3c4cc6b0b3db6760ad1590c5 ] Fix the leak of the CRTC structure in the failure paths of armada_drm_crtc_create(). Signed-off-by: Russell King <rmk+kernel(a)armlinux.org.uk> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/armada/armada_crtc.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) --- a/drivers/gpu/drm/armada/armada_crtc.c +++ b/drivers/gpu/drm/armada/armada_crtc.c @@ -1225,17 +1225,13 @@ static int armada_drm_crtc_create(struct ret = devm_request_irq(dev, irq, armada_drm_irq, 0, "armada_drm_crtc", dcrtc); - if (ret < 0) { - kfree(dcrtc); - return ret; - } + if (ret < 0) + goto err_crtc; if (dcrtc->variant->init) { ret = dcrtc->variant->init(dcrtc, dev); - if (ret) { - kfree(dcrtc); - return ret; - } + if (ret) + goto err_crtc; } /* Ensure AXI pipeline is enabled */ @@ -1246,13 +1242,15 @@ static int armada_drm_crtc_create(struct dcrtc->crtc.port = port; primary = kzalloc(sizeof(*primary), GFP_KERNEL); - if (!primary) - return -ENOMEM; + if (!primary) { + ret = -ENOMEM; + goto err_crtc; + } ret = armada_drm_plane_init(primary); if (ret) { kfree(primary); - return ret; + goto err_crtc; } ret = drm_universal_plane_init(drm, &primary->base, 0, @@ -1263,7 +1261,7 @@ static int armada_drm_crtc_create(struct DRM_PLANE_TYPE_PRIMARY, NULL); if (ret) { kfree(primary); - return ret; + goto err_crtc; } ret = drm_crtc_init_with_planes(drm, &dcrtc->crtc, &primary->base, NULL, @@ -1282,6 +1280,9 @@ static int armada_drm_crtc_create(struct err_crtc_init: primary->base.funcs->destroy(&primary->base); +err_crtc: + kfree(dcrtc); + return ret; } Patches currently in stable-queue which might be from rmk+kernel(a)armlinux.org.uk are queue-4.14/sfp-fix-rx_los-signal-handling.patch queue-4.14/drm-armada-fix-leak-of-crtc-structure.patch queue-4.14/arm-8743-1-bl_switcher-add-module_license-tag.patch queue-4.14/phylink-ensure-we-take-the-link-down-when-phylink_stop-is-called.patch

7 years, 4 months

1
0
0 0

[Linux-stable-mirror] [GIT PULL] commits for Linux 4.14

by Sasha Levin

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Greg, Pleae pull commits for Linux 4.14 . I've sent a review request for all commits over a week ago and all comments were addressed. Thanks, Sasha ===== The following changes since commit 0146985addc322ca518d27fecfe98ae5acda7c1e: Linux 4.14.17 (2018-02-03 17:39:25 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-4.14-04022018 for you to fetch changes up to 0f45bcb0408641cd67f098d5b3f15572f3fb578b: hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close (2018-02-04 10:57:17 -0500) - ---------------------------------------------------------------- for-greg-4.14-04022018 - ---------------------------------------------------------------- Adam Ford (2): ARM: dts: logicpd-som-lv: Fix gpmc addresses for NAND and enet ARM: dts: logicpd-somlv: Fix wl127x pinmux Andi Kleen (1): perf record: Fix -c/-F options for cpu event aliases Andre Przywara (2): pinctrl: sunxi: Fix A80 interrupt pin bank pinctrl: sunxi: Fix A64 UART mux value Andreas Platschek (1): usb: dwc3: of-simple: fix missing clk_disable_unprepare Andrew Lunn (2): net: dsa: mv88e6xxx: Fix interrupt masking on removal net: dsa: mv88e6xxx: Unregister MDIO bus on error path Andy Shevchenko (3): pinctrl: denverton: Fix UART2 RTS pin mode iio: proximity: sx9500: Assign interrupt from GpioIo() brcmfmac: Avoid build error with make W=1 Anju T Sudhakar (1): powerpc/perf/imc: Fix nest-imc cpuhotplug callback failure Ard Biesheuvel (1): kvm: arm: don't treat unavailable HYP mode as an error Arnaud Patard (1): meson-gx-socinfo: Fix package id parsing Aviv Heller (1): xfrm: Fix xfrm_input() to verify state is valid when (encap_type < 0) Branislav Radocaj (1): net: ethernet: arc: fix error handling in emac_rockchip_probe Cai Li (1): clk: fix a panic error caused by accessing NULL pointer Chien Tin Tung (1): i40iw: Allocate a sdbuf per CQP WQE Christophe JAILLET (1): dmaengine: ioat: Fix error handling path Claudiu Manoil (1): gianfar: Disable EEE autoneg by default Dan Carpenter (2): scsi: lpfc: Use after free in lpfc_rq_buf_free() staging: ccree: Uninitialized return in ssi_ahash_import() Dave Young (1): mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep Dennis Dalessandro (1): IB/hfi1: Initialize bth1 in 16B rc ack builder Dmitry Monakhov (1): IB/core: Init subsys if compiled to vmlinuz-core Eric Biggers (1): 509: fix printing uninitialized stack memory when OID is empty Gao Feng (1): ipvlan: Add the skb->mark as flow4's member to lookup route Geert Uytterhoeven (2): gpio: 74x164: Fix crash during .remove() PCI: rcar: Fix use-after-free in probe error path Greg Ungerer (1): m68k: add missing SOFTIRQENTRY_TEXT linker section Gustavo A. R. Silva (1): dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Guy Levi (1): IB/mlx4: Fix RSS hash fields restrictions Jan Beulich (1): xen: XEN_ACPI_PROCESSOR is Dom0-only Jann Horn (1): netfilter: xt_bpf: add overflow checks Jia-Ju Bai (1): hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close Jiada Wang (1): ASoC: rsnd: ssi: fix race condition in rsnd_ssi_pointer_update Jim Mattson (1): KVM: VMX: fix page leak in hardware_setup() Jiri Olsa (2): perf: Fix header.size for namespace events perf top: Fix window dimensions change handling Johan Hovold (1): serdev: fix receive_buf return value when no callback Johannes Thumshirn (1): scsi: bfa: fix access to bfad_im_port_s Justin Maggard (1): btrfs: Fix quota reservation leak on preallocated files Karol Herbst (1): x86/mm/kmmio: Fix mmiotrace for page unaligned addresses Keerthy (2): ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function gpio: davinci: Assign first bank regs for unbanked case Leon Romanovsky (1): RDMA/netlink: Fix general protection fault Marc Zyngier (1): KVM: arm/arm64: Fix spinlock acquisition in vgic_set_owner Mauro Carvalho Chehab (1): media: s5k6aa: describe some function parameters Michael S. Tsirkin (1): s390/virtio: add BSD license to virtio-ccw Mohamed Ghannam (1): dccp: CVE-2017-8824: use-after-free in DCCP code Moni Shoua (1): RDMA/cma: Make sure that PSN is not over max allowed Mustafa Ismail (2): i40iw: Do not free sqbuf when event is I40IW_TIMER_TYPE_CLOSE i40iw: Correct ARP index mask Namhyung Kim (1): perf help: Fix a bug during strstart() conversion Nikolay Borisov (1): btrfs: Fix possible off-by-one in btrfs_search_path_in_tree Nogah Frankel (2): net_sched: red: Avoid devision by zero net_sched: red: Avoid illegal values Omar Sandoval (2): sched/wait: Fix add_wait_queue() behavioral change Btrfs: disable FUA if mounted with nobarrier Pali RohÃ¡r (1): platform/x86: dell-laptop: Fix keyboard max lighting for Dell Latitude E6410 Peter Ujfalusi (2): ARM: dts: am4372: Correct the interrupts_properties of McASP ARM: dts: am437x-cm-t43: Correct the dmas property of spi0 Peter Zijlstra (1): locking/lockdep: Fix possible NULL deref Pieter Jansen van Vuuren (1): nfp: fix port stats for mac representors Rafael J. Wysocki (1): PM / runtime: Fix handling of suppliers with disabled runtime PM Randy Dunlap (2): usb: build drivers/usb/common/ when USB_SUPPORT is set iio: fix kernel-doc build errors Ravi Bangoria (2): perf annotate: Do not truncate instruction names at 6 chars powerpc/perf: Fix oops when grouping different pmu events Ray Jui (1): bnxt_en: Need to unconditionally shut down RoCE in bnxt_shutdown Russell King (3): sfp: fix RX_LOS signal handling phylink: ensure we take the link down when phylink_stop() is called drm/armada: fix leak of crtc structure Sakari Ailus (1): media: ov13858: Select V4L2_FWNODE Satheesh Rajendran (1): perf bench numa: Fixup discontiguous/sparse numa nodes Shaohua Li (1): md/raid1/10: add missed blk plug Stefan Haberland (1): s390/dasd: prevent prefix I/O error Stefan Hajnoczi (1): VSOCK: fix outdated sk_state value in hvs_release() Stefan Potyra (1): ASoC: rockchip: disable clock on error Stefan Schake (1): drm/vc4: Release fence after signalling Steffen Klassert (2): xfrm: Fix stack-out-of-bounds read on socket policy lookup. xfrm: Fix stack-out-of-bounds with misconfigured transport mode policies. Subash Abhinov Kasiviswanathan (1): net: qualcomm: rmnet: Fix leak on transmit failure Takuo Koguchi (1): spi: sun4i: disable clocks in the remove function Thomas Richter (2): perf test shell: Fix check open filename arg using 'perf trace' on s390x perf test: Fix test 21 for s390x Tobias Jordan (1): dmaengine: jz4740: disable/unprepare clk if probe fails Tony Lindgren (3): ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context ARM: dts: Fix omap4 hang with GPS connected to USB by using wakeupgen ARM: dts: Fix elm interrupt compiler warning Vincent Pelletier (1): usb: dwc3: gadget: Wait longer for controller to end command processing Will Deacon (1): scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Xie XiuQi (1): trace/xdp: fix compile warning: 'struct bpf_map' declared inside parameter list Xin Long (1): sctp: only update outstanding_bytes for transmitted queue when doing prsctp_prune Yan Markman (1): net: mvpp2: allocate zeroed tx descriptors Yunjian Wang (1): virtio_net: fix return value check in receive_mergeable() Zumeng Chen (1): gianfar: fix a flooded alignment reports because of padding issue. bingjingc (1): md/raid5: correct degraded calculation in raid5_error arch/arm/boot/dts/am4372.dtsi | 6 ++- arch/arm/boot/dts/am437x-cm-t43.dts | 4 +- arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts | 3 +- arch/arm/boot/dts/logicpd-som-lv.dtsi | 16 ++++--- arch/arm/boot/dts/omap4.dtsi | 4 +- arch/arm/mach-omap2/omap-secure.c | 19 ++++++++ arch/arm/mach-omap2/omap-secure.h | 4 ++ arch/arm/mach-omap2/pm.h | 4 -- arch/arm/mach-omap2/pm34xx.c | 13 ++--- arch/arm/mach-omap2/prm33xx.c | 12 ----- arch/arm/mach-omap2/sleep34xx.S | 26 ++-------- arch/m68k/kernel/vmlinux-nommu.lds | 2 + arch/m68k/kernel/vmlinux-std.lds | 2 + arch/m68k/kernel/vmlinux-sun3.lds | 2 + arch/powerpc/perf/core-book3s.c | 4 +- arch/powerpc/perf/imc-pmu.c | 13 +++++ arch/s390/include/uapi/asm/virtio-ccw.h | 2 +- arch/x86/kvm/vmx.c | 1 - arch/x86/mm/ioremap.c | 4 +- arch/x86/mm/kmmio.c | 12 +++-- drivers/Makefile | 1 + drivers/base/power/runtime.c | 3 +- drivers/dma/at_hdmac.c | 4 +- drivers/dma/dma-jz4740.c | 4 +- drivers/dma/ioat/init.c | 2 +- drivers/gpio/gpio-74x164.c | 4 +- drivers/gpio/gpio-davinci.c | 2 +- drivers/gpu/drm/armada/armada_crtc.c | 25 +++++----- drivers/gpu/drm/vc4/vc4_gem.c | 4 +- drivers/gpu/drm/vc4/vc4_irq.c | 1 + drivers/iio/industrialio-core.c | 4 +- drivers/iio/proximity/sx9500.c | 9 ++++ drivers/infiniband/core/cma.c | 3 +- drivers/infiniband/core/device.c | 4 +- drivers/infiniband/core/iwcm.c | 2 +- drivers/infiniband/core/nldev.c | 2 +- drivers/infiniband/hw/hfi1/rc.c | 2 +- drivers/infiniband/hw/i40iw/i40iw_cm.c | 6 +-- drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 43 ++++++++++++----- drivers/infiniband/hw/i40iw/i40iw_d.h | 6 ++- drivers/infiniband/hw/mlx4/qp.c | 26 +++++++--- drivers/md/raid1.c | 4 ++ drivers/md/raid10.c | 4 ++ drivers/md/raid5.c | 2 +- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/s5k6aa.c | 5 ++ drivers/net/dsa/mv88e6xxx/chip.c | 34 ++++++------- drivers/net/ethernet/arc/emac_rockchip.c | 7 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +- drivers/net/ethernet/freescale/gianfar.c | 11 ++++- drivers/net/ethernet/marvell/mvpp2.c | 2 +- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 15 +++--- .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 8 +++- drivers/net/hippi/rrunner.c | 2 +- drivers/net/ipvlan/ipvlan_core.c | 1 + drivers/net/phy/phylink.c | 1 + drivers/net/phy/sfp.c | 8 ++-- drivers/net/virtio_net.c | 2 +- .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- drivers/pci/host/pcie-rcar.c | 8 ++-- drivers/pinctrl/intel/pinctrl-denverton.c | 2 +- drivers/pinctrl/sunxi/pinctrl-sun50i-a64.c | 2 +- drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c | 6 +-- drivers/platform/x86/dell-laptop.c | 17 +++++++ drivers/s390/block/dasd_eckd.c | 16 ++++--- drivers/scsi/bfa/bfad_bsg.c | 6 ++- drivers/scsi/lpfc/lpfc_mem.c | 2 +- drivers/soc/amlogic/meson-gx-socinfo.c | 4 +- drivers/spi/spi-sun4i.c | 2 +- drivers/staging/ccree/ssi_hash.c | 2 +- drivers/usb/dwc3/dwc3-of-simple.c | 4 +- drivers/usb/dwc3/gadget.c | 2 +- drivers/xen/Kconfig | 2 +- fs/btrfs/disk-io.c | 12 ++--- fs/btrfs/inode.c | 2 + fs/btrfs/ioctl.c | 2 +- include/linux/serdev.h | 2 +- include/net/red.h | 13 ++++- include/trace/events/clk.h | 4 +- include/trace/events/xdp.h | 1 + kernel/events/core.c | 5 +- kernel/locking/lockdep.c | 3 +- kernel/sched/wait.c | 2 +- lib/oid_registry.c | 8 +++- mm/early_ioremap.c | 2 +- net/dccp/proto.c | 5 ++ net/netfilter/xt_bpf.c | 6 +++ net/sched/sch_choke.c | 3 ++ net/sched/sch_gred.c | 3 ++ net/sched/sch_red.c | 2 + net/sched/sch_sfq.c | 3 ++ net/sctp/outqueue.c | 6 ++- net/vmw_vsock/hyperv_transport.c | 2 +- net/xfrm/xfrm_input.c | 12 ++++- net/xfrm/xfrm_policy.c | 8 +++- net/xfrm/xfrm_user.c | 9 ++++ scripts/kernel-doc | 2 +- sound/soc/rockchip/rockchip_spdif.c | 18 +++++-- sound/soc/sh/rcar/ssi.c | 16 ++++--- tools/perf/bench/numa.c | 56 ++++++++++++++++++++-- tools/perf/builtin-help.c | 4 +- tools/perf/builtin-top.c | 15 ++++-- tools/perf/tests/shell/trace+probe_vfs_getname.sh | 6 ++- tools/perf/tests/task-exit.c | 4 ++ tools/perf/util/annotate.c | 18 +++---- tools/perf/util/evsel.c | 12 +++-- tools/perf/util/evsel.h | 1 + tools/perf/util/parse-events.c | 2 + tools/perf/util/parse-events.h | 3 ++ tools/perf/util/pmu.c | 5 ++ virt/kvm/arm/arm.c | 2 +- virt/kvm/arm/vgic/vgic.c | 5 +- 112 files changed, 528 insertions(+), 253 deletions(-) -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJady7RAAoJEN6mb/eXdyzcOYoP/2/aF6DBCEI0QhowCl4wOPd3 TlvDjo0672GhntAw5pk4LqvehyWBuaY5nl2FyZ9y9h7CREgtRZgax1HOIGb33HHu UK8wNPK2F4LJe1Pj5fvH2/pfHaC4HK190FaNCmCNblpGBN67mb8TGzPAvU2QQkrn n3Zecl3I7IwMN33GMBRiaLcR/NFpnr5buepQpmnUUQnz6S2C7oezpK2oU+7NOPFW f5J7Ici2rfo8UrtUgjojnpEG7AzvmaJ1TzDIIOZylutJdxQx1B9Hny8H9jjD4Bk+ fctAoLYvvslIwP9QSD2KYtD5UfQ6EbpKcv2WDUMDAMZ2Z5ZyPTTChxaXb8BnQ+rv f6apEf80c/tKMyqMg2cLqCiaLJ9TtbyVvbpDnJdK4lCNR8cof01NhTGUg5SVi1fK i5tcTgFv4us/Uyo66GRVERWH3M5kICplXTOmdwkc7noDU8ASWo/E65XMFG193zon qOeJfy67wqeTw5hH4/wPub649ByXsQA3KJrwUbuSRUVDws9KYoeKkTGOOLFeg51I T/yDI5DD6xDqg+P5nzouOIT35vjT3Al46+r1ojI6bM6Pb0Vj4x40Y76WsjojZwhD Kg9CY/KJoPBV/JPd9+Yo+G7x3EAyZyfIvUib4DgbTXjW/6/CQMqiKY0Za/LXIz48 KV2grHI0Cq9vNNNHcseI =8zkY -----END PGP SIGNATURE-----

7 years, 4 months

2
4
0 0

Patch "dmaengine: jz4740: disable/unprepare clk if probe fails" has been added to the 4.14-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled dmaengine: jz4740: disable/unprepare clk if probe fails to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: dmaengine-jz4740-disable-unprepare-clk-if-probe-fails.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Tobias Jordan <Tobias.Jordan(a)elektrobit.com> Date: Wed, 6 Dec 2017 14:28:27 +0100 Subject: dmaengine: jz4740: disable/unprepare clk if probe fails From: Tobias Jordan <Tobias.Jordan(a)elektrobit.com> [ Upstream commit eb9436966fdc84cebdf222952a99898ab46d9bb0 ] in error path of jz4740_dma_probe(), call clk_disable_unprepare() to clean up. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 25ce6c35fea0 MIPS: jz4740: Remove custom DMA API Signed-off-by: Tobias Jordan <Tobias.Jordan(a)elektrobit.com> Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/dma/dma-jz4740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -555,7 +555,7 @@ static int jz4740_dma_probe(struct platf ret = dma_async_device_register(dd); if (ret) - return ret; + goto err_clk; irq = platform_get_irq(pdev, 0); ret = request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev); @@ -568,6 +568,8 @@ static int jz4740_dma_probe(struct platf err_unregister: dma_async_device_unregister(dd); +err_clk: + clk_disable_unprepare(dmadev->clk); return ret; } Patches currently in stable-queue which might be from Tobias.Jordan(a)elektrobit.com are queue-4.14/dmaengine-jz4740-disable-unprepare-clk-if-probe-fails.patch

7 years, 4 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror