June 2025 - Linux-stable-mirror

[tip: x86/urgent] x86/virt/tdx: Avoid indirect calls to TDX assembly functions

by tip-bot2 for Kai Huang

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 0b3bc018e86afdc0cbfef61328c63d5c08f8b370 Gitweb: https://git.kernel.org/tip/0b3bc018e86afdc0cbfef61328c63d5c08f8b370 Author: Kai Huang <kai.huang(a)intel.com> AuthorDate: Sat, 07 Jun 2025 01:07:37 +12:00 Committer: Dave Hansen <dave.hansen(a)linux.intel.com> CommitterDate: Tue, 10 Jun 2025 12:32:52 -07:00 x86/virt/tdx: Avoid indirect calls to TDX assembly functions Two 'static inline' TDX helper functions (sc_retry() and sc_retry_prerr()) take function pointer arguments which refer to assembly functions. Normally, the compiler inlines the TDX helper, realizes that the function pointer targets are completely static -- thus can be resolved at compile time -- and generates direct call instructions. But, other times (like when CONFIG_CC_OPTIMIZE_FOR_SIZE=y), the compiler declines to inline the helpers and will instead generate indirect call instructions. Indirect calls to assembly functions require special annotation (for various Control Flow Integrity mechanisms). But TDX assembly functions lack the special annotations and can only be called directly. Annotate both the helpers as '__always_inline' to prod the compiler into maintaining the direct calls. There is no guarantee here, but Peter has volunteered to report the compiler bug if this assumption ever breaks[1]. Fixes: 1e66a7e27539 ("x86/virt/tdx: Handle SEAMCALL no entropy error in common code") Fixes: df01f5ae07dd ("x86/virt/tdx: Add SEAMCALL error printing for module initialization") Signed-off-by: Kai Huang <kai.huang(a)intel.com> Signed-off-by: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/lkml/20250605145914.GW39944@noisy.programming.kicks… [1] Link: https://lore.kernel.org/all/20250606130737.30713-1-kai.huang%40intel.com --- arch/x86/include/asm/tdx.h | 2 +- arch/x86/virt/vmx/tdx/tdx.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index 8b19294..7ddef3a 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -106,7 +106,7 @@ void tdx_init(void); typedef u64 (*sc_func_t)(u64 fn, struct tdx_module_args *args); -static inline u64 sc_retry(sc_func_t func, u64 fn, +static __always_inline u64 sc_retry(sc_func_t func, u64 fn, struct tdx_module_args *args) { int retry = RDRAND_RETRY_LOOPS; diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index 2457d13..c7a9a08 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -75,8 +75,9 @@ static inline void seamcall_err_ret(u64 fn, u64 err, args->r9, args->r10, args->r11); } -static inline int sc_retry_prerr(sc_func_t func, sc_err_func_t err_func, - u64 fn, struct tdx_module_args *args) +static __always_inline int sc_retry_prerr(sc_func_t func, + sc_err_func_t err_func, + u64 fn, struct tdx_module_args *args) { u64 sret = sc_retry(func, fn, args);

6 months, 1 week

1
0
0 0

[REGRESSION][stable v6.14] AMD GPU init failure in v6.14.10 – revert needed for commit c53f23f7075c9f63f14d7ec8f2cc3e33e118d986

by msk

Hi all, #regzbot introduced: c53f23f7075c9f63f14d7ec8f2cc3e33e118d986 **Summary** A regression introduced in **v6.14.10** breaks AMD GPU initialization on RX 9070 XT system due to commit c53f23f7… (“drm/amd/display: check stream id dml21 wrapper…”). Reverting this commit restores proper graphical startup. dmesg output before revert [ 2.699091] ACPI: bus type drm_connector registered [ 2.699734] xhci_hcd 0000:02:00.0: xHCI Host Controller [ 2.699740] xhci_hcd 0000:02:00.0: new USB bus registered, assigned bus number 1 [ 2.755165] xhci_hcd 0000:02:00.0: hcc params 0x0200ef81 hci version 0x110 quirks 0x0000000000000010 [ 2.755445] xhci_hcd 0000:02:00.0: xHCI Host Controller [ 2.755448] xhci_hcd 0000:02:00.0: new USB bus registered, assigned bus number 2 [ 2.755450] xhci_hcd 0000:02:00.0: Host supports USB 3.1 Enhanced SuperSpeed [ 2.755511] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.14 [ 2.755512] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.755514] usb usb1: Product: xHCI Host Controller [ 2.755515] usb usb1: Manufacturer: Linux 6.14.10-x64v3-xanmod1 xhci-hcd [ 2.755517] usb usb1: SerialNumber: 0000:02:00.0 [ 2.755613] hub 1-0:1.0: USB hub found [ 2.755629] hub 1-0:1.0: 10 ports detected [ 2.755952] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [ 2.755973] usb usb2: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 6.14 [ 2.755975] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.755976] usb usb2: Product: xHCI Host Controller [ 2.755978] usb usb2: Manufacturer: Linux 6.14.10-x64v3-xanmod1 xhci-hcd [ 2.755979] usb usb2: SerialNumber: 0000:02:00.0 [ 2.756056] hub 2-0:1.0: USB hub found [ 2.756065] hub 2-0:1.0: 4 ports detected [ 2.756274] xhci_hcd 0000:0a:00.3: xHCI Host Controller [ 2.756278] xhci_hcd 0000:0a:00.3: new USB bus registered, assigned bus number 3 [ 2.756384] xhci_hcd 0000:0a:00.3: hcc params 0x0278ffe5 hci version 0x110 quirks 0x0000000000000010 [ 2.756622] xhci_hcd 0000:0a:00.3: xHCI Host Controller [ 2.756624] xhci_hcd 0000:0a:00.3: new USB bus registered, assigned bus number 4 [ 2.756626] xhci_hcd 0000:0a:00.3: Host supports USB 3.1 Enhanced SuperSpeed [ 2.756657] usb usb3: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.14 [ 2.756659] usb usb3: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.756660] usb usb3: Product: xHCI Host Controller [ 2.756661] usb usb3: Manufacturer: Linux 6.14.10-x64v3-xanmod1 xhci-hcd [ 2.756663] usb usb3: SerialNumber: 0000:0a:00.3 [ 2.756748] hub 3-0:1.0: USB hub found [ 2.756756] hub 3-0:1.0: 4 ports detected [ 2.756903] usb usb4: We don't know the algorithms for LPM for this host, disabling LPM. [ 2.756924] usb usb4: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 6.14 [ 2.756926] usb usb4: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.756927] usb usb4: Product: xHCI Host Controller [ 2.756928] usb usb4: Manufacturer: Linux 6.14.10-x64v3-xanmod1 xhci-hcd [ 2.756929] usb usb4: SerialNumber: 0000:0a:00.3 [ 2.757008] hub 4-0:1.0: USB hub found [ 2.757015] hub 4-0:1.0: 4 ports detected [ 2.757180] usbcore: registered new interface driver usbserial_generic [ 2.757184] usbserial: USB Serial support registered for generic [ 2.757253] rtc_cmos 00:02: RTC can wake from S4 [ 2.757465] rtc_cmos 00:02: registered as rtc0 [ 2.757494] rtc_cmos 00:02: setting system clock to 2025-06-10T13:46:18 UTC (1749563178) [ 2.757517] rtc_cmos 00:02: alarms up to one month, y3k, 114 bytes nvram [ 2.793080] simple-framebuffer simple-framebuffer.0: [drm] Registered 1 planes with drm panic [ 2.793082] [drm] Initialized simpledrm 1.0.0 for simple-framebuffer.0 on minor 0 [ 2.796240] fbcon: Deferring console take-over [ 2.796241] simple-framebuffer simple-framebuffer.0: [drm] fb0: simpledrmdrmfb frame buffer device dmesg output after revert [ 2.634779] ata1: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80100 irq 40 lpm-pol 0 [ 2.634782] ata2: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80180 irq 40 lpm-pol 0 [ 2.634785] ata3: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80200 irq 40 lpm-pol 0 [ 2.634787] ata4: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80280 irq 40 lpm-pol 0 [ 2.634789] ata5: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80300 irq 40 lpm-pol 0 [ 2.634791] ata6: SATA max UDMA/133 abar m131072@0xfcc80000 port 0xfcc80380 irq 40 lpm-pol 0 [ 2.634848] ACPI: bus type drm_connector registered [ 2.634869] [drm] amdgpu kernel modesetting enabled. [ 2.644006] amdgpu: Virtual CRAT table created for CPU [ 2.644017] amdgpu: Topology: Add CPU node [ 2.644089] amdgpu 0000:08:00.0: enabling device (0006 -> 0007) [ 2.644120] [drm] initializing kernel modesetting (IP DISCOVERY 0x1002:0x7550 0x1EAE:0x8811 0xC0). [ 2.644128] [drm] register mmio base: 0xFCD00000 [ 2.644129] [drm] register mmio size: 524288 [ 2.648358] amdgpu 0000:08:00.0: amdgpu: detected ip block number 0 <soc24_common> [ 2.648360] amdgpu 0000:08:00.0: amdgpu: detected ip block number 1 <gmc_v12_0> [ 2.648362] amdgpu 0000:08:00.0: amdgpu: detected ip block number 2 <ih_v7_0> [ 2.648364] amdgpu 0000:08:00.0: amdgpu: detected ip block number 3 <psp> [ 2.648365] amdgpu 0000:08:00.0: amdgpu: detected ip block number 4 <smu> [ 2.648366] amdgpu 0000:08:00.0: amdgpu: detected ip block number 5 <dm> [ 2.648368] amdgpu 0000:08:00.0: amdgpu: detected ip block number 6 <gfx_v12_0> [ 2.648369] amdgpu 0000:08:00.0: amdgpu: detected ip block number 7 <sdma_v7_0> [ 2.648370] amdgpu 0000:08:00.0: amdgpu: detected ip block number 8 <vcn_v5_0_0> [ 2.648372] amdgpu 0000:08:00.0: amdgpu: detected ip block number 9 <jpeg_v5_0_0> [ 2.648373] amdgpu 0000:08:00.0: amdgpu: detected ip block number 10 <mes_v12_0> [ 2.648383] amdgpu 0000:08:00.0: amdgpu: Fetched VBIOS from VFCT [ 2.648385] amdgpu: ATOM BIOS: 113-EXT108832-100 [ 2.659806] amdgpu 0000:08:00.0: vgaarb: deactivate vga console [ 2.659809] amdgpu 0000:08:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported [ 2.659830] amdgpu 0000:08:00.0: amdgpu: MEM ECC is not presented. [ 2.659831] amdgpu 0000:08:00.0: amdgpu: SRAM ECC is not presented. [ 2.659845] [drm] vm size is 262144 GB, 4 levels, block size is 9-bit, fragment size is 9-bit [ 2.659850] amdgpu 0000:08:00.0: amdgpu: VRAM: 16304M 0x0000008000000000 - 0x00000083FAFFFFFF (16304M used) [ 2.659852] amdgpu 0000:08:00.0: amdgpu: GART: 512M 0x0000000000000000 - 0x000000001FFFFFFF [ 2.659856] [drm] Detected VRAM RAM=16304M, BAR=16384M [ 2.659858] [drm] RAM width 256bits GDDR6 [ 2.659915] [drm] amdgpu: 16304M of VRAM memory ready [ 2.659916] [drm] amdgpu: 15990M of GTT memory ready. [ 2.659926] [drm] GART: num cpu pages 131072, num gpu pages 131072 [ 2.659998] amdgpu 0000:08:00.0: amdgpu: PCIE GART of 512M enabled (table at 0x00000083DAB00000). [ 2.660416] [drm] Loading DMUB firmware via PSP: version=0x00010300 [ 2.660749] [drm] Found VCN firmware Version ENC: 1.7 DEC: 9 VEP: 0 Revision: 19 [ 2.895324] amdgpu 0000:08:00.0: amdgpu: RAP: optional rap ta ucode is not available [ 2.895327] amdgpu 0000:08:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available [ 2.895357] amdgpu 0000:08:00.0: amdgpu: smu driver if version = 0x0000002e, smu fw if version = 0x00000032, smu fw program = 0, smu fw version = 0x00684400 (104.68.0) [ 2.895360] amdgpu 0000:08:00.0: amdgpu: SMU driver if version not matched [ 2.934857] amdgpu 0000:08:00.0: amdgpu: SMU is initialized successfully! [ 2.935596] [drm] Display Core v3.2.316 initialized on DCN 4.0.1 [ 2.935598] [drm] DP-HDMI FRL PCON supported [ 2.939115] [drm] DMUB hardware initialized: version=0x00010300 [ 2.942565] ata1: SATA link down (SStatus 0 SControl 300) [ 3.233092] amdgpu 0000:08:00.0: amdgpu: program CP_MES_CNTL : 0x4000000 [ 3.233097] amdgpu 0000:08:00.0: amdgpu: program CP_MES_CNTL : 0xc000000 [ 3.293410] amdgpu: HMM registered 16304MB device memory [ 3.294762] kfd kfd: amdgpu: Allocated 3969056 bytes on gart [ 3.294771] kfd kfd: amdgpu: Total number of KFD nodes to be created: 1 [ 3.294806] amdgpu: Virtual CRAT table created for GPU [ 3.294972] amdgpu: Topology: Add dGPU node [0x7550:0x1002] [ 3.294974] kfd kfd: amdgpu: added device 1002:7550 [ 3.294983] amdgpu 0000:08:00.0: amdgpu: SE 4, SH per SE 2, CU per SH 8, active_cu_number 64 [ 3.294986] amdgpu 0000:08:00.0: amdgpu: ring gfx_0.0.0 uses VM inv eng 0 on hub 0 [ 3.294987] amdgpu 0000:08:00.0: amdgpu: ring comp_1.0.0 uses VM inv eng 1 on hub 0 [ 3.294989] amdgpu 0000:08:00.0: amdgpu: ring comp_1.1.0 uses VM inv eng 4 on hub 0 [ 3.294990] amdgpu 0000:08:00.0: amdgpu: ring comp_1.0.1 uses VM inv eng 6 on hub 0 [ 3.294991] amdgpu 0000:08:00.0: amdgpu: ring comp_1.1.1 uses VM inv eng 7 on hub 0 [ 3.294993] amdgpu 0000:08:00.0: amdgpu: ring sdma0 uses VM inv eng 8 on hub 0 [ 3.294994] amdgpu 0000:08:00.0: amdgpu: ring sdma1 uses VM inv eng 9 on hub 0 [ 3.294995] amdgpu 0000:08:00.0: amdgpu: ring vcn_unified_0 uses VM inv eng 0 on hub 8 [ 3.294997] amdgpu 0000:08:00.0: amdgpu: ring jpeg_dec uses VM inv eng 1 on hub 8 [ 3.296713] [drm] ring gfx_32768.1.1 was added [ 3.296874] [drm] ring compute_32768.2.2 was added [ 3.297032] [drm] ring sdma_32768.3.3 was added [ 3.297075] [drm] ring gfx_32768.1.1 ib test pass [ 3.297119] [drm] ring compute_32768.2.2 ib test pass [ 3.297157] [drm] ring sdma_32768.3.3 ib test pass [ 3.299782] amdgpu 0000:08:00.0: amdgpu: Using BACO for runtime pm [ 3.300156] amdgpu 0000:08:00.0: [drm] Registered 4 planes with drm panic [ 3.300158] [drm] Initialized amdgpu 3.61.0 for 0000:08:00.0 on minor 0 [ 3.328171] fbcon: amdgpudrmfb (fb0) is primary device [ 3.328173] fbcon: Deferring console take-over [ 3.328175] amdgpu 0000:08:00.0: [drm] fb0: amdgpudrmfb frame buffer device I am aware that this issue pertains to the XanMod kernel. However, upon reviewing the commits, there is no indication that it is a downstream issue. I attempted to confirm this regression by building the kernel from the Git repository, but my limited skills and knowledge proved insufficient. Please review this regression and consider reverting the commit from the stable 6.14 and 6.15 branches - or propose an alternate patch. Thanks & Regards, Marcin Kryzak

6 months, 1 week

1
0
0 0

[PATCH] HID: lenovo: Restrict F7/9/11 mode to compact keyboards only

by Iusico Maxim

Commit 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume for compact keyboards") introduced a regression for ThinkPad TrackPoint Keyboard II by removing the conditional check for enabling F7/9/11 mode needed for compact keyboards only. As a result, the non-compact keyboards can no longer toggle Fn-lock via Fn+Esc, although it can be controlled via sysfs knob that directly sends raw commands. This patch restores the previous conditional check without any additions. Cc: stable(a)vger.kernel.org Fixes: 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume for compact keyboards") Signed-off-by: Iusico Maxim <iusico.maxim(a)libero.it> --- drivers/hid/hid-lenovo.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index af29ba84052..a3c23a72316 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -548,11 +548,14 @@ static void lenovo_features_set_cptkbd(struct hid_device *hdev) /* * Tell the keyboard a driver understands it, and turn F7, F9, F11 into - * regular keys + * regular keys (Compact only) */ - ret = lenovo_send_cmd_cptkbd(hdev, 0x01, 0x03); - if (ret) - hid_warn(hdev, "Failed to switch F7/9/11 mode: %d\n", ret); + if (hdev->product == USB_DEVICE_ID_LENOVO_CUSBKBD || + hdev->product == USB_DEVICE_ID_LENOVO_CBTKBD) { + ret = lenovo_send_cmd_cptkbd(hdev, 0x01, 0x03); + if (ret) + hid_warn(hdev, "Failed to switch F7/9/11 mode: %d\n", ret); + } /* Switch middle button to native mode */ ret = lenovo_send_cmd_cptkbd(hdev, 0x09, 0x01); -- 2.48.1

6 months, 1 week

2
1
0 0

[PATCH v2] tools/resolve_btfids: Fix build when cross compiling kernel with clang.

by Suleiman Souhlal

When cross compiling the kernel with clang, we need to override CLANG_CROSS_FLAGS when preparing the step libraries. Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs when building tools in parallel"), MAKEFLAGS would have been set to a value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the fact that we weren't properly overriding it. Cc: stable(a)vger.kernel.org Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program") Signed-off-by: Suleiman Souhlal <suleiman(a)google.com> --- v2: - "Signed-off-by:" instead of "Signed-of-by". v1: https://lore.kernel.org/lkml/20250606052301.810338-1-suleiman@google.com/ --- tools/bpf/resolve_btfids/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile index afbddea3a39c..ce1b556dfa90 100644 --- a/tools/bpf/resolve_btfids/Makefile +++ b/tools/bpf/resolve_btfids/Makefile @@ -17,7 +17,7 @@ endif # Overrides for the prepare step libraries. HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \ - CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)" + CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)" RM ?= rm HOSTCC ?= gcc -- 2.50.0.rc0.642.g800a2b2222-goog

6 months, 1 week

3
2
0 0

Re: [PATCH net] netrom: fix possible deadlock in nr_rt_device_down

by Jakub Kicinski

On Mon, 9 Jun 2025 16:16:32 -0700 David Ranch wrote: > I'm not sure what you mean by "the only user of this code". There are > many people using the Linux AX.25 + NETROM stack but we unfortunately > don't have a active kernel maintainer for this code today. Alright, sorry. Either way - these locks are not performance critical for you, right?

6 months, 1 week

3
3
0 0

WTS Available laptops and Memory

by Exceptional One PC

Hello, Looking for a buyer to move any of the following Items located in USA. Used MICRON SSD 7300 PRO 3.84TB U.2 HTFDHBE3T8TDF SSD 2.5" NVMe 3480GB Quantity 400, price $100 EACH 005052112 _ 7.68TB HDD -$200 PER w/ caddies refurbished Quantity 76, price $100 Brand New CISCO C9300-48UXM-E Available 5 $2000 EACH Brand New C9200L-48T-4X-E $1,200 EACH QTY4 HP 1040G3 Elite Book Folio Processor :- Intel Core i5 ◻Processor :- Intel Core i5 ◻Generation :- 6th ◻RAM :- 16GB ◻Storage :- 256G SSD ◻Display :- 14 inch" Touch Screen QTY 340 $90 EA SK HYNIX 16GB 2RX4 PC4 - 2133P-RAO-10 HMA42GR7AFR4N-TF TD AB 1526 QTY560 $20 EA Xeon Gold 6442Y (60M Cache, 2.60 GHz) PK8071305120500 QTY670 700 each SAMSUNG 64GB 4DRX4 PC4-2666V-LD2-12-MAO M386A8K40BM2-CTD60 S QTY 320 $42 each Brand New CISCO C9300-48UXM-E Available 5 $2500 EACH Core i3-1315U (10M Cache, up to 4.50 GHz) FJ8071505258601 QTY50 $80 EA Intel Xeon Gold 5418Y Processors QTY28 $780 each Brand New C9200L-48T-4X-E $1000 EACH QTY4 Brand New Gigabyte NVIDIA GeForce RTX 5090 AORUS MASTER OC Graphics Card GPU 32GB GDDR7 QTY50 $1,300 Brand New N9K-C93108TC-FX-24 Nexus 9300-FX w/ 24p 100M/1/10GT & 6p 40/100G Available 4 $3000 each Brand New NVIDIA GeForce RTX 4090 Founders Edition 24GB - QTY: 56 - $700 each Charles Lawson Exceptional One PC 3645 Central Ave, Riverside CA 92506, United States www.exceptionalonepc.com info(a)exceptionalonepc.com Office: (951)-556-3104

6 months, 1 week

1
0
0 0

[PATCH v4 01/10] platform/x86/intel/pmt: fix a crashlog NULL pointer access

by Michael J. Ruhl

Usage of the intel_pmt_read() for binary sysfs, requires a pcidev. The current use of the endpoint value is only valid for telemetry endpoint usage. Without the ep, the crashlog usage causes the following NULL pointer exception: BUG: kernel NULL pointer dereference, address: 0000000000000000 Oops: Oops: 0000 [#1] SMP NOPTI RIP: 0010:intel_pmt_read+0x3b/0x70 [pmt_class] Code: Call Trace: <TASK> ? sysfs_kf_bin_read+0xc0/0xe0 kernfs_fop_read_iter+0xac/0x1a0 vfs_read+0x26d/0x350 ksys_read+0x6b/0xe0 __x64_sys_read+0x1d/0x30 x64_sys_call+0x1bc8/0x1d70 do_syscall_64+0x6d/0x110 Augment the inte_pmt_entry to include the pcidev to allow for access to the pcidev and avoid the NULL pointer exception. Fixes: 416eeb2e1fc7 ("platform/x86/intel/pmt: telemetry: Export API to read telemetry") Cc: <stable(a)vger.kernel.org> Signed-off-by: Michael J. Ruhl <michael.j.ruhl(a)intel.com> --- drivers/platform/x86/intel/pmt/class.c | 3 ++- drivers/platform/x86/intel/pmt/class.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c index 7233b654bbad..d046e8752173 100644 --- a/drivers/platform/x86/intel/pmt/class.c +++ b/drivers/platform/x86/intel/pmt/class.c @@ -97,7 +97,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj, if (count > entry->size - off) count = entry->size - off; - count = pmt_telem_read_mmio(entry->ep->pcidev, entry->cb, entry->header.guid, buf, + count = pmt_telem_read_mmio(entry->pcidev, entry->cb, entry->header.guid, buf, entry->base, off, count); return count; @@ -252,6 +252,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry, return -EINVAL; } + entry->pcidev = pci_dev; entry->guid = header->guid; entry->size = header->size; entry->cb = ivdev->priv_data; diff --git a/drivers/platform/x86/intel/pmt/class.h b/drivers/platform/x86/intel/pmt/class.h index b2006d57779d..f6ce80c4e051 100644 --- a/drivers/platform/x86/intel/pmt/class.h +++ b/drivers/platform/x86/intel/pmt/class.h @@ -39,6 +39,7 @@ struct intel_pmt_header { struct intel_pmt_entry { struct telem_endpoint *ep; + struct pci_dev *pcidev; struct intel_pmt_header header; struct bin_attribute pmt_bin_attr; struct kobject *kobj; -- 2.49.0

6 months, 1 week

1
0
0 0

[PATCH] ASoC: sdw_utils: Fix potential NULL pointer deref in is_sdca_endpoint_present()

by Thorsten Blum

Check the return value of kzalloc() and exit early to avoid a potential NULL pointer dereference. Cc: stable(a)vger.kernel.org Fixes: 4f8ef33dd44a ("ASoC: soc_sdw_utils: skip the endpoint that doesn't present") Signed-off-by: Thorsten Blum <thorsten.blum(a)linux.dev> --- sound/soc/sdw_utils/soc_sdw_utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sdw_utils/soc_sdw_utils.c b/sound/soc/sdw_utils/soc_sdw_utils.c index 30f84f4e7637..b70cb3793d8f 100644 --- a/sound/soc/sdw_utils/soc_sdw_utils.c +++ b/sound/soc/sdw_utils/soc_sdw_utils.c @@ -1180,6 +1180,8 @@ static int is_sdca_endpoint_present(struct device *dev, int i; dlc = kzalloc(sizeof(*dlc), GFP_KERNEL); + if (!dlc) + return -ENOMEM; adr_end = &adr_dev->endpoints[end_index]; dai_info = &codec_info->dais[adr_end->num]; -- 2.49.0

6 months, 1 week

3
2
0 0

FAILED: patch "[PATCH] dt-bindings: pwm: adi,axi-pwmgen: Fix clocks" failed to apply to 6.12-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.12-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y git checkout FETCH_HEAD git cherry-pick -x e683131e64f71e957ca77743cb3d313646157329 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2025060734-elated-juvenile-da5c@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From e683131e64f71e957ca77743cb3d313646157329 Mon Sep 17 00:00:00 2001 From: David Lechner <dlechner(a)baylibre.com> Date: Thu, 29 May 2025 11:53:19 -0500 Subject: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Fix clocks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix a shortcoming in the bindings that doesn't allow for a separate external clock. The AXI PWMGEN IP block has a compile option ASYNC_CLK_EN that allows the use of an external clock for the PWM output separate from the AXI clock that runs the peripheral. This was missed in the original bindings and so users were writing dts files where the one and only clock specified would be the external clock, if there was one, incorrectly missing the separate AXI clock. The correct bindings are that the AXI clock is always required and the external clock is optional (must be given only when HDL compile option ASYNC_CLK_EN=1). Fixes: 1edf2c2a2841 ("dt-bindings: pwm: Add AXI PWM generator") Cc: stable(a)vger.kernel.org Signed-off-by: David Lechner <dlechner(a)baylibre.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Link: https://lore.kernel.org/r/20250529-pwm-axi-pwmgen-add-external-clock-v3-2-5… Signed-off-by: Uwe Kleine-König <ukleinek(a)kernel.org> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml index 45e112d0efb4..5575c58357d6 100644 --- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml @@ -30,11 +30,19 @@ properties: const: 3 clocks: - maxItems: 1 + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: axi + - const: ext required: - reg - clocks + - clock-names unevaluatedProperties: false @@ -43,6 +51,7 @@ examples: pwm@44b00000 { compatible = "adi,axi-pwmgen-2.00.a"; reg = <0x44b00000 0x1000>; - clocks = <&spi_clk>; + clocks = <&fpga_clk>, <&spi_clk>; + clock-names = "axi", "ext"; #pwm-cells = <3>; };

6 months, 1 week

3
3
0 0

[PATCH] sched: Fix preemption string of preempt_dynamic_none

by Thomas Weißschuh

Zero is a valid value for "preempt_dynamic_mode", namely "preempt_dynamic_none". Fix the off-by-one in preempt_model_str(), so that "preempty_dynamic_none" is correctly formatted as PREEMPT(none) instead of PREEMPT(undef). Fixes: 8bdc5daaa01e ("sched: Add a generic function to return the preemption string") Cc: stable(a)vger.kernel.org Signed-off-by: Thomas Weißschuh <thomas.weissschuh(a)linutronix.de> --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index dce50fa57471dffc4311b9d393ae300a43d38d20..021b0a703d094b3386c5ba50e0e111e3a7c2b3df 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7663,7 +7663,7 @@ const char *preempt_model_str(void) if (IS_ENABLED(CONFIG_PREEMPT_DYNAMIC)) { seq_buf_printf(&s, "(%s)%s", - preempt_dynamic_mode > 0 ? + preempt_dynamic_mode >= 0 ? preempt_modes[preempt_dynamic_mode] : "undef", brace ? "}" : ""); return seq_buf_str(&s); --- base-commit: 546b1c9e93c2bb8cf5ed24e0be1c86bb089b3253 change-id: 20250603-preempt-str-none-d21231cc2238 Best regards, -- Thomas Weißschuh <thomas.weissschuh(a)linutronix.de>

6 months, 1 week

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2025