July 2023 - Linux-stable-mirror

[PATCH v4 2/6] usb: dwc3: gadget: cancel requests instead of release after missed isoc

by Dan Vacura

From: Jeff Vanhoof <qjv001(a)motorola.com> arm-smmu related crashes seen after a Missed ISOC interrupt when no_interrupt=1 is used. This can happen if the hardware is still using the data associated with a TRB after the usb_request's ->complete call has been made. Instead of immediately releasing a request when a Missed ISOC interrupt has occurred, this change will add logic to cancel the request instead where it will eventually be released when the END_TRANSFER command has completed. This logic is similar to some of the cleanup done in dwc3_gadget_ep_dequeue. Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status") Cc: <stable(a)vger.kernel.org> Signed-off-by: Jeff Vanhoof <qjv001(a)motorola.com> Co-developed-by: Dan Vacura <w36195(a)motorola.com> Signed-off-by: Dan Vacura <w36195(a)motorola.com> --- V1 -> V3: - no change, new patch in series V3 -> V4: - no change drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/gadget.c | 38 ++++++++++++++++++++++++++------------ 2 files changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 8f9959ba9fd4..9b005d912241 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -943,6 +943,7 @@ struct dwc3_request { #define DWC3_REQUEST_STATUS_DEQUEUED 3 #define DWC3_REQUEST_STATUS_STALLED 4 #define DWC3_REQUEST_STATUS_COMPLETED 5 +#define DWC3_REQUEST_STATUS_MISSED_ISOC 6 #define DWC3_REQUEST_STATUS_UNKNOWN -1 u8 epnum; diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 079cd333632e..411532c5c378 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2021,6 +2021,9 @@ static void dwc3_gadget_ep_cleanup_cancelled_requests(struct dwc3_ep *dep) case DWC3_REQUEST_STATUS_STALLED: dwc3_gadget_giveback(dep, req, -EPIPE); break; + case DWC3_REQUEST_STATUS_MISSED_ISOC: + dwc3_gadget_giveback(dep, req, -EXDEV); + break; default: dev_err(dwc->dev, "request cancelled with wrong reason:%d\n", req->status); dwc3_gadget_giveback(dep, req, -ECONNRESET); @@ -3402,21 +3405,32 @@ static bool dwc3_gadget_endpoint_trbs_complete(struct dwc3_ep *dep, struct dwc3 *dwc = dep->dwc; bool no_started_trb = true; - dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); + if (status == -EXDEV) { + struct dwc3_request *tmp; + struct dwc3_request *req; - if (dep->flags & DWC3_EP_END_TRANSFER_PENDING) - goto out; + if (!(dep->flags & DWC3_EP_END_TRANSFER_PENDING)) + dwc3_stop_active_transfer(dep, true, true); - if (!dep->endpoint.desc) - return no_started_trb; + list_for_each_entry_safe(req, tmp, &dep->started_list, list) + dwc3_gadget_move_cancelled_request(req, + DWC3_REQUEST_STATUS_MISSED_ISOC); + } else { + dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); - if (usb_endpoint_xfer_isoc(dep->endpoint.desc) && - list_empty(&dep->started_list) && - (list_empty(&dep->pending_list) || status == -EXDEV)) - dwc3_stop_active_transfer(dep, true, true); - else if (dwc3_gadget_ep_should_continue(dep)) - if (__dwc3_gadget_kick_transfer(dep) == 0) - no_started_trb = false; + if (dep->flags & DWC3_EP_END_TRANSFER_PENDING) + goto out; + + if (!dep->endpoint.desc) + return no_started_trb; + + if (usb_endpoint_xfer_isoc(dep->endpoint.desc) && + list_empty(&dep->started_list) && list_empty(&dep->pending_list)) + dwc3_stop_active_transfer(dep, true, true); + else if (dwc3_gadget_ep_should_continue(dep)) + if (__dwc3_gadget_kick_transfer(dep) == 0) + no_started_trb = false; + } out: /* -- 2.34.1

1 year, 3 months

5
5
0 0

[PATCH] power: supply: rk817: Add missing module alias

by Nicolas Frattaroli

Similar to the rk817 codec alias that was missing, the rk817 charger driver is missing a module alias as well. This absence prevents the driver from autoprobing on OF systems when it is built as a module. Add the right MODULE_ALIAS to fix this. Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817") Cc: stable(a)vger.kernel.org Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas(a)gmail.com> --- drivers/power/supply/rk817_charger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c index 1a2143641e66..76b991e112da 100644 --- a/drivers/power/supply/rk817_charger.c +++ b/drivers/power/supply/rk817_charger.c @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC"); MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc(a)gmail.com>"); MODULE_AUTHOR("Chris Morgan <macromorgan(a)hotmail.com>"); MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:rk817-charger"); -- 2.41.0

1 year, 3 months

3
2
0 0

[PATCH 5.15 000/107] 5.15.118-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.118 release. There are 107 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 21 Jun 2023 10:21:12 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.118-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.118-rc1 Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: reject devices with insufficient block count Christian Loehle <CLoehle(a)hyperstone.com> mmc: block: ensure error propagation for non-blk Frank Rowand <frank.rowand(a)sony.com> of: overlay: add entry to of_overlay_action_name[] Leon Romanovsky <leon(a)kernel.org> neighbour: delete neigh_lookup_nodev as not used Guillaume Nault <gnault(a)redhat.com> net: Remove DECnet leftovers from flow.h. Gaosheng Cui <cuigaosheng1(a)huawei.com> net: Remove unused inline function dst_hold_and_use() Gaosheng Cui <cuigaosheng1(a)huawei.com> neighbour: Remove unused inline function neigh_key_eq16() Ziwei Dai <ziwei.dai(a)unisoc.com> rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period John Sperbeck <jsperbeck(a)google.com> cgroup: always put cset in cgroup_css_set_put_fork David Howells <dhowells(a)redhat.com> afs: Fix vlserver probe RTT handling Alex Maftei <alex.maftei(a)amd.com> selftests/ptp: Fix timestamp printf format for PTP_SYS_OFFSET Lin Ma <linma(a)zju.edu.cn> net: tipc: resize nlattr array to correct size Li Lingfeng <lilingfeng3(a)huawei.com> dm: don't lock fs when the map is NULL during suspend or resume Eric Dumazet <edumazet(a)google.com> net: lapbether: only support ethernet devices Vlad Buslov <vladbu(a)nvidia.com> net/sched: cls_api: Fix lockup on flushing explicitly created chain Fabio M. De Francesco <fmdefrancesco(a)gmail.com> ext4: drop the call to ext4_error() from ext4_get_group_info() Steve French <stfrench(a)microsoft.com> cifs: fix lease break oops in xfstest generic/098 Natalia Petrova <n.petrova(a)fintech.ru> drm/nouveau: add nv_encoder pointer check for NULL Natalia Petrova <n.petrova(a)fintech.ru> drm/nouveau/dp: check for NULL nv_connector->native_mode Ratchanan Srirattanamet <peathot(a)hotmail.com> drm/nouveau: don't detect DSM for non-NVIDIA device Aleksandr Loktionov <aleksandr.loktionov(a)intel.com> igb: fix nvm.ops.read() error handling Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli(a)intel.com> igc: Clean the TX buffer and TX descriptor ring Dan Carpenter <dan.carpenter(a)linaro.org> sctp: fix an error code in sctp_sf_eat_auth() Hangbin Liu <liuhangbin(a)gmail.com> ipvlan: fix bound dev checking for IPv6 l3s mode Jakub Kicinski <kuba(a)kernel.org> net: ethtool: correct MAX attribute value for stats Saravanan Vajravel <saravanan.vajravel(a)broadcom.com> IB/isert: Fix incorrect release of isert connection Saravanan Vajravel <saravanan.vajravel(a)broadcom.com> IB/isert: Fix possible list corruption in CMA handler Saravanan Vajravel <saravanan.vajravel(a)broadcom.com> IB/isert: Fix dead lock in ib_isert Yishai Hadas <yishaih(a)nvidia.com> IB/uverbs: Fix to consider event queue closing also upon non-blocking mode Mark Zhang <markzhang(a)nvidia.com> RDMA/cma: Always set static rate to 0 for RoCE Maher Sanalla <msanalla(a)nvidia.com> RDMA/mlx5: Initiate dropless RQ for RAW Ethernet functions Nithin Dabilpuram <ndabilpuram(a)marvell.com> octeontx2-af: fix lbk link credits on cn10k Satha Rao <skoteshwar(a)marvell.com> octeontx2-af: fixed resource availability check Ahmed Zaki <ahmed.zaki(a)intel.com> iavf: remove mask from iavf_irq_enable_queues() Zhu Yanjun <yanjun.zhu(a)linux.dev> RDMA/rxe: Fix the use-before-initialization error of resp_pkts Bob Pearson <rpearsonhpe(a)gmail.com> RDMA/rxe: Removed unused name from rxe_task struct Zhu Yanjun <yanjun.zhu(a)linux.dev> RDMA/rxe: Remove the unused variable obj Lee Jones <lee(a)kernel.org> net/sched: cls_u32: Fix reference counter leak leading to overflow Max Tottenham <mtottenh(a)akamai.com> net/sched: act_pedit: Parse L3 Header for L4 offset Pedro Tammela <pctammela(a)mojatatu.com> net/sched: act_pedit: remove extra check for key type Pedro Tammela <pctammela(a)mojatatu.com> net/sched: simplify tcf_pedit_act Guillaume Nault <gnault(a)redhat.com> ping6: Fix send to link-local addresses with VRF. Wei Fang <wei.fang(a)nxp.com> net: enetc: correct the indexes of highest and 2nd highest TCs Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nfnetlink: skip error delivery on batch in case of ENOMEM Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: integrate pipapo into commit protocol Vladimir Oltean <vladimir.oltean(a)nxp.com> spi: fsl-dspi: avoid SCK glitches with continuous transfers Bob Pearson <rpearsonhpe(a)gmail.com> RDMA/rxe: Fix packet length checks Li Zhijian <lizhijian(a)fujitsu.com> RDMA/rtrs: Fix rxe_dealloc_pd warning Li Zhijian <lizhijian(a)fujitsu.com> RDMA/rtrs: Fix the last iu->buf leak in err path Elson Roy Serrao <quic_eserrao(a)quicinc.com> usb: dwc3: gadget: Reset num TRBs before giving back the request Bernhard Seibold <mail(a)bernhard-seibold.de> serial: lantiq: add missing interrupt ack Jerry Meng <jerry-meng(a)foxmail.com> USB: serial: option: add Quectel EM061KGL series Mika Westerberg <mika.westerberg(a)linux.intel.com> thunderbolt: Mask ring interrupt on Intel hardware as well Mika Westerberg <mika.westerberg(a)linux.intel.com> thunderbolt: dma_test: Use correct value for absent rings when creating paths Stephen Hemminger <stephen(a)networkplumber.org> Remove DECnet support from kernel Edson Juliano Drosdeck <edson.drosdeck(a)gmail.com> ALSA: hda/realtek: Add a quirk for Compaq N14JP6 Alex Deucher <alexander.deucher(a)amd.com> drm/amdgpu: add missing radeon secondary PCI ID Hersen Wu <hersenxs.wu(a)amd.com> drm/amd/display: edp do not add non-edid timings Wes Huang <wes.huang(a)moxa.com> net: usb: qmi_wwan: add support for Compal RXM-G1 Edward Srouji <edwards(a)nvidia.com> RDMA/uverbs: Restrict usage of privileged QKEYs Dave Airlie <airlied(a)redhat.com> nouveau: fix client work fence deletion race Li Lingfeng <lilingfeng3(a)huawei.com> dm thin metadata: check fail_io before using data_sm Lukasz Tyl <ltyl(a)hem-e.com> ALSA: usb-audio: Add quirk flag for HEM devices to enable native DSD playback Ricardo Ribalda <ribalda(a)chromium.org> powerpc/purgatory: remove PGO flags Ricardo Ribalda <ribalda(a)chromium.org> x86/purgatory: remove PGO flags Ricardo Ribalda <ribalda(a)chromium.org> kexec: support purgatories with .text.hot sections Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix possible out-of-bounds segment allocation in resize ioctl Ryusuke Konishi <konishi.ryusuke(a)gmail.com> nilfs2: fix incomplete buffer cleanup in nilfs_btnode_abort_change_key() Janne Grunau <j(a)jannau.net> nios2: dts: Fix tse_mac "max-frame-size" property Luís Henriques <ocfs2-devel(a)oss.oracle.com> ocfs2: check new file size on fallocate call Luís Henriques <ocfs2-devel(a)oss.oracle.com> ocfs2: fix use-after-free when unmounting read-only filesystem Benjamin Segall <bsegall(a)google.com> epoll: ep_autoremove_wake_function should use list_del_init_careful Dan Carpenter <dan.carpenter(a)linaro.org> wifi: cfg80211: fix double lock bug in reg_wdev_chan_valid() Johannes Berg <johannes.berg(a)intel.com> wifi: cfg80211: fix locking in regulatory disconnect Jens Axboe <axboe(a)kernel.dk> io_uring: hold uring mutex around poll removal Marc Zyngier <maz(a)kernel.org> irqchip/gic: Correctly validate OF quirk descriptors Tatsuki Sugiura <sugi(a)nemui.org> NVMe: Add MAXIO 1602 to bogus nid list. Sukrut Bellary <sukrut.bellary(a)linux.com> drm:amd:amdgpu: Fix missing buffer object unlock in failure path Ross Lagerwall <ross.lagerwall(a)citrix.com> xen/blkfront: Only check REQ_FUA for writes Maxim Kochetkov <fido_max(a)inbox.ru> ASoC: dwc: move DMA init to snd_soc_dai_driver probe() Liviu Dudau <liviu(a)dudau.co.uk> mips: Move initrd_start check after initrd address sanitisation. Manuel Lauss <manuel.lauss(a)gmail.com> MIPS: Alchemy: fix dbdma2 Manuel Lauss <manuel.lauss(a)gmail.com> MIPS: unhide PATA_PLATFORM Helge Deller <deller(a)gmx.de> parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Helge Deller <deller(a)gmx.de> parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> ASoC: soc-pcm: test if a BE can be prepared Johannes Thumshirn <johannes.thumshirn(a)wdc.com> btrfs: handle memory allocation failure in btrfs_csum_one_bio Qu Wenruo <wqu(a)suse.com> btrfs: scrub: try harder to mark RAID56 block groups read-only Mario Limonciello <mario.limonciello(a)amd.com> power: supply: Fix logic checking if system is running from battery Douglas Anderson <dianders(a)chromium.org> irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Osama Muhammad <osmtendev(a)gmail.com> regulator: Fix error checking for debugfs_create_dir Alexandru Sorodoc <ealex95(a)gmail.com> platform/x86: asus-wmi: Ignore WMI events with codes 0x7B, 0xC0 Marek Vasut <marex(a)denx.de> power: supply: Ratelimit no data debug output Milo Spadacini <milo.spadacini(a)gmail.com> tools: gpio: fix debounce_period_us output of lsgpio Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> ARM: dts: vexpress: add missing cache properties Hans de Goede <hdegoede(a)redhat.com> power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Hans de Goede <hdegoede(a)redhat.com> power: supply: sc27xx: Fix external_power_changed race Hans de Goede <hdegoede(a)redhat.com> power: supply: ab8500: Fix external_power_changed race Kunihiko Hayashi <hayashi.kunihiko(a)socionext.com> of: overlay: Fix missing of_node_put() in error case of init_overlay_changeset() Frank Rowand <frank.rowand(a)sony.com> of: overlay: rework overlay apply and remove kfree()s Frank Rowand <frank.rowand(a)sony.com> of: overlay: rename variables to be consistent Horatio Zhang <Hongkun.Zhang(a)amd.com> drm/amdgpu: fix Null pointer dereference error in amdgpu_device_recover_vram Kuan-Ting Chen <h3xrabbit(a)gmail.com> ksmbd: fix slab-out-of-bounds read in smb2_handle_negotiate Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr> test_firmware: fix a memory leak with reqs buffer Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr> test_firmware: prevent race conditions by a correct implementation of locking Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> test_firmware: Use kstrtobool() instead of strtobool() ------------- Diffstat: Documentation/admin-guide/kernel-parameters.txt | 4 - Documentation/admin-guide/sysctl/net.rst | 15 +- Documentation/devicetree/overlay-notes.rst | 30 +- Documentation/networking/decnet.rst | 243 -- Documentation/networking/index.rst | 1 - Documentation/userspace-api/ioctl/ioctl-number.rst | 1 - MAINTAINERS | 7 - Makefile | 4 +- arch/arm/boot/dts/vexpress-v2p-ca5s.dts | 1 + arch/mips/Kconfig | 1 + arch/mips/alchemy/common/dbdma.c | 27 +- arch/mips/configs/decstation_64_defconfig | 2 - arch/mips/configs/decstation_defconfig | 2 - arch/mips/configs/decstation_r4k_defconfig | 2 - arch/mips/configs/gpr_defconfig | 2 - arch/mips/configs/mtx1_defconfig | 2 - arch/mips/configs/nlm_xlp_defconfig | 2 - arch/mips/configs/nlm_xlr_defconfig | 2 - arch/mips/configs/rm200_defconfig | 2 - arch/mips/kernel/setup.c | 9 +- arch/nios2/boot/dts/10m50_devboard.dts | 2 +- arch/nios2/boot/dts/3c120_devboard.dts | 2 +- arch/parisc/kernel/pci-dma.c | 18 +- arch/powerpc/configs/ppc6xx_defconfig | 2 - arch/powerpc/purgatory/Makefile | 5 + arch/x86/purgatory/Makefile | 5 + drivers/block/xen-blkfront.c | 3 +- drivers/char/agp/parisc-agp.c | 15 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 - drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +- drivers/gpu/drm/nouveau/nouveau_acpi.c | 3 + drivers/gpu/drm/nouveau/nouveau_connector.c | 7 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 14 +- drivers/infiniband/core/cma.c | 4 +- drivers/infiniband/core/uverbs_cmd.c | 7 +- drivers/infiniband/core/uverbs_main.c | 12 +- drivers/infiniband/hw/mlx5/main.c | 3 + drivers/infiniband/sw/rxe/rxe_net.c | 6 + drivers/infiniband/sw/rxe/rxe_qp.c | 16 +- drivers/infiniband/sw/rxe/rxe_task.c | 5 +- drivers/infiniband/sw/rxe/rxe_task.h | 5 +- drivers/infiniband/ulp/isert/ib_isert.c | 16 +- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 55 +- drivers/infiniband/ulp/rtrs/rtrs.c | 4 +- drivers/irqchip/irq-gic-common.c | 10 +- drivers/irqchip/irq-gic-common.h | 1 + drivers/irqchip/irq-gic-v3.c | 20 + drivers/md/dm-ioctl.c | 5 +- drivers/md/dm-thin-metadata.c | 20 +- drivers/md/dm.c | 4 + drivers/mmc/core/block.c | 5 + drivers/net/ethernet/freescale/enetc/enetc_qos.c | 4 +- drivers/net/ethernet/intel/iavf/iavf.h | 2 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 15 +- drivers/net/ethernet/intel/iavf/iavf_register.h | 2 +- drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 + drivers/net/ethernet/intel/igc/igc_main.c | 9 +- .../net/ethernet/marvell/octeontx2/af/rvu_nix.c | 7 +- drivers/net/ipvlan/ipvlan_l3s.c | 4 + drivers/net/usb/qmi_wwan.c | 2 + drivers/net/wan/lapbether.c | 3 + drivers/nvme/host/pci.c | 2 + drivers/of/overlay.c | 311 ++- drivers/platform/x86/asus-nb-wmi.c | 2 + drivers/power/supply/ab8500_btemp.c | 6 +- drivers/power/supply/ab8500_fg.c | 6 +- drivers/power/supply/bq27xxx_battery.c | 6 +- drivers/power/supply/power_supply_core.c | 8 +- drivers/power/supply/power_supply_sysfs.c | 3 +- drivers/power/supply/sc27xx_fuel_gauge.c | 9 +- drivers/regulator/core.c | 4 +- drivers/spi/spi-fsl-dspi.c | 15 + drivers/thunderbolt/dma_test.c | 8 +- drivers/thunderbolt/nhi.c | 11 +- drivers/tty/serial/lantiq.c | 1 + drivers/usb/dwc3/gadget.c | 1 + drivers/usb/serial/option.c | 16 + fs/afs/vl_probe.c | 4 +- fs/btrfs/block-group.c | 14 +- fs/btrfs/file-item.c | 4 +- fs/btrfs/scrub.c | 9 +- fs/cifs/file.c | 8 +- fs/eventpoll.c | 6 +- fs/ext4/balloc.c | 20 +- fs/ksmbd/smb2pdu.c | 10 +- fs/nilfs2/btnode.c | 12 +- fs/nilfs2/sufile.c | 9 + fs/nilfs2/the_nilfs.c | 44 +- fs/ocfs2/file.c | 8 +- fs/ocfs2/super.c | 6 +- include/linux/netdevice.h | 4 - include/linux/netfilter.h | 5 - include/linux/netfilter_defs.h | 8 - include/linux/of.h | 16 +- include/net/dn.h | 231 -- include/net/dn_dev.h | 199 -- include/net/dn_fib.h | 167 -- include/net/dn_neigh.h | 30 - include/net/dn_nsp.h | 195 -- include/net/dn_route.h | 115 - include/net/dst.h | 6 - include/net/flow.h | 26 - include/net/neighbour.h | 7 - include/net/netfilter/nf_tables.h | 4 +- include/net/netns/netfilter.h | 3 - include/rdma/ib_addr.h | 23 - include/sound/soc-dpcm.h | 4 + include/uapi/linux/dn.h | 149 -- include/uapi/linux/ethtool_netlink.h | 2 +- include/uapi/linux/netfilter_decnet.h | 72 - include/uapi/linux/netlink.h | 2 +- io_uring/io_uring.c | 3 + kernel/cgroup/cgroup.c | 17 +- kernel/kexec_file.c | 14 +- kernel/rcu/tree.c | 39 +- lib/test_firmware.c | 65 +- net/Kconfig | 2 - net/Makefile | 1 - net/core/dev.c | 4 +- net/core/neighbour.c | 34 - net/decnet/Kconfig | 43 - net/decnet/Makefile | 10 - net/decnet/README | 8 - net/decnet/af_decnet.c | 2400 -------------------- net/decnet/dn_dev.c | 1433 ------------ net/decnet/dn_fib.c | 798 ------- net/decnet/dn_neigh.c | 605 ----- net/decnet/dn_nsp_in.c | 906 -------- net/decnet/dn_nsp_out.c | 695 ------ net/decnet/dn_route.c | 1922 ---------------- net/decnet/dn_rules.c | 258 --- net/decnet/dn_table.c | 929 -------- net/decnet/dn_timer.c | 104 - net/decnet/netfilter/Kconfig | 17 - net/decnet/netfilter/Makefile | 6 - net/decnet/netfilter/dn_rtmsg.c | 158 -- net/decnet/sysctl_net_decnet.c | 362 --- net/ipv6/ping.c | 3 +- net/netfilter/core.c | 10 - net/netfilter/nf_tables_api.c | 59 +- net/netfilter/nfnetlink.c | 3 +- net/netfilter/nfnetlink_hook.c | 7 - net/netfilter/nft_set_pipapo.c | 55 +- net/sched/act_pedit.c | 176 +- net/sched/cls_api.c | 12 +- net/sched/cls_u32.c | 18 +- net/sctp/sm_statefuns.c | 2 +- net/tipc/bearer.c | 4 +- net/wireless/reg.c | 6 +- sound/pci/hda/patch_realtek.c | 1 + sound/soc/dwc/dwc-i2s.c | 41 +- sound/soc/soc-pcm.c | 20 + sound/usb/quirks.c | 2 + tools/gpio/lsgpio.c | 2 +- tools/testing/selftests/ptp/testptp.c | 6 +- 159 files changed, 1004 insertions(+), 12795 deletions(-)

1 year, 3 months

13
126
0 0

[PATCH v7 0/4] kexec: Fix kexec_file_load for llvm16 with PGO

by Ricardo Ribalda

When upreving llvm I realised that kexec stopped working on my test platform. The reason seems to be that due to PGO there are multiple .text sections on the purgatory, and kexec does not supports that. Signed-off-by: Ricardo Ribalda <ribalda(a)chromium.org> --- Changes in v7: - Fix $SUBJECT of riscv patch - Rename PGO as Profile-guided optimization - Link to v6: https://lore.kernel.org/r/20230321-kexec_clang16-v6-0-a2255e81ab45@chromium… Changes in v6: - Replace linker script with Makefile rule. Thanks Nick - Link to v5: https://lore.kernel.org/r/20230321-kexec_clang16-v5-0-5563bf7c4173@chromium… Changes in v5: - Add warning when multiple text sections are found. Thanks Simon! - Add Fixes tag. - Link to v4: https://lore.kernel.org/r/20230321-kexec_clang16-v4-0-1340518f98e9@chromium… Changes in v4: - Add Cc: stable - Add linker script for x86 - Add a warning when the kernel image has overlapping sections. - Link to v3: https://lore.kernel.org/r/20230321-kexec_clang16-v3-0-5f016c8d0e87@chromium… Changes in v3: - Fix initial value. Thanks Ross! - Link to v2: https://lore.kernel.org/r/20230321-kexec_clang16-v2-0-d10e5d517869@chromium… Changes in v2: - Fix if condition. Thanks Steven!. - Update Philipp email. Thanks Baoquan. - Link to v1: https://lore.kernel.org/r/20230321-kexec_clang16-v1-0-a768fc2c7c4d@chromium… --- Ricardo Ribalda (4): kexec: Support purgatories with .text.hot sections x86/purgatory: Remove PGO flags powerpc/purgatory: Remove PGO flags riscv/purgatory: Remove PGO flags arch/powerpc/purgatory/Makefile | 5 +++++ arch/riscv/purgatory/Makefile | 5 +++++ arch/x86/purgatory/Makefile | 5 +++++ kernel/kexec_file.c | 14 +++++++++++++- 4 files changed, 28 insertions(+), 1 deletion(-) --- base-commit: 58390c8ce1bddb6c623f62e7ed36383e7fa5c02f change-id: 20230321-kexec_clang16-4510c23d129c Best regards, -- Ricardo Ribalda Delgado <ribalda(a)chromium.org>

1 year, 3 months

3
10
0 0

[PATCH] iio: afe: rescale: Fix logic bug

by Linus Walleij

When introducing support for processed channels I needed to invert the expression: if (!iio_channel_has_info(schan, IIO_CHAN_INFO_RAW) || !iio_channel_has_info(schan, IIO_CHAN_INFO_SCALE)) dev_err(dev, "source channel does not support raw/scale\n"); To the inverse, meaning detect when we can usse raw+scale rather than when we can not. This was the result: if (iio_channel_has_info(schan, IIO_CHAN_INFO_RAW) || iio_channel_has_info(schan, IIO_CHAN_INFO_SCALE)) dev_info(dev, "using raw+scale source channel\n"); Ooops. Spot the error. Yep old George Boole came up and bit me. That should be an &&. The current code "mostly works" because we have not run into systems supporting only raw but not scale or only scale but not raw, and I doubt there are few using the rescaler on anything such, but let's fix the logic. Cc: Liam Beguin <liambeguin(a)gmail.com> Cc: stable(a)vger.kernel.org Fixes: 53ebee949980 ("iio: afe: iio-rescale: Support processed channels") Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- drivers/iio/afe/iio-rescale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c index 7e511293d6d1..dc426e1484f0 100644 --- a/drivers/iio/afe/iio-rescale.c +++ b/drivers/iio/afe/iio-rescale.c @@ -278,7 +278,7 @@ static int rescale_configure_channel(struct device *dev, chan->ext_info = rescale->ext_info; chan->type = rescale->cfg->type; - if (iio_channel_has_info(schan, IIO_CHAN_INFO_RAW) || + if (iio_channel_has_info(schan, IIO_CHAN_INFO_RAW) && iio_channel_has_info(schan, IIO_CHAN_INFO_SCALE)) { dev_info(dev, "using raw+scale source channel\n"); } else if (iio_channel_has_info(schan, IIO_CHAN_INFO_PROCESSED)) { -- 2.35.3

1 year, 3 months

6
17
0 0

[PATCH] file: always lock position

by Christian Brauner

By abusing new methods of file descriptor transferal it is possible to break the assumption that f_pos_lock doesn't need to be acquired when the caller is single threaded and the file_count(file) is one aka when the caller holds the only reference to the file. The explanation has two parts. The first part is about a new io_uring interface that isn't merged yet where I realized that only acquiring the lock when multiple references to a file are held would be broken in some circumstances. The second part illustrates that this assumption is already broken by abusing another interface. During review of the io_uring patchset for adding getdents support I pointed out various problems in the locking assumptions that were made. Effectively, the guts of __fdget_pos() were copied out and a trylock scheme for f_pos_lock was introduced. The approach overall is workable but the locking was wrong because it copied the file_count(file) greater than one optimization that __fdget_pos() had into io_uring. But this assumption is broken when fixed file descriptors are used. Short reminder of fixed files here via some C pseudo code: T1 (still single threaded) fd_register = open("/some/file") -----------------> f_count == 1 fd_fixed = io_uring_register_file(fd_register) -> io_sqe_files_register(fd_register) -> fget(fd_register) --------------------------> f_count == 2 -> io_fixed_file_set(fd_register) close(fd_register); -> close_fd(fd_register) -> file = pick_file() -> filp_close(file) -> fput(file) ------------------------------> f_count == 1 The caller has now traded a regular file descriptor reference for a fixed file reference. Such fixed files never use fget() again and thus fully eliminate any fget()/fput() overhead. However, for getdents f_pos_lock needs to be acquired as state may often be kept that requires synchronization with seek and other concurrent getdent requests. Since io_uring is an asynchronous interface it is of course possible to register multiple concurrent getdent calls that aren't synchronized by io_uring as that's never done unless the user requests specific chaining. And since the reference count for fixed files is always one it's possible to create multiple racing getdent requests if locking is conditional on file_count(file) being greater than one. That wouldn't be a problem since io_uring can just unconditionally take f_pos_lock and eliminate this problem for fixed files since they aren't usable with the regular system call api. However, while thinking about this I realized that a while ago the file_count(file) greater than one optimization was already broken and that concurrent read/write/getdents/seek calls are possible in the regular system call api. The pidfd_getfd() system call allows a caller with ptrace_may_access() abilities on another process to steal a file descriptor from this process. This system call is used by debuggers, container runtimes, system call supervisors, networking proxies etc (cf. [1]-[3]). So while it is a special interest system call it is used in common tools. Via pidfd_getfd() it's possible to intercept syscalls such as connect(2). For example, a container manager might want to rewrite the connect(2) request to something other than the task intended for security reasons or because the task lacks the necessary information about the networking layout to connect to the right endpoint. In these cases pidfd_getfd(2) can be used to retrieve a copy of the file descriptor of the task and perform the connect(2) for it. When used in combination with the seccomp notifier things are pretty simple. The intercepted task itself is blocked in the seccomp code. That code runs before the actual requested system call is performed. So the task is blocked before any system call is performed. The seccomp notifier will then notify the supervising process which holds the seccomp notifier fd. The supervisor can now call pidfd_getfd() while the target process is blocked and steal the file descriptor. It can then perform whatever operation it wants on that file descriptor and then tell seccomp to either return a specific return value to the task once it is unblocked or even continue the task using the SECCOMP_USER_NOTIF_FLAG_CONTINUE flag. One of the most useful things for pidfd_getfd() is that the target task from which the caller is about to steal a file descriptor doesn't need to be blocked or stopped. But that makes it possible for the target process to be in the middle of a read/write/getdents/seek system call while the caller is stealing the file on which that read/write/getdents/seek was issued and issuing a concurrent read/write/getdents/seek system call: P1 P2 getdents(fd) -> fdget_pos() { * @file->f_count == 1 * @current->files->count == 1 => not taking @file->f_pos_lock } fd = pidfd_getfd(fd) -> __pidfd_fget() -> fget_task() ----> f_count = 2 -> receive_fd() -> get_file() --> f_count = 3 -> fd_install() -> fput() ---------> f_count = 2 getdents(fd) -> fdget_pos() { * @file->f_count == 1 * @file->f_count == 2 => taking @file->f_pos_lock and bumping @file->f_count = 3 } -> vfs_readdir() -> vfs_readdir() -> fdput() -> fdput()---------> f_count = 2 Although I'm not happy about it, I'm somewhat confident that this analysis is correct but that the race is hard to hit in real life but with some ingenuity it might be possible to make it more reliable. However, I was lazy and introduced a luscious 10 second delay after fdget_pos() succeeded into vfs_read() that was triggerable by passing -1 as the buffer size to the read() system call. I then used the very very ugly program in [4] to enforce the order illustrated above. Lastly, I wrote a bpftrace program which attached a kretfunc to __fdget_pos() and a kfunc and a kretfunc to vfs_read(). The bpftrace program would only trigger if the target file with a specific inode number was read: Attaching 3 probes... fdget_pos() on file pointer 0xffff8b3500d6a300: name(stealme) | i_ino(1591) | pid(9690) FDPUT_POS_UNLOCK(0), count(1) => mutex not acquired vfs_read() on file pointer 0xffff8b3500d6a300: pid 9690 started reading from name(stealme) | i_ino(1591) fdget_pos() on file pointer 0xffff8b3500d6a300: name(stealme) | i_ino(1591) | pid(9691) FDPUT_POS_UNLOCK(2), count(2) => mutex acquired vfs_read() on file pointer 0xffff8b3500d6a300: pid 9691 started reading from name(stealme) | i_ino(1591) vfs_read() on file pointer 0xffff8b3500d6a300: pid 9690 finished reading from name(stealme) | i_ino(1591) vfs_read() on file pointer 0xffff8b3500d6a300: pid 9691 finished reading from name(stealme) | i_ino(1591) I thought about various ways to fix this such as introducing some mechanism to refuse pidfd_getfd() if the target process is in the middle of an fdget_pos() protected system call with file count being one up to just not caring about it at all. But it is pretty nasty to leave this race open and it feels like something that'll bite us later anyway. Plus, with io_uring having to acquire f_pos_lock unconditionally anyway for getdents support I'm not sure that deviation in locking semantics here is worth keeping. So remove the locking optimization for file count being one. We'll see if this has a significant performance impact. This survives xfstests and LTP. Link: https://github.com/rr-debugger/rr [1] Link: https://github.com/opencontainers/runc [2] Link: https://brauner.io/2020/07/23/seccomp-notify.html [3] Link: https://gist.github.com/brauner/599d31048c8adcb3aa0c537b76c89e12 [4] Fixes: 8649c322f75c ("pid: Implement pidfd_getfd syscall") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Brauner <brauner(a)kernel.org> --- --- fs/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/file.c b/fs/file.c index 7893ea161d77..35c62b54c9d6 100644 --- a/fs/file.c +++ b/fs/file.c @@ -1042,10 +1042,8 @@ unsigned long __fdget_pos(unsigned int fd) struct file *file = (struct file *)(v & ~3); if (file && (file->f_mode & FMODE_ATOMIC_POS)) { - if (file_count(file) > 1) { - v |= FDPUT_POS_UNLOCK; - mutex_lock(&file->f_pos_lock); - } + v |= FDPUT_POS_UNLOCK; + mutex_lock(&file->f_pos_lock); } return v; } --- base-commit: 6eaae198076080886b9e7d57f4ae06fa782f90ef change-id: 20230724-vfs-fdget_pos-c6540e3ed7d9

1 year, 3 months

7
36
0 0

Fwd: in linux 6.3.7-200.fc38.x86_64 goes vlc in time to switch tv channels to zombie-process

by Bagas Sanjaya

Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > vmlinuz-6.3.7-200.fc38.x86_64 and vmlinuz-6.3.8-200.fc38.x86_64 > > in the switch tv channel to another vlc stay blocked and and the loading of firmware newer ending. power must be switch to off. > from dmesg: > > dvb-tuner-si2141-a10-01.fw > dvb-demod-si2168-d60-01.fw > firmware version: D 6.0.13 > > restart of dvb modules is impossible, They stay working. > > kernel 6.3.5-200.fc38.x86_64 works OK. I don't how works kernel 6.3.6-200.fc38.x86_64 > > this same error is in vmlinuz-6.3.5-200.fc38.x86_64 and earliers but there is the occurence accesptable. > > listing from 6.3.5 kernel: > > [ 3378.026035] si2168 7-0064: firmware version: D 6.0.13 > [ 3431.891579] si2168 7-0064: downloading firmware from file 'dvb-demod-si2168-d60-01.fw' > [ 3434.037278] usb 1-4: dvb_usb_v2: 2nd usb_bulk_msg() failed=-110 > [ 3434.037289] si2168 7-0064: firmware download failed -110 > [ 3436.085265] usb 1-4: dvb_usb_v2: usb_bulk_msg() failed=-110 > > lsmod |grep dvb > dvb_usb_dvbsky 32768 2 > dvb_usb_v2 57344 1 dvb_usb_dvbsky > m88ds3103 49152 1 dvb_usb_dvbsky > dvb_core 192512 3 dvb_usb_v2,m88ds3103,dvb_usb_dvbsky > m > > modprobe -r dvb_usb_dvbsky > modprobe: FATAL: Module dvb_usb_dvbsky is in use. > > ?????? The problem in dvb_usb_dvbsky or firmware ????? > > The answer from https://bugzilla.rpmfusion.org was: > > If it was working with previous kernel this is likely a kernel regression. > please forward to the dvb sub-system maintainers. > > this problen insist a long time (years), but not too horible See Bugzilla for the full thread and attached dmesg and lsusb. Thorsten: The reporter can't perform bisection for he has problem compiling his own vanilla kernel (see comment 8 on the Bugzilla ticket, albeit with translated make(1) output). Can you take a look on it? Anyway, I'm adding it to regzbot (as stable-specific regression for now): #regzbot introduced: v6.3.5..v6.3.7 https://bugzilla.kernel.org/show_bug.cgi?id=217566 #regzbot title: switching TV channel causes VLC and firmware loading hang Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217566 -- An old man doll... just what I always wanted! - Clara

1 year, 3 months

5
6
0 0

6.1.30: thunderbolt: Clear registers properly when auto clear isn't in use cause call trace after resume

by beld zhang

Upgrade to 6.1.30, got crash message after resume, but looks still running normally After revert e16629c639d429e48c849808e59f1efcce886849 thunderbolt: Clear registers properly when auto clear isn't in use This error was gone. kernel config attached, system is Slackware 15.0 on XPS 9700 May 27 13:55:39 devel kernel: ------------[ cut here ]------------ May 27 13:55:39 devel kernel: thunderbolt 0000:07:00.0: interrupt for TX ring 0 is already enabled May 27 13:55:39 devel kernel: WARNING: CPU: 15 PID: 21394 at drivers/thunderbolt/nhi.c:137 ring_interrupt_active+0x1ff/0x250 [thunderbolt] May 27 13:55:39 devel kernel: Modules linked in: squashfs nls_iso8859_1 nls_cp437 tun fuse 8021q garp mrp iptable_nat xt_MASQUERADE nf_nat nf_conntrack nf_defrag_ipv4 ip_tables x_tables efivarfs binfmt_misc snd_ctl_led snd_soc_sof_sdw snd_soc_intel_hda_dsp_common snd_soc_intel_sof_maxim_common snd_sof_probes snd_soc_rt715 snd_soc_rt711 snd_soc_rt1308_sdw regmap_sdw snd_soc_dmic snd_sof_pci_intel_cnl snd_sof_intel_hda_common snd_sof_pci soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_intel_hda snd_sof snd_sof_utils snd_sof_xtensa_dsp snd_soc_acpi_intel_match snd_soc_acpi snd_soc_hdac_hda soundwire_bus snd_hda_ext_core snd_hda_codec_hdmi snd_soc_core coretemp snd_compress ac97_bus nouveau intel_tcc_cooling snd_hda_intel x86_pkg_temp_thermal dell_smm_hwmon hid_multitouch iwlmvm hwmon intel_powerclamp snd_intel_dspcfg mxm_wmi i915 i2c_designware_platform snd_intel_sdw_acpi rtsx_pci_sdmmc drm_ttm_helper i2c_designware_core mac80211 drm_buddy i2c_algo_bit dell_laptop snd_hda_codec May 27 13:55:39 devel kernel: ucsi_ccg dell_wmi mmc_core hid_generic drm_display_helper ledtrig_audio sparse_keymap libarc4 snd_hwdep intel_rapl_msr dell_smbios uvcvideo ttm snd_hda_core dell_wmi_sysman kvm_intel videobuf2_vmalloc firmware_attributes_class dell_wmi_descriptor wmi_bmof intel_wmi_thunderbolt dcdbas processor_thermal_device_pci_legacy drm_kms_helper videobuf2_memops iwlwifi intel_soc_dts_iosf kvm btusb r8153_ecm btrtl videobuf2_v4l2 snd_pcm syscopyarea processor_thermal_device irqbypass cdc_ether btbcm evdev usbnet psmouse intel_lpss_pci btintel processor_thermal_rfim snd_timer videobuf2_common crc32c_intel ucsi_acpi sysfillrect ghash_clmulni_intel serio_raw cfg80211 efi_pstore r8152 typec_ucsi bluetooth sysimgblt videodev processor_thermal_mbox intel_gtt intel_lpss fb_sys_fops processor_thermal_rapl i2c_i801 roles snd i2c_nvidia_gpu drm i2c_smbus ecdh_generic idma64 i2c_hid_acpi mii usbhid thunderbolt mc soundcore rtsx_pci ecc agpgart i2c_ccgx_ucsi rfkill intel_rapl_common mfd_core May 27 13:55:39 devel kernel: intel_pch_thermal i2c_hid typec video button battery hid int3403_thermal int340x_thermal_zone pinctrl_cannonlake pinctrl_intel wmi int3400_thermal intel_pmc_core acpi_pad acpi_thermal_rel acpi_tad ac usb_storage May 27 13:55:39 devel kernel: CPU: 15 PID: 21394 Comm: kworker/u32:15 Tainted: G W 6.1.30-dell-2 #1 May 27 13:55:39 devel kernel: Hardware name: Dell Inc. XPS 17 9700/0P1CHN, BIOS 1.11.1 11/18/2021 May 27 13:55:39 devel kernel: Workqueue: events_unbound async_run_entry_fn May 27 13:55:39 devel kernel: RIP: 0010:ring_interrupt_active+0x1ff/0x250 [thunderbolt] May 27 13:55:39 devel kernel: Code: 24 04 e8 24 2b 3c e1 4c 8b 4c 24 08 44 8b 44 24 04 48 c7 c7 50 c7 29 a0 48 8b 4c 24 10 48 8b 54 24 18 48 89 c6 e8 71 34 e4 e0 <0f> 0b 45 84 ed 0f 85 09 ff ff ff 48 8b 43 08 f6 40 70 01 0f 85 38 May 27 13:55:39 devel kernel: RSP: 0018:ffffc90000517c48 EFLAGS: 00010082 May 27 13:55:39 devel kernel: RAX: 0000000000000000 RBX: ffff888101dab800 RCX: 0000000000000000 May 27 13:55:39 devel kernel: RDX: 0000000000000004 RSI: 0000000000000086 RDI: 00000000ffffffff May 27 13:55:39 devel kernel: RBP: 0000000000000000 R08: 80000000ffffe7b4 R09: 0000000082999bac May 27 13:55:39 devel kernel: R10: ffffffffffffffff R11: ffffffff82999ba1 R12: 0000000000001001 May 27 13:55:39 devel kernel: R13: 0000000000000001 R14: 0000000000038200 R15: 0000000000000001 May 27 13:55:39 devel kernel: FS: 0000000000000000(0000) GS:ffff88887d7c0000(0000) knlGS:0000000000000000 May 27 13:55:39 devel kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 May 27 13:55:39 devel kernel: CR2: 00007f745c010b00 CR3: 000000000220a005 CR4: 00000000007706e0 May 27 13:55:39 devel kernel: PKRU: 55555554 May 27 13:55:39 devel kernel: Call Trace: May 27 13:55:39 devel kernel: <TASK> May 27 13:55:39 devel kernel: tb_ring_start+0x141/0x230 [thunderbolt] May 27 13:55:39 devel kernel: tb_ctl_start+0x1f/0x70 [thunderbolt] May 27 13:55:39 devel kernel: ? pci_pm_restore_noirq+0xc0/0xc0 May 27 13:55:39 devel kernel: tb_domain_runtime_resume+0x15/0x30 [thunderbolt] May 27 13:55:39 devel kernel: __rpm_callback+0x41/0x110 May 27 13:55:39 devel kernel: ? pci_pm_restore_noirq+0xc0/0xc0 May 27 13:55:39 devel kernel: rpm_callback+0x59/0x70 May 27 13:55:39 devel kernel: rpm_resume+0x4b3/0x7f0 May 27 13:55:39 devel kernel: ? _raw_spin_unlock_irq+0x13/0x30 May 27 13:55:39 devel kernel: ? __wait_for_common+0x171/0x1a0 May 27 13:55:39 devel kernel: ? usleep_range_state+0x90/0x90 May 27 13:55:39 devel kernel: ? preempt_count_add+0x68/0xa0 May 27 13:55:39 devel kernel: __pm_runtime_resume+0x4a/0x80 May 27 13:55:39 devel kernel: pci_pm_suspend+0x60/0x170 May 27 13:55:39 devel kernel: ? pci_pm_freeze+0xb0/0xb0 May 27 13:55:39 devel kernel: dpm_run_callback+0x3f/0x150 May 27 13:55:39 devel kernel: ? _raw_spin_lock_irqsave+0x19/0x40 May 27 13:55:39 devel kernel: __device_suspend+0x130/0x4d0 May 27 13:55:39 devel kernel: async_suspend+0x1b/0x90 May 27 13:55:39 devel kernel: async_run_entry_fn+0x1a/0xa0 May 27 13:55:39 devel kernel: process_one_work+0x1bd/0x3c0 May 27 13:55:39 devel kernel: worker_thread+0x4d/0x3c0 May 27 13:55:39 devel kernel: ? process_one_work+0x3c0/0x3c0 May 27 13:55:39 devel kernel: kthread+0xe5/0x110 May 27 13:55:39 devel kernel: ? kthread_complete_and_exit+0x20/0x20 May 27 13:55:39 devel kernel: ret_from_fork+0x1f/0x30 May 27 13:55:39 devel kernel: </TASK> May 27 13:55:39 devel kernel: ---[ end trace 0000000000000000 ]---

1 year, 3 months

5
12
0 0

Re: New kernel warning after updating from LTS 5.15.110 to 5.15.112 (and 5.15.113)

by Lino Sanfilippo

Hi Greg, On 06.06.23 08:45, Greg KH wrote: >> >> Lino, it looks like this regression is caused by (backported) commit of yours. >> Would you like to take a look on it? >> >> Anyway, telling regzbot: >> >> #regzbot introduced: 51162b05a44cb5 > > There's some tpm backports to 5.15.y that were suspect and I'll look > into reverting them and see if this was one of the ones that was on that > list. Give me a few days... > Could you please consider to apply (mainline) commit 0c7e66e5fd69 ("tpm, tpm_tis: Request threaded interrupt handler") to 5.15.y? As Chris confirmed it fixes the regression caused by 51162b05a44cb5 ("tpm, tpm_tis: Claim locality before writing interrupt registers"). Commit 0c7e66e5fd69 is also needed for 5.10.y, 6.1.y and 6.3.y. Best regards, Lino

1 year, 3 months

3
3
0 0

[PATCH] clocksource/drivers/arm_arch_timer: Disable timer before programming CVAL

by walter.chang＠mediatek.com

From: Walter Chang <walter.chang(a)mediatek.com> Due to the fact that the use of `writeq_relaxed()` to program CVAL is not guaranteed to be atomic, it is necessary to disable the timer before programming CVAL. However, if the MMIO timer is already enabled and has not yet expired, there is a possibility of unexpected behavior occurring: when the CPU enters the idle state during this period, and if the CPU's local event is earlier than the broadcast event, the following process occurs: tick_broadcast_enter() tick_broadcast_oneshot_control(TICK_BROADCAST_ENTER) __tick_broadcast_oneshot_control() ___tick_broadcast_oneshot_control() tick_broadcast_set_event() clockevents_program_event() set_next_event_mem() During this process, the MMIO timer remains enabled while programming CVAL. To prevent such behavior, disable timer explicitly prior to programming CVAL. Fixes: 8b82c4f883a7 ("clocksource/drivers/arm_arch_timer: Move MMIO timer programming over to CVAL") Cc: stable(a)vger.kernel.org Signed-off-by: Walter Chang <walter.chang(a)mediatek.com> --- drivers/clocksource/arm_arch_timer.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c index e733a2a1927a..7dd2c615bce2 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b/drivers/clocksource/arm_arch_timer.c @@ -792,6 +792,13 @@ static __always_inline void set_next_event_mem(const int access, unsigned long e u64 cnt; ctrl = arch_timer_reg_read(access, ARCH_TIMER_REG_CTRL, clk); + + /* Timer must be disabled before programming CVAL */ + if (ctrl & ARCH_TIMER_CTRL_ENABLE) { + ctrl &= ~ARCH_TIMER_CTRL_ENABLE; + arch_timer_reg_write(access, ARCH_TIMER_REG_CTRL, ctrl, clk); + } + ctrl |= ARCH_TIMER_CTRL_ENABLE; ctrl &= ~ARCH_TIMER_CTRL_IT_MASK; -- 2.18.0

1 year, 3 months

6
5
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2023