July 2023 - Linux-stable-mirror

FAILED: patch "[PATCH] r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions" failed to apply to 6.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.4.y git checkout FETCH_HEAD git cherry-pick -x cf2ffdea0839398cb0551762af7f5efb0a6e0fea # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2023072337-dreamlike-rewrite-a12e@gregkh' --subject-prefix 'PATCH 6.4.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From cf2ffdea0839398cb0551762af7f5efb0a6e0fea Mon Sep 17 00:00:00 2001 From: Heiner Kallweit <hkallweit1(a)gmail.com> Date: Tue, 18 Jul 2023 13:11:31 +0200 Subject: [PATCH] r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions now that ASPM is disabled during NAPI poll") There have been reports that on a number of systems this change breaks network connectivity. Therefore effectively revert it. Mainly affected seem to be systems where BIOS denies ASPM access to OS. Due to later changes we can't do a direct revert. Fixes: 2ab19de62d67 ("r8169: remove ASPM restrictions now that ASPM is disabled during NAPI poll") Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/netdev/e47bac0d-e802-65e1-b311-6acb26d5cf10@freenet… Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217596 Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> Link: https://lore.kernel.org/r/57f13ec0-b216-d5d8-363d-5b05528ec5fb@gmail.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index fce4a2b908c2..8a8b7d8a5c3f 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -623,6 +623,7 @@ struct rtl8169_private { int cfg9346_usage_count; unsigned supports_gmii:1; + unsigned aspm_manageable:1; dma_addr_t counters_phys_addr; struct rtl8169_counters *counters; struct rtl8169_tc_offsets tc_offset; @@ -2746,7 +2747,8 @@ static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) if (tp->mac_version < RTL_GIGA_MAC_VER_32) return; - if (enable) { + /* Don't enable ASPM in the chip if OS can't control ASPM */ + if (enable && tp->aspm_manageable) { /* On these chip versions ASPM can even harm * bus communication of other PCI devices. */ @@ -5165,6 +5167,16 @@ static void rtl_init_mac_address(struct rtl8169_private *tp) rtl_rar_set(tp, mac_addr); } +/* register is set if system vendor successfully tested ASPM 1.2 */ +static bool rtl_aspm_is_safe(struct rtl8169_private *tp) +{ + if (tp->mac_version >= RTL_GIGA_MAC_VER_61 && + r8168_mac_ocp_read(tp, 0xc0b2) & 0xf) + return true; + + return false; +} + static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) { struct rtl8169_private *tp; @@ -5234,6 +5246,19 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) xid); tp->mac_version = chipset; + /* Disable ASPM L1 as that cause random device stop working + * problems as well as full system hangs for some PCIe devices users. + * Chips from RTL8168h partially have issues with L1.2, but seem + * to work fine with L1 and L1.1. + */ + if (rtl_aspm_is_safe(tp)) + rc = 0; + else if (tp->mac_version >= RTL_GIGA_MAC_VER_46) + rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1_2); + else + rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1); + tp->aspm_manageable = !rc; + tp->dash_type = rtl_check_dash(tp); tp->cp_cmd = RTL_R16(tp, CPlusCmd) & CPCMD_MASK;

2 years, 4 months

3
4
0 0

stable/linux-5.15.y baseline: 27 runs, 7 regressions (v5.15.122)

by kernelci.org bot

stable/linux-5.15.y baseline: 27 runs, 7 regressions (v5.15.122) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-C436FA-Flip-hatch | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 asus-CM1400CXA-dalboz | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 asus-cx9400-volteer | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 hp-x360-12b-c...4020-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 hp-x360-14a-cb0001xx-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 lenovo-TPad-C13-Yoga-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/job/stable/branch/linux-5.15.y/kernel/v5.15.122/p… Test: baseline Tree: stable Branch: linux-5.15.y Describe: v5.15.122 URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git SHA: 5c6a716301d915055c7bd6d935f7a4fccec2649c Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-C436FA-Flip-hatch | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf068ea25a67b1e78ace3b Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf068ea25a67b1e78ace40 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:17.099751 <8>[ 8.157551] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130816_1.4.2.3.1> 2023-07-24T23:17:17.103151 + set +x 2023-07-24T23:17:17.207653 / # # 2023-07-24T23:17:17.308257 export SHELL=/bin/sh 2023-07-24T23:17:17.308447 # 2023-07-24T23:17:17.408966 / # export SHELL=/bin/sh. /lava-11130816/environment 2023-07-24T23:17:17.409138 2023-07-24T23:17:17.509644 / # . /lava-11130816/environment/lava-11130816/bin/lava-test-runner /lava-11130816/1 2023-07-24T23:17:17.509880 2023-07-24T23:17:17.515934 / # /lava-11130816/bin/lava-test-runner /lava-11130816/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-CM1400CXA-dalboz | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf0698039dd67e558ace21 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf0698039dd67e558ace26 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:27.252438 + set<8>[ 11.291998] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130818_1.4.2.3.1> 2023-07-24T23:17:27.252524 +x 2023-07-24T23:17:27.356524 / # # 2023-07-24T23:17:27.457141 export SHELL=/bin/sh 2023-07-24T23:17:27.457339 # 2023-07-24T23:17:27.557858 / # export SHELL=/bin/sh. /lava-11130818/environment 2023-07-24T23:17:27.558025 2023-07-24T23:17:27.658655 / # . /lava-11130818/environment/lava-11130818/bin/lava-test-runner /lava-11130818/1 2023-07-24T23:17:27.659689 2023-07-24T23:17:27.664441 / # /lava-11130818/bin/lava-test-runner /lava-11130818/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ asus-cx9400-volteer | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf06a2376449665d8ace24 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf06a2376449665d8ace29 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:43.055067 <8>[ 10.789807] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130820_1.4.2.3.1> 2023-07-24T23:17:43.058434 + set +x 2023-07-24T23:17:43.159877 # 2023-07-24T23:17:43.160342 2023-07-24T23:17:43.261093 / # #export SHELL=/bin/sh 2023-07-24T23:17:43.261306 2023-07-24T23:17:43.361829 / # export SHELL=/bin/sh. /lava-11130820/environment 2023-07-24T23:17:43.362026 2023-07-24T23:17:43.462559 / # . /lava-11130820/environment/lava-11130820/bin/lava-test-runner /lava-11130820/1 2023-07-24T23:17:43.462993 ... (13 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-12b-c...4020-octopus | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf0680d14dcb07da8ace50 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf0680d14dcb07da8ace55 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:21.850328 + set +x 2023-07-24T23:17:21.857135 <8>[ 9.906592] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130842_1.4.2.3.1> 2023-07-24T23:17:21.961421 / # # 2023-07-24T23:17:22.062000 export SHELL=/bin/sh 2023-07-24T23:17:22.062191 # 2023-07-24T23:17:22.162677 / # export SHELL=/bin/sh. /lava-11130842/environment 2023-07-24T23:17:22.162875 2023-07-24T23:17:22.263393 / # . /lava-11130842/environment/lava-11130842/bin/lava-test-runner /lava-11130842/1 2023-07-24T23:17:22.263704 2023-07-24T23:17:22.268689 / # /lava-11130842/bin/lava-test-runner /lava-11130842/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-14-G1-sona | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf067b226fa9f50e8ace53 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf067b226fa9f50e8ace58 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:05.842199 <8>[ 10.070568] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130830_1.4.2.3.1> 2023-07-24T23:17:05.845144 + set +x 2023-07-24T23:17:05.946788 # 2023-07-24T23:17:05.947075 2023-07-24T23:17:06.047677 / # #export SHELL=/bin/sh 2023-07-24T23:17:06.047939 2023-07-24T23:17:06.148513 / # export SHELL=/bin/sh. /lava-11130830/environment 2023-07-24T23:17:06.148691 2023-07-24T23:17:06.249217 / # . /lava-11130830/environment/lava-11130830/bin/lava-test-runner /lava-11130830/1 2023-07-24T23:17:06.249519 ... (13 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ hp-x360-14a-cb0001xx-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf069a42649666c98ace1e Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf069a42649666c98ace23 failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:25.800687 + set<8>[ 10.850466] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130857_1.4.2.3.1> 2023-07-24T23:17:25.801192 +x 2023-07-24T23:17:25.909843 / # # 2023-07-24T23:17:26.012231 export SHELL=/bin/sh 2023-07-24T23:17:26.012945 # 2023-07-24T23:17:26.114658 / # export SHELL=/bin/sh. /lava-11130857/environment 2023-07-24T23:17:26.115340 2023-07-24T23:17:26.216914 / # . /lava-11130857/environment/lava-11130857/bin/lava-test-runner /lava-11130857/1 2023-07-24T23:17:26.218258 2023-07-24T23:17:26.222414 / # /lava-11130857/bin/lava-test-runner /lava-11130857/1 ... (12 line(s) more) platform | arch | lab | compiler | defconfig | regressions -----------------------------+--------+---------------+----------+------------------------------+------------ lenovo-TPad-C13-Yoga-zork | x86_64 | lab-collabora | gcc-10 | x86_64_defcon...6-chromebook | 1 Details: https://kernelci.org/test/plan/id/64bf067ad14dcb07da8ace29 Results: 6 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig+x86-chromebook Compiler: gcc-10 (gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… HTML log: https://storage.kernelci.org//stable/linux-5.15.y/v5.15.122/x86_64/x86_64_d… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/buildroot-baseline/2023… * baseline.bootrr.deferred-probe-empty: https://kernelci.org/test/case/id/64bf067ad14dcb07da8ace2e failing since 116 days (last pass: v5.15.104, first fail: v5.15.105) 2023-07-24T23:17:08.780544 + set<8>[ 12.296441] <LAVA_SIGNAL_ENDRUN 0_dmesg 11130821_1.4.2.3.1> 2023-07-24T23:17:08.780630 +x 2023-07-24T23:17:08.885236 / # # 2023-07-24T23:17:08.985850 export SHELL=/bin/sh 2023-07-24T23:17:08.986074 # 2023-07-24T23:17:09.086609 / # export SHELL=/bin/sh. /lava-11130821/environment 2023-07-24T23:17:09.086802 2023-07-24T23:17:09.187317 / # . /lava-11130821/environment/lava-11130821/bin/lava-test-runner /lava-11130821/1 2023-07-24T23:17:09.187589 2023-07-24T23:17:09.192734 / # /lava-11130821/bin/lava-test-runner /lava-11130821/1 ... (12 line(s) more)

2 years, 4 months

1
0
0 0

stable-rc/linux-4.19.y build: 6 builds: 1 failed, 5 passed, 8 warnings (v4.19.289-218-g1cf0365815540)

by kernelci.org bot

stable-rc/linux-4.19.y build: 6 builds: 1 failed, 5 passed, 8 warnings (v4.19.289-218-g1cf0365815540) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.289-2… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.289-218-g1cf0365815540 Git Commit: 1cf0365815540b3e2db00b630d9519430a31b3bc Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 5 unique architectures Build Failure Detected: riscv: tinyconfig: (gcc-10) FAIL Warnings Detected: arc: arm: multi_v7_defconfig (gcc-10): 1 warning omap2plus_defconfig (gcc-10): 1 warning mips: 32r2el_defconfig (gcc-10): 1 warning riscv: x86_64: x86_64_defconfig (gcc-10): 5 warnings Warnings summary: 4 fs/ext4/ioctl.c:583:7: warning: assignment to ‘int’ from ‘struct super_block *’ makes integer from pointer without a cast [-Wint-conversion] 1 ld: warning: creating DT_TEXTREL in a PIE 1 ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' 1 drivers/gpu/drm/drm_edid.o: warning: objtool: validate_displayid.constprop.0()+0x6a: return with modified stack frame 1 drivers/gpu/drm/drm_edid.o: warning: objtool: validate_displayid.constprop.0()+0x0: stack state mismatch: cfa1=7+112 cfa2=7+8 ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- 32r2el_defconfig (mips, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: fs/ext4/ioctl.c:583:7: warning: assignment to ‘int’ from ‘struct super_block *’ makes integer from pointer without a cast [-Wint-conversion] -------------------------------------------------------------------------------- haps_hs_smp_defconfig (arc, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- multi_v7_defconfig (arm, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: fs/ext4/ioctl.c:583:7: warning: assignment to ‘int’ from ‘struct super_block *’ makes integer from pointer without a cast [-Wint-conversion] -------------------------------------------------------------------------------- omap2plus_defconfig (arm, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: fs/ext4/ioctl.c:583:7: warning: assignment to ‘int’ from ‘struct super_block *’ makes integer from pointer without a cast [-Wint-conversion] -------------------------------------------------------------------------------- tinyconfig (riscv, gcc-10) — FAIL, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- x86_64_defconfig (x86_64, gcc-10) — PASS, 0 errors, 5 warnings, 0 section mismatches Warnings: fs/ext4/ioctl.c:583:7: warning: assignment to ‘int’ from ‘struct super_block *’ makes integer from pointer without a cast [-Wint-conversion] drivers/gpu/drm/drm_edid.o: warning: objtool: validate_displayid.constprop.0()+0x6a: return with modified stack frame drivers/gpu/drm/drm_edid.o: warning: objtool: validate_displayid.constprop.0()+0x0: stack state mismatch: cfa1=7+112 cfa2=7+8 ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE --- For more info write to <info(a)kernelci.org>

2 years, 4 months

1
0
0 0

[PATCH net 1/2] can: gs_usb: gs_can_close(): add missing set of CAN state to CAN_STATE_STOPPED

by Marc Kleine-Budde

After an initial link up the CAN device is in ERROR-ACTIVE mode. Due to a missing CAN_STATE_STOPPED in gs_can_close() it doesn't change to STOPPED after a link down: | ip link set dev can0 up | ip link set dev can0 down | ip --details link show can0 | 13: can0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 10 | link/can promiscuity 0 allmulti 0 minmtu 0 maxmtu 0 | can state ERROR-ACTIVE restart-ms 1000 Add missing assignment of CAN_STATE_STOPPED in gs_can_close(). Cc: stable(a)vger.kernel.org Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices") Link: https://lore.kernel.org/all/20230718-gs_usb-fix-can-state-v1-1-f19738ae2c23… Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- drivers/net/can/usb/gs_usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c index f418066569fc..bd9eb066ecf1 100644 --- a/drivers/net/can/usb/gs_usb.c +++ b/drivers/net/can/usb/gs_usb.c @@ -1030,6 +1030,8 @@ static int gs_can_close(struct net_device *netdev) usb_kill_anchored_urbs(&dev->tx_submitted); atomic_set(&dev->active_tx_urbs, 0); + dev->can.state = CAN_STATE_STOPPED; + /* reset the device */ rc = gs_cmd_reset(dev); if (rc < 0) base-commit: 9f9d4c1a2e82174a4e799ec405284a2b0de32b6a -- 2.40.1

2 years, 4 months

2
1
0 0

[PATCH v9 0/7] Update AUX invalidation sequence

by Andi Shyti

Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between. This 9th version is simplified compared to the previous round. Thanks a lot Nirmoy, Andrzej and Matt for your review and for the fruitful discussions! Thanks, Andi Changelog: ========= v8 -> v9 - Removed the patch that was refactoring into intel_emit_pipe_control_cs() the pipe control emission as it was adding more confusion than simplification. - Cleaned up the engine quiescing sequence for BCS, VECS and VCS engines. After this the patch that was extending the quiescing sequence was very little to be kept on its own and squashed with the one adding the CCS_FLUSH in the pipe control. - The above changes have brought some more refactoring in the very last patch. - Added, whenever needed, the "Required:" tag to make sure dependencies are held. v7 -> v8 - Removed the aux invalidation from the device info and added a helper function, instead (patch 2). - Use "MTL and beyond" instead of "MTL+" in comments. - Use the "gen12_" prefix instead of "intel_". - In patch 6 return an int error instead of an error embedded in the pointer in the intel_emit_pipe_control_cs() function and propagate the error to the upper layers. v6 -> v7 - Fix correct sequence applied to the correct engine. A little confusion promptly cought by Nirmoy when applying to the VD engine the sequence belonging to the compute engines. Thanks a lot, Nirmoy! v5 -> v6 - Fixed ccs flush in the engines VE and BCS. They are sent as a separate command instead of added in the pipe control. - Separated the CCS flusing in the pipe control patch with the quiescing of the memory. They were meant to be on separate patch already in the previous verision, but apparently I squashed them by mistake. v4 -> v5 - The AUX CCS is added as a device property instead of checking against FLAT CCS. This adds the new HAS_AUX_CCS check (Patch 2, new). - little and trivial refactoring here and there. - extended the flags{0,1}/bit_group_{0,1} renaming to other functions. - Created an intel_emit_pipe_control_cs() wrapper for submitting the pipe control. - Quiesce memory for all the engines, not just RCS (Patch 6, new). - The PIPE_CONTROL_CCS_FLUSH is added to all the engines. - Remove redundant EMIT_FLUSH_CCS mode flag. - Remove unnecessary NOOPs from the command streamer for invalidating the CCS table. - Use INVALID_MMIO_REG and gen12_get_aux_inv_reg() instad of __MMIO(0) and reg.reg. - Remove useless wrapper and just use gen12_get_aux_inv_reg(). v3 -> v4 - A trivial patch 3 is added to rename the flags with bit_group_{0,1} to align with the datasheet naming. - Patch 4 fixes a confusion I made where the CCS flag was applied to the wrong bit group. v2 -> v3 - added r-b from Nirmoy in patch 1 and 4. - added patch 3 which enables the ccs_flush in the control pipe for mtl+ compute and render engines. - added redundant checks in patch 2 for enabling the EMIT_FLUSH flag. v1 -> v2 - add a clean up preliminary patch for the existing registers - add support for more engines - add the Fixes tag Andi Shyti (5): drm/i915/gt: Cleanup aux invalidation registers drm/i915: Add the gen12_needs_ccs_aux_inv helper drm/i915/gt: Rename flags with bit_group_X according to the datasheet drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control and in the CS drm/i915/gt: Support aux invalidation on all engines Jonathan Cavitt (2): drm/i915/gt: Ensure memory quiesced before invalidation drm/i915/gt: Poll aux invalidation register bit on invalidation drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 140 ++++++++++++------- drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 21 +-- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 16 +-- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +-- 5 files changed, 117 insertions(+), 79 deletions(-) -- 2.40.1

2 years, 4 months

1
7
0 0

stable/linux-5.15.y build: 2 builds: 0 failed, 2 passed, 1 warning (v5.15.122)

by kernelci.org bot

stable/linux-5.15.y build: 2 builds: 0 failed, 2 passed, 1 warning (v5.15.122) Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.15.y/kernel/v5.15.122/ Tree: stable Branch: linux-5.15.y Git Describe: v5.15.122 Git Commit: 5c6a716301d915055c7bd6d935f7a4fccec2649c Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 2 unique architectures Warnings Detected: riscv: x86_64: x86_64_defconfig+x86-chromebook (gcc-10): 1 warning Warnings summary: 1 arch/x86/kernel/smp.o: warning: objtool: sysvec_reboot()+0x45: unreachable instruction ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- nommu_k210_sdcard_defconfig (riscv, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- x86_64_defconfig+x86-chromebook (x86_64, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: arch/x86/kernel/smp.o: warning: objtool: sysvec_reboot()+0x45: unreachable instruction --- For more info write to <info(a)kernelci.org>

2 years, 4 months

1
0
0 0

[PATCH net] net: ipa: only reset hashed tables when supported

by Alex Elder

Last year, the code that manages GSI channel transactions switched from using spinlock-protected linked lists to using indexes into the ring buffer used for a channel. Recently, Google reported seeing transaction reference count underflows occasionally during shutdown. Doug Anderson found a way to reproduce the issue reliably, and bisected the issue to the commit that eliminated the linked lists and the lock. The root cause was ultimately determined to be related to unused transactions being committed as part of the modem shutdown cleanup activity. Unused transactions are not normally expected (except in error cases). The modem uses some ranges of IPA-resident memory, and whenever it shuts down we zero those ranges. In ipa_filter_reset_table() a transaction is allocated to zero modem filter table entries. If hashing is not supported, hashed table memory should not be zeroed. But currently nothing prevents that, and the result is an unused transaction. Something similar occurs when we zero routing table entries for the modem. By preventing any attempt to clear hashed tables when hashing is not supported, the reference count underflow is avoided in this case. Note that there likely remains an issue with properly freeing unused transactions (if they occur due to errors). This patch addresses only the underflows that Google originally reported. Fixes: d338ae28d8a8 ("net: ipa: kill all other transaction lists") Cc: <stable(a)vger.kernel.org> # 6.4.x Tested-by: Douglas Anderson <dianders(a)chromium.org> Signed-off-by: Alex Elder <elder(a)linaro.org> --- drivers/net/ipa/ipa_table.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c index f0529c31d0b6e..7b637bb8b41c8 100644 --- a/drivers/net/ipa/ipa_table.c +++ b/drivers/net/ipa/ipa_table.c @@ -273,16 +273,15 @@ static int ipa_filter_reset(struct ipa *ipa, bool modem) if (ret) return ret; - ret = ipa_filter_reset_table(ipa, true, false, modem); - if (ret) - return ret; - ret = ipa_filter_reset_table(ipa, false, true, modem); + if (ret || !ipa_table_hash_support(ipa)) + return ret; + + ret = ipa_filter_reset_table(ipa, true, false, modem); if (ret) return ret; - ret = ipa_filter_reset_table(ipa, true, true, modem); - return ret; + return ipa_filter_reset_table(ipa, true, true, modem); } /* The AP routes and modem routes are each contiguous within the @@ -291,12 +290,13 @@ static int ipa_filter_reset(struct ipa *ipa, bool modem) * */ static int ipa_route_reset(struct ipa *ipa, bool modem) { + bool hash_support = ipa_table_hash_support(ipa); u32 modem_route_count = ipa->modem_route_count; struct gsi_trans *trans; u16 first; u16 count; - trans = ipa_cmd_trans_alloc(ipa, 4); + trans = ipa_cmd_trans_alloc(ipa, hash_support ? 4 : 2); if (!trans) { dev_err(&ipa->pdev->dev, "no transaction for %s route reset\n", @@ -313,10 +313,12 @@ static int ipa_route_reset(struct ipa *ipa, bool modem) } ipa_table_reset_add(trans, false, false, false, first, count); - ipa_table_reset_add(trans, false, true, false, first, count); - ipa_table_reset_add(trans, false, false, true, first, count); - ipa_table_reset_add(trans, false, true, true, first, count); + + if (hash_support) { + ipa_table_reset_add(trans, false, true, false, first, count); + ipa_table_reset_add(trans, false, true, true, first, count); + } gsi_trans_commit_wait(trans); -- 2.34.1

2 years, 4 months

1
0
0 0

stable/linux-5.4.y build: 1 build: 0 failed, 1 passed, 2 warnings (v5.4.250)

by kernelci.org bot

stable/linux-5.4.y build: 1 build: 0 failed, 1 passed, 2 warnings (v5.4.250) Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.4.y/kernel/v5.4.250/ Tree: stable Branch: linux-5.4.y Git Describe: v5.4.250 Git Commit: 27745d94abe1036a3423cb8577b665c01725e321 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 1 unique architecture Warnings Detected: i386: allnoconfig (gcc-10): 2 warnings Warnings summary: 1 ld: warning: creating DT_TEXTREL in a PIE 1 ld: arch/x86/boot/compressed/head_32.o: warning: relocation in read-only section `.head.text' ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- allnoconfig (i386, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ld: arch/x86/boot/compressed/head_32.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE --- For more info write to <info(a)kernelci.org>

2 years, 4 months

1
0
0 0

stable/linux-4.19.y build: 1 build: 0 failed, 1 passed, 2 warnings (v4.19.289)

by kernelci.org bot

stable/linux-4.19.y build: 1 build: 0 failed, 1 passed, 2 warnings (v4.19.289) Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.19.y/kernel/v4.19.289/ Tree: stable Branch: linux-4.19.y Git Describe: v4.19.289 Git Commit: 767049cead76cf699707290d5aeefb3e4d0d5b43 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 1 unique architecture Warnings Detected: x86_64: tinyconfig (gcc-10): 2 warnings Warnings summary: 1 ld: warning: creating DT_TEXTREL in a PIE 1 ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- tinyconfig (x86_64, gcc-10) — PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE --- For more info write to <info(a)kernelci.org>

2 years, 4 months

1
0
0 0

[PATCH v3 0/4] fs/9p: fix mmap regression

by Eric Van Hensbergen

This series attempts to fix a reported exception with mmap on newer kernels. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reported-by: Robert Schwebel <r.schwebel(a)pengutronix.de> Signed-off-by: Eric Van Hensbergen <ericvh(a)kernel.org> --- Changes in v3: - Clarify debug print to read-only mmap mode versus no mmap mode in v9fs_file_mmap - Fix suggested regression tags and propagate across series - Link to v2: https://lore.kernel.org/r/20230716-fixes-overly-restrictive-mmap-v2-0-147d6… Changes in v2: - fix requested changes in commit messages - add patch to remove unnecessary invalidate_inode_pages in mmap readonly path - Link to v1: https://lore.kernel.org/r/20230716-fixes-overly-restrictive-mmap-v1-0-0683b… --- Eric Van Hensbergen (4): fs/9p: remove unnecessary and overrestrictive check fs/9p: fix typo in comparison logic for cache mode fs/9p: fix type mismatch in file cache mode helper fs/9p: remove unnecessary invalidate_inode_pages2 fs/9p/fid.h | 6 +++--- fs/9p/vfs_file.c | 5 +---- 2 files changed, 4 insertions(+), 7 deletions(-) --- base-commit: 95f41d87810083d8b3dedcce46a4e356cf4a9673 change-id: 20230716-fixes-overly-restrictive-mmap-30a23501e787 Best regards, -- Eric Van Hensbergen <ericvh(a)kernel.org>

2 years, 4 months

4
11
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2023