June 2020 - Linux-stable-mirror

FAILED: patch "[PATCH] KVM: nVMX: Skip IBPB when switching between vmcs01 and vmcs02" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5c911beff20aa8639e7a1f28988736c13e03ed54 Mon Sep 17 00:00:00 2001 From: Sean Christopherson <sean.j.christopherson(a)intel.com> Date: Fri, 1 May 2020 09:31:17 -0700 Subject: [PATCH] KVM: nVMX: Skip IBPB when switching between vmcs01 and vmcs02 Skip the Indirect Branch Prediction Barrier that is triggered on a VMCS switch when running with spectre_v2_user=on/auto if the switch is between two VMCSes in the same guest, i.e. between vmcs01 and vmcs02. The IBPB is intended to prevent one guest from attacking another, which is unnecessary in the nested case as it's the same guest from KVM's perspective. This all but eliminates the overhead observed for nested VMX transitions when running with CONFIG_RETPOLINE=y and spectre_v2_user=on/auto, which can be significant, e.g. roughly 3x on current systems. Reported-by: Alexander Graf <graf(a)amazon.com> Cc: KarimAllah Raslan <karahmed(a)amazon.de> Cc: stable(a)vger.kernel.org Fixes: 15d45071523d ("KVM/x86: Add IBPB support") Signed-off-by: Sean Christopherson <sean.j.christopherson(a)intel.com> Message-Id: <20200501163117.4655-1-sean.j.christopherson(a)intel.com> [Invert direction of bool argument. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index 669445136144..7f754b3bc6dd 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -303,7 +303,7 @@ static void vmx_switch_vmcs(struct kvm_vcpu *vcpu, struct loaded_vmcs *vmcs) cpu = get_cpu(); prev = vmx->loaded_vmcs; vmx->loaded_vmcs = vmcs; - vmx_vcpu_load_vmcs(vcpu, cpu); + vmx_vcpu_load_vmcs(vcpu, cpu, prev); vmx_sync_vmcs_host_state(vmx, prev); put_cpu(); diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index fbede089d0f7..db842ce74e5d 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -1311,10 +1311,12 @@ static void vmx_vcpu_pi_load(struct kvm_vcpu *vcpu, int cpu) pi_set_on(pi_desc); } -void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu) +void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu, + struct loaded_vmcs *buddy) { struct vcpu_vmx *vmx = to_vmx(vcpu); bool already_loaded = vmx->loaded_vmcs->cpu == cpu; + struct vmcs *prev; if (!already_loaded) { loaded_vmcs_clear(vmx->loaded_vmcs); @@ -1333,10 +1335,18 @@ void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu) local_irq_enable(); } - if (per_cpu(current_vmcs, cpu) != vmx->loaded_vmcs->vmcs) { + prev = per_cpu(current_vmcs, cpu); + if (prev != vmx->loaded_vmcs->vmcs) { per_cpu(current_vmcs, cpu) = vmx->loaded_vmcs->vmcs; vmcs_load(vmx->loaded_vmcs->vmcs); - indirect_branch_prediction_barrier(); + + /* + * No indirect branch prediction barrier needed when switching + * the active VMCS within a guest, e.g. on nested VM-Enter. + * The L1 VMM can protect itself with retpolines, IBPB or IBRS. + */ + if (!buddy || WARN_ON_ONCE(buddy->vmcs != prev)) + indirect_branch_prediction_barrier(); } if (!already_loaded) { @@ -1377,7 +1387,7 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) { struct vcpu_vmx *vmx = to_vmx(vcpu); - vmx_vcpu_load_vmcs(vcpu, cpu); + vmx_vcpu_load_vmcs(vcpu, cpu, NULL); vmx_vcpu_pi_load(vcpu, cpu); diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index b5e773267abe..d3d48acc6bd9 100644 --- a/arch/x86/kvm/vmx/vmx.h +++ b/arch/x86/kvm/vmx/vmx.h @@ -320,7 +320,8 @@ struct kvm_vmx { }; bool nested_vmx_allowed(struct kvm_vcpu *vcpu); -void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu); +void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu, + struct loaded_vmcs *buddy); void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu); int allocate_vpid(void); void free_vpid(int vpid);

4 years, 6 months

1
0
0 0

FAILED: patch "[PATCH] KVM: nVMX: Skip IBPB when switching between vmcs01 and vmcs02" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5c911beff20aa8639e7a1f28988736c13e03ed54 Mon Sep 17 00:00:00 2001 From: Sean Christopherson <sean.j.christopherson(a)intel.com> Date: Fri, 1 May 2020 09:31:17 -0700 Subject: [PATCH] KVM: nVMX: Skip IBPB when switching between vmcs01 and vmcs02 Skip the Indirect Branch Prediction Barrier that is triggered on a VMCS switch when running with spectre_v2_user=on/auto if the switch is between two VMCSes in the same guest, i.e. between vmcs01 and vmcs02. The IBPB is intended to prevent one guest from attacking another, which is unnecessary in the nested case as it's the same guest from KVM's perspective. This all but eliminates the overhead observed for nested VMX transitions when running with CONFIG_RETPOLINE=y and spectre_v2_user=on/auto, which can be significant, e.g. roughly 3x on current systems. Reported-by: Alexander Graf <graf(a)amazon.com> Cc: KarimAllah Raslan <karahmed(a)amazon.de> Cc: stable(a)vger.kernel.org Fixes: 15d45071523d ("KVM/x86: Add IBPB support") Signed-off-by: Sean Christopherson <sean.j.christopherson(a)intel.com> Message-Id: <20200501163117.4655-1-sean.j.christopherson(a)intel.com> [Invert direction of bool argument. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index 669445136144..7f754b3bc6dd 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -303,7 +303,7 @@ static void vmx_switch_vmcs(struct kvm_vcpu *vcpu, struct loaded_vmcs *vmcs) cpu = get_cpu(); prev = vmx->loaded_vmcs; vmx->loaded_vmcs = vmcs; - vmx_vcpu_load_vmcs(vcpu, cpu); + vmx_vcpu_load_vmcs(vcpu, cpu, prev); vmx_sync_vmcs_host_state(vmx, prev); put_cpu(); diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index fbede089d0f7..db842ce74e5d 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -1311,10 +1311,12 @@ static void vmx_vcpu_pi_load(struct kvm_vcpu *vcpu, int cpu) pi_set_on(pi_desc); } -void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu) +void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu, + struct loaded_vmcs *buddy) { struct vcpu_vmx *vmx = to_vmx(vcpu); bool already_loaded = vmx->loaded_vmcs->cpu == cpu; + struct vmcs *prev; if (!already_loaded) { loaded_vmcs_clear(vmx->loaded_vmcs); @@ -1333,10 +1335,18 @@ void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu) local_irq_enable(); } - if (per_cpu(current_vmcs, cpu) != vmx->loaded_vmcs->vmcs) { + prev = per_cpu(current_vmcs, cpu); + if (prev != vmx->loaded_vmcs->vmcs) { per_cpu(current_vmcs, cpu) = vmx->loaded_vmcs->vmcs; vmcs_load(vmx->loaded_vmcs->vmcs); - indirect_branch_prediction_barrier(); + + /* + * No indirect branch prediction barrier needed when switching + * the active VMCS within a guest, e.g. on nested VM-Enter. + * The L1 VMM can protect itself with retpolines, IBPB or IBRS. + */ + if (!buddy || WARN_ON_ONCE(buddy->vmcs != prev)) + indirect_branch_prediction_barrier(); } if (!already_loaded) { @@ -1377,7 +1387,7 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) { struct vcpu_vmx *vmx = to_vmx(vcpu); - vmx_vcpu_load_vmcs(vcpu, cpu); + vmx_vcpu_load_vmcs(vcpu, cpu, NULL); vmx_vcpu_pi_load(vcpu, cpu); diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index b5e773267abe..d3d48acc6bd9 100644 --- a/arch/x86/kvm/vmx/vmx.h +++ b/arch/x86/kvm/vmx/vmx.h @@ -320,7 +320,8 @@ struct kvm_vmx { }; bool nested_vmx_allowed(struct kvm_vcpu *vcpu); -void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu); +void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu, + struct loaded_vmcs *buddy); void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu); int allocate_vpid(void); void free_vpid(int vpid);

4 years, 6 months

1
0
0 0

[PATCH v2 0/4] bootconfig: Fix quote-character issue and return value

by Masami Hiramatsu

Hi, This is the 2nd version of bootconfig bugfixes. The previous version is here. https://lkml.kernel.org/r/159197538852.80267.10091816844311950396.stgit@dev… This version fixes the patch description and modify(cleanup) code according to Steve's comment. Thank you, --- Masami Hiramatsu (4): proc/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig tools/bootconfig: Add testcase for show-command and quotes test fs/proc/bootconfig.c | 15 ++++++++++----- tools/bootconfig/main.c | 24 ++++++++++++++---------- tools/bootconfig/test-bootconfig.sh | 10 ++++++++++ 3 files changed, 34 insertions(+), 15 deletions(-) -- Masami Hiramatsu (Linaro) <mhiramat(a)kernel.org>

4 years, 6 months

1
4
0 0

stable-rc 4.19.129-rc1/d694d4388e88: no regressions found in project stable v4.19.y

by Naresh Kamboju

Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary ------------------------------------------------------------------------ kernel: 4.19.129-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.19.y git commit: d694d4388e889e15298d8de938fb4e61e4df75bf git describe: v4.19.128-58-gd694d4388e88 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.128-… No regressions (compared to build v4.19.127-26-gf6c346f2d42d) No fixes (compared to build v4.19.127-26-gf6c346f2d42d) Ran 33239 total tests in the following environments and test suites. Environments -------------- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - juno-r2-compat - juno-r2-kasan - nxp-ls2088 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 - x86-kasan Test Suites ----------- * build * install-android-platform-tools-r2800 * linux-log-parser * ltp-cap_bounds-tests * ltp-commands-tests * ltp-containers-tests * ltp-controllers-tests * ltp-cpuhotplug-tests * ltp-crypto-tests * ltp-cve-tests * ltp-dio-tests * ltp-fs-tests * ltp-io-tests * ltp-math-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * v4l2-compliance * install-android-platform-tools-r2600 * kselftest * kselftest/drivers * kselftest/filesystems * kvm-unit-tests * libhugetlbfs * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-ipc-tests * ltp-mm-tests * network-basic-tests * perf * kselftest/net * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-native/drivers * kselftest-vsyscall-mode-native/filesystems * kselftest-vsyscall-mode-native/net * kselftest-vsyscall-mode-none * kselftest-vsyscall-mode-none/drivers * kselftest-vsyscall-mode-none/filesystems * kselftest-vsyscall-mode-none/net -- Linaro LKFT https://lkft.linaro.org

4 years, 6 months

1
0
0 0

stable-rc 5.4.47-rc1/cbc29a7953ca: no regressions found in project stable v5.4.y

by Naresh Kamboju

Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. While running kselftest on arm64 Juno the following kernel warning was reported. FYI, we are running kselftest 5.7. We have been noticing this warning on 5.4 and 5.6 branches. [ 486.146777] kselftest: Running tests in gpio [ 486.498350] ------------[ cut here ]------------ [ 486.503045] refcount_t: underflow; use-after-free. [ 486.508067] WARNING: CPU: 1 PID: 7242 at /usr/src/kernel/lib/refcount.c:190 refcount_sub_and_test_checked+0xac/0xc8 [ 486.518525] Modules linked in: gpio_mockup(-) cls_bpf sch_fq 8021q garp stp mrp llc sch_ingress veth algif_hash rfkill tda998x drm_kms_helper drm crct10dif_ce fuse [last unloaded: test_bpf] [ 486.535459] CPU: 1 PID: 7242 Comm: modprobe Not tainted 5.4.47-rc1 #1 [ 486.541913] Hardware name: ARM Juno development board (r2) (DT) [ 486.547847] pstate: 40000005 (nZcv daif -PAN -UAO) [ 486.552650] pc : refcount_sub_and_test_checked+0xac/0xc8 [ 486.557974] lr : refcount_sub_and_test_checked+0xac/0xc8 [ 486.563296] sp : ffff80001aee3bb0 [ 486.566617] x29: ffff80001aee3bb0 x28: ffff000953b20000 [ 486.571943] x27: 0000000000000000 x26: 0000000000000000 [ 486.577269] x25: 0000000000000045 x24: ffff00096ee6d478 [ 486.582594] x23: ffff8000123e4800 x22: ffff8000123e4000 [ 486.587920] x21: ffff00096ee6b008 x20: ffff00096ee6b000 [ 486.593245] x19: ffff00096ee6b008 x18: ffffffffffffffff [ 486.598569] x17: 0000000000000000 x16: 0000000000000000 [ 486.603895] x15: ffff8000122bfa48 x14: ffff80009aee3897 [ 486.609219] x13: ffff80001aee38a5 x12: ffff8000122ec000 [ 486.614544] x11: 0000000005f5e0ff x10: ffff80001aee3830 [ 486.619869] x9 : ffff8000125f1c98 x8 : 0000000000000028 [ 486.625195] x7 : ffff800010193e3c x6 : ffff00097ef303e8 [ 486.630520] x5 : ffff00097ef303e8 x4 : ffff000953b20000 [ 486.635844] x3 : ffff8000122c0000 x2 : 0000000000000000 [ 486.641169] x1 : 677d96118732a100 x0 : 0000000000000000 [ 486.646495] Call trace: [ 486.648948] refcount_sub_and_test_checked+0xac/0xc8 [ 486.653924] refcount_dec_and_test_checked+0x14/0x20 [ 486.658901] kobject_put+0x24/0x210 [ 486.662400] put_device+0x24/0x30 [ 486.665723] gpiochip_remove+0xe0/0x120 [ 486.669567] devm_gpio_chip_release+0x20/0x30 [ 486.673934] release_nodes+0x150/0x248 [ 486.677690] devres_release_all+0x3c/0x60 [ 486.681710] device_release_driver_internal+0x110/0x1d8 [ 486.686947] driver_detach+0x5c/0xe8 [ 486.690529] bus_remove_driver+0x64/0x118 [ 486.694548] driver_unregister+0x34/0x60 [ 486.698482] platform_driver_unregister+0x20/0x30 [ 486.703201] gpio_mockup_exit+0x30/0x490 [gpio_mockup] [ 486.708355] __arm64_sys_delete_module+0x190/0x2c0 [ 486.713160] el0_svc_common.constprop.2+0x7c/0x180 [ 486.717962] el0_svc_handler+0x34/0xa0 [ 486.721720] el0_svc+0x8/0xc [ 486.724606] irq event stamp: 2790 [ 486.727930] hardirqs last enabled at (2789): [<ffff800010193fdc>] console_unlock+0x52c/0x5f8 [ 486.736476] hardirqs last disabled at (2790): [<ffff8000100a8f0c>] debug_exception_enter+0xac/0xe8 [ 486.745455] softirqs last enabled at (2786): [<ffff8000100821ec>] __do_softirq+0x4c4/0x578 [ 486.753827] softirqs last disabled at (2687): [<ffff80001010a8b4>] irq_exit+0x144/0x150 [ 486.761846] ---[ end trace 2c86a1fe4de2724b ]--- [ 487.328176] gpio gpiochip2: (gpio-mockup-B): line cnt 1024 is greater than fast path cnt 512 [ 487.336696] gpiochip_find_base: cannot find free range [ 487.342013] gpiochip_add_data_with_key: GPIOs 0..1023 (gpio-mockup-B) failed to register, -28 [ 487.426615] gpio-mockup: probe of gpio-mockup.1 failed with error -28 Ref: stable rc-5.4 warning on arm64 Juno-r2 while running kselftest https://qa-reports.linaro.org/lkft/linux-stable-rc-5.4-oe/build/v5.4.46-83-… stable rc-5.6 warning on arm64 Juno-r2 while running kselftest https://lkft.validation.linaro.org/scheduler/job/1496847#L9357 Summary ------------------------------------------------------------------------ kernel: 5.4.47-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-5.4.y git commit: cbc29a7953ca53d5db824b78b27ea50936747544 git describe: v5.4.46-83-gcbc29a7953ca Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-5.4-oe/build/v5.4.46-83-… No regressions (compared to build v5.4.45-35-g12a5ce113626) No fixes (compared to build v5.4.45-35-g12a5ce113626) Ran 34599 total tests in the following environments and test suites. Environments -------------- - dragonboard-410c - hi6220-hikey - i386 - juno-r2 - juno-r2-compat - juno-r2-kasan - nxp-ls2088 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - x86 - x86-kasan Test Suites ----------- * build * install-android-platform-tools-r2600 * install-android-platform-tools-r2800 * kselftest * kselftest/drivers * kselftest/filesystems * kselftest/net * linux-log-parser * ltp-cap_bounds-tests * ltp-commands-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-crypto-tests * ltp-dio-tests * ltp-fs-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-mm-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * perf * libhugetlbfs * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-syscalls-tests * network-basic-tests * v4l2-compliance * ltp-controllers-tests * ltp-open-posix-tests * kvm-unit-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-native/drivers * kselftest-vsyscall-mode-native/filesystems * kselftest-vsyscall-mode-native/net * kselftest-vsyscall-mode-none * kselftest-vsyscall-mode-none/drivers * kselftest-vsyscall-mode-none/filesystems * kselftest-vsyscall-mode-none/net -- Linaro LKFT https://lkft.linaro.org

4 years, 6 months

1
0
0 0

stable-rc 5.6.19-rc1/d73794b63b4e: no regressions found in project stable v5.6.y

by Naresh Kamboju

Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary ------------------------------------------------------------------------ kernel: 5.6.19-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-5.6.y git commit: d73794b63b4ef9b4bd884d4e00d1fd78679a74e0 git describe: v5.6.18-104-gd73794b63b4e Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-5.6-oe/build/v5.6.18-104… No regressions (compared to build v5.6.17-42-g1bece508f6a9) No fixes (compared to build v5.6.17-42-g1bece508f6a9) Ran 34859 total tests in the following environments and test suites. Environments -------------- - dragonboard-410c - hi6220-hikey - i386 - juno-r2 - juno-r2-compat - juno-r2-kasan - nxp-ls2088 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - x86 - x86-kasan Test Suites ----------- * build * install-android-platform-tools-r2600 * install-android-platform-tools-r2800 * kselftest * kselftest/drivers * kselftest/filesystems * kselftest/net * libhugetlbfs * linux-log-parser * ltp-commands-tests * ltp-containers-tests * ltp-cve-tests * ltp-dio-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-math-tests * ltp-mm-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * perf * v4l2-compliance * kvm-unit-tests * ltp-syscalls-tests * network-basic-tests * ltp-cap_bounds-tests * ltp-controllers-tests * ltp-cpuhotplug-tests * ltp-crypto-tests * ltp-ipc-tests * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-native/drivers * kselftest-vsyscall-mode-native/filesystems * kselftest-vsyscall-mode-native/net * kselftest-vsyscall-mode-none * kselftest-vsyscall-mode-none/drivers * kselftest-vsyscall-mode-none/filesystems * kselftest-vsyscall-mode-none/net -- Linaro LKFT https://lkft.linaro.org

4 years, 6 months

1
0
0 0

[PATCH v4] ovl: inode reference leak in ovl_is_inuse true case.

by youngjun

When "ovl_is_inuse" true case, trap inode reference not put. plus adding the comment explaining sequence of ovl_is_inuse after ovl_setup_trap. Fixes: 0be0bfd2de9d ("ovl: fix regression caused by overlapping layers..") Cc: <stable(a)vger.kernel.org> # v4.19+ Reviewed-by: Amir Goldstein <amir73il(a)gmail.com> Signed-off-by: youngjun <her0gyugyu(a)gmail.com> --- fs/overlayfs/super.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 91476bc422f9..3097142b1e23 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -1493,14 +1493,22 @@ static int ovl_get_layers(struct super_block *sb, struct ovl_fs *ofs, if (err < 0) goto out; + /* + * Check if lower root conflicts with this overlay layers before checking + * if it is in-use as upperdir/workdir of "another" mount, because we do + * not bother to check in ovl_is_inuse() if the upperdir/workdir is in fact + * in-use by our upperdir/workdir. + */ err = ovl_setup_trap(sb, stack[i].dentry, &trap, "lowerdir"); if (err) goto out; if (ovl_is_inuse(stack[i].dentry)) { err = ovl_report_in_use(ofs, "lowerdir"); - if (err) + if (err) { + iput(trap); goto out; + } } mnt = clone_private_mount(&stack[i]); -- 2.17.1 Sorry. I Wrongly sent subect version. I changed it to v4. Thank you Amir.

4 years, 6 months

1
0
0 0

stable-rc/linux-4.14.y baseline: 70 runs, 3 regressions (v4.14.183-90-g4416c389d63e)

by kernelci.org bot

stable-rc/linux-4.14.y baseline: 70 runs, 3 regressions (v4.14.183-90-g4416c389d63e) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | results ----------------+--------+--------------+----------+------------------+-------- meson-gxbb-p200 | arm64 | lab-baylibre | gcc-8 | defconfig | 0/1 qemu_i386 | i386 | lab-baylibre | gcc-8 | i386_defconfig | 0/1 qemu_x86_64 | x86_64 | lab-baylibre | gcc-8 | x86_64_defconfig | 0/1 Details: https://kernelci.org/test/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.18… Test: baseline Tree: stable-rc Branch: linux-4.14.y Describe: v4.14.183-90-g4416c389d63e URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 4416c389d63e76d897a5788f6145f08522cf58b4 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | results ----------------+--------+--------------+----------+------------------+-------- meson-gxbb-p200 | arm64 | lab-baylibre | gcc-8 | defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5ee84ee1a643474df697bf0d Results: 0 PASS, 1 FAIL, 0 SKIP Full config: defconfig Compiler: gcc-8 (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… HTML log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2019.02-11-g17e793f… * baseline.login: https://kernelci.org/test/case/id/5ee84ee1a643474df697bf0e failing since 76 days (last pass: v4.14.172-114-g734382e2d26e, first fail: v4.14.174-131-g234ce78cac23) platform | arch | lab | compiler | defconfig | results ----------------+--------+--------------+----------+------------------+-------- qemu_i386 | i386 | lab-baylibre | gcc-8 | i386_defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5ee84d45f00504c39f97bf10 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: i386_defconfig Compiler: gcc-8 (gcc (Debian 8.3.0-6) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… HTML log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2019.02-11-g17e793f… * baseline.login: https://kernelci.org/test/case/id/5ee84d45f00504c39f97bf11 new failure (last pass: v4.14.183-47-g9817cdae1b62) platform | arch | lab | compiler | defconfig | results ----------------+--------+--------------+----------+------------------+-------- qemu_x86_64 | x86_64 | lab-baylibre | gcc-8 | x86_64_defconfig | 0/1 Details: https://kernelci.org/test/plan/id/5ee84dc025518073d697bf6f Results: 0 PASS, 1 FAIL, 0 SKIP Full config: x86_64_defconfig Compiler: gcc-8 (gcc (Debian 8.3.0-6) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… HTML log: https://storage.kernelci.org//stable-rc/linux-4.14.y/v4.14.183-90-g4416c389… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2019.02-11-g17e793f… * baseline.login: https://kernelci.org/test/case/id/5ee84dc025518073d697bf70 new failure (last pass: v4.14.183-23-g6b882ea9cfe0)

4 years, 6 months

1
0
0 0

[PATCH 4.19 00/25] 4.19.128-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.128 release. There are 25 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 11 Jun 2020 17:40:24 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.128-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.128-rc1 Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "net/mlx5: Annotate mutex destroy for root ns" Oleg Nesterov <oleg(a)redhat.com> uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned Josh Poimboeuf <jpoimboe(a)redhat.com> x86/speculation: Add Ivy Bridge to affected list Mark Gross <mgross(a)linux.intel.com> x86/speculation: Add SRBDS vulnerability and mitigation documentation Mark Gross <mgross(a)linux.intel.com> x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation Mark Gross <mgross(a)linux.intel.com> x86/cpu: Add 'table' argument to cpu_matches() Mark Gross <mgross(a)linux.intel.com> x86/cpu: Add a steppings field to struct x86_cpu_id Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> nvmem: qfprom: remove incorrect write support Oliver Neukum <oneukum(a)suse.com> CDC-ACM: heed quirk also in error handling Pascal Terjan <pterjan(a)google.com> staging: rtl8712: Fix IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK Jiri Slaby <jslaby(a)suse.cz> tty: hvc_console, fix crashes on parallel open/close Dmitry Torokhov <dmitry.torokhov(a)gmail.com> vt: keyboard: avoid signed integer overflow in k_ascii Dinghao Liu <dinghao.liu(a)zju.edu.cn> usb: musb: Fix runtime PM imbalance on error Bin Liu <b-liu(a)ti.com> usb: musb: start session in resume for host port Mathieu Othacehe <m.othacehe(a)gmail.com> iio: vcnl4000: Fix i2c swapped word reading. Daniele Palmas <dnlplm(a)gmail.com> USB: serial: option: add Telit LE910C1-EUX compositions Bin Liu <b-liu(a)ti.com> USB: serial: usb_wwan: do not resubmit rx urb on fatal errors Matt Jolly <Kangie(a)footclan.ninja> USB: serial: qcserial: add DW5816e QDL support Willem de Bruijn <willemb(a)google.com> net: check untrusted gso_size at kernel entry Stefano Garzarella <sgarzare(a)redhat.com> vsock: fix timeout in vsock_accept() Chuhong Yuan <hslester96(a)gmail.com> NFC: st21nfca: add missed kfree_skb() in an error path Daniele Palmas <dnlplm(a)gmail.com> net: usb: qmi_wwan: add Telit LE910C1-EUX composition Eric Dumazet <edumazet(a)google.com> l2tp: do not use inet_hash()/inet_unhash() Eric Dumazet <edumazet(a)google.com> l2tp: add sk_family checks to l2tp_validate_socket Yang Yingliang <yangyingliang(a)huawei.com> devinet: fix memleak in inetdev_init() ------------- Diffstat: Documentation/ABI/testing/sysfs-devices-system-cpu | 1 + Documentation/admin-guide/hw-vuln/index.rst | 1 + .../special-register-buffer-data-sampling.rst | 149 +++++++++++++++++++++ Documentation/admin-guide/kernel-parameters.txt | 20 +++ Makefile | 4 +- arch/x86/include/asm/cpu_device_id.h | 27 ++++ arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/msr-index.h | 4 + arch/x86/kernel/cpu/bugs.c | 106 +++++++++++++++ arch/x86/kernel/cpu/common.c | 54 ++++++-- arch/x86/kernel/cpu/cpu.h | 1 + arch/x86/kernel/cpu/match.c | 7 +- drivers/base/cpu.c | 8 ++ drivers/iio/light/vcnl4000.c | 6 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 6 - drivers/net/usb/qmi_wwan.c | 1 + drivers/nfc/st21nfca/dep.c | 4 +- drivers/nvmem/qfprom.c | 14 -- drivers/staging/rtl8712/wifi.h | 9 +- drivers/tty/hvc/hvc_console.c | 23 ++-- drivers/tty/vt/keyboard.c | 26 ++-- drivers/usb/class/cdc-acm.c | 2 +- drivers/usb/musb/musb_core.c | 7 + drivers/usb/musb/musb_debugfs.c | 10 +- drivers/usb/serial/option.c | 4 + drivers/usb/serial/qcserial.c | 1 + drivers/usb/serial/usb_wwan.c | 4 + include/linux/mod_devicetable.h | 6 + include/linux/virtio_net.h | 14 +- kernel/events/uprobes.c | 16 ++- net/ipv4/devinet.c | 1 + net/l2tp/l2tp_core.c | 3 + net/l2tp/l2tp_ip.c | 29 +++- net/l2tp/l2tp_ip6.c | 30 +++-- net/vmw_vsock/af_vsock.c | 2 +- 35 files changed, 503 insertions(+), 99 deletions(-)

4 years, 6 months

9
39
0 0

[PATCH 0/4] bootconfig: Fix quote-character issue and return value

by Masami Hiramatsu

Hi Steve, I found 2 bugs in /proc/bootconfig and tools/bootconfig. - They always use double-quote to quote values. For the values which includes double-quote, it should use single-quote instead. - tools/bootconfig always returns error code if it shows the bootconfig in initrd (executed without options) This series fixes those bugs and add testcases to ensure no regressions. Thank you, --- Masami Hiramatsu (4): proc/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig tools/bootconfig: Add testcase for show-command and quotes test fs/proc/bootconfig.c | 13 +++++++++---- tools/bootconfig/main.c | 18 +++++++++++------- tools/bootconfig/test-bootconfig.sh | 10 ++++++++++ 3 files changed, 30 insertions(+), 11 deletions(-) -- Masami Hiramatsu (Linaro) <mhiramat(a)kernel.org>

4 years, 6 months

5
15
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2020