October 2019 - Linux-stable-mirror

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 52020d3f6633 - Linux 5.3.5 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/215365 One or more kernel tests failed: x86_64: ❌ Boot test ❌ Boot test ❌ Boot test ❌ Boot test We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 52020d3f6633 - Linux 5.3.5 We grabbed the 2a8e073dff19 commit of the stable queue repository. We then merged the patchset with `git am`: s390-process-avoid-potential-reading-of-freed-stack.patch s390-sclp-fix-bit-checked-for-has_sipl.patch kvm-s390-test-for-bad-access-register-and-size-at-the-start-of-s390_mem_op.patch s390-topology-avoid-firing-events-before-kobjs-are-created.patch s390-cio-avoid-calling-strlen-on-null-pointer.patch s390-cio-exclude-subchannels-with-no-parent-from-pseudo-check.patch s390-dasd-fix-error-handling-during-online-processing.patch revert-s390-dasd-add-discard-support-for-ese-volumes.patch kvm-s390-fix-__insn32_query-inline-assembly.patch kvm-ppc-book3s-enable-xive-native-capability-only-if-opal-has-required-functions.patch kvm-ppc-book3s-hv-xive-free-escalation-interrupts-before-disabling-the-vp.patch kvm-ppc-book3s-hv-don-t-push-xive-context-when-not-using-xive-device.patch kvm-ppc-book3s-hv-fix-race-in-re-enabling-xive-escalation-interrupts.patch kvm-ppc-book3s-hv-check-for-mmu-ready-on-piggybacked-virtual-cores.patch kvm-ppc-book3s-hv-don-t-lose-pending-doorbell-request-on-migration-on-p9.patch kvm-x86-fix-userspace-set-invalid-cr4.patch nbd-fix-max-number-of-supported-devs.patch pm-devfreq-tegra-fix-khz-to-hz-conversion.patch asoc-define-a-set-of-dapm-pre-post-up-events.patch asoc-sgtl5000-improve-vag-power-and-mute-control.patch powerpc-xive-implement-get_irqchip_state-method-for-xive-to-fix-shutdown-race.patch powerpc-mce-fix-mce-handling-for-huge-pages.patch powerpc-mce-schedule-work-from-irq_work.patch powerpc-603-fix-handling-of-the-dirty-flag.patch powerpc-32s-fix-boot-failure-with-debug_pagealloc-without-kasan.patch powerpc-ptdump-fix-addresses-display-on-ppc32.patch powerpc-powernv-restrict-opal-symbol-map-to-only-be-readable-by-root.patch powerpc-pseries-fix-cpu_hotplug_lock-acquisition-in-resize_hpt.patch powerpc-powernv-ioda-fix-race-in-tce-level-allocation.patch powerpc-kasan-fix-parallel-loading-of-modules.patch powerpc-kasan-fix-shadow-area-set-up-for-modules.patch powerpc-book3s64-mm-don-t-do-tlbie-fixup-for-some-hardware-revisions.patch powerpc-book3s64-radix-rename-cpu_ftr_p9_tlbie_bug-feature-flag.patch powerpc-mm-add-a-helper-to-select-page_kernel_ro-or-page_readonly.patch powerpc-mm-fix-an-oops-in-kasan_mmu_init.patch powerpc-mm-fixup-tlbie-vs-mtpidr-mtlpidr-ordering-issue-on-power9.patch can-mcp251x-mcp251x_hw_reset-allow-more-time-after-a-reset.patch tools-lib-traceevent-fix-robust-test-of-do_generate_dynamic_list_file.patch tools-lib-traceevent-do-not-free-tep-cmdlines-in-add_new_comm-on-failure.patch crypto-qat-silence-smp_processor_id-warning.patch crypto-skcipher-unmap-pages-after-an-external-error.patch crypto-cavium-zip-add-missing-single_release.patch crypto-caam-qi-fix-error-handling-in-ern-handler.patch crypto-caam-fix-concurrency-issue-in-givencrypt-descriptor.patch crypto-ccree-account-for-tee-not-ready-to-report.patch crypto-ccree-use-the-full-crypt-length-value.patch mips-treat-loongson-extensions-as-ases.patch power-supply-sbs-battery-use-correct-flags-field.patch power-supply-sbs-battery-only-return-health-when-battery-present.patch tracing-make-sure-variable-reference-alias-has-correct-var_ref_idx.patch usercopy-avoid-highmem-pfn-warning.patch timer-read-jiffies-once-when-forwarding-base-clk.patch pci-vmd-fix-config-addressing-when-using-bus-offsets.patch pci-hv-avoid-use-of-hv_pci_dev-pci_slot-after-freeing-it.patch pci-vmd-fix-shadow-offsets-to-reflect-spec-changes.patch pci-restore-resizable-bar-size-bits-correctly-for-1mb-bars.patch selftests-tpm2-add-the-missing-test_files-assignment.patch selftests-pidfd-fix-undefined-reference-to-pthread_create.patch watchdog-imx2_wdt-fix-min-calculation-in-imx2_wdt_set_timeout.patch perf-tools-fix-segfault-in-cpu_cache_level__read.patch perf-stat-fix-a-segmentation-fault-when-using-repeat-forever.patch drm-i915-dp-fix-dsc-bpp-calculations-v5.patch drm-atomic-reject-flip_async-unconditionally.patch drm-atomic-take-the-atomic-toys-away-from-x.patch drm-mali-dp-mark-expected-switch-fall-through.patch drm-omap-fix-max-fclk-divider-for-omap36xx.patch drm-msm-dsi-fix-return-value-check-for-clk_get_parent.patch drm-nouveau-kms-nv50-don-t-create-mstms-for-edp-connectors.patch drm-amd-powerplay-change-metrics-update-period-from-1ms-to-100ms.patch drm-i915-gvt-update-vgpu-workload-head-pointer-correctly.patch drm-i915-userptr-acquire-the-page-lock-around-set_page_dirty.patch drm-i915-to-make-vgpu-ppgtt-notificaiton-as-atomic-operation.patch mac80211-keep-bhs-disabled-while-calling-drv_tx_wake_queue.patch mmc-tegra-implement-set_dma_mask.patch mmc-sdhci-improve-adma-error-reporting.patch mmc-sdhci-of-esdhc-set-dma-snooping-based-on-dma-coherence.patch mmc-sdhci-let-drivers-define-their-dma-mask.patch revert-locking-pvqspinlock-don-t-wait-if-vcpu-is-preempted.patch libnvdimm-altmap-track-namespace-boundaries-in-altmap.patch sched-add-__assembly__-guards-around-struct-clone_args.patch dts-arm-gta04-introduce-legacy-spi-cs-high-to-make-display-work-again.patch xen-balloon-set-pages-pageoffline-in-balloon_add_region.patch xen-xenbus-fix-self-deadlock-after-killing-user-process.patch ieee802154-atusb-fix-use-after-free-at-disconnect.patch nl80211-validate-beacon-head.patch cfg80211-validate-ssid-mbssid-element-ordering-assumption.patch cfg80211-initialize-on-stack-chandefs.patch drivers-thermal-qcom-tsens-fix-memory-leak-from-qfpr.patch ima-always-return-negative-code-for-error.patch ima-fix-freeing-ongoing-ahash_request.patch fs-nfs-fix-possible-null-pointer-dereferences-in-enc.patch xprtrdma-toggle-xprt_congested-in-xprtrdma-s-slot-me.patch xprtrdma-send-queue-size-grows-after-a-reconnect.patch 9p-transport-error-uninitialized.patch 9p-avoid-attaching-writeback_fid-on-mmap-with-type-p.patch xen-pci-reserve-mcfg-areas-earlier.patch fuse-fix-request-limit.patch ceph-fix-directories-inode-i_blkbits-initialization.patch ceph-fetch-cap_gen-under-spinlock-in-ceph_add_cap.patch ceph-reconnect-connection-if-session-hang-in-opening.patch sunrpc-rpc-level-errors-should-always-set-task-tk_rp.patch watchdog-aspeed-add-support-for-ast2600.patch netfilter-nf_tables-allow-lookups-in-dynamic-sets.patch drm-amdgpu-fix-kfd-related-kernel-oops-on-hawaii.patch drm-amdgpu-check-for-valid-number-of-registers-to-re.patch perf-probe-fix-to-clear-tev-nargs-in-clear_probe_tra.patch pnfs-ensure-we-do-clear-the-return-on-close-layout-s.patch sunrpc-don-t-try-to-parse-incomplete-rpc-messages.patch pwm-stm32-lp-add-check-in-case-requested-period-cann.patch selftests-seccomp-fix-build-on-older-kernels.patch x86-purgatory-disable-the-stackleak-gcc-plugin-for-t.patch ntb-point-to-right-memory-window-index.patch thermal-fix-use-after-free-when-unregistering-therma.patch thermal_hwmon-sanitize-thermal_zone-type.patch iommu-amd-fix-downgrading-default-page-sizes-in-allo.patch libnvdimm-region-initialize-bad-block-for-volatile-n.patch libnvdimm-fix-endian-conversion-issues.patch fuse-fix-memleak-in-cuse_channel_open.patch libnvdimm-nfit_test-fix-acpi_handle-redefinition.patch sched-membarrier-call-sync_core-only-before-usermode.patch sched-membarrier-fix-private-expedited-registration-.patch sched-core-fix-migration-to-invalid-cpu-in-__set_cpu.patch perf-build-add-detection-of-java-11-openjdk-devel-pa.patch include-trace-events-writeback.h-fix-wstringop-trunc.patch selftests-bpf-adjust-strobemeta-loop-to-satisfy-late.patch kernel-elfcore.c-include-proper-prototypes.patch libbpf-fix-false-uninitialized-variable-warning.patch blk-mq-move-lockdep_assert_held-into-elevator_exit.patch bpf-fix-bpf_event_output-re-entry-issue.patch net-dsa-microchip-always-set-regmap-stride-to-1.patch i2c-qcom-geni-disable-dma-processing-on-the-lenovo-y.patch perf-unwind-fix-libunwind-build-failure-on-i386-syst.patch mlxsw-spectrum_flower-fail-in-case-user-specifies-mu.patch nfp-abm-fix-memory-leak-in-nfp_abm_u32_knode_replace.patch drm-radeon-bail-earlier-when-radeon.cik_-si_support-.patch btrfs-fix-selftests-failure-due-to-uninitialized-i_m.patch kvm-nvmx-fix-consistency-check-on-injected-exception.patch tick-broadcast-hrtimer-fix-a-race-in-bc_set_next.patch perf-stat-reset-previous-counts-on-repeat-with-inter.patch riscv-avoid-interrupts-being-erroneously-enabled-in-.patch vfs-fix-eoverflow-testing-in-put_compat_statfs64.patch coresight-etm4x-use-explicit-barriers-on-enable-disable.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ Usex - version 1.9-29 🚧 ✅ LTP lite 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ ALSA PCM loopback test 🚧 ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ trace: ftrace/tracer Host 2: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ❌ Storage blktests x86_64: Host 1: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ IOMMU boot test 🚧 ✅ Storage blktests Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ Usex - version 1.9-29 ✅ stress: stress-ng 🚧 ❌ LTP lite 🚧 ✅ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ ALSA PCM loopback test 🚧 ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ trace: ftrace/tracer Host 3: ❌ Boot test 🚧 ❌ /kernel/infiniband/env_setup 🚧 ❌ /kernel/infiniband/sanity Host 4: ❌ Boot test 🚧 ❌ /kernel/infiniband/env_setup 🚧 ❌ /kernel/infiniband/sanity Host 5: ❌ Boot test 🚧 ❌ /kernel/infiniband/env_setup 🚧 ❌ /kernel/infiniband/sanity Host 6: ❌ Boot test 🚧 ❌ /kernel/infiniband/env_setup 🚧 ❌ /kernel/infiniband/sanity Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years

1
0
0 0

[PATCH bpf-next 1/2] sched: introduce this_rq_is_locked()

by Song Liu

this_rq_is_locked() is introduced to check whether current CPU is holding rq_lock(). This will be used in bpf/stackmap.c to decide whether is safe to call up_read(), which may call rq_lock() for the same CPU. Fixes: commit 615755a77b24 ("bpf: extend stackmap to save binary_build_id+offset instead of address") Cc: stable(a)vger.kernel.org # v4.17+ Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Alexei Starovoitov <ast(a)kernel.org> Cc: Daniel Borkmann <daniel(a)iogearbox.net> Cc: Tejun Heo <tj(a)kernel.org> Signed-off-by: Song Liu <songliubraving(a)fb.com> --- include/linux/sched.h | 1 + kernel/sched/core.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/include/linux/sched.h b/include/linux/sched.h index 2c2e56bd8913..fb0fcbd1b6f6 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1995,4 +1995,5 @@ int sched_trace_rq_cpu(struct rq *rq); const struct cpumask *sched_trace_rd_span(struct root_domain *rd); +bool this_rq_is_locked(void); #endif diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7880f4f64d0e..577cbe7c05fc 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -138,6 +138,14 @@ struct rq *task_rq_lock(struct task_struct *p, struct rq_flags *rf) } } +bool this_rq_is_locked(void) +{ + struct rq *rq; + + rq = this_rq(); + return raw_spin_is_locked(&rq->lock); +} + /* * RQ-clock updating methods: */ -- 2.17.1

5 years

1
0
0 0

[PATCH] ch: Make it again possible to open a ch device two or more times

by Bart Van Assche

Clearing ch->device in ch_release() is wrong because that pointer must remain valid until ch_remove() is called. This patch fixes the following crash the second time a ch device is opened: BUG: kernel NULL pointer dereference, address: 0000000000000790 RIP: 0010:scsi_device_get+0x5/0x60 Call Trace: ch_open+0x4c/0xa0 [ch] chrdev_open+0xa2/0x1c0 do_dentry_open+0x13a/0x380 path_openat+0x591/0x1470 do_filp_open+0x91/0x100 do_sys_open+0x184/0x220 do_syscall_64+0x5f/0x1a0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Reported-by: Rob Turk <robtu(a)rtist.nl> Suggested-by: Rob Turk <robtu(a)rtist.nl> Cc: Hannes Reinecke <hare(a)suse.de> Cc: <stable(a)vger.kernel.org> Fixes: 085e56766f74 ("scsi: ch: add refcounting") Signed-off-by: Bart Van Assche <bvanassche(a)acm.org> --- drivers/scsi/ch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c index 5f8153c37f77..76751d6c7f0d 100644 --- a/drivers/scsi/ch.c +++ b/drivers/scsi/ch.c @@ -579,7 +579,6 @@ ch_release(struct inode *inode, struct file *file) scsi_changer *ch = file->private_data; scsi_device_put(ch->device); - ch->device = NULL; file->private_data = NULL; kref_put(&ch->ref, ch_destroy); return 0; -- 2.23.0.581.g78d2f28ef7-goog

5 years

2
1
0 0

[PATCH AUTOSEL 4.19 01/26] KVM: arm/arm64: vgic: Use the appropriate TRACE_INCLUDE_PATH

by Sasha Levin

From: Zenghui Yu <yuzenghui(a)huawei.com> [ Upstream commit aac60f1a867773de9eb164013d89c99f3ea1f009 ] Commit 49dfe94fe5ad ("KVM: arm/arm64: Fix TRACE_INCLUDE_PATH") fixes TRACE_INCLUDE_PATH to the correct relative path to the define_trace.h and explains why did the old one work. The same fix should be applied to virt/kvm/arm/vgic/trace.h. Reviewed-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> Signed-off-by: Zenghui Yu <yuzenghui(a)huawei.com> Signed-off-by: Marc Zyngier <maz(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- virt/kvm/arm/vgic/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/vgic/trace.h b/virt/kvm/arm/vgic/trace.h index 55fed77a9f739..4fd4f6db181b0 100644 --- a/virt/kvm/arm/vgic/trace.h +++ b/virt/kvm/arm/vgic/trace.h @@ -30,7 +30,7 @@ TRACE_EVENT(vgic_update_irq_pending, #endif /* _TRACE_VGIC_H */ #undef TRACE_INCLUDE_PATH -#define TRACE_INCLUDE_PATH ../../../virt/kvm/arm/vgic +#define TRACE_INCLUDE_PATH ../../virt/kvm/arm/vgic #undef TRACE_INCLUDE_FILE #define TRACE_INCLUDE_FILE trace -- 2.20.1

5 years

3
30
0 0

[PATCH 4.19] nvme: Assign subsys instance from first ctrl

by Keith Busch

commit 733e4b69d508d03c20adfdcf4bd27abc60fae9cc upstream The namespace disk names must be unique for the lifetime of the subsystem. This was accomplished by using their parent subsystems' instances which were allocated independently from the controllers connected to that subsystem. This allowed name prefixes assigned to namespaces to match a controller from an unrelated subsystem, and has created confusion among users examining device nodes. Ensure a namespace's subsystem instance never clashes with a controller instance of another subsystem by transferring the instance ownership to the parent subsystem from the first controller discovered in that subsystem. Reviewed-by: Logan Gunthorpe <logang(a)deltatee.com> Reviewed-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Minwoo Im <minwoo.im(a)samsung.com> Reviewed-by: Hannes Reinecke <hare(a)suse.com> Reviewed-by: Sagi Grimberg <sagi(a)grimberg.me> Signed-off-by: Keith Busch <kbusch(a)kernel.org> Signed-off-by: Sagi Grimberg <sagi(a)grimberg.me> --- drivers/nvme/host/core.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index ae0b01059fc6..cab4f368ef2d 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -88,7 +88,6 @@ EXPORT_SYMBOL_GPL(nvme_reset_wq); struct workqueue_struct *nvme_delete_wq; EXPORT_SYMBOL_GPL(nvme_delete_wq); -static DEFINE_IDA(nvme_subsystems_ida); static LIST_HEAD(nvme_subsystems); static DEFINE_MUTEX(nvme_subsystems_lock); @@ -2139,7 +2138,8 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct static void __nvme_release_subsystem(struct nvme_subsystem *subsys) { - ida_simple_remove(&nvme_subsystems_ida, subsys->instance); + if (subsys->instance >= 0) + ida_simple_remove(&nvme_instance_ida, subsys->instance); kfree(subsys); } @@ -2255,12 +2255,8 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) subsys = kzalloc(sizeof(*subsys), GFP_KERNEL); if (!subsys) return -ENOMEM; - ret = ida_simple_get(&nvme_subsystems_ida, 0, 0, GFP_KERNEL); - if (ret < 0) { - kfree(subsys); - return ret; - } - subsys->instance = ret; + + subsys->instance = -1; mutex_init(&subsys->lock); kref_init(&subsys->ref); INIT_LIST_HEAD(&subsys->ctrls); @@ -2275,7 +2271,7 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) subsys->dev.class = nvme_subsys_class; subsys->dev.release = nvme_release_subsystem; subsys->dev.groups = nvme_subsys_attrs_groups; - dev_set_name(&subsys->dev, "nvme-subsys%d", subsys->instance); + dev_set_name(&subsys->dev, "nvme-subsys%d", ctrl->instance); device_initialize(&subsys->dev); mutex_lock(&nvme_subsystems_lock); @@ -2308,6 +2304,8 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) list_add_tail(&subsys->entry, &nvme_subsystems); } + if (!found) + subsys->instance = ctrl->instance; ctrl->subsys = subsys; mutex_unlock(&nvme_subsystems_lock); @@ -2319,7 +2317,6 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) return -EINVAL; } - mutex_lock(&subsys->lock); list_add_tail(&ctrl->subsys_entry, &subsys->ctrls); mutex_unlock(&subsys->lock); @@ -3545,7 +3542,9 @@ static void nvme_free_ctrl(struct device *dev) container_of(dev, struct nvme_ctrl, ctrl_device); struct nvme_subsystem *subsys = ctrl->subsys; - ida_simple_remove(&nvme_instance_ida, ctrl->instance); + if (subsys && ctrl->instance != subsys->instance) + ida_simple_remove(&nvme_instance_ida, ctrl->instance); + kfree(ctrl->effects); nvme_mpath_uninit(ctrl); @@ -3775,7 +3774,6 @@ int __init nvme_core_init(void) void nvme_core_exit(void) { - ida_destroy(&nvme_subsystems_ida); class_destroy(nvme_subsys_class); class_destroy(nvme_class); unregister_chrdev_region(nvme_chr_devt, NVME_MINORS); -- 2.21.0

5 years

2
2
0 0

[PATCH v6 07/43] ceph: fix compat_ioctl for ceph_dir_operations

by Arnd Bergmann

The ceph_ioctl function is used both for files and directories, but only the files support doing that in 32-bit compat mode. For consistency, add the same compat handler to the dir operations as well, and use a handler that applies the appropriate compat_ptr() conversion. Reviewed-by: "Yan, Zheng" <zyan(a)redhat.com> Cc: stable(a)vger.kernel.org Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- fs/ceph/dir.c | 1 + fs/ceph/file.c | 2 +- fs/ceph/super.h | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 4ca0b8ff9a72..401c17d36b71 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -1808,6 +1808,7 @@ const struct file_operations ceph_dir_fops = { .open = ceph_open, .release = ceph_release, .unlocked_ioctl = ceph_ioctl, + .compat_ioctl = ceph_compat_ioctl, .fsync = ceph_fsync, .lock = ceph_lock, .flock = ceph_flock, diff --git a/fs/ceph/file.c b/fs/ceph/file.c index d277f71abe0b..9e8e4bfe1d50 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -2162,7 +2162,7 @@ const struct file_operations ceph_file_fops = { .splice_read = generic_file_splice_read, .splice_write = iter_file_splice_write, .unlocked_ioctl = ceph_ioctl, - .compat_ioctl = ceph_ioctl, + .compat_ioctl = ceph_compat_ioctl, .fallocate = ceph_fallocate, .copy_file_range = ceph_copy_file_range, }; diff --git a/fs/ceph/super.h b/fs/ceph/super.h index f98d9247f9cb..87bf9db76f98 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -6,6 +6,7 @@ #include <asm/unaligned.h> #include <linux/backing-dev.h> +#include <linux/compat.h> #include <linux/completion.h> #include <linux/exportfs.h> #include <linux/fs.h> @@ -1123,6 +1124,15 @@ extern void ceph_readdir_cache_release(struct ceph_readdir_cache_control *ctl); /* ioctl.c */ extern long ceph_ioctl(struct file *file, unsigned int cmd, unsigned long arg); +static inline long +ceph_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{ +#ifdef CONFIG_COMPAT + return ceph_ioctl(file, cmd, (unsigned long)compat_ptr(arg)); +#else + return -ENOTTY; +#endif +} /* export.c */ extern const struct export_operations ceph_export_ops; -- 2.20.0

5 years

1
0
0 0

[PATCH 4.14.y] xfs: clear sb->s_fs_info on mount failure

by Ajay Kaher

From: Dave Chinner <dchinner(a)redhat.com> commit c9fbd7bbc23dbdd73364be4d045e5d3612cf6e82 upstream. We recently had an oops reported on a 4.14 kernel in xfs_reclaim_inodes_count() where sb->s_fs_info pointed to garbage and so the m_perag_tree lookup walked into lala land. Essentially, the machine was under memory pressure when the mount was being run, xfs_fs_fill_super() failed after allocating the xfs_mount and attaching it to sb->s_fs_info. It then cleaned up and freed the xfs_mount, but the sb->s_fs_info field still pointed to the freed memory. Hence when the superblock shrinker then ran it fell off the bad pointer. With the superblock shrinker problem fixed at teh VFS level, this stale s_fs_info pointer is still a problem - we use it unconditionally in ->put_super when the superblock is being torn down, and hence we can still trip over it after a ->fill_super call failure. Hence we need to clear s_fs_info if xfs-fs_fill_super() fails, and we need to check if it's valid in the places it can potentially be dereferenced after a ->fill_super failure. Signed-Off-By: Dave Chinner <dchinner(a)redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Ajay Kaher <akaher(a)vmware.com> --- fs/xfs/xfs_super.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 0b0282d..10151c9 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1715,6 +1715,7 @@ xfs_fs_fill_super( out_close_devices: xfs_close_devices(mp); out_free_fsname: + sb->s_fs_info = NULL; xfs_free_fsname(mp); kfree(mp); out: @@ -1732,6 +1733,10 @@ xfs_fs_put_super( { struct xfs_mount *mp = XFS_M(sb); + /* if ->fill_super failed, we have no mount to tear down */ + if (!sb->s_fs_info) + return; + xfs_notice(mp, "Unmounting Filesystem"); xfs_filestream_unmount(mp); xfs_unmountfs(mp); @@ -1741,6 +1746,8 @@ xfs_fs_put_super( xfs_destroy_percpu_counters(mp); xfs_destroy_mount_workqueues(mp); xfs_close_devices(mp); + + sb->s_fs_info = NULL; xfs_free_fsname(mp); kfree(mp); } @@ -1760,6 +1767,9 @@ xfs_fs_nr_cached_objects( struct super_block *sb, struct shrink_control *sc) { + /* Paranoia: catch incorrect calls during mount setup or teardown */ + if (WARN_ON_ONCE(!sb->s_fs_info)) + return 0; return xfs_reclaim_inodes_count(XFS_M(sb)); } -- 2.7.4

5 years

1
0
0 0

[PATCH 1/3] USB: usb-skeleton: fix NULL-deref on disconnect

by Johan Hovold

The driver was using its struct usb_interface pointer as an inverted disconnected flag and was setting it to NULL before making sure all completion handlers had run. This could lead to NULL-pointer dereferences in the dev_err() statements in the completion handlers which relies on said pointer. Fix this by using a dedicated disconnected flag. Note that this is also addresses a NULL-pointer dereference at release() and a struct usb_interface reference leak introduced by a recent runtime PM fix, which depends on and should have been submitted together with this patch. Fixes: 4212cd74ca6f ("USB: usb-skeleton.c: remove err() usage") Fixes: 5c290a5e42c3 ("USB: usb-skeleton: fix runtime PM after driver unbind") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/usb/usb-skeleton.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index 8001d6384c73..c2843fcfa52d 100644 --- a/drivers/usb/usb-skeleton.c +++ b/drivers/usb/usb-skeleton.c @@ -61,6 +61,7 @@ struct usb_skel { spinlock_t err_lock; /* lock for errors */ struct kref kref; struct mutex io_mutex; /* synchronize I/O with disconnect */ + unsigned long disconnected:1; wait_queue_head_t bulk_in_wait; /* to wait for an ongoing read */ }; #define to_skel_dev(d) container_of(d, struct usb_skel, kref) @@ -238,7 +239,7 @@ static ssize_t skel_read(struct file *file, char *buffer, size_t count, if (rv < 0) return rv; - if (!dev->interface) { /* disconnect() was called */ + if (dev->disconnected) { /* disconnect() was called */ rv = -ENODEV; goto exit; } @@ -420,7 +421,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer, /* this lock makes sure we don't submit URBs to gone devices */ mutex_lock(&dev->io_mutex); - if (!dev->interface) { /* disconnect() was called */ + if (dev->disconnected) { /* disconnect() was called */ mutex_unlock(&dev->io_mutex); retval = -ENODEV; goto error; @@ -571,7 +572,7 @@ static void skel_disconnect(struct usb_interface *interface) /* prevent more I/O from starting */ mutex_lock(&dev->io_mutex); - dev->interface = NULL; + dev->disconnected = 1; mutex_unlock(&dev->io_mutex); usb_kill_anchored_urbs(&dev->submitted); -- 2.23.0

5 years

1
0
0 0

[PATCH AUTOSEL 4.4 01/11] scsi: ufs: skip shutdown if hba is not powered

by Sasha Levin

From: Stanley Chu <stanley.chu(a)mediatek.com> [ Upstream commit f51913eef23f74c3bd07899dc7f1ed6df9e521d8 ] In some cases, hba may go through shutdown flow without successful initialization and then make system hang. For example, if ufshcd_change_power_mode() gets error and leads to ufshcd_hba_exit() to release resources of the host, future shutdown flow may hang the system since the host register will be accessed in unpowered state. To solve this issue, simply add checking to skip shutdown for above kind of situation. Link: https://lore.kernel.org/r/1568780438-28753-1-git-send-email-stanley.chu@med… Signed-off-by: Stanley Chu <stanley.chu(a)mediatek.com> Acked-by: Bean Huo <beanhuo(a)micron.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/scsi/ufs/ufshcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index fd8bbd2b5d0eb..504d367961528 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5371,6 +5371,9 @@ int ufshcd_shutdown(struct ufs_hba *hba) { int ret = 0; + if (!hba->is_powered) + goto out; + if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) goto out; -- 2.20.1

5 years

1
10
0 0

[PATCH AUTOSEL 4.9 01/13] scsi: ufs: skip shutdown if hba is not powered

by Sasha Levin

From: Stanley Chu <stanley.chu(a)mediatek.com> [ Upstream commit f51913eef23f74c3bd07899dc7f1ed6df9e521d8 ] In some cases, hba may go through shutdown flow without successful initialization and then make system hang. For example, if ufshcd_change_power_mode() gets error and leads to ufshcd_hba_exit() to release resources of the host, future shutdown flow may hang the system since the host register will be accessed in unpowered state. To solve this issue, simply add checking to skip shutdown for above kind of situation. Link: https://lore.kernel.org/r/1568780438-28753-1-git-send-email-stanley.chu@med… Signed-off-by: Stanley Chu <stanley.chu(a)mediatek.com> Acked-by: Bean Huo <beanhuo(a)micron.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/scsi/ufs/ufshcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index a9c172692f21d..26f259fb6e3ca 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6492,6 +6492,9 @@ int ufshcd_shutdown(struct ufs_hba *hba) { int ret = 0; + if (!hba->is_powered) + goto out; + if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) goto out; -- 2.20.1

5 years

1
12
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror October 2019