Re: [PATCH v1 RESEND 1/5] dt-bidings: riscv: add Zilsd and Zclsd extension descriptions - Linux-kselftest-mirror

25 Aug 2025

...
-----Original Message-----
From: Inochi Amaoto inochiama@gmail.com
Sent: Saturday, August 23, 2025 6:35 AM
To: Pincheng Wang pincheng.plct@isrc.iscas.ac.cn;
paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu;
alex@ghiti.fr; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
anup@brainfault.org; pbonzini@redhat.com; shuah@kernel.org;
cyan.yang@sifive.com; cleger@rivosinc.com; charlie@rivosinc.com;
cuiyunhui@bytedance.com; samuel.holland@sifive.com;
namcao@linutronix.de; jesse@rivosinc.com; inochiama@gmail.com;
yongxuan.wang@sifive.com; ajones@ventanamicro.com;
parri.andrea@gmail.com; mikisabate@gmail.com; yikming2222@gmail.com;
thomas.weissschuh@linutronix.de
Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org;
linux-doc@vger.kernel.org; devicetree@vger.kernel.org; kvm@vger.kernel.org;
kvm-riscv@lists.infradead.org; linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 RESEND 1/5] dt-bidings: riscv: add Zilsd and Zclsd
extension descriptions
On Thu, Aug 21, 2025 at 10:01:27PM +0800, Pincheng Wang wrote:
...
Add descriptions for the Zilsd (Load/Store pair instructions) and
Zclsd (Compressed Load/Store pair instructions) ISA extensions which
were ratified in commit f88abf1 ("Integrating load/store pair for RV32
with the main manual") of the riscv-isa-manual.
Signed-off-by: Pincheng Wang pincheng.plct@isrc.iscas.ac.cn
.../devicetree/bindings/riscv/extensions.yaml | 39
+++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml
b/Documentation/devicetree/bindings/riscv/extensions.yaml
index ede6a58ccf53..d72ffe8f6fa7 100644
--- a/Documentation/devicetree/bindings/riscv/extensions.yaml
+++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
@@ -366,6 +366,20 @@ properties:
             guarantee on LR/SC sequences, as ratified in commit
b1d806605f87
...
         ("Updated to ratified state.") of the riscv profiles

specification.
...

   - const: zilsd


     description:


       The standard Zilsd extension which provides support for



aligned
...

       register-pair load and store operations in 32-bit instruction


       encodings, as ratified in commit f88abf1 ("Integrating


       load/store pair for RV32 with the main manual") of



riscv-isa-manual.
...


   - const: zclsd


     description:


       The Zclsd extension implements the compressed (16-bit)



version of the
...

       Load/Store Pair for RV32. As with Zilsd, this extension was



ratified
...

       in commit f88abf1 ("Integrating load/store pair for RV32 with



the
...

       main manual") of riscv-isa-manual.


   - const: zk
     description:
       The standard Zk Standard Scalar cryptography extension as



ratified @@ -847,6 +861,16 @@ properties:
             anyOf:
               - const: v
               - const: zve32x
...

 # Zclsd depends on Zilsd and Zca


 - if:


     contains:


       anyOf:


         - const: zclsd


   then:


     contains:


       anyOf:


         - const: zilsd


         - const: zca




Should be allOf? I see the comment says "Zclsd" requires both "Zilsd"
and "Zca".
Regards,
Inochi
You're absolutely right, thank you for catching this. Since Zclsd depends on both Zilsd and Zca, the condition should use allOf to correctly enforce the conjunction. I'll fix this in next revision.
Best regards,
Pincheng Wang

    