On Fri, Mar 24, 2023 at 7:13 AM Markus Elfring Markus.Elfring@web.de wrote:

Date: Fri, 24 Mar 2023 14:54:18 +0100

The label “err_out” was used to jump to another pointer check despite of the detail in the implementation of the function “rbtree_add_and_remove” that it was determined already that a corresponding variable contained a null pointer.

1. Thus return directly after the first call of the function “bpf_obj_new” failed.

2. Delete two questionable checks.

3. Omit an extra initialisation (for the variable “m”) which became unnecessary with this refactoring.

This issue was detected by using the Coccinelle software.

Fixes: 215249f6adc0359e3546829e7ee622b5e309b0ad ("selftests/bpf: Add rbtree selftests") Signed-off-by: Markus Elfring elfring@users.sourceforge.net

Nack. Please stop sending such "cleanup" patches.