I'm wondering about the ASSERT_* and EXPECT_* macros from tools/testing/selftests/kselftest_harness.h Do you think we should treat them as "for macros" as well? They can either be used with or without a following code block.
On 12/04/2022 17:58, Miguel Ojeda wrote:
Hi Mickaël,
On Tue, Apr 12, 2022 at 5:39 PM Mickaël Salaün mic@digikod.net wrote:
Add tools/ to the shell fragment generating the for_each list and update it. This is useful to format files in the tools directory (e.g. selftests) with the same coding style as the kernel.
Sounds good to me. There have been discussions about doing it for the entire tree too, so we can start with this.
Cheers, Miguel
On Tue, Apr 12, 2022 at 7:05 PM Mickaël Salaün mic@digikod.net wrote:
I'm wondering about the ASSERT_* and EXPECT_* macros from tools/testing/selftests/kselftest_harness.h Do you think we should treat them as "for macros" as well? They can either be used with or without a following code block.
I would keep the style that we have in the kernel -- as far as I can see, that means without a space.
Also, from a quick grep, it seems most callers do not use the optional handler, which also makes sense w.r.t. not using a space.
Cheers, Miguel
linux-kselftest-mirror@lists.linaro.org
-
Mickaël Salaün -
Miguel Ojeda