The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch.
Signed-off-by: Abhash Jha abhashkumarjha123@gmail.com --- tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh index cfc849580..62eceb385 100755 --- a/tools/testing/selftests/net/pmtu.sh +++ b/tools/testing/selftests/net/pmtu.sh @@ -1347,7 +1347,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() { size=$(du -sb $tmpoutfile) size=${size%%/tmp/*}
- [ $size -ne 1048576 ] && err "File size $size mismatches exepcted value in locally bridged vxlan test" && return 1 + [ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1 done
rm -f "$tmpoutfile"
Hi Abhash,
You need add target repo for the patch. e.g. [PATCH net] selftests...
On Wed, Aug 14, 2024 at 11:01:21PM +0530, Abhash Jha wrote:
The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch.
Here you need to add the fixes tag. e.g. Fixes: 136a1b434bbb ("selftests: net: test vxlan pmtu exceptions with tcp")
Signed-off-by: Abhash Jha abhashkumarjha123@gmail.com
tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh index cfc849580..62eceb385 100755 --- a/tools/testing/selftests/net/pmtu.sh +++ b/tools/testing/selftests/net/pmtu.sh @@ -1347,7 +1347,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() { size=$(du -sb $tmpoutfile) size=${size%%/tmp/*}
[ $size -ne 1048576 ] && err "File size $size mismatches exepcted value in locally bridged vxlan test" && return 1
[ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1rm -f "$tmpoutfile" -- 2.43.0
On Wed, Aug 14, 2024 at 11:01:21PM +0530, Abhash Jha wrote:
The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch.
Signed-off-by: Abhash Jha abhashkumarjha123@gmail.com
I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.
Reviewed-by: Simon Horman horms@kernel.org
I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.
Reviewed-by: Simon Horman horms@kernel.org
Hi Simon, Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by liuhangbin@gmail.com. Or is it fine for now.
Regards, Abhash
On Thu, Aug 15, 2024 at 10:37:19PM +0530, Abhash jha wrote:
I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.
Reviewed-by: Simon Horman horms@kernel.org
Hi Simon, Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by liuhangbin@gmail.com. Or is it fine for now.
Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.
TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug. But if you believe it is, then please follow Hangbin's advice.
On Thu, 15 Aug 2024 18:45:08 +0100 Simon Horman wrote:
On Thu, Aug 15, 2024 at 10:37:19PM +0530, Abhash jha wrote:
I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.
Reviewed-by: Simon Horman horms@kernel.org
Hi Simon, Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by liuhangbin@gmail.com. Or is it fine for now.
Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.
TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug.
+1, same feeling here, I'll apply as is.
On Thu, Aug 15, 2024 at 05:38:18PM -0700, Jakub Kicinski wrote:
On Thu, 15 Aug 2024 18:45:08 +0100 Simon Horman wrote:
On Thu, Aug 15, 2024 at 10:37:19PM +0530, Abhash jha wrote:
I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.
Reviewed-by: Simon Horman horms@kernel.org
Hi Simon, Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by liuhangbin@gmail.com. Or is it fine for now.
Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.
TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug.
+1, same feeling here, I'll apply as is.
Thanks, good to know this.
Hangbin
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Wed, 14 Aug 2024 23:01:21 +0530 you wrote:
The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch.
Signed-off-by: Abhash Jha abhashkumarjha123@gmail.com
tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links: - selftests/net/pmtu.sh: Fix typo in error message https://git.kernel.org/netdev/net-next/c/e7d731326ef0
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Abhash Jha -
Abhash jha
-
Hangbin Liu -
Jakub Kicinski -
patchwork-bot+netdevbpf＠kernel.org -
Simon Horman