Fix:

clone3_cap_checkpoint_restore.c:56:7: warning: unused variable 'ret' 56 | int ret; | ^~~ clone3_cap_checkpoint_restore.c:57:8: warning: unused variable 'tmp' 57 | char tmp = 0; | ^~~ clone3_cap_checkpoint_restore.c:138:6: warning: unused variable 'ret' 138 | int ret = 0;

by removing the unused variables.

Fixes: 1d27a0be16d6 ("selftests: add clone3() CAP_CHECKPOINT_RESTORE test") Cc: Adrian Reber areber@redhat.com Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes build warnings

.../testing/selftests/clone3/clone3_cap_checkpoint_restore.c | 4 ---- 1 file changed, 4 deletions(-)

diff --git a/tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c b/tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c index 3c196fa86c99..976e92c259fc 100644 --- a/tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c +++ b/tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c @@ -53,9 +53,6 @@ static int call_clone3_set_tid(struct __test_metadata *_metadata, }

if (pid == 0) { - int ret; - char tmp = 0; - TH_LOG("I am the child, my PID is %d (expected %d)", getpid(), set_tid[0]);

if (set_tid[0] != getpid()) @@ -135,7 +132,6 @@ TEST(clone3_cap_checkpoint_restore) { pid_t pid; int status; - int ret = 0; pid_t set_tid[1];

test_clone3_supported();

Fix

fclog.c:37:21: warning: call to undeclared function 'open' fclog.c:37:47: error: use of undeclared identifier 'O_RDONLY'; did you mean 'MS_RDONLY'? fclog.c:37:56: error: use of undeclared identifier 'O_CLOEXEC'

by including fcntl.h.

Fixes: df579e471111b ("selftests/filesystems: add basic fscontext log tests") Cc: Aleksa Sarai cyphar@cyphar.com Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch also fixes build warnings.

tools/testing/selftests/filesystems/fclog.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/filesystems/fclog.c b/tools/testing/selftests/filesystems/fclog.c index 912a8b755c3b..d7cc3aaa8672 100644 --- a/tools/testing/selftests/filesystems/fclog.c +++ b/tools/testing/selftests/filesystems/fclog.c @@ -6,6 +6,7 @@

#include <assert.h> #include <errno.h> +#include <fcntl.h> #include <sched.h> #include <stdio.h> #include <stdlib.h>

Fix

anon_inode_test.c:45:12: warning: call to undeclared function 'execveat'

by adding the missing include file.

Fixes: f8ca403ae77cb ("selftests/filesystems: add exec() test for anonymous inodes") Cc: Christian Brauner brauner@kernel.org Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes a build warning. This patch does not fix: anon_inode_test.c: In function ‘anon_inode_no_exec’: anon_inode_test.c:46:19: warning: argument 3 null where non-null expected because I have no idea how to do avoid that warning.

tools/testing/selftests/filesystems/anon_inode_test.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c index 73e0a4d4fb2f..5ddcfd2927f9 100644 --- a/tools/testing/selftests/filesystems/anon_inode_test.c +++ b/tools/testing/selftests/filesystems/anon_inode_test.c @@ -4,6 +4,7 @@

#include <fcntl.h> #include <stdio.h> +#include <unistd.h> #include <sys/stat.h>

#include "../kselftest_harness.h"

test_futex_mpol() is not called, resulting in the following build warning.

futex_numa_mpol.c:134:13: warning: ‘test_futex_mpol’ defined but not used

Disable the function but keep it in case it was supposed to be used.

Fixes: d35ca2f64272 ("selftests/futex: Refactor futex_numa_mpol with kselftest_harness.h") Cc: André Almeida andrealmeid@igalia.com Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes a build warning.

tools/testing/selftests/futex/functional/futex_numa_mpol.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools/testing/selftests/futex/functional/futex_numa_mpol.c index d037a3f10ee8..8e3d17d66684 100644 --- a/tools/testing/selftests/futex/functional/futex_numa_mpol.c +++ b/tools/testing/selftests/futex/functional/futex_numa_mpol.c @@ -131,10 +131,12 @@ static void test_futex(void *futex_ptr, int err_value) __test_futex(futex_ptr, err_value, FUTEX2_SIZE_U32 | FUTEX_PRIVATE_FLAG | FUTEX2_NUMA); }

+#ifdef NOTUSED static void test_futex_mpol(void *futex_ptr, int err_value) { __test_futex(futex_ptr, err_value, FUTEX2_SIZE_U32 | FUTEX_PRIVATE_FLAG | FUTEX2_NUMA | FUTEX2_MPOL); } +#endif

TEST(futex_numa_mpol) {

Fix:

seccomp_bpf.c: In function ‘UPROBE_setup’: seccomp_bpf.c:5175:74: warning: pointer type mismatch in conditional expression

by type casting the argument to get_uprobe_offset().

Fixes: 9ffc7a635c35a ("selftests/seccomp: validate uprobe syscall passes through seccomp") Cc: Jiri Olsa jolsa@kernel.org Cc: Peter Zijlstra (Intel) peterz@infradead.org Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes a build warning.

tools/testing/selftests/seccomp/seccomp_bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 874f17763536..2584f4f5c062 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -5172,7 +5172,8 @@ FIXTURE_SETUP(UPROBE) ASSERT_GE(bit, 0); }

- offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe); + offset = get_uprobe_offset(variant->uretprobe ? + (void *)probed_uretprobe : (void *)probed_uprobe); ASSERT_GE(offset, 0);

if (variant->uretprobe)

Fix

ksft.h: In function ‘ksft_ready’: ksft.h:27:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’

ksft.h: In function ‘ksft_wait’: ksft.h:51:9: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’

by checking the return value of the affected functions and displaying an error message if an error is seen.

Fixes: 2b6d490b82668 ("selftests: drv-net: Factor out ksft C helpers") Cc: Joe Damato jdamato@fastly.com Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes build warnings. Use perror() to display an error message if one of the functions returns an error.

tools/testing/selftests/net/lib/ksft.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/lib/ksft.h b/tools/testing/selftests/net/lib/ksft.h index 17dc34a612c6..03912902a6d3 100644 --- a/tools/testing/selftests/net/lib/ksft.h +++ b/tools/testing/selftests/net/lib/ksft.h @@ -24,7 +24,8 @@ static inline void ksft_ready(void) fd = STDOUT_FILENO; }

- write(fd, msg, sizeof(msg)); + if (write(fd, msg, sizeof(msg)) < 0) + perror("write()"); if (fd != STDOUT_FILENO) close(fd); } @@ -48,7 +49,8 @@ static inline void ksft_wait(void) fd = STDIN_FILENO; }

- read(fd, &byte, sizeof(byte)); + if (read(fd, &byte, sizeof(byte)) < 0) + perror("read()"); if (fd != STDIN_FILENO) close(fd); }

Fix

mount-notify_test_ns.c: In function ‘fanotify_rmdir’: mount-notify_test_ns.c:494:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’

by checking the return value of chdir() and displaying an error message if it returns an error.

Fixes: 781091f3f5945 ("selftests/fs/mount-notify: add a test variant running inside userns") Cc: Amir Goldstein amir73il@gmail.com Signed-off-by: Guenter Roeck linux@roeck-us.net --- v2: Update subject and description to reflect that the patch fixes a build warning. Use perror() to display an error message if chdir() returns an error.

.../selftests/filesystems/mount-notify/mount-notify_test_ns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c index 9f57ca46e3af..90bec6faf64e 100644 --- a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c +++ b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c @@ -491,7 +491,8 @@ TEST_F(fanotify, rmdir) ASSERT_GE(ret, 0);

if (ret == 0) { - chdir("/"); + if (chdir("/")) + perror("chdir()"); unshare(CLONE_NEWNS); mount("", "/", NULL, MS_REC|MS_PRIVATE, NULL); umount2("/a", MNT_DETACH);

On Friday, 5 December 2025 11:09:56 CST Guenter Roeck wrote:

Fix

ntsync.c:1286:20: warning: call to undeclared function 'gettid'; ISO C99 and later do not support implicit function declarations 1286 | wait_args.owner = gettid(); | ^ ntsync.c:1280:8: warning: unused variable 'index' 1280 | __u32 index, count, i; | ^~~~~ ntsync.c:1281:6: warning: unused variable 'ret' 1281 | int ret;

by adding the missing include file and removing the unused variables.

Fixes: a22860e57b54 ("selftests: ntsync: Add a stress test for contended waits.") Cc: Elizabeth Figura zfigura@codeweavers.com Signed-off-by: Guenter Roeck linux@roeck-us.net

---

v2: Update subject and description to reflect that the patch fixes build warnings

tools/testing/selftests/drivers/ntsync/ntsync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c index 3aad311574c4..d3df94047e4d 100644 --- a/tools/testing/selftests/drivers/ntsync/ntsync.c +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c @@ -11,6 +11,7 @@ #include <fcntl.h> #include <time.h> #include <pthread.h> +#include <unistd.h> #include <linux/ntsync.h> #include "../../kselftest_harness.h" @@ -1277,8 +1278,7 @@ static int stress_device, stress_start_event, stress_mutex; static void *stress_thread(void *arg) { struct ntsync_wait_args wait_args = {0};

• __u32 index, count, i;
• int ret;

• __u32 count, i;

wait_args.timeout = UINT64_MAX; wait_args.count = 1;

LGTM.

Reviewed-by: Elizabeth Figura zfigura@codeweavers.com