The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".
Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org --- CC: shuah@kernel.org CC: willemb@google.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/drivers/net/hw/tso.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/hw/tso.py b/tools/testing/selftests/drivers/net/hw/tso.py index 150d6db241a0..3370827409aa 100755 --- a/tools/testing/selftests/drivers/net/hw/tso.py +++ b/tools/testing/selftests/drivers/net/hw/tso.py @@ -216,7 +216,7 @@ from lib.py import bkg, cmd, defer, ethtool, ip, rand_port, wait_port_listen ("", "6", "tx-tcp6-segmentation", None), ("vxlan", "", "tx-udp_tnl-segmentation", ("vxlan", True, "id 100 dstport 4789 noudpcsum")), ("vxlan_csum", "", "tx-udp_tnl-csum-segmentation", ("vxlan", False, "id 100 dstport 4789 udpcsum")), - ("gre", "4", "tx-gre-segmentation", ("ipgre", False, "")), + ("gre", "4", "tx-gre-segmentation", ("gre", False, "")), ("gre", "6", "tx-gre-segmentation", ("ip6gre", False, "")), )
On Tue, Jun 03, 2025 at 06:20:31PM -0700, Jakub Kicinski wrote:
The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".
Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org
Reviewed-by: Simon Horman horms@kernel.org
Jakub Kicinski wrote:
The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".
Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org
Reviewed-by: Willem de Bruijn willemb@google.com
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski kuba@kernel.org:
On Tue, 3 Jun 2025 18:20:31 -0700 you wrote:
The device type for IPv4 GRE is "gre" not "ipgre", unlike for IPv6 which uses "ip6gre".
Not sure how I missed this when writing the test, perhaps because all HW I have access to is on an IPv6-only network.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org
[...]
Here is the summary with links: - [net] selftests: drv-net: tso: fix the GRE device name https://git.kernel.org/netdev/net/c/c68804c934e3
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org