The cbo and which-cpu hwprobe selftests leave their artifacts in the kernel tree and end up being tracked by git. Add the binaries to the hwprobe selftest .gitignore so this no longer happens.
Signed-off-by: Charlie Jenkins charlie@rivosinc.com Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests") Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test") --- tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore index 8113dc3bdd03..6e384e80ea1a 100644 --- a/tools/testing/selftests/riscv/hwprobe/.gitignore +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore @@ -1 +1,3 @@ hwprobe +cbo +which-cpus
--- base-commit: ed30a4a51bb196781c8058073ea720133a65596f change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
On 4/26/24 12:58 AM, Charlie Jenkins wrote:
The cbo and which-cpu hwprobe selftests leave their artifacts in the kernel tree and end up being tracked by git. Add the binaries to the hwprobe selftest .gitignore so this no longer happens.
I've been posted comments on patches adding new tests to please put artifacts in the .gitignore. But still people forget or don't know about it as .gitignore is specific to selftests and they aren't used-to it.
Signed-off-by: Charlie Jenkins charlie@rivosinc.com Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests") Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
Reviewed-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore index 8113dc3bdd03..6e384e80ea1a 100644 --- a/tools/testing/selftests/riscv/hwprobe/.gitignore +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore @@ -1 +1,3 @@ hwprobe +cbo +which-cpus
base-commit: ed30a4a51bb196781c8058073ea720133a65596f change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
On Thu, Apr 25, 2024 at 12:58:03PM GMT, Charlie Jenkins wrote:
The cbo and which-cpu hwprobe selftests leave their artifacts in the kernel tree and end up being tracked by git. Add the binaries to the hwprobe selftest .gitignore so this no longer happens.
Signed-off-by: Charlie Jenkins charlie@rivosinc.com Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests") Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore index 8113dc3bdd03..6e384e80ea1a 100644 --- a/tools/testing/selftests/riscv/hwprobe/.gitignore +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore @@ -1 +1,3 @@ hwprobe +cbo +which-cpus
base-commit: ed30a4a51bb196781c8058073ea720133a65596f change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c --
- Charlie
We can also consider doing what kvm selftests does, which is to just have the top-level .gitignore which ignores everything except the code. See tools/testing/selftests/kvm/.gitignore
But, until (if at all) we go that way, we can do what this patch does,
Reviewed-by: Andrew Jones ajones@ventanamicro.com
Thanks, drew
Hello:
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt palmer@rivosinc.com:
On Thu, 25 Apr 2024 12:58:03 -0700 you wrote:
The cbo and which-cpu hwprobe selftests leave their artifacts in the kernel tree and end up being tracked by git. Add the binaries to the hwprobe selftest .gitignore so this no longer happens.
Signed-off-by: Charlie Jenkins charlie@rivosinc.com Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests") Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
[...]
Here is the summary with links: - riscv: selftests: Add hwprobe binaries to .gitignore https://git.kernel.org/riscv/c/b1f4ad94cd12
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Andrew Jones -
Charlie Jenkins -
Muhammad Usama Anjum -
patchwork-bot+linux-riscv＠kernel.org