For some distributions (e.g. OpenWrt) we don't want to rely on rsync to copy the tests to the target as some extra dependencies need to be installed. The Makefile in tools/testing/selftests/net/forwarding already installs most of the tests.
This series adds the two missing tests to the list of installed tests. That way a downstream distribution can build a package using this Makefile (and add dependencies there as needed).
Martin Blumenstingl (2): selftests: forwarding: Install local_termination.sh selftests: forwarding: Install no_forwarding.sh
tools/testing/selftests/net/forwarding/Makefile | 2 ++ 1 file changed, 2 insertions(+)
When using the Makefile from tools/testing/selftests/net/forwarding/ all tests should be installed. Add local_termination.sh to the list of "to be installed tests" where it has been missing so far.
Fixes: 90b9566aa5cd3f ("selftests: forwarding: add a test for local_termination.sh") Signed-off-by: Martin Blumenstingl martin.blumenstingl@googlemail.com --- tools/testing/selftests/net/forwarding/Makefile | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile index 669ffd6f2a68..6fcf6cdfaee2 100644 --- a/tools/testing/selftests/net/forwarding/Makefile +++ b/tools/testing/selftests/net/forwarding/Makefile @@ -38,6 +38,7 @@ TEST_PROGS = bridge_igmp.sh \ ipip_hier_gre_key.sh \ ipip_hier_gre_keys.sh \ ipip_hier_gre.sh \ + local_termination.sh \ loopback.sh \ mirror_gre_bound.sh \ mirror_gre_bridge_1d.sh \
On Thu, Jul 07, 2022 at 03:55:31PM +0200, Martin Blumenstingl wrote:
When using the Makefile from tools/testing/selftests/net/forwarding/ all tests should be installed. Add local_termination.sh to the list of "to be installed tests" where it has been missing so far.
Fixes: 90b9566aa5cd3f ("selftests: forwarding: add a test for local_termination.sh") Signed-off-by: Martin Blumenstingl martin.blumenstingl@googlemail.com
Reviewed-by: Vladimir Oltean vladimir.oltean@nxp.com
When using the Makefile from tools/testing/selftests/net/forwarding/ all tests should be installed. Add no_forwarding.sh to the list of "to be installed tests" where it has been missing so far.
Fixes: 476a4f05d9b83f ("selftests: forwarding: add a no_forwarding.sh test") Signed-off-by: Martin Blumenstingl martin.blumenstingl@googlemail.com --- tools/testing/selftests/net/forwarding/Makefile | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile index 6fcf6cdfaee2..a9c5c1be5088 100644 --- a/tools/testing/selftests/net/forwarding/Makefile +++ b/tools/testing/selftests/net/forwarding/Makefile @@ -54,6 +54,7 @@ TEST_PROGS = bridge_igmp.sh \ mirror_gre_vlan_bridge_1q.sh \ mirror_gre_vlan.sh \ mirror_vlan.sh \ + no_forwarding.sh \ pedit_dsfield.sh \ pedit_ip.sh \ pedit_l4port.sh \
On Thu, Jul 07, 2022 at 03:55:32PM +0200, Martin Blumenstingl wrote:
When using the Makefile from tools/testing/selftests/net/forwarding/ all tests should be installed. Add no_forwarding.sh to the list of "to be installed tests" where it has been missing so far.
Fixes: 476a4f05d9b83f ("selftests: forwarding: add a no_forwarding.sh test") Signed-off-by: Martin Blumenstingl martin.blumenstingl@googlemail.com
Reviewed-by: Vladimir Oltean vladimir.oltean@nxp.com
Hi Martin,
On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote:
For some distributions (e.g. OpenWrt) we don't want to rely on rsync to copy the tests to the target as some extra dependencies need to be installed. The Makefile in tools/testing/selftests/net/forwarding already installs most of the tests.
This series adds the two missing tests to the list of installed tests. That way a downstream distribution can build a package using this Makefile (and add dependencies there as needed).
Just for future reference, the netdev process is to mark patch sets such as this one with "PATCH net" since they fix a packaging problem with an rc kernel. There's more information about this in Documentation/process/maintainer-netdev.rst.
Do we need to create a Makefile for the selftests symlinked by DSA in tools/testing/selftests/drivers/net/dsa/, for the symlinks to be installed, or how do you see this?
The reason why I created the symlinks was to make use of the custom forwarding.config provided there, and also to reduce the clutter a bit and only focus on the selftests I felt were relevant for DSA for now.
Hi Vladimir,
On Fri, Jul 8, 2022 at 12:25 AM Vladimir Oltean vladimir.oltean@nxp.com wrote:
Hi Martin,
On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote:
For some distributions (e.g. OpenWrt) we don't want to rely on rsync to copy the tests to the target as some extra dependencies need to be installed. The Makefile in tools/testing/selftests/net/forwarding already installs most of the tests.
This series adds the two missing tests to the list of installed tests. That way a downstream distribution can build a package using this Makefile (and add dependencies there as needed).
Just for future reference, the netdev process is to mark patch sets such as this one with "PATCH net" since they fix a packaging problem with an rc kernel. There's more information about this in Documentation/process/maintainer-netdev.rst.
noted
Do we need to create a Makefile for the selftests symlinked by DSA in tools/testing/selftests/drivers/net/dsa/, for the symlinks to be installed, or how do you see this?
Yes, we should have a Makefile there as well (IMO). I'll send a patch for this.
The reason why I created the symlinks was to make use of the custom forwarding.config provided there, and also to reduce the clutter a bit and only focus on the selftests I felt were relevant for DSA for now.
Makes sense, I'll make sure that this one is installed by the Makefile as well
Best regards, Martin
Hello:
This series was applied to netdev/net.git (master) by Jakub Kicinski kuba@kernel.org:
On Thu, 7 Jul 2022 15:55:30 +0200 you wrote:
For some distributions (e.g. OpenWrt) we don't want to rely on rsync to copy the tests to the target as some extra dependencies need to be installed. The Makefile in tools/testing/selftests/net/forwarding already installs most of the tests.
This series adds the two missing tests to the list of installed tests. That way a downstream distribution can build a package using this Makefile (and add dependencies there as needed).
[...]
Here is the summary with links: - [1/2] selftests: forwarding: Install local_termination.sh https://git.kernel.org/netdev/net/c/437ac2592c09 - [2/2] selftests: forwarding: Install no_forwarding.sh https://git.kernel.org/netdev/net/c/cfbba7b46aef
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Martin Blumenstingl -
patchwork-bot+netdevbpf＠kernel.org -
Vladimir Oltean