Fix double "-ed" in malloc return value check
Signed-off-by: Nikola Z. Ivanov zlatistiv@gmail.com --- tools/testing/selftests/arm64/fp/fp-stress.c | 2 +- tools/testing/selftests/arm64/fp/kernel-test.c | 4 ++-- tools/testing/selftests/arm64/gcs/gcs-stress.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/arm64/fp/fp-stress.c b/tools/testing/selftests/arm64/fp/fp-stress.c index 74e23208b94c..ddc01efea3f9 100644 --- a/tools/testing/selftests/arm64/fp/fp-stress.c +++ b/tools/testing/selftests/arm64/fp/fp-stress.c @@ -549,7 +549,7 @@ int main(int argc, char **argv)
evs = calloc(tests, sizeof(*evs)); if (!evs) - ksft_exit_fail_msg("Failed to allocated %d epoll events\n", + ksft_exit_fail_msg("Failed to allocate %d epoll events\n", tests);
for (i = 0; i < cpus; i++) { diff --git a/tools/testing/selftests/arm64/fp/kernel-test.c b/tools/testing/selftests/arm64/fp/kernel-test.c index e3cec3723ffa..0c40007d1282 100644 --- a/tools/testing/selftests/arm64/fp/kernel-test.c +++ b/tools/testing/selftests/arm64/fp/kernel-test.c @@ -188,13 +188,13 @@ static bool create_socket(void)
ref = malloc(digest_len); if (!ref) { - printf("Failed to allocated %d byte reference\n", digest_len); + printf("Failed to allocate %d byte reference\n", digest_len); return false; }
digest = malloc(digest_len); if (!digest) { - printf("Failed to allocated %d byte digest\n", digest_len); + printf("Failed to allocate %d byte digest\n", digest_len); return false; }
diff --git a/tools/testing/selftests/arm64/gcs/gcs-stress.c b/tools/testing/selftests/arm64/gcs/gcs-stress.c index bbc7f4950c13..cf316d78ea97 100644 --- a/tools/testing/selftests/arm64/gcs/gcs-stress.c +++ b/tools/testing/selftests/arm64/gcs/gcs-stress.c @@ -433,7 +433,7 @@ int main(int argc, char **argv)
evs = calloc(tests, sizeof(*evs)); if (!evs) - ksft_exit_fail_msg("Failed to allocated %d epoll events\n", + ksft_exit_fail_msg("Failed to allocate %d epoll events\n", tests);
for (i = 0; i < gcs_threads; i++)
On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
Fix double "-ed" in malloc return value check
Refine wordings in error message string literals?
I think what the patch author (Nikola) intends is "The error messages' wording use parallel structure device, where the second verb should've been in infinitives form. Correct it."
Thanks.
On Mon, Aug 25, 2025 at 08:06:29PM +0700, Bagas Sanjaya wrote:
On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
Fix double "-ed" in malloc return value check
Refine wordings in error message string literals?
I think what the patch author (Nikola) intends is "The error messages' wording use parallel structure device, where the second verb should've been in infinitives form. Correct it."
Thanks.
-- An old man doll... just what I always wanted! - Clara
Thanks, I did not expect to get schooled like this (in a good way of course). Should I send v2?
On Mon, Aug 25, 2025 at 06:44:23PM +0300, Nikola Z. Ivanov wrote:
On Mon, Aug 25, 2025 at 08:06:29PM +0700, Bagas Sanjaya wrote:
On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
Fix double "-ed" in malloc return value check
Refine wordings in error message string literals?
I think what the patch author (Nikola) intends is "The error messages' wording use parallel structure device, where the second verb should've been in infinitives form. Correct it."
Thanks.
-- An old man doll... just what I always wanted! - Clara
Thanks, I did not expect to get schooled like this (in a good way of course). Should I send v2?
Sure.
On Sun, Aug 24, 2025 at 04:16:47PM +0300, Nikola Z. Ivanov wrote:
Fix double "-ed" in malloc return value check
Reviewed-by: Mark Brown broonie@kernel.org
linux-kselftest-mirror@lists.linaro.org