tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they are available. In case, when these devices are not available test fails, but expected behaviour is skipped test.
Signed-off-by: Nikita Sobolev Nikita.Sobolev@synopsys.com --- Changes for v2: - Coding Style cleanup
tools/testing/selftests/tpm2/test_smoke.sh | 5 +++++ tools/testing/selftests/tpm2/test_space.sh | 5 +++++ 2 files changed, 10 insertions(+)
diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index 8155c2ea7ccb..663062701d5a 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -1,6 +1,11 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +[ -f /dev/tpm0 ] || exit $ksft_skip + python -m unittest -v tpm2_tests.SmokeTest python -m unittest -v tpm2_tests.AsyncTest
diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index a6f5e346635e..36c9d030a1c6 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -1,4 +1,9 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +[ -f /dev/tpmrm0 ] || exit $ksft_skip + python -m unittest -v tpm2_tests.SpaceTest
Hi Nikita,
tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they are available. In case, when these devices are not available test fails, but expected behaviour is skipped test.
Signed-off-by: Nikita Sobolev Nikita.Sobolev@synopsys.com
Reviewed-by: Petr Vorel pvorel@suse.cz
Thanks for v2, but I see v1 already merged in next tree since February. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?...
Kind regards, Petr
tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they are available. In case, when these devices are not available test fails, but expected behaviour is skipped test.
Signed-off-by: Nikita Sobolev Nikita.Sobolev@synopsys.com
OK, I see it was also reverted by Jarkko
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?...
I wonder if only wrong shell syntax (self.flags = flags) is a problem.
Kind regards, Petr
On Tue, May 19, 2020 at 03:07:43PM +0300, Nikita Sobolev wrote:
tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they are available. In case, when these devices are not available test fails, but expected behaviour is skipped test.
Signed-off-by: Nikita Sobolev Nikita.Sobolev@synopsys.com
See
https://lore.kernel.org/linux-kselftest/20200519134838.GA17129@linux.intel.c...
The comments about the fixes tag and acronym spelling were not addressed. The code change looks great tho now, thanks.
/Jarkko
linux-kselftest-mirror@lists.linaro.org