Selftests "config" file is intended to represent the config required to run the tests; a few values are missing for the BPF selftests and these can result in test failures due to missing helpers etc. Add the missing values as they will help document the config needed for a clean BPF selftests run.
Alan Maguire (2): selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh
tools/testing/selftests/bpf/config | 2 ++ 1 file changed, 2 insertions(+)
test_seg6_loop.o uses the helper bpf_lwt_seg6_adjust_srh(); it will not be present if CONFIG_IPV6_SEG6_BPF is not specified.
Fixes: b061017f8b4d ("selftests/bpf: add realistic loop tests") Signed-off-by: Alan Maguire alan.maguire@oracle.com --- tools/testing/selftests/bpf/config | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config index 60e3ae5..48e0585 100644 --- a/tools/testing/selftests/bpf/config +++ b/tools/testing/selftests/bpf/config @@ -25,6 +25,7 @@ CONFIG_XDP_SOCKETS=y CONFIG_FTRACE_SYSCALLS=y CONFIG_IPV6_TUNNEL=y CONFIG_IPV6_GRE=y +CONFIG_IPV6_SEG6_BPF=y CONFIG_NET_FOU=m CONFIG_NET_FOU_IP_TUNNELS=y CONFIG_IPV6_FOU=m
test_lirc_mode2.sh assumes presence of /sys/class/rc/rc0/lirc*/uevent which will not be present unless CONFIG_LIRC=y
Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program") Signed-off-by: Alan Maguire alan.maguire@oracle.com --- tools/testing/selftests/bpf/config | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config index 48e0585..2118e23 100644 --- a/tools/testing/selftests/bpf/config +++ b/tools/testing/selftests/bpf/config @@ -38,3 +38,4 @@ CONFIG_IPV6_SIT=m CONFIG_BPF_JIT=y CONFIG_BPF_LSM=y CONFIG_SECURITY=y +CONFIG_LIRC=y
On 5/22/20 1:36 PM, Alan Maguire wrote:
Selftests "config" file is intended to represent the config required to run the tests; a few values are missing for the BPF selftests and these can result in test failures due to missing helpers etc. Add the missing values as they will help document the config needed for a clean BPF selftests run.
Alan Maguire (2): selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh
tools/testing/selftests/bpf/config | 2 ++ 1 file changed, 2 insertions(+)
Applied to bpf-next, thanks!
linux-kselftest-mirror@lists.linaro.org
-
Alan Maguire -
Daniel Borkmann