From: Jason Xing kernelxing@tencent.com
The output goes like this if I make samples/bpf: ...warning: no previous prototype for ‘get_cgroup_id_from_path’...
Make this function static could solve the warning problem since no one outside of the file calls it.
Signed-off-by: Jason Xing kernelxing@tencent.com --- tools/testing/selftests/bpf/cgroup_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c index 19be9c63d5e8..f2952a65dcc2 100644 --- a/tools/testing/selftests/bpf/cgroup_helpers.c +++ b/tools/testing/selftests/bpf/cgroup_helpers.c @@ -429,7 +429,7 @@ int create_and_get_cgroup(const char *relative_path) * which is an invalid cgroup id. * If there is a failure, it prints the error to stderr. */ -unsigned long long get_cgroup_id_from_path(const char *cgroup_workdir) +static unsigned long long get_cgroup_id_from_path(const char *cgroup_workdir) { int dirfd, err, flags, mount_id, fhsize; union {
On 4/6/24 7:46 AM, Jason Xing wrote:
From: Jason Xing kernelxing@tencent.com
The output goes like this if I make samples/bpf: ...warning: no previous prototype for ‘get_cgroup_id_from_path’...
The CI does not build samples/bpf...
Make this function static could solve the warning problem since no one outside of the file calls it.
Signed-off-by: Jason Xing kernelxing@tencent.com
But your change looks fine.
Acked-by: Yonghong Song yonghong.song@linux.dev
Hello:
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau martin.lau@kernel.org:
On Sat, 6 Apr 2024 22:46:13 +0800 you wrote:
From: Jason Xing kernelxing@tencent.com
The output goes like this if I make samples/bpf: ...warning: no previous prototype for ‘get_cgroup_id_from_path’...
Make this function static could solve the warning problem since no one outside of the file calls it.
[...]
Here is the summary with links: - [net-next] selftests/bpf: eliminate warning of get_cgroup_id_from_path() https://git.kernel.org/bpf/bpf-next/c/bb761fcb8217
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org