Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
Signed-off-by: Breno Leitao leitao@debian.org --- tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh index 258af805497b4..b6071e80ebbb6 100644 --- a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh +++ b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh @@ -281,6 +281,11 @@ function check_for_dependencies() { exit "${ksft_skip}" fi
+ if [ ! -f /proc/net/if_inet6 ]; then + echo "SKIP: IPv6 not configured. Check if CONFIG_IPV6 is enabled" >&2 + exit "${ksft_skip}" + fi + if [ ! -f "${NSIM_DEV_SYS_NEW}" ]; then echo "SKIP: file ${NSIM_DEV_SYS_NEW} does not exist. Check if CONFIG_NETDEVSIM is enabled" >&2 exit "${ksft_skip}"
--- base-commit: dd500e4aecf25e48e874ca7628697969df679493 change-id: 20250723-netcons_test_ipv6-15b1b76bb231
Best regards, -- Breno Leitao leitao@debian.org
On Wed, Jul 23, 2025 at 10:35:06AM -0700, Breno Leitao wrote:
Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
Signed-off-by: Breno Leitao leitao@debian.org
Reviewed-by: Simon Horman horms@kernel.org
On Wed, 23 Jul 2025 10:35:06 -0700 Breno Leitao wrote:
Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
IDK. I think this is related to some of the recent patches? The context would be helpful in the commit message. Otherwise, as networking people, I think we are obligated to respond with hostility to "IPv6 may not be enabled"..
Hello Jakub,
On Thu, Jul 24, 2025 at 06:24:27PM -0700, Jakub Kicinski wrote:
On Wed, 23 Jul 2025 10:35:06 -0700 Breno Leitao wrote:
Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
IDK. I think this is related to some of the recent patches?
Yes, commit 3dc6c76391cbe (“selftests: net: Add IPv6 support to netconsole basic tests”) introduced IPv6 support to the netconsole basic tests.
Because the NIPA config enables IPv6, the tests pass in that environment. However, if the tests are run somewhere without IPv6 support such as in a test I was doing regarding another patch, they will fail, when it should be skipped.
The context would be helpful in the commit message.
Apologies for not including more context in the commit message.
Otherwise, as networking people, I think we are obligated to respond with hostility to "IPv6 may not be enabled"..
As for handling systems without IPv6, if IPv6 isn’t available, the intention is for the test to be skipped. That’s exactly what this patch addresses.
I did consider making the test adaptable so it would just run with whichever protocol (IPv4 or IPv6) is present, but rejected that approach. Allowing the test to “pass” in such cases doesn’t really demonstrate meaningful coverage, since the test isn’t actually being exercised as intended.
In short, it seems more appropriate to skip the test entirely if all conditions aren’t met, so, you know that your .config needs adjustment.
Thanks for your review, --breno
Breno Leitao wrote:
Hello Jakub,
On Thu, Jul 24, 2025 at 06:24:27PM -0700, Jakub Kicinski wrote:
On Wed, 23 Jul 2025 10:35:06 -0700 Breno Leitao wrote:
Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
IDK. I think this is related to some of the recent patches?
Yes, commit 3dc6c76391cbe (“selftests: net: Add IPv6 support to netconsole basic tests”) introduced IPv6 support to the netconsole basic tests.
Because the NIPA config enables IPv6, the tests pass in that environment. However, if the tests are run somewhere without IPv6 support such as in a test I was doing regarding another patch, they will fail, when it should be skipped.
The context would be helpful in the commit message.
Apologies for not including more context in the commit message.
Otherwise, as networking people, I think we are obligated to respond with hostility to "IPv6 may not be enabled"..
As for handling systems without IPv6, if IPv6 isn’t available, the intention is for the test to be skipped. That’s exactly what this patch addresses.
I think there is some consensus that these environments should no longer exist in 2025. And test failure is the best way to accomplish that.
Less opinionated: the tests implicitly depends on the config files in the test directory. Do we have to start making the robust against situations where CONFIGs in that file are missing?
I did consider making the test adaptable so it would just run with whichever protocol (IPv4 or IPv6) is present, but rejected that approach. Allowing the test to “pass” in such cases doesn’t really demonstrate meaningful coverage, since the test isn’t actually being exercised as intended.
In short, it seems more appropriate to skip the test entirely if all conditions aren’t met, so, you know that your .config needs adjustment.
Thanks for your review, --breno
On Fri, 25 Jul 2025 16:47:54 -0400 Willem de Bruijn wrote:
Less opinionated: the tests implicitly depends on the config files in the test directory. Do we have to start making the robust against situations where CONFIGs in that file are missing?
I was considering adding something like this to the test guidance.
### Ensure necessary kernel config knobs are set
Each test directory has a `config` file listing which kernel configuration options the tests depend on. This file must be kept up to date, our CIs build minimal kernels for each test group.
Adding checks inside the tests to validate that the necessary kernel configs are enabled is discouraged. The test author may include such checks, but standalone patches to make tests compatible e.g. with distro kernel configs are unlikely to be accepted.
WDYT?
Primarily trying to minimize the number of patches and adjustments we'd see, as the matrix of systems and kernel configs can easily get out of hand..
Jakub Kicinski wrote:
On Fri, 25 Jul 2025 16:47:54 -0400 Willem de Bruijn wrote:
Less opinionated: the tests implicitly depends on the config files in the test directory. Do we have to start making the robust against situations where CONFIGs in that file are missing?
I was considering adding something like this to the test guidance.
### Ensure necessary kernel config knobs are set
Each test directory has a `config` file listing which kernel configuration options the tests depend on. This file must be kept up to date, our CIs build minimal kernels for each test group.
Adding checks inside the tests to validate that the necessary kernel configs are enabled is discouraged. The test author may include such checks, but standalone patches to make tests compatible e.g. with distro kernel configs are unlikely to be accepted.
WDYT?
Primarily trying to minimize the number of patches and adjustments we'd see, as the matrix of systems and kernel configs can easily get out of hand..
This is great!
It's not really feasible to maintain tests with arbitrary missing dependencies.
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Wed, 23 Jul 2025 10:35:06 -0700 you wrote:
Extend the `check_for_dependencies()` function in `lib_netcons.sh` to check whether IPv6 is enabled by verifying the existence of `/proc/net/if_inet6`. Having IPv6 is a now a dependency of netconsole tests. If the file does not exist, the script will skip the test with an appropriate message suggesting to verify if `CONFIG_IPV6` is enabled.
This prevents the test to misbehave if IPv6 is not configured.
[...]
Here is the summary with links: - [net-next] selftests: net: Skip test if IPv6 is not configured https://git.kernel.org/netdev/net-next/c/5ec9b15d8dfa
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Breno Leitao -
Jakub Kicinski -
patchwork-bot+netdevbpf＠kernel.org -
Simon Horman -
Willem de Bruijn