The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
Fixes: d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs") Signed-off-by: Jakub Kicinski kuba@kernel.org --- Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...
CC: shuah@kernel.org CC: 0x7f454c46@gmail.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/net/tcp_ao/settings | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/net/tcp_ao/settings
diff --git a/tools/testing/selftests/net/tcp_ao/settings b/tools/testing/selftests/net/tcp_ao/settings new file mode 100644 index 000000000000..6091b45d226b --- /dev/null +++ b/tools/testing/selftests/net/tcp_ao/settings @@ -0,0 +1 @@ +timeout=120
On 1/24/24 23:36, Jakub Kicinski wrote:
The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
Fixes: d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs") Signed-off-by: Jakub Kicinski kuba@kernel.org
Thanks! Reviewed-by: Dmitry Safonov 0x7f454c46@gmail.com
Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...
I'll fix and send a patch for rst selftests on Thursday/Friday :)
CC: shuah@kernel.org CC: 0x7f454c46@gmail.com CC: linux-kselftest@vger.kernel.org
tools/testing/selftests/net/tcp_ao/settings | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/net/tcp_ao/settings
diff --git a/tools/testing/selftests/net/tcp_ao/settings b/tools/testing/selftests/net/tcp_ao/settings new file mode 100644 index 000000000000..6091b45d226b --- /dev/null +++ b/tools/testing/selftests/net/tcp_ao/settings @@ -0,0 +1 @@ +timeout=120
Thanks, Dmitry
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski kuba@kernel.org:
On Wed, 24 Jan 2024 15:36:30 -0800 you wrote:
The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
Fixes: d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs") Signed-off-by: Jakub Kicinski kuba@kernel.org
[...]
Here is the summary with links: - [net] selftests: tcp_ao: set the timeout to 2 minutes https://git.kernel.org/netdev/net/c/39b383d77961
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Dmitry Safonov -
Jakub Kicinski -
patchwork-bot+netdevbpf＠kernel.org