On Tue, Apr 23, 2024 at 2:27 PM Ivan Orlov ivan.orlov0322@gmail.com wrote:

Use KUNIT_DEFINE_ACTION_WRAPPER macro to define the 'kfree' and 'string_stream_destroy' wrappers for kunit_add_action.

Signed-off-by: Ivan Orlov ivan.orlov0322@gmail.com

Hello!

This looks like a good use of the macro. Thanks!

Reviewed-by: Rae Moar rmoar@google.com

Thanks! -Rae

---

lib/kunit/string-stream-test.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/lib/kunit/string-stream-test.c b/lib/kunit/string-stream-test.c index 03fb511826f7..7511442ea98f 100644 --- a/lib/kunit/string-stream-test.c +++ b/lib/kunit/string-stream-test.c @@ -22,18 +22,10 @@ struct string_stream_test_priv { };

/* Avoids a cast warning if kfree() is passed direct to kunit_add_action(). */ -static void kfree_wrapper(void *p) -{

•   kfree(p);
  

-} +KUNIT_DEFINE_ACTION_WRAPPER(kfree_wrapper, kfree, const void *);

/* Avoids a cast warning if string_stream_destroy() is passed direct to kunit_add_action(). */ -static void cleanup_raw_stream(void *p) -{

•   struct string_stream *stream = p;
  

•   string_stream_destroy(stream);
  

-} +KUNIT_DEFINE_ACTION_WRAPPER(cleanup_raw_stream, string_stream_destroy, struct string_stream *);

static char *get_concatenated_string(struct kunit *test, struct string_stream *stream) { -- 2.34.1