In 'poll_partial_rec_async' a uninitialized char variable 'token' with is used for write/read instruction to synchronize between threads via a pipe.
tls.c:2833:26: warning: variable 'token' is uninitialized when passed as a const pointer argument
Initialize 'token' to '\0' to silence compiler warning.
Signed-off-by: Ankit Khushwaha ankitkhushwaha.linux@gmail.com --- compiler used: clang version 21.1.5 (Fedora 21.1.5-1.fc43).
changelog: v2: - update patch name and msg
v1: https://lore.kernel.org/all/20251129063726.31210-1-ankitkhushwaha.linux@gmai... --- tools/testing/selftests/net/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index a3ef4b57eb5f..a4d16a460fbe 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -2786,10 +2786,10 @@ TEST_F(tls_err, epoll_partial_rec) TEST_F(tls_err, poll_partial_rec_async) { struct pollfd pfd = { }; + char token = '\0'; ssize_t rec_len; char rec[256]; char buf[128]; - char token; int p[2]; int ret;
-- 2.52.0
On Fri, Dec 05, 2025 at 10:02:42PM +0530, Ankit Khushwaha wrote:
In 'poll_partial_rec_async' a uninitialized char variable 'token' with is used for write/read instruction to synchronize between threads via a pipe.
tls.c:2833:26: warning: variable 'token' is uninitialized when passed as a const pointer argument
Initialize 'token' to '\0' to silence compiler warning.
Signed-off-by: Ankit Khushwaha ankitkhushwaha.linux@gmail.com
compiler used: clang version 21.1.5 (Fedora 21.1.5-1.fc43).
changelog: v2:
- update patch name and msg
v1: https://lore.kernel.org/all/20251129063726.31210-1-ankitkhushwaha.linux@gmai...
Hi Ankit,
Thanks for the update. Overall this seems good to me, however, net-next is currently closed.
## Form letter - net-next-closed
The merge window for v6.19 has begun and therefore net-next has closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens.
Due to a combination of the merge-window, travel commitments of the maintainers, and the holiday season, net-next will re-open after 2nd January.
RFC patches sent for review only are welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#developm...
On Sat, 6 Dec 2025 10:27:01 +0000 Simon Horman wrote:
Thanks for the update. Overall this seems good to me, however, net-next is currently closed.
FWIW after Simon made this comment more fixes for various ksft warnings got posted, I think we should apply them now and to be consistent I'll also take this one.
On Wed, Dec 10, 2025 at 06:06:40PM +0900, Jakub Kicinski wrote:
On Sat, 6 Dec 2025 10:27:01 +0000 Simon Horman wrote:
Thanks for the update. Overall this seems good to me, however, net-next is currently closed.
FWIW after Simon made this comment more fixes for various ksft warnings got posted, I think we should apply them now and to be consistent I'll also take this one.
Understood. I'm always a little unsure where selftest changes should best land.
In any case, feel free to add my tag as this does look good to me.
Reviewed-by: Simon Horman horms@kernel.org
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski kuba@kernel.org:
On Fri, 5 Dec 2025 22:02:42 +0530 you wrote:
In 'poll_partial_rec_async' a uninitialized char variable 'token' with is used for write/read instruction to synchronize between threads via a pipe.
tls.c:2833:26: warning: variable 'token' is uninitialized when passed as a const pointer argument
[...]
Here is the summary with links: - [net-next,v2] selftests: tls: fix warning of uninitialized variable https://git.kernel.org/netdev/net/c/9580f6d47dd6
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Ankit Khushwaha -
Jakub Kicinski -
patchwork-bot+netdevbpf＠kernel.org -
Simon Horman