Currently, even if some subtests fails, the end result will still yield "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are any failures.
Signed-off-by: Ricardo B. Marlière rbm@suse.com --- tools/testing/selftests/bpf/test_xsk.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755 --- a/tools/testing/selftests/bpf/test_xsk.sh +++ b/tools/testing/selftests/bpf/test_xsk.sh @@ -241,4 +241,6 @@ done
if [ $failures -eq 0 ]; then echo "All tests successful!" +else + exit 1 fi
--- base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322 change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071
Best regards,
On Thu, 28 Aug 2025 at 20:48, Ricardo B. Marlière rbm@suse.com wrote:
Currently, even if some subtests fails, the end result will still yield "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are any failures.
Signed-off-by: Ricardo B. Marlière rbm@suse.com
Thanks Ricardo.
Acked-by: Magnus Karlsson magnus.karlsson@intel.com
tools/testing/selftests/bpf/test_xsk.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755 --- a/tools/testing/selftests/bpf/test_xsk.sh +++ b/tools/testing/selftests/bpf/test_xsk.sh @@ -241,4 +241,6 @@ done
if [ $failures -eq 0 ]; then echo "All tests successful!" +else
exit 1fi
base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322 change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071
Best regards,
Ricardo B. Marlière rbm@suse.com
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko andrii@kernel.org:
On Thu, 28 Aug 2025 15:48:30 -0300 you wrote:
Currently, even if some subtests fails, the end result will still yield "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are any failures.
Signed-off-by: Ricardo B. Marlière rbm@suse.com
tools/testing/selftests/bpf/test_xsk.sh | 2 ++ 1 file changed, 2 insertions(+)
[...]
Here is the summary with links: - selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh https://git.kernel.org/bpf/bpf-next/c/2a912258c90e
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Magnus Karlsson -
patchwork-bot+netdevbpf＠kernel.org -
Ricardo B. Marlière