Hi Linus,
Without reply from Shuah, and given the importance of these fixes [1], here is a PR to fix Kselftest (broken since v6.9-rc1) for at least KVM, pidfd, and Landlock. I cannot test against all kselftests though. This has been in linux-next since the beginning of this week, and so far only one issue has been reported [2] and fixed [3].
Feel free to take this PR if you see fit.
Regards, Mickaël
[1] https://lore.kernel.org/r/Zjo1xyhjmehsRhZ2@google.com [2] https://lore.kernel.org/r/202405100339.vfBe0t9C-lkp@intel.com [3] https://lore.kernel.org/r/20240511171445.904356-1-mic@digikod.net
-- The following changes since commit e67572cd2204894179d89bd7b984072f19313b03:
Linux 6.9-rc6 (2024-04-28 13:47:24 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux.git tags/kselftest-fix-vfork-2024-05-12
for you to fetch changes up to 323feb3bdb67649bfa5614eb24ec9cb92a60cf33:
selftests/harness: Handle TEST_F()'s explicit exit codes (2024-05-11 19:18:47 +0200)
---------------------------------------------------------------- Fix Kselftest's vfork() side effects
See https://lore.kernel.org/r/20240511171445.904356-1-mic@digikod.net
---------------------------------------------------------------- Mickaël Salaün (10): selftests/pidfd: Fix config for pidfd_setns_test selftests/landlock: Fix FS tests when run on a private mount point selftests/harness: Fix fixture teardown selftests/harness: Fix interleaved scheduling leading to race conditions selftests/landlock: Do not allocate memory in fixture data selftests/harness: Constify fixture variants selftests/pidfd: Fix wrong expectation selftests/harness: Share _metadata between forked processes selftests/harness: Fix vfork() side effects selftests/harness: Handle TEST_F()'s explicit exit codes
tools/testing/selftests/kselftest_harness.h | 127 +++++++++++++++++------ tools/testing/selftests/landlock/fs_test.c | 83 +++++++++------ tools/testing/selftests/pidfd/config | 2 + tools/testing/selftests/pidfd/pidfd_setns_test.c | 2 +- 4 files changed, 147 insertions(+), 67 deletions(-)
The pull request you sent on Sun, 12 May 2024 12:56:57 +0200:
git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux.git tags/kselftest-fix-vfork-2024-05-12
has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/af300a3959290b005f27ab5858bfebcb4840cd66
Thank you!
On 5/12/24 04:56, Mickaël Salaün wrote:
Hi Linus,
Without reply from Shuah, and given the importance of these fixes [1], here is a PR to fix Kselftest (broken since v6.9-rc1) for at least KVM, pidfd, and Landlock. I cannot test against all kselftests though. This has been in linux-next since the beginning of this week, and so far only one issue has been reported [2] and fixed [3].
Feel free to take this PR if you see fit.
Thank you - I totally missed the emails about sending these up for 6.9 :(
I see that these are already in Linux 6.9
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org