From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2.
Thanks and regards, Mirsad Todorovac
Reported-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de
--- tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr, - sizeof(struct sockaddr)) != 0) { + sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM); exit(1);
-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
Hi,
Thanks for the patch.
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr Date: Fri, 6 Jan 2023 18:18:58 +0100
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/test_oob_unix.c:127.
Could you wrap the changelog to 75 chars except for log (strace below) ? checkpatch.pl will help.
$ git show HEAD --format=email | ./scripts/checkpatch.pl
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2.
Every patch that fixes networking code has to be applied cleanly on net.git. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
But the patch can not be applied to net.git. Could you check this ? https://patchwork.kernel.org/project/netdevbpf/patch/bd7ff00a-6892-fd56-b3ca...
Also, the mail title should be
[PATCH Tree Version Nth/Total] subsystem: Description.
Next time, Tree is net and Version is v2, and we need not write 1/1, so the subject should be
[PATCH net v2] af_unix: selftest: Fix size of parameter to connect()
Please see here for details. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Doc...
Thanks and regards, Mirsad Todorovac
You can remove these lines.
Reported-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
In this case, you are the reporter and the author of the patch, so the Reported-by tag is not needed. Instead, you have to add your SOB tag.
Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de
Please add Fixes tag as I said here. https://lore.kernel.org/netdev/20230103111335.81600-1-kuniyu@amazon.com/#r
Thank you, Kuniyuki
tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr,
sizeof(struct sockaddr)) != 0) {
sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM); exit(1);-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu -- System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union
Hi,
On 06. 01. 2023. 18:58, Kuniyuki Iwashima wrote:
Hi,
Thanks for the patch.
Thank you for your quick review. I had to do the homework before replying.
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr Date: Fri, 6 Jan 2023 18:18:58 +0100
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/test_oob_unix.c:127.
Could you wrap the changelog to 75 chars except for log (strace below) ? checkpatch.pl will help.
$ git show HEAD --format=email | ./scripts/checkpatch.pl
The complete result according to the guidelines will be in the followup email.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2.
Every patch that fixes networking code has to be applied cleanly on net.git. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
But the patch can not be applied to net.git.
I have tested the patch against net.git, and it is a verbatim copy (tested by diff).
Could you check this ? https://patchwork.kernel.org/project/netdevbpf/patch/bd7ff00a-6892-fd56-b3ca...
Also, the mail title should be
[PATCH Tree Version Nth/Total] subsystem: Description.
Next time, Tree is net and Version is v2, and we need not write 1/1, so the subject should be
[PATCH net v2] af_unix: selftest: Fix size of parameter to connect()
Got it. Will do in the followup email.
Please see here for details. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Doc...
Thanks and regards, Mirsad Todorovac
You can remove these lines.
Sure.
Reported-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
In this case, you are the reporter and the author of the patch, so the Reported-by tag is not needed. Instead, you have to add your SOB tag.
Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
OK.
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de
Please add Fixes tag as I said here. https://lore.kernel.org/netdev/20230103111335.81600-1-kuniyu@amazon.com/#r
Thank you, Kuniyuki
tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr,
sizeof(struct sockaddr)) != 0) {
sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM); exit(1);
-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix the "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2. (Tested to apply against net.git tree.)
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
--- tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr, - sizeof(struct sockaddr)) != 0) { + sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM);
-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
On Fri, 6 Jan 2023 20:28:33 +0100 Mirsad Goran Todorovac wrote:
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2. (Tested to apply against net.git tree.)
This kind of info belongs outside of the commit message (under the --- line).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
no new line here
still doesn't apply, probably because there are two email footers
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr ---
The patch is generated against the "vanilla" Torvalds mainline tree 6.2-rc2. (Tested against the net.git tree.)
tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr, - sizeof(struct sockaddr)) != 0) { + sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM); exit(1);
On 07. 01. 2023. 01:14, Jakub Kicinski wrote:
On Fri, 6 Jan 2023 20:28:33 +0100 Mirsad Goran Todorovac wrote:
The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2. (Tested to apply against net.git tree.)
This kind of info belongs outside of the commit message (under the --- line).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
no new line here
still doesn't apply, probably because there are two email footers
Thank you for the guidelines to make your robots happy :), the next time I will assume all these from start, provided that I find and patch another bug or issue.
Thanks, Mirsad
On Sat, 7 Jan 2023 02:42:43 +0100 Mirsad Goran Todorovac wrote:
still doesn't apply, probably because there are two email footers
Thank you for the guidelines to make your robots happy :), the next time I will assume all these from start, provided that I find and patch another bug or issue.
Ah, sorry, wrong assumption :S
Your email client converts tabs to spaces, that's the problem.
Could you try get send-email ?
On Fri, 6 Jan 2023, Jakub Kicinski wrote:
On Sat, 7 Jan 2023 02:42:43 +0100 Mirsad Goran Todorovac wrote:
still doesn't apply, probably because there are two email footers
Thank you for the guidelines to make your robots happy :), the next time I will assume all these from start, provided that I find and patch another bug or issue.
Ah, sorry, wrong assumption :S
Your email client converts tabs to spaces, that's the problem.
Could you try get send-email ?
Sorry, couldn't make git send-email nor mutt IMAP running at such a short notice.
I've chosen Alpine due to advice in Documentation/process/email-clients.rst
Hope that will work.
Thank you for your patience with guidelines for this patch.
Thanks, Mirsad
-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr ---
The patch is generated against the "vanilla" Torvalds mainline tree 6.2-rc2. (Tested and applies against the net.git tree.)
tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr, - sizeof(struct sockaddr)) != 0) { + sizeof(*consumer_addr)) != 0) { perror("Connect failed"); kill(0, SIGTERM); exit(1);
-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union
From: Mirsad Goran Todorovac mirsad.todorovac@alu.hr Date: Sat, 7 Jan 2023 04:40:20 +0100 (CET)
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Reviewed-by: Kuniyuki Iwashima kuniyu@amazon.com
You can check the current status here. https://patchwork.kernel.org/project/netdevbpf/patch/alpine.DEB.2.21.2301070...
PS: you may want to check config not to send a mail as multipart next time.
Thank you, Kuniyuki
The patch is generated against the "vanilla" Torvalds mainline tree 6.2-rc2. (Tested and applies against the net.git tree.)
tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c index b57e91e1c3f2..532459a15067 100644 --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr) wait_for_signal(pipefd[0]); if (connect(cfd, (struct sockaddr *)consumer_addr,
sizeof(struct sockaddr)) != 0) {
sizeof(*consumer_addr)) != 0) {-- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu
System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb, Republic of Croatia The European Union
On 9.1.2023. 2:15, Kuniyuki Iwashima wrote:
From: Mirsad Goran Todorovac mirsad.todorovac@alu.hr Date: Sat, 7 Jan 2023 04:40:20 +0100 (CET)
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
Visible from the trace excerpt:
bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
BUG: The filename is trimmed to sizeof (struct sockaddr).
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Cc: Kuniyuki Iwashima kuniyu@amazon.co.jp Cc: Florian Westphal fw@strlen.de Reviewed-by: Florian Westphal fw@strlen.de Fixes: 314001f0bf92 ("af_unix: Add OOB support") Signed-off-by: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Reviewed-by: Kuniyuki Iwashima kuniyu@amazon.com
You can check the current status here. https://patchwork.kernel.org/project/netdevbpf/patch/alpine.DEB.2.21.2301070...
Thank you very much for your time on this, Koniyuki, Jakub.
PS: you may want to check config not to send a mail as multipart next time.
Done! Thanks for the hint. This should work:
[ Sending Preferences ] [X] Do Not Generate Sender Header [ ] Use Sender Instead of X-X-Sender [X] Do Not Send Flowed Text [X] Downgrade Multipart to Text
Maybe add this to Documentation/process/email-clients.rst, section Alpine? It could save some round-trips ...
Thanks, Mirsad
Hello:
This patch was applied to netdev/net.git (master) by David S. Miller davem@davemloft.net:
On Sat, 7 Jan 2023 04:40:20 +0100 (CET) you wrote:
From: Mirsad Goran Todorovac mirsad.todorovac@alu.unizg.hr
Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" error in selftests/net/af_unix/ test_oob_unix.c:127.
The existing code happens to work provided that the autogenerated pathname is shorter than sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
[...]
Here is the summary with links: - [net,v4] af_unix: selftest: Fix the size of the parameter to connect() https://git.kernel.org/netdev/net/c/7d6ceeb1875c
You are awesome, thank you!
On 07. 01. 2023. 03:08, Jakub Kicinski wrote:
On Sat, 7 Jan 2023 02:42:43 +0100 Mirsad Goran Todorovac wrote:
still doesn't apply, probably because there are two email footers
Thank you for the guidelines to make your robots happy :), the next time I will assume all these from start, provided that I find and patch another bug or issue.
Ah, sorry, wrong assumption :S
Your email client converts tabs to spaces, that's the problem.
Could you try get send-email ?
Sorry, Jakub, just to "remove this from stack", did the [PATCH net v4] af_unix: selftest: Fix the size of the parameter to connect() apply?
I can't seem to handle more than about half a dozen of bug reports at a time or I started overlooking emails :(
Thanks, Mirsad
linux-kselftest-mirror@lists.linaro.org
-
Jakub Kicinski -
Kuniyuki Iwashima -
Mirsad Goran Todorovac -
Mirsad Goran Todorovac -
patchwork-bot+netdevbpf＠kernel.org