This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org --- I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
CC: brendan.higgins@linux.dev CC: davidgow@google.com CC: rmoar@google.com CC: broonie@kernel.org CC: rf@opensource.cirrus.com CC: mic@digikod.net CC: skhan@linuxfoundation.org CC: linux-kselftest@vger.kernel.org CC: kunit-dev@googlegroups.com --- tools/testing/kunit/configs/all_tests.config | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config index 48b132cd9d2a..2f093048d985 100644 --- a/tools/testing/kunit/configs/all_tests.config +++ b/tools/testing/kunit/configs/all_tests.config @@ -10,7 +10,6 @@ CONFIG_KUNIT_EXAMPLE_TEST=y CONFIG_KUNIT_ALL_TESTS=y
CONFIG_FORTIFY_SOURCE=y -CONFIG_INIT_STACK_ALL_PATTERN=y
CONFIG_IIO=y
On Fri, May 30, 2025 at 06:58:00AM -0700, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
The commit in question breaks kunit for older compilers:
$ gcc --version gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
This seems like there's a bigger issue here - this sort of thing will keep happening if you're running with older compilers and it's also going to be prevent the addition of any coverage that's specific to architectures. It would seem better to fix this by warning only and not erroring out, perhaps splitting the config fragments into must succeed and can be dropped sections.
On Fri, May 30, 2025 at 04:09:22PM +0100, Mark Brown wrote:
On Fri, May 30, 2025 at 06:58:00AM -0700, Jakub Kicinski wrote:
$ make ARCH=x86_64 O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
This seems like there's a bigger issue here - this sort of thing will keep happening if you're running with older compilers and it's also going to be prevent the addition of any coverage that's specific to architectures. It would seem better to fix this by warning only and not erroring out, perhaps splitting the config fragments into must succeed and can be dropped sections.
Sorry, meant to also say:
Acked-by: Mark Brown broonie@kernel.org
On 5/30/25 07:58, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Does adding config option work for you? ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org
I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
I am good with reverting it for now.
David, Brendan, We will have to enable this at a later time. Also we saw this problem before with other configs. Anyway way to fix this for alltests case?
thanks, -- Shuah
On 5/30/25 10:59, Shuah Khan wrote:
On 5/30/25 07:58, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Does adding config option work for you? ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org
I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
I am good with reverting it for now.
Meant to add Ack.
Acked-by: Shuah Khan skhan@linuxfoundation.org
David, Brendan, We will have to enable this at a later time. Also we saw this problem before with other configs. Anyway way to fix this for alltests case?
thanks, -- Shuah
On Fri, 30 May 2025 10:59:54 -0600 Shuah Khan wrote:
On 5/30/25 07:58, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Does adding config option work for you? ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN
Nope (with this patch applied):
$ ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN=y [18:02:47] Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org
I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
I am good with reverting it for now.
David, Brendan, We will have to enable this at a later time. Also we saw this problem before with other configs. Anyway way to fix this for alltests case?
FWIW Richard commented in the linked thread, IIUC this was just for added coverage but not a hard requirement.
On 31/05/2025 2:07 am, Jakub Kicinski wrote:
On Fri, 30 May 2025 10:59:54 -0600 Shuah Khan wrote:
On 5/30/25 07:58, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Does adding config option work for you? ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN
Nope (with this patch applied):
$ ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN=y [18:02:47] Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org
I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
I am good with reverting it for now.
David, Brendan, We will have to enable this at a later time. Also we saw this problem before with other configs. Anyway way to fix this for alltests case?
FWIW Richard commented in the linked thread, IIUC this was just for added coverage but not a hard requirement.
Correct. It's not required (for me). It found a bug in my code, so it seemed useful to have enabled while testing. I thought this was safe to do, I didn't know that this only works with certain platforms and compilers.
On 6/2/25 07:34, Richard Fitzgerald wrote:
On 31/05/2025 2:07 am, Jakub Kicinski wrote:
On Fri, 30 May 2025 10:59:54 -0600 Shuah Khan wrote:
On 5/30/25 07:58, Jakub Kicinski wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
$ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=x86_64 O=.kunit olddefconfig
ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y
Does adding config option work for you? ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN
Nope (with this patch applied):
$ ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_INIT_STACK_ALL_PATTERN=y [18:02:47] Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_INIT_STACK_ALL_PATTERN=y Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
Link: https://lore.kernel.org/20250529083811.778bc31b@kernel.org Fixes: a571a9a1b120 ("kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests") Signed-off-by: Jakub Kicinski kuba@kernel.org
I'd like to take this in via netdev since it fixes our CI. We'll send it to Linus next week.
I am good with reverting it for now.
David, Brendan, We will have to enable this at a later time. Also we saw this problem before with other configs. Anyway way to fix this for alltests case?
FWIW Richard commented in the linked thread, IIUC this was just for added coverage but not a hard requirement.
Correct. It's not required (for me). It found a bug in my code, so it seemed useful to have enabled while testing. I thought this was safe to do, I didn't know that this only works with certain platforms and compilers.
Thanks for clarifying. Looks good to me.
thanks, -- Shuah
Hello:
This patch was applied to netdev/net.git (main) by Paolo Abeni pabeni@redhat.com:
On Fri, 30 May 2025 06:58:00 -0700 you wrote:
This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
The commit in question breaks kunit for older compilers:
$ gcc --version gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
[...]
Here is the summary with links: - [net] Revert "kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests" https://git.kernel.org/netdev/net/c/f6695269dc52
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Jakub Kicinski -
Mark Brown -
patchwork-bot+netdevbpf＠kernel.org -
Richard Fitzgerald -
Shuah Khan