Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
I suggest to improve the change description.
* Adjustment: … operation (i. e. …
* Will the tag “Fixes” become relevant?
Regards, Markus
On 2020/4/14 15:54, Markus Elfring wrote:
Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
I suggest to improve the change description.
- Adjustment: … operation (i. e. …
Hi Markus,
Which part of description do you want to change or could you provide an example for reference?
- Will the tag “Fixes” become relevant?
Do you mean to add the following "Fixes" tag? Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
Thanks, Xiao Yang
Regards, Markus
.
On Wed, 15 Apr 2020 09:40:20 +0800 Xiao Yang yangx.jy@cn.fujitsu.com wrote:
On 2020/4/14 15:54, Markus Elfring wrote:
Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
I suggest to improve the change description.
- Adjustment: … operation (i. e. …
Hi Markus,
Which part of description do you want to change or could you provide an example for reference?
That part is fine for me.
- Will the tag “Fixes” become relevant?
Do you mean to add the following "Fixes" tag? Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
Yeah, that fixes tag is appropriate. But I usually add those myself, you don't need to resend.
-- Steve
On 2020/4/15 9:46, Steven Rostedt wrote:
On Wed, 15 Apr 2020 09:40:20 +0800 Xiao Yangyangx.jy@cn.fujitsu.com wrote:
On 2020/4/14 15:54, Markus Elfring wrote:
Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
I suggest to improve the change description.
- Adjustment: … operation (i. e. …
Hi Markus,
Which part of description do you want to change or could you provide an example for reference?
That part is fine for me.
- Will the tag “Fixes” become relevant?
Do you mean to add the following "Fixes" tag? Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
Yeah, that fixes tag is appropriate. But I usually add those myself, you don't need to resend.
Hi Steven,
Thanks for your quick reply. Got it and I will keep the v2 patch.
Thanks, Xiao Yang
-- Steve
.
- Adjustment: … operation (i. e. …
Hi Markus,
Which part of description do you want to change or could you provide an example for reference?
I proposed to insert two space characters in a wording.
That part is fine for me.
Such a view can be fine if you would like to adjust the provided contents another bit for the final commit message.
Do you mean to add the following "Fixes" tag? Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
Yeah, that fixes tag is appropriate.
I suggest to reconsider the influence of parentheses at such places. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
Regards, Markus
linux-kselftest-mirror@lists.linaro.org
-
Markus Elfring -
Steven Rostedt -
Xiao Yang