This series aims to keep the git status clean after building the selftests by adding some missing .gitignore files and object inclusion in existing .gitignore files. This is one of the requirements listed in the selftests documentation for new tests, but it is not always followed as desired.
After adding these .gitignore files and including the generated objects, the working tree appears clean again.
The new version includes a missing entry fot the .gitignore in damon, which was reported by Bernd Edlinger bernd.edlinger@hotmail.de, who also proposed a patch for it as well as for other missing .gitignore files covered by v1. Bernd has been added to the corresponding patch as the reporter. If a different tag is desired, I am fine with it.
To: Shuah Khan shuah@kernel.org To: SeongJae Park sj@kernel.org To: Bernd Edlinger bernd.edlinger@hotmail.de Cc: linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: damon@lists.linux.dev Cc: linux-mm@kvack.org Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
Changes in v3: - General: base on mm-unstable to avoid conflicts. - damon: add missing Closes tag. - Link to v2: https://lore.kernel.org/r/20240212-selftest_gitignore-v2-0-75f0de50a178@gmai...
Changes in v2: - Remove patch for netfilter (not relevant anymore). - Add patch for damon (missing binary in .gitignore). - Link to v1: https://lore.kernel.org/r/20240101-selftest_gitignore-v1-0-eb61b09adb05@gmai...
--- Javier Carrasco (4): selftests: uevent: add missing gitignore selftests: thermal: intel: power_floor: add missing gitignore selftests: thermal: intel: workload_hint: add missing gitignore selftests: damon: add access_memory to .gitignore
tools/testing/selftests/damon/.gitignore | 1 + tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 + tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 + tools/testing/selftests/uevent/.gitignore | 1 + 4 files changed, 4 insertions(+) --- base-commit: 7e56cf9a7f108e8129d75cea0dabc9488fb4defa change-id: 20240101-selftest_gitignore-7da2c503766e
Best regards,
The 'uevent_filtering' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'uevent_filtering'.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/uevent/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/uevent/.gitignore b/tools/testing/selftests/uevent/.gitignore new file mode 100644 index 000000000000..382afb74cd40 --- /dev/null +++ b/tools/testing/selftests/uevent/.gitignore @@ -0,0 +1 @@ +uevent_filtering
The 'power_floor' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'power_floor'.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/thermal/intel/power_floor/.gitignore b/tools/testing/selftests/thermal/intel/power_floor/.gitignore new file mode 100644 index 000000000000..1b9a76406f18 --- /dev/null +++ b/tools/testing/selftests/thermal/intel/power_floor/.gitignore @@ -0,0 +1 @@ +power_floor_test
The 'workload_hint_test' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'workload_hint_test'.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/thermal/intel/workload_hint/.gitignore b/tools/testing/selftests/thermal/intel/workload_hint/.gitignore new file mode 100644 index 000000000000..d697b034a3a8 --- /dev/null +++ b/tools/testing/selftests/thermal/intel/workload_hint/.gitignore @@ -0,0 +1 @@ +workload_hint_test
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by: Bernd Edlinger bernd.edlinger@hotmail.de Closes: https://lore.kernel.org/all/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB... Reviewed-by: SeongJae Park sj@kernel.org Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/damon/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore index d861701f0327..e65ef9d9cedc 100644 --- a/tools/testing/selftests/damon/.gitignore +++ b/tools/testing/selftests/damon/.gitignore @@ -2,3 +2,4 @@ huge_count_read_write debugfs_target_ids_read_before_terminate_race debugfs_target_ids_pid_leak +access_memory
On Tue, 13 Feb 2024 23:46:53 +0100 Javier Carrasco javier.carrasco.cruz@gmail.com wrote:
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by: Bernd Edlinger bernd.edlinger@hotmail.de Closes: https://lore.kernel.org/all/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB... Reviewed-by: SeongJae Park sj@kernel.org Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
Thank you, I confirmed this can cleanly be applied on mm-unstable. But, I think my suggestion was to split this patch out of the patchset and send separately so that Andrew can carry this on mm-unstable? Otherwise, Shuah would get the conflict on her tree, or Andrew would need to carry the patches for theremal and uevent selftests on mm-unstable.
Thanks, SJ
tools/testing/selftests/damon/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore index d861701f0327..e65ef9d9cedc 100644 --- a/tools/testing/selftests/damon/.gitignore +++ b/tools/testing/selftests/damon/.gitignore @@ -2,3 +2,4 @@ huge_count_read_write debugfs_target_ids_read_before_terminate_race debugfs_target_ids_pid_leak +access_memory
-- 2.40.1
linux-kselftest-mirror@lists.linaro.org
-
Javier Carrasco -
SeongJae Park