Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.
I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org --- v2: - drop NET_IP_TUNNEL v1: https://lore.kernel.org/20250602231640.314556-1-kuba@kernel.org
CC: shuah@kernel.org CC: willemb@google.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/drivers/net/hw/config | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 tools/testing/selftests/drivers/net/hw/config
diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config new file mode 100644 index 000000000000..88ae719e6f8f --- /dev/null +++ b/tools/testing/selftests/drivers/net/hw/config @@ -0,0 +1,5 @@ +CONFIG_IPV6=y +CONFIG_IPV6_GRE=y +CONFIG_NET_IPGRE=y +CONFIG_NET_IPGRE_DEMUX=y +CONFIG_VXLAN=y
Jakub Kicinski wrote:
Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.
I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org
Reviewed-by: Willem de Bruijn willemb@google.com
I wonder if we'll slowly recreate tools/testing/selftests/net/config. An ugly hack, but maybe let the Makefile just copy that config here? Or append it.
On Wed, 04 Jun 2025 09:47:48 -0400 Willem de Bruijn wrote:
Jakub Kicinski wrote:
Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.
I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.
Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Signed-off-by: Jakub Kicinski kuba@kernel.org
Reviewed-by: Willem de Bruijn willemb@google.com
I wonder if we'll slowly recreate tools/testing/selftests/net/config. An ugly hack, but maybe let the Makefile just copy that config here? Or append it.
Yes, even drivers/net vs drivers/net/hw is a bit annoying. Not sure how to cleanly align with selftest infra here :( Our CI right now only uses configs from the TARGETS we're intending to run. While it makes sense "to a human" to include net, is it clean to auto-include $target if drivers/$target is included? Maybe...
To some extent I think the issue was that we haven't actually had any device on which NIPA could run this test. Otherwise we'd have caught the problem before merging.
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski kuba@kernel.org:
On Tue, 3 Jun 2025 17:16:52 -0700 you wrote:
Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.
I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.
[...]
Here is the summary with links: - [net,v2] selftests: drv-net: add configs for the TSO test https://git.kernel.org/netdev/net/c/7eb6b63aa3c3
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Jakub Kicinski -
patchwork-bot+netdevbpf＠kernel.org -
Willem de Bruijn