- Linux-kselftest-mirror - lists.linaro.org

Re: [PATCH] selftests/seccomp: Fix seccomp failure by adding missing headers

by Shuah Khan

On 2/10/22 11:08 AM, Sherry Yang wrote: > Yeah, -I works, but just with some compiler warnings. > warnings aren't good. Kees, hope you are okay with this. > If warnings are acceptable, do I need to send V2 patch with -I? > > Sherry > No top posting please. No need to fix it to -I - please send v2 I can't find your patch on lore - not sure why. Please cc linux-kselftest and linux-kernel(a)vger.kernel.org Also run scripts/get_maintainer.pl for a complete list of recipients for this patch. thanks, -- Shuah

3 years, 7 months

2
1
0 0

Re: [PATCH] selftests/seccomp: Fix seccomp failure by adding missing headers

by Shuah Khan

On 2/2/22 1:11 PM, Sherry Yang wrote: > seccomp_bpf failed on tests 47 global.user_notification_filter_empty > and 48 global.user_notification_filter_empty_threaded when it's > tested on updated kernel but with old kernel headers. Because old > kernel headers don't have definition of macro __NR_clone3 which is > required for these two tests. Since under selftests/, we can install > headers once for all tests (the default INSTALL_HDR_PATH is > usr/include), fix it by adding usr/include to the list of directories > to be searched. Use "-isystem" to indicate it's a system directory as > the real kernel headers directories are. > > Signed-off-by: Sherry Yang <sherry.yang(a)oracle.com> > Tested-by: Sherry Yang <sherry.yang(a)oracle.com> > --- > tools/testing/selftests/seccomp/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile > index 0ebfe8b0e147..585f7a0c10cb 100644 > --- a/tools/testing/selftests/seccomp/Makefile > +++ b/tools/testing/selftests/seccomp/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS += -Wl,-no-as-needed -Wall > +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/ > LDFLAGS += -lpthread > > TEST_GEN_PROGS := seccomp_bpf seccomp_benchmark > Looks good to me. Adding Kees Cook for his review of this change. thanks, -- Shuah

3 years, 7 months

3
6
0 0

[PATCH] selftests/exec: Add non-regular to TEST_GEN_PROGS

by Muhammad Usama Anjum

non-regular file needs to be compiled and then copied to the output directory. Remove it from TEST_PROGS and add it to TEST_GEN_PROGS. This removes error thrown by rsync when non-regular object isn't found: rsync: [sender] link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3] Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests") Reported-by: "kernelci.org bot" <bot(a)kernelci.org> Signed-off-by: Muhammad Usama Anjum <usama.anjum(a)collabora.com> --- tools/testing/selftests/exec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile index 551affb437fe1..a89ba6de79870 100644 --- a/tools/testing/selftests/exec/Makefile +++ b/tools/testing/selftests/exec/Makefile @@ -3,8 +3,8 @@ CFLAGS = -Wall CFLAGS += -Wno-nonnull CFLAGS += -D_GNU_SOURCE -TEST_PROGS := binfmt_script non-regular -TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 +TEST_PROGS := binfmt_script +TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular TEST_GEN_FILES := execveat.symlink execveat.denatured script subdir # Makefile is a run-time dependency, since it's accessed by the execveat test TEST_FILES := Makefile -- 2.30.2

3 years, 7 months

3
3
0 0

[PATCH v4 0/2] Documentation: dev-tools: clarify KTAP specification wording

by frowand.list＠gmail.com

From: Frank Rowand <frank.rowand(a)sony.com> Clarify ambiguous wording in KTAP specification version 1. Fix build warnings. Changes since version 3 - Add Reviewed-by: Shuah Khan - Add patch 2/2 to fix build warnings Frank Rowand (2): Documentation: dev-tools: clarify KTAP specification wording Documentation: dev-tools: fix KTAP specification build warnings Documentation/dev-tools/ktap.rst | 49 +++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 17 deletions(-) -- Frank Rowand <frank.rowand(a)sony.com>

3 years, 7 months

4
6
0 0

[PATCH] selftest: KVM: Remove absent target file

by Muhammad Usama Anjum

There is no vmx_pi_mmio_test file. Remove it to get rid of error while creation of selftest archive: rsync: [sender] link_stat "/kselftest/kvm/x86_64/vmx_pi_mmio_test" failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3] Fixes: 6a58150859fd ("selftest: KVM: Add intra host migration tests") Reported-by: "kernelci.org bot" <bot(a)kernelci.org> Signed-off-by: Muhammad Usama Anjum <usama.anjum(a)collabora.com> --- tools/testing/selftests/kvm/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile index d61286208e242..b970397f725c7 100644 --- a/tools/testing/selftests/kvm/Makefile +++ b/tools/testing/selftests/kvm/Makefile @@ -82,7 +82,6 @@ TEST_GEN_PROGS_x86_64 += x86_64/tsc_msrs_test TEST_GEN_PROGS_x86_64 += x86_64/vmx_pmu_msrs_test TEST_GEN_PROGS_x86_64 += x86_64/xen_shinfo_test TEST_GEN_PROGS_x86_64 += x86_64/xen_vmcall_test -TEST_GEN_PROGS_x86_64 += x86_64/vmx_pi_mmio_test TEST_GEN_PROGS_x86_64 += x86_64/sev_migrate_tests TEST_GEN_PROGS_x86_64 += x86_64/amx_test TEST_GEN_PROGS_x86_64 += access_tracking_perf_test -- 2.30.2

3 years, 7 months

1
0
0 0

[PATCH net-next 00/11] net: ping6: support basic socket cmsgs

by Jakub Kicinski

Add support for common SOL_SOCKET cmsgs in ICMPv6 sockets. Extend the cmsg tests to cover more cmsgs and socket types. SOL_IPV6 cmsgs to follow. Jakub Kicinski (11): net: ping6: remove a pr_debug() statement net: ping6: support packet timestamping net: ping6: support setting socket options via cmsg selftests: net: rename cmsg_so_mark selftests: net: make cmsg_so_mark ready for more options selftests: net: cmsg_sender: support icmp and raw sockets selftests: net: cmsg_so_mark: test ICMP and RAW sockets selftests: net: cmsg_so_mark: test with SO_MARK set by setsockopt selftests: net: cmsg_sender: support setting SO_TXTIME selftests: net: cmsg_sender: support Tx timestamping selftests: net: test standard socket cmsgs across UDP and ICMP sockets net/ipv6/ping.c | 14 +- tools/testing/selftests/net/.gitignore | 2 +- tools/testing/selftests/net/Makefile | 3 +- tools/testing/selftests/net/cmsg_sender.c | 380 ++++++++++++++++++++ tools/testing/selftests/net/cmsg_so_mark.c | 67 ---- tools/testing/selftests/net/cmsg_so_mark.sh | 32 +- tools/testing/selftests/net/cmsg_time.sh | 83 +++++ 7 files changed, 499 insertions(+), 82 deletions(-) create mode 100644 tools/testing/selftests/net/cmsg_sender.c delete mode 100644 tools/testing/selftests/net/cmsg_so_mark.c create mode 100755 tools/testing/selftests/net/cmsg_time.sh -- 2.34.1

3 years, 7 months

5
18
0 0

Re: [PATCH] selftest/vm: Use correct PAGE_SHIFT value for ppc64

by Shuah Khan

On 2/10/22 8:03 AM, Aneesh Kumar K V wrote: > On 2/10/22 20:09, Shuah Khan wrote: >> On 2/9/22 9:12 PM, Aneesh Kumar K.V wrote: >>> Shuah Khan <skhan(a)linuxfoundation.org> writes: >>> >>>> On 2/9/22 8:43 AM, Aneesh Kumar K.V wrote: >>>>> Keep it simple by using a #define and limiting hugepage size to 2M. >>>>> This keeps the test simpler instead of dynamically finding the page size >>>>> and huge page size. >>>>> >>>>> Without this tests are broken w.r.t reading /proc/self/pagemap >>>>> >>>>> if (pread(pagemap_fd, ent, sizeof(ent), >>>>> (uintptr_t)ptr >> (PAGE_SHIFT - 3)) != sizeof(ent)) >>>>> err(2, "read pagemap"); >>>>> >>>>> Cc: Shuah Khan <shuah(a)kernel.org> >>>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> >>>>> --- >>>>> tools/testing/selftests/vm/ksm_tests.c | 8 ++++++++ >>>>> tools/testing/selftests/vm/transhuge-stress.c | 8 ++++++++ >>>>> 2 files changed, 16 insertions(+) >>>>> >>>>> diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c >>>>> index 1436e1a9a3d3..8200328ff018 100644 >>>>> --- a/tools/testing/selftests/vm/ksm_tests.c >>>>> +++ b/tools/testing/selftests/vm/ksm_tests.c >>>>> @@ -22,8 +22,16 @@ >>>>> #define KSM_MERGE_ACROSS_NODES_DEFAULT true >>>>> #define MB (1ul << 20) >>>>> +#ifdef __powerpc64__ >>>>> +#define PAGE_SHIFT 16 >>>>> +/* >>>>> + * This will only work with radix 2M hugepage size >>>>> + */ >>>>> +#define HPAGE_SHIFT 21 >>>>> +#else >>>>> #define PAGE_SHIFT 12 >>>>> #define HPAGE_SHIFT 21 >>>>> +#endif >>>>> #define PAGE_SIZE (1 << PAGE_SHIFT) >>>>> #define HPAGE_SIZE (1 << HPAGE_SHIFT) >>>>> diff --git a/tools/testing/selftests/vm/transhuge-stress.c b/tools/testing/selftests/vm/transhuge-stress.c >>>>> index 5e4c036f6ad3..f04c8aa4bcf6 100644 >>>>> --- a/tools/testing/selftests/vm/transhuge-stress.c >>>>> +++ b/tools/testing/selftests/vm/transhuge-stress.c >>>>> @@ -16,8 +16,16 @@ >>>>> #include <string.h> >>>>> #include <sys/mman.h> >>>>> +#ifdef __powerpc64__ >>>>> +#define PAGE_SHIFT 16 >>>>> +/* >>>>> + * This will only work with radix 2M hugepage size >>>>> + */ >>>>> +#define HPAGE_SHIFT 21 >>>> >>>> Why not have this is in common code? >>> >>> Can you suggest where I can move that. We also have helper functions >>> like allocate_transhuge() duplicated between tests. I didn't find >>> libutil.a or anything similar supported by the selftets build. >>> >>>> >> >> I noticed that HPAGE_SHIFT is defined in #ifdef __powerpc64__ block >> as well as #else. I am asking is it necessary to be part of both >> blocks. >> >> +#ifdef __powerpc64__ >> +#define PAGE_SHIFT 16 >> +/* >> + * This will only work with radix 2M hugepage size >> + */ >> +#define HPAGE_SHIFT 21 --- this one >> +#else >> #define PAGE_SHIFT 12 >> #define HPAGE_SHIFT 21 --- this one >> +#endif >> > > > The reason I did that was to add the comment which is relevant only for ppc64. ppc64 supports two hugepage sizes, 2M and 16M. The test won't work correctly with 16M hugepage size. We do have other tests in selftest/vm/ with similar restrictions. > > Right. You don't have to duplicate code for the comment. You can add the comment and then clarify in the comment that it is only relevant to ppc64. This way the comment is clear and we can avoid duplicate code that makes it hard to maintain in the future. thanks, -- Shuah

3 years, 7 months

1
0
0 0

[PATCH v2] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

by Krzysztof Kozlowski

The PREEMPT_RT patchset does not use soft IRQs thus trying to filter for do_softirq fails for such kernel: echo do_softirq ftracetest: 81: echo: echo: I/O error Choose some other visible function for the test. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> Reviewed-by: Shuah Khan <skhan(a)linuxfoundation.org> --- Changes since v1: 1. Use scheduler_tick. 2. Add review tag. Notes: I understand that the failure does not exist on mainline kernel (only with PREEMPT_RT patchset) but the change does not harm it. If it is not suitable alone, please consider it for RT patchset. --- .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc index e96e279e0533..25432b8cd5bd 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc @@ -19,7 +19,7 @@ fail() { # mesg FILTER=set_ftrace_filter FUNC1="schedule" -FUNC2="do_softirq" +FUNC2="scheduler_tick" ALL_FUNCS="#### all functions enabled ####" -- 2.32.0

3 years, 7 months

3
7
0 0

[PATCH] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

by Krzysztof Kozlowski

The PREEMPT_RT patchset does not use soft IRQs thus trying to filter for do_softirq fails for such kernel: echo do_softirq ftracetest: 81: echo: echo: I/O error Choose some other externally visible function for the test. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> --- I understand that the failure does not exist on mainline kernel (only with PREEMPT_RT patchset) but the change does not harm it. If it is not suitable alone, please consider it for RT patchset. --- .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc index e96e279e0533..1d0c7601865f 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc @@ -19,7 +19,7 @@ fail() { # mesg FILTER=set_ftrace_filter FUNC1="schedule" -FUNC2="do_softirq" +FUNC2="_printk" ALL_FUNCS="#### all functions enabled ####" -- 2.32.0

3 years, 7 months

3
3
0 0

[PATCH] MAINTAINERS: Update maintainer list of DMA MAPPING BENCHMARK

by chenxiang

From: Xiang Chen <chenxiang66(a)hisilicon.com> Barry Song will not focus on this area, and Xiang Chen will continue his work to maintain this module. Signed-off-by: Xiang Chen <chenxiang66(a)hisilicon.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea3e6c914384..48335022b0e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5765,7 +5765,7 @@ F: include/linux/dma-map-ops.h F: kernel/dma/ DMA MAPPING BENCHMARK -M: Barry Song <song.bao.hua(a)hisilicon.com> +M: Xiang Chen <chenxiang66(a)hisilicon.com> L: iommu(a)lists.linux-foundation.org F: kernel/dma/map_benchmark.c F: tools/testing/selftests/dma/ -- 2.33.0

3 years, 7 months

3
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror