- Linux-kselftest-mirror - lists.linaro.org

[PATCH 0/2] proc: proc_setattr for /proc/$PID/net

by Thomas Weißschuh

/proc/$PID/net currently allows the setting of file attributes, in contrast to other /proc/$PID/ files and directories. This would break the nolibc testsuite so the first patch in the series removes the offending testcase. The "fix" for nolibc-test is intentionally kept trivial as the series will most likely go through the filesystem tree and if conflicts arise, it is obvious on how to resolve them. Technically this can lead to breakage of nolibc-test if an old nolibc-test is used with a newer kernel containing the fix. Note: Except for /proc itself this is the only "struct inode_operations" in fs/proc/ that is missing an implementation of setattr(). Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> --- Thomas Weißschuh (2): selftests/nolibc: drop test chmod_net proc: use generic setattr() for /proc/$PID/net fs/proc/proc_net.c | 1 + tools/testing/selftests/nolibc/nolibc-test.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) --- base-commit: a92b7d26c743b9dc06d520f863d624e94978a1d9 change-id: 20230624-proc-net-setattr-8f0a6b8eb2f5 Best regards, -- Thomas Weißschuh <linux(a)weissschuh.net>

1 year, 11 months

5
15
0 0

[PATCH][next] selftests: ALSA: Fix fclose on an already fclosed file pointer

by Colin Ian King

In the case where a sysfs file cannot be opened the error return path fcloses file pointer fpl, however, fpl has already been closed in the previous stanza. Fix the double fclose by removing it. Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver") Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> --- tools/testing/selftests/alsa/test-pcmtest-driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/alsa/test-pcmtest-driver.c b/tools/testing/selftests/alsa/test-pcmtest-driver.c index 71931b240a83..357adc722cba 100644 --- a/tools/testing/selftests/alsa/test-pcmtest-driver.c +++ b/tools/testing/selftests/alsa/test-pcmtest-driver.c @@ -47,10 +47,8 @@ static int read_patterns(void) sprintf(pf, "/sys/kernel/debug/pcmtest/fill_pattern%d", i); fp = fopen(pf, "r"); - if (!fp) { - fclose(fpl); + if (!fp) return -1; - } fread(patterns[i].buf, 1, patterns[i].len, fp); fclose(fp); } -- 2.39.2

1 year, 11 months

3
2
0 0

[PATCH] x86: checksum: Fix unaligned checksums on < i686

by David Gow

The checksum_32 code was originally written to only handle 2-byte aligned buffers, but was later extended to support arbitrary alignment. However, the non-PPro variant doesn't apply the carry before jumping to the 2- or 4-byte aligned versions, which clear CF. This causes the new checksum_kunit test to fail, as it runs with a large number of different possible alignments and both with and without carries. For example: ./tools/testing/kunit/kunit.py run --arch i386 --kconfig_add CONFIG_M486=y checksum Gives: KTAP version 1 # Subtest: checksum 1..3 ok 1 test_csum_fixed_random_inputs # test_csum_all_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:267 Expected result == expec, but result == 65281 (0xff01) expec == 65280 (0xff00) not ok 2 test_csum_all_carry_inputs # test_csum_no_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:314 Expected result == expec, but result == 65535 (0xffff) expec == 65534 (0xfffe) not ok 3 test_csum_no_carry_inputs With this patch, it passes. KTAP version 1 # Subtest: checksum 1..3 ok 1 test_csum_fixed_random_inputs ok 2 test_csum_all_carry_inputs ok 3 test_csum_no_carry_inputs I also tested it on a real 486DX2, with the same results. Signed-off-by: David Gow <davidgow(a)google.com> --- This is a follow-up to the UML patch to use the common 32-bit x86 checksum implementations: https://lore.kernel.org/linux-um/20230704083022.692368-2-davidgow@google.co… --- arch/x86/lib/checksum_32.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/lib/checksum_32.S b/arch/x86/lib/checksum_32.S index 23318c338db0..128287cea42d 100644 --- a/arch/x86/lib/checksum_32.S +++ b/arch/x86/lib/checksum_32.S @@ -62,6 +62,7 @@ SYM_FUNC_START(csum_partial) jl 8f movzbl (%esi), %ebx adcl %ebx, %eax + adcl $0, %eax roll $8, %eax inc %esi testl $2, %esi -- 2.41.0.255.g8b1d071c50-goog

1 year, 11 months

2
2
0 0

[PATCH] kunit: qemu_configs: Enable all architectural features for arm64

by Mark Brown

While it probably doesn't make a huge difference given the current KUnit coverage we will get the best coverage of arm64 architecture features if we specify -cpu=max rather than picking a specific CPU, this will include all architecture features that qemu supports including many which have not yet made it into physical implementations. Due to performance issues emulating the architected pointer authentication algorithm it is recommended to use the implementation defined algorithm that qemu has instead, this should make no meaningful difference to the coverage and will run the tests faster. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- tools/testing/kunit/qemu_configs/arm64.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/kunit/qemu_configs/arm64.py b/tools/testing/kunit/qemu_configs/arm64.py index 67d04064f785..d3ff27024755 100644 --- a/tools/testing/kunit/qemu_configs/arm64.py +++ b/tools/testing/kunit/qemu_configs/arm64.py @@ -9,4 +9,4 @@ CONFIG_SERIAL_AMBA_PL011_CONSOLE=y''', qemu_arch='aarch64', kernel_path='arch/arm64/boot/Image.gz', kernel_command_line='console=ttyAMA0', - extra_qemu_params=['-machine', 'virt', '-cpu', 'cortex-a57']) + extra_qemu_params=['-machine', 'virt', '-cpu', 'max,pauth-impdef=on']) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230702-kunit-arm64-cpu-max-7e3aa5f02fb2 Best regards, -- Mark Brown <broonie(a)kernel.org>

1 year, 11 months

2
1
0 0

Re: [PATCH 6.4 0/6] 6.4.3-rc2 review

by Naresh Kamboju

On Mon, 10 Jul 2023 at 02:15, Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> wrote: > > This is the start of the stable review cycle for the 6.4.3 release. > There are 6 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Tue, 11 Jul 2023 20:38:10 +0000. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.4.3-rc2.… > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.4.y > and the diffstat can be found below. > > thanks, > > greg k-h Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Tested-by: Linux Kernel Functional Testing <lkft(a)linaro.org> NOTE: Following two issues are not specific to this round of review, We have been noticing on stable-rc 6.4.1-rc1 release with kselftest merge configs builds testing selftests: net tests. 1) While running selftests: net: pmtu.sh on arm64 ARM juno-r2, qemu-arm64 and Raspberry Pi 4 Model B following kernel crash reported. # selftests: net: pmtu.sh # TEST: ipv4: PMTU exceptions [ OK ] # TEST: ipv4: PMTU exceptions - nexthop objects [ OK ] # TEST: ipv6: PMTU exceptions [FAIL] # PMTU exception wasn't created after exceeding MTU # TEST: ipv6: PMTU exceptions - nexthop objects [FAIL] # PMTU exception wasn't created after exceeding MTU # TEST: ICMPv4 with DSCP and ECN: PMTU exceptions [ OK ] # TEST: ICMPv4 with DSCP and ECN: PMTU exceptions - nexthop objects [ OK ] # TEST: UDPv4 with DSCP and ECN: PMTU exceptions [ OK ] # TEST: UDPv4 with DSCP and ECN: PMTU exceptions - nexthop objects [ OK ] # TEST: IPv4 over vxlan4: PMTU exceptions [ OK ] # TEST: IPv4 over vxlan4: PMTU exceptions - nexthop objects [ OK ] # TEST: IPv6 over vxlan4: PMTU exceptions [FAIL] # PMTU exception wasn't created after exceeding link layer MTU on vxlan interface # TEST: IPv6 over vxlan4: PMTU exceptions - nexthop objects [FAIL] # PMTU exception wasn't created after exceeding link layer MTU on vxlan interface # TEST: IPv4 over vxlan6: PMTU exceptions [ OK ] [ 226.478625] Unable to handle kernel paging request at virtual address ffff800974529000 [ 226.486721] Mem abort info: [ 226.489534] ESR = 0x0000000096000005 [ 226.493304] EC = 0x25: DABT (current EL), IL = 32 bits [ 226.498643] SET = 0, FnV = 0 [ 226.501716] EA = 0, S1PTW = 0 [ 226.504876] FSC = 0x05: level 1 translation fault [ 226.509778] Data abort info: [ 226.512675] ISV = 0, ISS = 0x00000005 [ 226.516531] CM = 0, WnR = 0 [ 226.519518] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000082721000 [ 226.526249] [ffff800974529000] pgd=10000009fffff003, p4d=10000009fffff003, pud=0000000000000000 [ 226.535343] Internal error: Oops: 0000000096000005 [#1] PREEMPT SMP [ 226.541633] Modules linked in: act_csum libcrc32c act_pedit cls_flower sch_prio bpfilter ip_tables x_tables veth macvtap tap tun cfg80211 bluetooth rfkill tda998x hdlcd cec drm_dma_helper onboard_usb_hub drm_kms_helper crct10dif_ce sch_fq_codel fuse drm [last unloaded: test_blackhole_dev] [ 226.567412] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.4.3-rc2 #1 [ 226.573614] Hardware name: ARM Juno development board (r2) (DT) [ 226.579549] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 226.586534] pc : percpu_counter_add_batch+0x40/0x148 [ 226.591529] lr : percpu_counter_add_batch+0x124/0x148 [ 226.596603] sp : ffff800008003dc0 [ 226.599926] x29: ffff800008003dc0 x28: ffff80000b282040 x27: ffff800008199b00 [ 226.607101] x26: ffff800008199ab4 x25: 0000000000000000 x24: ffff80000b318888 [ 226.614275] x23: ffff80000b274b80 x22: 0000000000000020 x21: 0000000000000000 [ 226.621449] x20: ffffffffffffffff x19: ffff00082892d740 x18: 0000000000000000 [ 226.628623] x17: ffff800974529000 x16: 0000000000000000 x15: 00000000000001da [ 226.635796] x14: 0000000000000400 x13: ffff8009745ce000 x12: 0000000000000000 [ 226.642969] x11: ffff80000a7cac24 x10: 0000000000000000 x9 : ffff8000094984cc [ 226.650143] x8 : ffff800008003cd8 x7 : 0000000000000000 x6 : 0000000000000101 [ 226.657317] x5 : 0000000000000000 x4 : ffff800008003da0 x3 : 0000000000000000 [ 226.664489] x2 : 0000000100000101 x1 : ffff800974529000 x0 : 0000000000000000 [ 226.671663] Call trace: [ 226.674116] percpu_counter_add_batch+0x40/0x148 [ 226.678756] dst_destroy+0x18c/0x240 [ 226.682351] dst_destroy_rcu+0x24/0x40 [ 226.686118] rcu_core+0x464/0xe80 [ 226.689453] rcu_core_si+0x18/0x30 [ 226.692872] __do_softirq+0x130/0x4f4 [ 226.696549] ____do_softirq+0x18/0x30 [ 226.700228] call_on_irq_stack+0x24/0x58 [ 226.704167] do_softirq_own_stack+0x24/0x38 [ 226.708367] __irq_exit_rcu+0x17c/0x1b0 [ 226.712220] irq_exit_rcu+0x18/0x48 [ 226.715723] el1_interrupt+0x38/0x68 [ 226.719314] el1h_64_irq_handler+0x18/0x28 [ 226.723426] el1h_64_irq+0x64/0x68 [ 226.726841] cpuidle_enter_state+0x148/0x5b0 [ 226.731129] cpuidle_enter+0x40/0x60 [ 226.734723] do_idle+0x22c/0x2b8 [ 226.737970] cpu_startup_entry+0x30/0x40 [ 226.741912] rest_init+0x114/0x1c0 [ 226.745329] arch_call_rest_init+0x18/0x20 [ 226.749444] start_kernel+0x5e0/0x6f8 [ 226.753121] __primary_switched+0xbc/0xd0 [ 226.757152] Code: 927902b9 36380775 d538d081 f9402e60 (b8616817) [ 226.763268] ---[ end trace 0000000000000000 ]--- [ 226.767898] Kernel panic - not syncing: Oops: Fatal exception in interrupt [ 226.774790] SMP: stopping secondary CPUs [ 226.778932] Kernel Offset: disabled [ 226.782428] CPU features: 0x800004,18780800,0000421b [ 226.787408] Memory Limit: none [ 226.790479] ---[ end Kernel panic - not syncing: Oops: Fatal exception in interrupt ]--- Links: - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… - https://lkft.validation.linaro.org/scheduler/job/6578667#L4613 - https://storage.tuxsuite.com/public/linaro/lkft/builds/2SLr5Fizk6DFnf66nxHo… And 2) While running selftests: net: vrf-xfrm-tests.sh on arm64 Raspberry Pi 4 Model B and arm64 Qualcomm Technologies APQ 8016 SBC devices. # selftests: net: vrf-xfrm-tests.sh # # No qdisc on VRF device # TEST: IPv6 no xfrm policy [ OK ] # Cannot open netlink socket: Protocol not supported [ 3310.312970] audit: type=1334 audit(1651171022.511:197): prog-id=59 op=LOAD # TEST: IPv4 xfrm policy based on address [ OK ] # TEST: IPv6 xfrm policy based on address [ OK ] # Cannot open netlink socket: Protocol not supported # TEST: IPv6 xfrm policy with VRF in selector [ OK ] # TEST: IPv4 xfrm policy with xfrm device [FAIL] # TEST: IPv6 xfrm policy with xfrm device [FAIL] # # netem qdisc on VRF device # Cannot open netlink socket: Protocol not supported ... [ 3326.099841] [ 3326.108605] ============================= [ 3326.117159] WARNING: suspicious RCU usage [ 3326.125672] 6.4.3-rc2 #1 Not tainted [ 3326.134070] ----------------------------- [ 3326.142459] include/net/neighbour.h:302 suspicious rcu_dereference_check() usage! [ 3326.150984] [ 3326.150984] other info that might help us debug this: [ 3326.150984] [ 3326.175738] [ 3326.175738] rcu_scheduler_active = 2, debug_locks = 1 [ 3326.192048] 2 locks held by ping/19436: [ 3326.200354] #0: ffff00000bce3570 (sk_lock-AF_INET){+.+.}-{0:0}, at: raw_sendmsg+0x25c/0xf18 [ 3326.208962] #1: ffff80000b397b98 (rcu_read_lock_bh){....}-{1:2}, at: vrf_finish_output+0x70/0x8d0 [ 3326.217663] [ 3326.217663] stack backtrace: [ 3326.234476] CPU: 1 PID: 19436 Comm: ping Not tainted 6.4.3-rc2 #1 [ 3326.243032] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 3326.251626] Call trace: [ 3326.260137] dump_backtrace+0xa0/0x128 [ 3326.268713] show_stack+0x30/0x48 [ 3326.277235] dump_stack_lvl+0x90/0xb0 [ 3326.285718] dump_stack+0x18/0x28 [ 3326.294123] lockdep_rcu_suspicious+0x16c/0x230 [ 3326.302589] vrf_finish_output+0x664/0x8d0 [ 3326.311049] vrf_output+0x104/0x410 [ 3326.319488] ip_send_skb+0x60/0x128 [ 3326.327928] ip_push_pending_frames+0x44/0x70 [ 3326.336395] raw_sendmsg+0x584/0xf18 [ 3326.344815] inet_sendmsg+0x50/0x88 [ 3326.353251] __sys_sendto+0xfc/0x198 [ 3326.361650] __arm64_sys_sendto+0x34/0x50 [ 3326.369890] invoke_syscall+0x8c/0x120 [ 3326.377899] el0_svc_common.constprop.0+0x104/0x130 [ 3326.385824] do_el0_svc+0x44/0xb8 [ 3326.393644] el0_svc+0x40/0xa8 [ 3326.401277] el0t_64_sync_handler+0xbc/0x138 [ 3326.408721] el0t_64_sync+0x190/0x198 [ 3326.416111] [ 3326.423395] ============================= [ 3326.430605] WARNING: suspicious RCU usage [ 3326.437613] 6.4.3-rc2 #1 Not tainted [ 3326.444481] ----------------------------- [ 3326.451275] include/net/neighbour.h:307 suspicious rcu_dereference_check() usage! [ 3326.458148] [ 3326.458148] other info that might help us debug this: [ 3326.458148] [ 3326.477416] [ 3326.477416] rcu_scheduler_active = 2, debug_locks = 1 [ 3326.489637] 2 locks held by ping/19436: [ 3326.495704] #0: ffff00000bce3570 (sk_lock-AF_INET){+.+.}-{0:0}, at: raw_sendmsg+0x25c/0xf18 [ 3326.501817] #1: ffff80000b397b98 (rcu_read_lock_bh){....}-{1:2}, at: vrf_finish_output+0x70/0x8d0 [ 3326.509274] [ 3326.509274] stack backtrace: [ 3326.523226] CPU: 1 PID: 19436 Comm: ping Not tainted 6.4.3-rc2 #1 [ 3326.528565] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 3326.533774] Call trace: [ 3326.540093] dump_backtrace+0xa0/0x128 [ 3326.545130] show_stack+0x30/0x48 [ 3326.550107] dump_stack_lvl+0x90/0xb0 [ 3326.554925] dump_stack+0x18/0x28 [ 3326.559493] lockdep_rcu_suspicious+0x16c/0x230 [ 3326.563974] vrf_finish_output+0x618/0x8d0 [ 3326.568383] vrf_output+0x104/0x410 [ 3326.572598] ip_send_skb+0x60/0x128 [ 3326.576589] ip_push_pending_frames+0x44/0x70 [ 3326.580477] raw_sendmsg+0x584/0xf18 [ 3326.584239] inet_sendmsg+0x50/0x88 [ 3326.587983] __sys_sendto+0xfc/0x198 [ 3326.591723] __arm64_sys_sendto+0x34/0x50 [ 3326.595464] invoke_syscall+0x8c/0x120 [ 3326.599199] el0_svc_common.constprop.0+0x104/0x130 [ 3326.602929] do_el0_svc+0x44/0xb8 [ 3326.606753] el0_svc+0x40/0xa8 [ 3326.610378] el0t_64_sync_handler+0xbc/0x138 [ 3326.614029] el0t_64_sync+0x190/0x198 # TEST: IPv4 no xfrm policy [ OK ] Links: - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… metadata: git_ref: linux-6.4.y git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git_sha: 3e37df3ffd9a648c9f88f6bbca158e43d5077bef git_describe: v6.4.1-22-g3e37df3ffd9a kernel_version: 6.4.3-rc2 kernel-config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2SLr5Fizk6DFnf66nxHo… artifact-location: https://storage.tuxsuite.com/public/linaro/lkft/builds/2SLr5Fizk6DFnf66nxHo… toolchain: gcc-11 ## Build * kernel: 6.4.3-rc2 * git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc * git branch: linux-6.4.y * git commit: 3e37df3ffd9a648c9f88f6bbca158e43d5077bef * git describe: v6.4.1-22-g3e37df3ffd9a * test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4.1… ## Test Regressions (compared to v6.4.1) ## Metric Regressions (compared to v6.4.1) ## Test Fixes (compared to v6.4.1) ## Metric Fixes (compared to v6.4.1) ## Test result summary total: 173253, pass: 148435, fail: 2272, skip: 22546, xfail: 0 ## Build Summary * arc: 5 total, 5 passed, 0 failed * arm: 145 total, 145 passed, 0 failed * arm64: 54 total, 53 passed, 1 failed * i386: 41 total, 41 passed, 0 failed * mips: 30 total, 28 passed, 2 failed * parisc: 4 total, 4 passed, 0 failed * powerpc: 38 total, 36 passed, 2 failed * riscv: 26 total, 25 passed, 1 failed * s390: 16 total, 14 passed, 2 failed * sh: 14 total, 12 passed, 2 failed * sparc: 8 total, 8 passed, 0 failed * x86_64: 46 total, 46 passed, 0 failed ## Test suites summary * boot * fwts * kselftest-android * kselftest-arm64 * kselftest-breakpoints * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-drivers-dma-buf * kselftest-efivarfs * kselftest-exec * kselftest-filesystems * kselftest-filesystems-binderfs * kselftest-firmware * kselftest-fpu * kselftest-ftrace * kselftest-futex * kselftest-gpio * kselftest-intel_pstate * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kexec * kselftest-kvm * kselftest-lib * kselftest-livepatch * kselftest-membarrier * kselftest-memfd * kselftest-memory-hotplug * kselftest-mincore * kselftest-mount * kselftest-mqueue * kselftest-net * kselftest-net-forwarding * kselftest-net-mptcp * kselftest-netfilter * kselftest-nsfs * kselftest-openat2 * kselftest-pid_namespace * kselftest-pidfd * kselftest-proc * kselftest-pstore * kselftest-ptrace * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-tc-testing * kselftest-timens * kselftest-timers * kselftest-tmpfs * kselftest-tpm2 * kselftest-user * kselftest-user_events * kselftest-vDSO * kselftest-watchdog * kselftest-x86 * kselftest-zram * kunit * kvm-unit-tests * libgpiod * libhugetlbfs * log-parser-boot * log-parser-test * ltp-cap_bounds * ltp-commands * ltp-containers * ltp-controllers * ltp-cpuhotplug * ltp-crypto * ltp-cve * ltp-dio * ltp-fcntl-locktests * ltp-filecaps * ltp-fs * ltp-fs_bind * ltp-fs_perms_simple * ltp-fsx * ltp-hugetlb * ltp-io * ltp-ipc * ltp-math * ltp-mm * ltp-nptl * ltp-pty * ltp-sched * ltp-securebits * ltp-smoke * ltp-syscalls * ltp-tracing * network-basic-tests * perf * rcutorture * v4l2-compliance * vdso -- Linaro LKFT https://lkft.linaro.org

1 year, 11 months

4
5
0 0

[PATCH bpf-next v4 0/6] Support defragmenting IPv(4|6) packets in BPF

by Daniel Xu

=== Context === In the context of a middlebox, fragmented packets are tricky to handle. The full 5-tuple of a packet is often only available in the first fragment which makes enforcing consistent policy difficult. There are really only two stateless options, neither of which are very nice: 1. Enforce policy on first fragment and accept all subsequent fragments. This works but may let in certain attacks or allow data exfiltration. 2. Enforce policy on first fragment and drop all subsequent fragments. This does not really work b/c some protocols may rely on fragmentation. For example, DNS may rely on oversized UDP packets for large responses. So stateful tracking is the only sane option. RFC 8900 [0] calls this out as well in section 6.3: Middleboxes [...] should process IP fragments in a manner that is consistent with [RFC0791] and [RFC8200]. In many cases, middleboxes must maintain state in order to achieve this goal. === BPF related bits === Policy has traditionally been enforced from XDP/TC hooks. Both hooks run before kernel reassembly facilities. However, with the new BPF_PROG_TYPE_NETFILTER, we can rather easily hook into existing netfilter reassembly infra. The basic idea is we bump a refcnt on the netfilter defrag module and then run the bpf prog after the defrag module runs. This allows bpf progs to transparently see full, reassembled packets. The nice thing about this is that progs don't have to carry around logic to detect fragments. === Changelog === Changes from v3: * Correctly initialize `addrlen` stack var for recvmsg() Changes from v2: * module_put() if ->enable() fails * Fix CI build errors Changes from v1: * Drop bpf_program__attach_netfilter() patches * static -> static const where appropriate * Fix callback assignment order during registration * Only request_module() if callbacks are missing * Fix retval when modprobe fails in userspace * Fix v6 defrag module name (nf_defrag_ipv6_hooks -> nf_defrag_ipv6) * Simplify priority checking code * Add warning if module doesn't assign callbacks in the future * Take refcnt on module while defrag link is active [0]: https://datatracker.ietf.org/doc/html/rfc8900 Daniel Xu (6): netfilter: defrag: Add glue hooks for enabling/disabling defrag netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link netfilter: bpf: Prevent defrag module unload while link active bpf: selftests: Support not connecting client socket bpf: selftests: Support custom type and proto for client sockets bpf: selftests: Add defrag selftests include/linux/netfilter.h | 15 + include/uapi/linux/bpf.h | 5 + net/ipv4/netfilter/nf_defrag_ipv4.c | 17 +- net/ipv6/netfilter/nf_defrag_ipv6_hooks.c | 11 + net/netfilter/core.c | 6 + net/netfilter/nf_bpf_link.c | 150 +++++++++- tools/include/uapi/linux/bpf.h | 5 + tools/testing/selftests/bpf/Makefile | 4 +- .../selftests/bpf/generate_udp_fragments.py | 90 ++++++ .../selftests/bpf/ip_check_defrag_frags.h | 57 ++++ tools/testing/selftests/bpf/network_helpers.c | 26 +- tools/testing/selftests/bpf/network_helpers.h | 3 + .../bpf/prog_tests/ip_check_defrag.c | 283 ++++++++++++++++++ .../selftests/bpf/progs/ip_check_defrag.c | 104 +++++++ 14 files changed, 754 insertions(+), 22 deletions(-) create mode 100755 tools/testing/selftests/bpf/generate_udp_fragments.py create mode 100644 tools/testing/selftests/bpf/ip_check_defrag_frags.h create mode 100644 tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c create mode 100644 tools/testing/selftests/bpf/progs/ip_check_defrag.c -- 2.41.0

1 year, 11 months

1
3
0 0

[for-linus][PATCH 1/5] selftests/user_events: Test struct size match cases

by Steven Rostedt

From: Beau Belgrave <beaub(a)linux.microsoft.com> The self tests for user_events currently does not ensure that the edge case for struct types work properly with size differences. Add cases for mis-matching struct names and sizes to ensure they work properly. Link: https://lkml.kernel.org/r/20230629235049.581-3-beaub@linux.microsoft.com Cc: Shuah Khan <skhan(a)linuxfoundation.org> Cc: linux-kselftest(a)vger.kernel.org Signed-off-by: Beau Belgrave <beaub(a)linux.microsoft.com> Signed-off-by: Steven Rostedt (Google) <rostedt(a)goodmis.org> --- tools/testing/selftests/user_events/dyn_test.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c index d6979a48478f..91a4444ad42b 100644 --- a/tools/testing/selftests/user_events/dyn_test.c +++ b/tools/testing/selftests/user_events/dyn_test.c @@ -217,6 +217,18 @@ TEST_F(user, matching) { /* Types don't match */ TEST_NMATCH("__test_event u64 a; u64 b", "__test_event u32 a; u32 b"); + + /* Struct name and size matches */ + TEST_MATCH("__test_event struct my_struct a 20", + "__test_event struct my_struct a 20"); + + /* Struct name don't match */ + TEST_NMATCH("__test_event struct my_struct a 20", + "__test_event struct my_struct b 20"); + + /* Struct size don't match */ + TEST_NMATCH("__test_event struct my_struct a 20", + "__test_event struct my_struct a 21"); } int main(int argc, char **argv) -- 2.40.1

1 year, 11 months

1
0
0 0

[PATCH][next] selftests/mm: mkdirty: Fix incorrect position of #endif

by Colin Ian King

The #endif is the wrong side of a } causing a build failure when __NR_userfaultfd is not defined. Fix this by moving the #end to enclose the } Fixes: 9eac40fc0cc7 ("selftests/mm: mkdirty: test behavior of (pte|pmd)_mkdirty on VMAs without write permissions") Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> --- tools/testing/selftests/mm/mkdirty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c index 6d71d972997b..301abb99e027 100644 --- a/tools/testing/selftests/mm/mkdirty.c +++ b/tools/testing/selftests/mm/mkdirty.c @@ -321,8 +321,8 @@ static void test_uffdio_copy(void) munmap: munmap(dst, pagesize); free(src); -#endif /* __NR_userfaultfd */ } +#endif /* __NR_userfaultfd */ int main(void) { -- 2.39.2

1 year, 11 months

2
1
0 0

[linux-next:master] BUILD REGRESSION 40b055fe7f276cf2c1da47316c52f2ff9255a68a

by kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 40b055fe7f276cf2c1da47316c52f2ff9255a68a Add linux-next specific files for 20230712 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306122223.HHER4zOo-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306210212.N0BipYQd-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) arch/parisc/kernel/pdt.c:67:6: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] kernel/bpf/verifier.c:3959:12: warning: stack frame size (2064) exceeds limit (2048) in '__mark_chain_precision' [-Wframe-larger-than] lib/kunit/executor_test.c:138:4: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] lib/kunit/test.c:775:38: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict] Unverified Error/Warning (likely false positive, please contact us if interested): drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:98 mlx5_devcom_register_device() error: uninitialized symbol 'tmp_dev'. kernel/trace/trace_functions_graph.c:1012 print_graph_return() warn: bitwise AND condition is false here kernel/trace/trace_functions_graph.c:726 print_graph_entry_leaf() warn: bitwise AND condition is false here net/wireless/scan.c:373 cfg80211_gen_new_ie() warn: potential spectre issue 'sub->data' [r] net/wireless/scan.c:397 cfg80211_gen_new_ie() warn: possible spectre second half. 'ext_id' {standard input}: Error: local label `"2" (instance number 9 of a fb label)' is not defined Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- microblaze-randconfig-m041-20230710 | |-- drivers-net-ethernet-mellanox-mlx5-core-lib-devcom.c-mlx5_devcom_register_device()-error:uninitialized-symbol-tmp_dev-. | |-- net-wireless-scan.c-cfg80211_gen_new_ie()-warn:possible-spectre-second-half.-ext_id | `-- net-wireless-scan.c-cfg80211_gen_new_ie()-warn:potential-spectre-issue-sub-data-r |-- mips-randconfig-m031-20230710 | |-- kernel-trace-trace_functions_graph.c-print_graph_entry_leaf()-warn:bitwise-AND-condition-is-false-here | `-- kernel-trace-trace_functions_graph.c-print_graph_return()-warn:bitwise-AND-condition-is-false-here |-- parisc-randconfig-r082-20230710 | `-- arch-parisc-kernel-pdt.c:warning:no-previous-prototype-for-arch_report_meminfo `-- sh-allmodconfig `-- standard-input:Error:local-label-(instance-number-of-a-fb-label)-is-not-defined clang_recent_errors |-- hexagon-randconfig-r013-20230712 | |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type | `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type |-- riscv-randconfig-r023-20230712 | `-- kernel-bpf-verifier.c:warning:stack-frame-size-()-exceeds-limit-()-in-__mark_chain_precision `-- s390-randconfig-r044-20230712 |-- lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type `-- lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type elapsed time: 798m configs tested: 123 configs skipped: 8 tested configs: alpha allyesconfig gcc alpha defconfig gcc alpha randconfig-r003-20230712 gcc alpha randconfig-r015-20230712 gcc alpha randconfig-r025-20230712 gcc arc allyesconfig gcc arc defconfig gcc arc haps_hs_smp_defconfig gcc arc randconfig-r043-20230712 gcc arc vdk_hs38_smp_defconfig gcc arm allmodconfig gcc arm allyesconfig gcc arm am200epdkit_defconfig clang arm davinci_all_defconfig clang arm defconfig gcc arm milbeaut_m10v_defconfig clang arm multi_v7_defconfig gcc arm randconfig-r046-20230712 gcc arm rpc_defconfig gcc arm spear13xx_defconfig clang arm64 allyesconfig gcc arm64 defconfig gcc csky defconfig gcc csky randconfig-r034-20230712 gcc hexagon randconfig-r013-20230712 clang hexagon randconfig-r035-20230712 clang hexagon randconfig-r041-20230712 clang hexagon randconfig-r045-20230712 clang i386 allyesconfig gcc i386 buildonly-randconfig-r004-20230712 gcc i386 buildonly-randconfig-r005-20230712 gcc i386 buildonly-randconfig-r006-20230712 gcc i386 debian-10.3 gcc i386 defconfig gcc i386 randconfig-i001-20230712 gcc i386 randconfig-i002-20230712 gcc i386 randconfig-i003-20230712 gcc i386 randconfig-i004-20230712 gcc i386 randconfig-i005-20230712 gcc i386 randconfig-i006-20230712 gcc i386 randconfig-i011-20230712 clang i386 randconfig-i012-20230712 clang i386 randconfig-i013-20230712 clang i386 randconfig-i014-20230712 clang i386 randconfig-i015-20230712 clang i386 randconfig-i016-20230712 clang loongarch allmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc m68k allmodconfig gcc m68k allyesconfig gcc m68k defconfig gcc microblaze randconfig-r021-20230712 gcc mips allmodconfig gcc mips allyesconfig gcc mips randconfig-r031-20230712 clang mips randconfig-r032-20230712 clang nios2 alldefconfig gcc nios2 defconfig gcc nios2 randconfig-r001-20230712 gcc parisc allyesconfig gcc parisc defconfig gcc parisc randconfig-r036-20230712 gcc parisc64 defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc bamboo_defconfig gcc powerpc cm5200_defconfig gcc powerpc powernv_defconfig clang powerpc storcenter_defconfig gcc riscv allmodconfig gcc riscv allnoconfig gcc riscv allyesconfig gcc riscv defconfig gcc riscv randconfig-r023-20230712 clang riscv randconfig-r042-20230712 clang riscv rv32_defconfig gcc s390 allmodconfig gcc s390 allyesconfig gcc s390 defconfig gcc s390 randconfig-r044-20230712 clang sh allmodconfig gcc sh ecovec24-romimage_defconfig gcc sh landisk_defconfig gcc sh randconfig-r033-20230712 gcc sh sh7757lcr_defconfig gcc sh urquell_defconfig gcc sparc allyesconfig gcc sparc defconfig gcc sparc64 alldefconfig gcc sparc64 randconfig-r011-20230712 gcc sparc64 randconfig-r014-20230712 gcc um allmodconfig clang um allnoconfig clang um allyesconfig clang um defconfig gcc um i386_defconfig gcc um randconfig-r012-20230712 gcc um x86_64_defconfig gcc x86_64 allyesconfig gcc x86_64 buildonly-randconfig-r001-20230712 gcc x86_64 buildonly-randconfig-r002-20230712 gcc x86_64 buildonly-randconfig-r003-20230712 gcc x86_64 defconfig gcc x86_64 kexec gcc x86_64 randconfig-r026-20230712 clang x86_64 randconfig-x001-20230712 clang x86_64 randconfig-x002-20230712 clang x86_64 randconfig-x003-20230712 clang x86_64 randconfig-x004-20230712 clang x86_64 randconfig-x005-20230712 clang x86_64 randconfig-x006-20230712 clang x86_64 randconfig-x011-20230712 gcc x86_64 randconfig-x012-20230712 gcc x86_64 randconfig-x013-20230712 gcc x86_64 randconfig-x014-20230712 gcc x86_64 randconfig-x015-20230712 gcc x86_64 randconfig-x016-20230712 gcc x86_64 rhel-8.3-rust clang x86_64 rhel-8.3 gcc xtensa defconfig gcc xtensa randconfig-r006-20230712 gcc xtensa randconfig-r016-20230712 gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 year, 11 months

1
0
0 0

[PATCH v2] selftests/zram: avoid subshells and bc for ratio calculations

by David Disseldorp

Awk is already called for /sys/block/zram#/mm_stat parsing, so use it to also perform the floating point capacity vs consumption ratio calculations. The test output is unchanged. This allows bc to be dropped as a dependency for the zram selftests. The documented free dependency can also be removed following d18da7ec37195 ("selftests/zram01.sh: Fix compression ratio calculation") Signed-off-by: David Disseldorp <ddiss(a)suse.de> --- tools/testing/selftests/zram/README | 2 -- tools/testing/selftests/zram/zram01.sh | 18 ++++++++---------- 2 files changed, 8 insertions(+), 12 deletions(-) v2: drop unused dependencies from selftests/zram/README diff --git a/tools/testing/selftests/zram/README b/tools/testing/selftests/zram/README index 110b34834a6fa..510ca5a1087f5 100644 --- a/tools/testing/selftests/zram/README +++ b/tools/testing/selftests/zram/README @@ -27,9 +27,7 @@ zram01.sh: creates general purpose ram disks with ext4 filesystems zram02.sh: creates block device for swap Commands required for testing: - - bc - dd - - free - awk - mkswap - swapon diff --git a/tools/testing/selftests/zram/zram01.sh b/tools/testing/selftests/zram/zram01.sh index 8f4affe34f3e4..df1b1d4158989 100755 --- a/tools/testing/selftests/zram/zram01.sh +++ b/tools/testing/selftests/zram/zram01.sh @@ -33,7 +33,7 @@ zram_algs="lzo" zram_fill_fs() { - for i in $(seq $dev_start $dev_end); do + for ((i = $dev_start; i <= $dev_end && !ERR_CODE; i++)); do echo "fill zram$i..." local b=0 while [ true ]; do @@ -44,15 +44,13 @@ zram_fill_fs() done echo "zram$i can be filled with '$b' KB" - local mem_used_total=`awk '{print $3}' "/sys/block/zram$i/mm_stat"` - local v=$((100 * 1024 * $b / $mem_used_total)) - if [ "$v" -lt 100 ]; then - echo "FAIL compression ratio: 0.$v:1" - ERR_CODE=-1 - return - fi - - echo "zram compression ratio: $(echo "scale=2; $v / 100 " | bc):1: OK" + awk -v b="$b" '{ v = (100 * 1024 * b / $3) } END { + if (v < 100) { + printf "FAIL compression ratio: 0.%u:1\n", v + exit 1 + } + printf "zram compression ratio: %.2f:1: OK\n", v / 100 + }' "/sys/block/zram$i/mm_stat" || ERR_CODE=-1 done } -- 2.35.3

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror